)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b9f3ee06286c2550c45f933332c1a3b354571b9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d786fde7_d7062466","updated":"2024-02-26 22:48:01.000000000","message":"Working on the init_host part of this that I missed.","commit_id":"7bc7dba43e16d621aabd21693685e9d1b3013804"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1fba9ef8c0e086d2c77c26833e528ab70204f58d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cfe6fd94_91d17c19","updated":"2024-03-27 16:40:23.000000000","message":"I haven\u0027t looked yet at other files but at least I have a concern with the documentation.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6d39e9d6_f13c9eb7","updated":"2024-05-23 16:45:25.000000000","message":"Like I said, Sean had a fair point, we shouldn\u0027t hold this change on some docs nits, so providing +2. \nMel, once you create a FUP patch, I\u0027ll +W this change.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f9995a39cb520e3c0c4fdc54f3c7574d165444b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a007e477_1ac79a3a","updated":"2024-05-27 08:32:43.000000000","message":"OK, let\u0027s just accept this change.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d58081e0cf836b358092388bbff25c90639d2584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"28b0d6a9_d3da1007","updated":"2024-05-21 10:35:00.000000000","message":"im honestly fine with this patch as is and think we could have a follow up for the docs discussion\nso upgrading to +2","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"}],"doc/source/admin/virtual-gpu.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1fba9ef8c0e086d2c77c26833e528ab70204f58d","unresolved":true,"context_lines":[{"line_number":31,"context_line":"Enable GPU types (Compute)"},{"line_number":32,"context_line":"--------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#. Enable virtual functions on NVIDIA GPUs."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   .. code-block:: bash"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"cec71e6b_932523f3","line":34,"updated":"2024-03-27 16:40:23.000000000","message":"this is not only nvidia-specific but also nvidia product-line specific (ie. SRIOV GPUs).\n\nIf we really want to be keen with our upstream operators, we *may* provide some high-level note that would say \"heh, btw. ensure that if your vfio-mdev driver uses VFs as base resources, you also need to persist them, and you could look at hardware vendor doc accordingly\".\n\nI\u0027m also very reluctant to provide a link to an external prioprietary doc, given how often it changes per releases (at least for nvidia), so if we really want to give a link, we *need* to explain this would be for a specific release of the hardware vendor driver.\nExample for nvidia GRID 16.x version https://docs.nvidia.com/grid/16.0/grid-vgpu-user-guide/index.html#creating-sriov-vgpu-device-red-hat-el-kvm","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49cc46ab8e2a09993ba287d2ff2f8b14bcd546c3","unresolved":true,"context_lines":[{"line_number":31,"context_line":"Enable GPU types (Compute)"},{"line_number":32,"context_line":"--------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#. Enable virtual functions on NVIDIA GPUs."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   .. code-block:: bash"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"b005e81b_9b61d1e2","line":34,"in_reply_to":"9b3983e4_a7858c3b","updated":"2024-05-23 17:09:25.000000000","message":"Ack, I\u0027ll add a FUP.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1fb8e0fcff687f76dab26698ea3f86c2ef49cf7b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"Enable GPU types (Compute)"},{"line_number":32,"context_line":"--------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#. Enable virtual functions on NVIDIA GPUs."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   .. code-block:: bash"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ddace9a4_539961a1","line":34,"in_reply_to":"cec71e6b_932523f3","updated":"2024-03-29 19:32:57.000000000","message":"Thanks for the guidance! I\u0027ll adjust this section in the next revision. I\u0027ll wait until you have a chance to look at the code so I\u0027ll do all the changes at the same time.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a97bf10a60c5b91f2d5aedff1573cf54143c9a9a","unresolved":true,"context_lines":[{"line_number":31,"context_line":"Enable GPU types (Compute)"},{"line_number":32,"context_line":"--------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#. Enable virtual functions on NVIDIA GPUs."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   .. code-block:: bash"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"f79840c2_ef6c09b2","line":34,"in_reply_to":"ddace9a4_539961a1","updated":"2024-05-15 10:12:04.000000000","message":"i would prefer to have a know working example form a period of time with a note saying that it is only an example and that you should follow the vendor documentation for the relevent devices you have.\n\nwe do not need to link to the Nvidia docs if you dont want to but i don\u0027t think that is necessarily bad to do even if that can break.\n\nit\u0027s better to provide some information than force our users to try an find it all by themselves.\n\ni would presonally find \"heh, btw. ensure that if your vfio-mdev driver uses VFs as base resources, you also need to persist them, and you could look at hardware vendor doc accordingly\" to be borderline insulting so i dont want use to do that, no docs would be better at that point and i think this deserves docs.\n\ni am happy with the docs as is but as i said would be happy to add a note refering them ot the vendor docs for more information if you think that is requried.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":true,"context_lines":[{"line_number":31,"context_line":"Enable GPU types (Compute)"},{"line_number":32,"context_line":"--------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#. Enable virtual functions on NVIDIA GPUs."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   .. code-block:: bash"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9b3983e4_a7858c3b","line":34,"in_reply_to":"f79840c2_ef6c09b2","updated":"2024-05-23 16:45:25.000000000","message":"This is a fair point, we shouldn\u0027t hold this change on some documentation point. Mel, please just provide a FUP above that one so we can discuss what to modify for this topic.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"}],"nova/tests/functional/libvirt/test_vgpu.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[{"line_number":778,"context_line":"                               expected_rc\u003d\u0027CUSTOM_NOTVGPU\u0027)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"class VGPUTestsLibvirt7_3(VGPUTests):"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    # Minimum version supporting persistent mdevs is 7.3.0."},{"line_number":784,"context_line":"    # https://libvirt.org/drvnodedev.html#mediated-devices-mdevs"}],"source_content_type":"text/x-python","patch_set":6,"id":"cce8d267_289db37c","line":781,"range":{"start_line":781,"start_character":26,"end_line":781,"end_character":35},"updated":"2024-05-23 16:45:25.000000000","message":"fair enough, we\u0027ll just duplicate the main simple functests, not all the other testclasses.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49cc46ab8e2a09993ba287d2ff2f8b14bcd546c3","unresolved":false,"context_lines":[{"line_number":778,"context_line":"                               expected_rc\u003d\u0027CUSTOM_NOTVGPU\u0027)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"class VGPUTestsLibvirt7_3(VGPUTests):"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    # Minimum version supporting persistent mdevs is 7.3.0."},{"line_number":784,"context_line":"    # https://libvirt.org/drvnodedev.html#mediated-devices-mdevs"}],"source_content_type":"text/x-python","patch_set":6,"id":"f2621394_4836aac2","line":781,"range":{"start_line":781,"start_character":26,"end_line":781,"end_character":35},"in_reply_to":"cce8d267_289db37c","updated":"2024-05-23 17:09:25.000000000","message":"I wasn\u0027t sure if I should do all of them. If you think so, I can add that.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"}],"nova/tests/functional/regressions/test_bug_1951656.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class VGPUTestsLibvirt7_7(test_vgpu.VGPUTestBase):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 7007000"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(VGPUTestsLibvirt7_7, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"6de238b3_e7694d41","line":20,"updated":"2024-05-23 16:45:25.000000000","message":"Yeah, indeed 😊 it\u0027s better to now persist the mdev instead of creating it","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[{"line_number":250,"context_line":"# Autostart appears to be available starting in 7.8.0"},{"line_number":251,"context_line":"# https://github.com/libvirt/libvirt/commit/c6607a25b93bd6b0188405785d6608fdf71c8e0a"},{"line_number":252,"context_line":"MIN_LIBVIRT_NODEDEV_AUTOSTART \u003d (7, 8, 0)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"LIBVIRT_PERF_EVENT_PREFIX \u003d \u0027VIR_PERF_PARAM_\u0027"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# Maxphysaddr minimal support version."}],"source_content_type":"text/x-python","patch_set":6,"id":"fc8c3746_25547d31","line":253,"updated":"2024-05-23 16:45:25.000000000","message":"all good, indeed","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":true,"context_lines":[{"line_number":848,"context_line":"        if not self._host.has_min_version(MIN_LIBVIRT_PERSISTENT_MDEV):"},{"line_number":849,"context_line":"            # TODO(sbauza): Remove this code once mediated devices are"},{"line_number":850,"context_line":"            # persisted across reboots."},{"line_number":851,"context_line":"            self._recreate_assigned_mediated_devices()"},{"line_number":852,"context_line":"        else:"},{"line_number":853,"context_line":"            # NOTE(melwitt): We shouldn\u0027t need to do this with libvirt 7.8.0"},{"line_number":854,"context_line":"            # and newer because we\u0027re setting autostart\u003dTrue on the devices --"}],"source_content_type":"text/x-python","patch_set":6,"id":"93b749c5_506448eb","line":851,"updated":"2024-05-23 16:45:25.000000000","message":"well, we could just remove this as we already have a problem with this method https://bugs.launchpad.net/nova/+bug/1900800\n\nAnyway, we can do this by a follow-up change.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49cc46ab8e2a09993ba287d2ff2f8b14bcd546c3","unresolved":true,"context_lines":[{"line_number":848,"context_line":"        if not self._host.has_min_version(MIN_LIBVIRT_PERSISTENT_MDEV):"},{"line_number":849,"context_line":"            # TODO(sbauza): Remove this code once mediated devices are"},{"line_number":850,"context_line":"            # persisted across reboots."},{"line_number":851,"context_line":"            self._recreate_assigned_mediated_devices()"},{"line_number":852,"context_line":"        else:"},{"line_number":853,"context_line":"            # NOTE(melwitt): We shouldn\u0027t need to do this with libvirt 7.8.0"},{"line_number":854,"context_line":"            # and newer because we\u0027re setting autostart\u003dTrue on the devices --"}],"source_content_type":"text/x-python","patch_set":6,"id":"cebedd95_e427285e","line":851,"in_reply_to":"93b749c5_506448eb","updated":"2024-05-23 17:09:25.000000000","message":"I was thinking we can\u0027t remove it until the next minimum libvirt version, no?\n\nCurrently we have MIN_LIBVIRT_VERSION \u003d (7, 0, 0)","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f9995a39cb520e3c0c4fdc54f3c7574d165444b","unresolved":true,"context_lines":[{"line_number":848,"context_line":"        if not self._host.has_min_version(MIN_LIBVIRT_PERSISTENT_MDEV):"},{"line_number":849,"context_line":"            # TODO(sbauza): Remove this code once mediated devices are"},{"line_number":850,"context_line":"            # persisted across reboots."},{"line_number":851,"context_line":"            self._recreate_assigned_mediated_devices()"},{"line_number":852,"context_line":"        else:"},{"line_number":853,"context_line":"            # NOTE(melwitt): We shouldn\u0027t need to do this with libvirt 7.8.0"},{"line_number":854,"context_line":"            # and newer because we\u0027re setting autostart\u003dTrue on the devices --"}],"source_content_type":"text/x-python","patch_set":6,"id":"c228111e_34b2a6b0","line":851,"in_reply_to":"cebedd95_e427285e","updated":"2024-05-27 08:32:43.000000000","message":"What I mean is that the method is already providing an exception, so we can just remove it. Anyway, let\u0027s not do this by this change.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[{"line_number":854,"context_line":"            # and newer because we\u0027re setting autostart\u003dTrue on the devices --"},{"line_number":855,"context_line":"            # but if that fails for whatever reason and any devices become"},{"line_number":856,"context_line":"            # inactive, we can start them here. With libvirt version \u003c 7.8.0,"},{"line_number":857,"context_line":"            # this is needed because autostart is not available."},{"line_number":858,"context_line":"            self._start_inactive_mediated_devices()"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"        self._check_cpu_compatibility()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3adcde87_08abdf97","line":857,"updated":"2024-05-23 16:45:25.000000000","message":"++","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"            LOG.info(f\u0027Found inactive mdevs: {names}\u0027)"},{"line_number":1122,"context_line":"        for mdev in inactive_mdevs:"},{"line_number":1123,"context_line":"            LOG.info(f\u0027Starting inactive mdev: {mdev.name()}\u0027)"},{"line_number":1124,"context_line":"            self._host.device_start(mdev)"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"    @staticmethod"},{"line_number":1127,"context_line":"    def _is_existing_mdev(uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"367b49b1_72643ccf","line":1124,"updated":"2024-05-23 16:45:25.000000000","message":"++","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":true,"context_lines":[{"line_number":4106,"context_line":"                instance\u003dinstance)"},{"line_number":4107,"context_line":"            allocs \u003d self.virtapi.reportclient.get_allocations_for_consumer("},{"line_number":4108,"context_line":"                    context, instance.uuid)"},{"line_number":4109,"context_line":"            mdevs \u003d self._allocate_mdevs(allocs)"},{"line_number":4110,"context_line":"        # NOTE(vish): This could generate the wrong device_format if we are"},{"line_number":4111,"context_line":"        #             using the raw backend and the images don\u0027t exist yet."},{"line_number":4112,"context_line":"        #             The create_images_and_backing below doesn\u0027t properly"}],"source_content_type":"text/x-python","patch_set":6,"id":"430a94fd_9a502702","line":4109,"updated":"2024-05-23 16:45:25.000000000","message":"I think this is a different bug, but I\u0027m fine to fix it by the same change.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49cc46ab8e2a09993ba287d2ff2f8b14bcd546c3","unresolved":true,"context_lines":[{"line_number":4106,"context_line":"                instance\u003dinstance)"},{"line_number":4107,"context_line":"            allocs \u003d self.virtapi.reportclient.get_allocations_for_consumer("},{"line_number":4108,"context_line":"                    context, instance.uuid)"},{"line_number":4109,"context_line":"            mdevs \u003d self._allocate_mdevs(allocs)"},{"line_number":4110,"context_line":"        # NOTE(vish): This could generate the wrong device_format if we are"},{"line_number":4111,"context_line":"        #             using the raw backend and the images don\u0027t exist yet."},{"line_number":4112,"context_line":"        #             The create_images_and_backing below doesn\u0027t properly"}],"source_content_type":"text/x-python","patch_set":6,"id":"579a0439_85d84464","line":4109,"in_reply_to":"430a94fd_9a502702","updated":"2024-05-23 17:09:25.000000000","message":"That\u0027s fair. I found this during one of the times I messed up the code while working on it 😆 I got the VM into a state where I was stuck because I lost the mdevs and was unable to add them back automatically.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":true,"context_lines":[{"line_number":4172,"context_line":"            #   Verify all devices in group \u003cgroup\u003e are bound to vfio-\u003cbus\u003e or"},{"line_number":4173,"context_line":"            #   pci-stub and not already in use"},{"line_number":4174,"context_line":"            # Retry the guest creation once in this case as it usually succeeds"},{"line_number":4175,"context_line":"            # on the second try."},{"line_number":4176,"context_line":"            if (mdevs and errcode \u003d\u003d libvirt.VIR_ERR_INTERNAL_ERROR and"},{"line_number":4177,"context_line":"                    \u0027error getting device from group\u0027 in errmsg):"},{"line_number":4178,"context_line":"                LOG.info("}],"source_content_type":"text/x-python","patch_set":6,"id":"7aee79d7_e72f8dfc","line":4175,"updated":"2024-05-23 16:45:25.000000000","message":"hummmm, never saw this issue. Could you please create a bug report for this so I could discuss this with some RHEL folks ?","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49cc46ab8e2a09993ba287d2ff2f8b14bcd546c3","unresolved":true,"context_lines":[{"line_number":4172,"context_line":"            #   Verify all devices in group \u003cgroup\u003e are bound to vfio-\u003cbus\u003e or"},{"line_number":4173,"context_line":"            #   pci-stub and not already in use"},{"line_number":4174,"context_line":"            # Retry the guest creation once in this case as it usually succeeds"},{"line_number":4175,"context_line":"            # on the second try."},{"line_number":4176,"context_line":"            if (mdevs and errcode \u003d\u003d libvirt.VIR_ERR_INTERNAL_ERROR and"},{"line_number":4177,"context_line":"                    \u0027error getting device from group\u0027 in errmsg):"},{"line_number":4178,"context_line":"                LOG.info("}],"source_content_type":"text/x-python","patch_set":6,"id":"bc3ee48d_9a2e95a9","line":4175,"in_reply_to":"7aee79d7_e72f8dfc","updated":"2024-05-23 17:09:25.000000000","message":"Sure, I\u0027ll open a bug.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[{"line_number":8822,"context_line":"                    \u0027Failed to set autostart to True for mdev \u0027"},{"line_number":8823,"context_line":"                    f\u0027{mdev_dev.name()} with UUID {uuid}: {str(e)}.\u0027)"},{"line_number":8824,"context_line":"        return uuid"},{"line_number":8825,"context_line":""},{"line_number":8826,"context_line":"    def _create_new_mediated_device(self, parent, uuid\u003dNone):"},{"line_number":8827,"context_line":"        \"\"\"Find a physical device that can support a new mediated device and"},{"line_number":8828,"context_line":"        create it."}],"source_content_type":"text/x-python","patch_set":6,"id":"7add77ab_494d334a","line":8825,"updated":"2024-05-23 16:45:25.000000000","message":"++","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":false,"context_lines":[{"line_number":8857,"context_line":"                        pci_addr, dev_supported_type, uuid\u003duuid)"},{"line_number":8858,"context_line":"                else:"},{"line_number":8859,"context_line":"                    chosen_mdev \u003d self._create_mdev("},{"line_number":8860,"context_line":"                        dev_name, dev_supported_type, uuid\u003duuid)"},{"line_number":8861,"context_line":"                LOG.info(\u0027Created mdev: %s on pGPU: %s.\u0027,"},{"line_number":8862,"context_line":"                         chosen_mdev, pci_addr)"},{"line_number":8863,"context_line":"                return chosen_mdev"}],"source_content_type":"text/x-python","patch_set":6,"id":"ec14640e_a5923d8e","line":8860,"updated":"2024-05-23 16:45:25.000000000","message":"the crux of the change is here 👍","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"}],"releasenotes/notes/persistent-mdevs-2a69e44baae9d5ca.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"14154cdd1ce108b61b29b63d599999743e7ed096","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    .. note::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"       After a compute host reboots, the virtual functions for the GPU must be"},{"line_number":9,"context_line":"       enabled again before instances will be able to use their vGPUs."},{"line_number":10,"context_line":"       Please see https://docs.openstack.org/nova/latest/admin/virtual-gpu.html"},{"line_number":11,"context_line":"       for more information."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e4cc2656_b1ba8dc8","line":8,"range":{"start_line":8,"start_character":37,"end_line":8,"end_character":71},"updated":"2024-05-23 16:45:25.000000000","message":"nit: this depends on the GPU, some of them don\u0027t support SR-IOV (like nVidia Tesla ones) so I\u0027d prefer you modify this release note by a FUP telling this (something like \u0027if you have a GPU supporting SR-IOV VFs, then...\u0027","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"49cc46ab8e2a09993ba287d2ff2f8b14bcd546c3","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    .. note::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"       After a compute host reboots, the virtual functions for the GPU must be"},{"line_number":9,"context_line":"       enabled again before instances will be able to use their vGPUs."},{"line_number":10,"context_line":"       Please see https://docs.openstack.org/nova/latest/admin/virtual-gpu.html"},{"line_number":11,"context_line":"       for more information."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3578f713_d9b6eeac","line":8,"range":{"start_line":8,"start_character":37,"end_line":8,"end_character":71},"in_reply_to":"e4cc2656_b1ba8dc8","updated":"2024-05-23 17:09:25.000000000","message":"OK will do.","commit_id":"74befb68a79f8bff823fe067e0054504391ee179"}]}