)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4b6ca053548d4c29cc16c94d54a5a48e1d26a027","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-29 18:29:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor _fetch_instance_kernel_ramdisk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit refactors the method _fetch_instance_kernel_ramdisk"},{"line_number":10,"context_line":"to avoid duplicated logic in the code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad9bd40_ab5bc22c","line":7,"updated":"2014-05-02 23:23:38.000000000","message":"I am not a fan of using the word \u0027refactor in the title of the commit message.\u0027 We don\u0027t like refacotring for the sake of refactoring, so how about something like make _fetch_... DRYer or something.","commit_id":"977d3d8befec2503f5b6f6b87848d1b846de7152"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2880f928185fc996f92f6546939785b6e56eda00","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-07 10:42:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make _fetch_instance_kernel_ramdisk DRYer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit refactors the method _fetch_instance_kernel_ramdisk"},{"line_number":10,"context_line":"to avoid duplicated logic in the code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_e375b898","line":7,"updated":"2014-06-11 13:38:07.000000000","message":"What do you mean by \u0027DRYer\u0027 here ?","commit_id":"e4ba898aa1b94ffb53ba7b8c58fa664e6c617c34"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0f7ccf94a2f1819459ffc81c60f82de35af32a4b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-07 10:42:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make _fetch_instance_kernel_ramdisk DRYer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit refactors the method _fetch_instance_kernel_ramdisk"},{"line_number":10,"context_line":"to avoid duplicated logic in the code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_127ae876","line":7,"in_reply_to":"1ae5cdf2_12074819","updated":"2014-06-11 15:27:33.000000000","message":"Then please just change the commit to say that instead of using obscure acronyms :-)","commit_id":"e4ba898aa1b94ffb53ba7b8c58fa664e6c617c34"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2d9442c0bfe41ef3262b9ef7d1435ea87344ce98","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-07 10:42:32 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make _fetch_instance_kernel_ramdisk DRYer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit refactors the method _fetch_instance_kernel_ramdisk"},{"line_number":10,"context_line":"to avoid duplicated logic in the code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_12074819","line":7,"in_reply_to":"1ae5cdf2_e375b898","updated":"2014-06-11 15:24:35.000000000","message":"Don\u0027t Repeat Yourself. It just means to consolidate duplicated code.","commit_id":"e4ba898aa1b94ffb53ba7b8c58fa664e6c617c34"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fbea317bbc587c6e151cf6712258748defaaf1d9","unresolved":false,"context_lines":[{"line_number":4505,"context_line":"        is configured, it tries to retrieve the images from the specified host."},{"line_number":4506,"context_line":"        \"\"\""},{"line_number":4507,"context_line":""},{"line_number":4508,"context_line":"        def fetch(context, instance, path, image_id, host\u003dNone):"},{"line_number":4509,"context_line":"            try:"},{"line_number":4510,"context_line":"                libvirt_utils.fetch_image(context, path,"},{"line_number":4511,"context_line":"                                          image_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_eed21cd1","line":4508,"updated":"2014-05-05 10:51:59.000000000","message":"why does this need to be an internal method? can you please move it out and then it can be tested","commit_id":"8396e0858058eb672653b9b215ad47d4c2b934c8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"458119ec405b4f196f0983cd17133d6e51466d35","unresolved":false,"context_lines":[{"line_number":4505,"context_line":"        is configured, it tries to retrieve the images from the specified host."},{"line_number":4506,"context_line":"        \"\"\""},{"line_number":4507,"context_line":""},{"line_number":4508,"context_line":"        def fetch(context, instance, path, image_id, host\u003dNone):"},{"line_number":4509,"context_line":"            try:"},{"line_number":4510,"context_line":"                libvirt_utils.fetch_image(context, path,"},{"line_number":4511,"context_line":"                                          image_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_108100fb","line":4508,"in_reply_to":"9ad9bd40_eed21cd1","updated":"2014-05-06 07:55:01.000000000","message":"Sorry Gary, I\u0027m not sure it makes sense to do this. This method is only used in this private function as an helper. - I\u0027m waiting for other comments and then update it if needed. looks ok for you?","commit_id":"8396e0858058eb672653b9b215ad47d4c2b934c8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fbea317bbc587c6e151cf6712258748defaaf1d9","unresolved":false,"context_lines":[{"line_number":4515,"context_line":"                if not host:"},{"line_number":4516,"context_line":"                    raise"},{"line_number":4517,"context_line":"                LOG.info(_(\"Image %(image_id)s doesn\u0027t exist anymore \""},{"line_number":4518,"context_line":"                           \"on image service, copy it from %(host)s\") %"},{"line_number":4519,"context_line":"                         dict(image_id\u003dimage_id, host\u003dhost))"},{"line_number":4520,"context_line":"                libvirt_utils.copy_image("},{"line_number":4521,"context_line":"                    src\u003dpath, dest\u003dpath, host\u003dhost, receive\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_4ed788bf","line":4518,"updated":"2014-05-05 10:51:59.000000000","message":"if you are touching here please use a , instead of % and {} insteda of dict","commit_id":"8396e0858058eb672653b9b215ad47d4c2b934c8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"458119ec405b4f196f0983cd17133d6e51466d35","unresolved":false,"context_lines":[{"line_number":4515,"context_line":"                if not host:"},{"line_number":4516,"context_line":"                    raise"},{"line_number":4517,"context_line":"                LOG.info(_(\"Image %(image_id)s doesn\u0027t exist anymore \""},{"line_number":4518,"context_line":"                           \"on image service, copy it from %(host)s\") %"},{"line_number":4519,"context_line":"                         dict(image_id\u003dimage_id, host\u003dhost))"},{"line_number":4520,"context_line":"                libvirt_utils.copy_image("},{"line_number":4521,"context_line":"                    src\u003dpath, dest\u003dpath, host\u003dhost, receive\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_30b444d0","line":4518,"in_reply_to":"9ad9bd40_4ed788bf","updated":"2014-05-06 07:55:01.000000000","message":"Sure If I need to make a new patchset I\u0027m going to update this. if not i will update this in a separate patch since it is not in relation with my this change.","commit_id":"8396e0858058eb672653b9b215ad47d4c2b934c8"}]}