)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"6f870ac76667bfb99b526270514214c9c4cca6f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b865d30_bf4b6e11","updated":"2024-03-12 06:18:09.000000000","message":"clean cherry-pick from bobcat, lgtm.","commit_id":"f2adeebdf2ed1fbd2b748d8b95b9f671829d235a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98cf83443afebce8b8d017dcb1fcc96418c56060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"17c649dc_46db2496","updated":"2024-03-06 12:39:16.000000000","message":"just to capture the conversation i had with dan yesterday\n\ni was initally \"hell no\" on fixing this the way the first pathch was written on master initally as it was adding addtional special caseing for behavioral difffernce between different nuetron backends. during the review on master following a converstation on irc we agreed to take a different appoch which is to check the enable_dhcp field on the subnet to deterim if a dhcp is enabled instead fo trying to find a dhcp port in the subnet.\n\nwhen using external dhcp there will not be any dhcp port\nwhen using ml2/ovs or similiar agents using non distributed dhcp it was network:dhcp and when using ovn or other distirbuted dhcp it was network:distributed.\n\nin all cases if dhcp is enabeld for the subnet enable_dhcp is set on the subnet so we nolonger have to care  how dhcp is provided in nova.\n\nwith this change in approch i was ok with merging this in master and with the backport. the enable_dhcp filed is part of the core subnet api and predates the neutron stadium possibly even the rename form quantum so there is no concern regarding aviablity of this filed for backporting.\n\n\nwith all that said this is a  clean cherry-pick form 2023.2\nthe author requested this be backported to zed so there would be one more backport to do once this is merged.","commit_id":"f2adeebdf2ed1fbd2b748d8b95b9f671829d235a"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"5a0409e3cc4d7cab4f4b6ca1c8489d02dd06c0d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85c33e2d_c2908a45","in_reply_to":"17c649dc_46db2496","updated":"2024-03-15 09:00:08.000000000","message":"Thanks Sean for sharing these details. The patch looks valid to me to backport. Besides, backported and merged to stable/2023.2 where the patch has merged + clean cherry pick, indeed. LGTM.","commit_id":"f2adeebdf2ed1fbd2b748d8b95b9f671829d235a"}]}