)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b55191b653f371bd25b5f2f21dcc100785024a46","unresolved":false,"context_lines":[{"line_number":14,"context_line":"source and destination libvirt drivers would call the same method to"},{"line_number":15,"context_line":"online and offline cores. This made it impossible to maintain distinct"},{"line_number":16,"context_line":"core power state between source and destination."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch inserts a nova.virt.libvirt.cpu.api.API class, and gives"},{"line_number":19,"context_line":"the libvirt driver a cpu_api attribute with an instance of that"},{"line_number":20,"context_line":"class. Along with the tiny API.core() helper, this allows new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8cc45635_92f95471","line":17,"updated":"2024-03-12 10:58:46.000000000","message":"hum ok there are other ways to do this with mocking and context managers but i agree this is simpler as it allows use to just do basic depency injection by replacin gthe api object per driver instnace.","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e5f94146aa849f18c7ee6e7006ff9fa528573746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"880f03d6_9175821e","updated":"2024-03-11 19:28:13.000000000","message":"Ignore the glance failure comment, I had the wrong review open.","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f67a3909c49717eec28951ed2a49bfb29dd65604","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b2fd678_868e67c3","updated":"2024-03-11 12:56:45.000000000","message":"Looks good to me. I think this is a nice testability improvement that has a limited implementation complexity","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"997243c9717f37a22b2d563989c07be2dde573f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e0ec486_454f076d","updated":"2024-03-11 19:27:21.000000000","message":"Looks like a glance failure somewhere:\n\nMar 11 15:32:23.012052 [controller/logs/screen-g-api.txt] np0037025745 devstack@g-api.service[91011]: WARNING glance.api.v2.images [None req-884d780f-2be3-46de-afb9-b84b0a8eb582 tempest-ServerStableDeviceRescueTest-574732549 tempest-ServerStableDeviceRescueTest-574732549-project-member] After upload to backend, deletion of staged image data has failed because it cannot be found at /tmp/staging//b0d04e61-d53a-4d60-82e0-6601f8ded3c1","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"fb8fb13cfe956751b804afd7c9ede05df3261668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1066e3d_d2f4678d","updated":"2024-03-11 19:38:00.000000000","message":"Looks like tempest timed out and deleting the instance before Nova was done creating it?\n\nMar 09 02:20:37.680181 [controller/logs/screen-n-cpu.txt] np0037007344 nova-compute[90529]: DEBUG nova.compute.utils [None req-a0108718-eade-4b12-829e-e7b3f4b815fc tempest-ServersWithSpecificFlavorTestJSON-1191008068 tempest-ServersWithSp\necificFlavorTestJSON-1191008068-project-member] [instance: 8b5f164d-4d3d-4caa-adac-9095b1b2333c] Conflict updating instance 8b5f164d-4d3d-4caa-adac-9095b1b2333c. Expected: {\u0027task_state\u0027: [\u0027spawning\u0027]}. Actual: {\u0027task_state\u0027: \u0027deleting\u0027} {\n{(pid\u003d90529) notify_about_instance_usage /opt/stack/nova/nova/compute/utils.py:430}}\nMar 09 02:20:37.682682 [controller/logs/screen-n-cpu.txt] np0037007344 nova-compute[90529]: DEBUG nova.compute.manager [None req-a0108718-eade-4b12-829e-e7b3f4b815fc tempest-ServersWithSpecificFlavorTestJSON-1191008068 tempest-ServersWith\nSpecificFlavorTestJSON-1191008068-project-member] [instance: 8b5f164d-4d3d-4caa-adac-9095b1b2333c] Instance disappeared during build. {{(pid\u003d90529) _do_build_and_run_instance /opt/stack/nova/nova/compute/manager.py:2504}}","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"23e8bb4b356fd7f2bf14c2e268ef36599ec21e07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4c378ad9_a30a4846","updated":"2024-03-13 15:07:12.000000000","message":"recheck","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"36bc550e24a6f42d4531fedb33cabec38a44b229","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83f4d10f_82a66798","updated":"2024-03-11 19:38:04.000000000","message":"recheck","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"72bea51d94f5853323cf759e7d189bcc7b25b8d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cd5eb2dc_3c1a5cde","updated":"2024-03-11 19:27:25.000000000","message":"recheck","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f35067520ed9c5439f5e08b85632f4a7974ba528","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f947c18b_e271a8d4","updated":"2024-03-13 19:33:37.000000000","message":"recheck nova-multi-cell failed one test test_snapshot_pattern because the vm could not reach the metadata api.\n\nthat a littel odd because i tought we forced config drive in all our jobs to prevent that being an issue but this might be related the the fact ovn does not properly wait for the metadata to be configured befor sending the vif plugged event.","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"}],"nova/virt/libvirt/cpu/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b55191b653f371bd25b5f2f21dcc100785024a46","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class API(object):"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def core(self, i):"},{"line_number":81,"context_line":"        \"\"\"From a purely functional point of view, there is no need for this"},{"line_number":82,"context_line":"        method. However, we want to test power management in multinode"},{"line_number":83,"context_line":"        scenarios (ex: live migration) in our functional tests. If we"}],"source_content_type":"text/x-python","patch_set":2,"id":"9876d9fe_76d03d1c","line":80,"updated":"2024-03-12 10:58:46.000000000","message":"nit: i would have prefered to keep all functions that dont need self as static or class methods but ok\n\nthe memory overhead is minimal i guess, i just dont like passing self unless its actully need.","commit_id":"29dc044a7aa1b1dd35ea4695c055feb5136ba1e5"}]}