)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5dd92824f83d339907626c656e7316fdb17320a9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove an unncessary LOG"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove an unnessary LOG call in virt/libvirt/driver.py"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If56c68c05b9daf60d81096cfc09e5f1a8df6bd76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f904369_43fac430","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":54},"updated":"2025-03-16 06:37:00.000000000","message":"By the way this is not really accurate because you are not removing a call but merging two calls.","commit_id":"ff51414be33535fd6219ac62aa88955a3b9b25f1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f2ab643a3f72acf8ea7e5a74fe2d7213b49de20b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove an unncessary LOG"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove an unnessary LOG call in virt/libvirt/driver.py"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If56c68c05b9daf60d81096cfc09e5f1a8df6bd76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b7448b8a_3e0be67d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":54},"in_reply_to":"5f904369_43fac430","updated":"2025-03-16 07:20:29.000000000","message":"(I\u0027m not saying this should be fixed, given how trivial it is. Just in case you have to respin this consider a better description)","commit_id":"ff51414be33535fd6219ac62aa88955a3b9b25f1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"e2b36867fbee191beda8c1b180dbaaacd768038e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"369ced6d_745dcf23","updated":"2024-03-13 07:13:07.000000000","message":"recheck","commit_id":"fed435068035d68c6fe7471b171de66b3a934255"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"585954e2f4a1826a3b41a546dc3046675f4b2dbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71ec717d_e5a743ce","updated":"2024-03-13 22:22:25.000000000","message":"recheck","commit_id":"fed435068035d68c6fe7471b171de66b3a934255"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"4dbfd435af54689002c0400295a5e849b1918049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4554585a_dc502795","updated":"2024-11-25 22:01:52.000000000","message":"gentle ping","commit_id":"ff51414be33535fd6219ac62aa88955a3b9b25f1"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"384bfc500249f6e182329cd0cdd8f1b5c018f088","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d36d55d_7465f5ec","updated":"2024-10-18 08:53:07.000000000","message":"gentle ping","commit_id":"ff51414be33535fd6219ac62aa88955a3b9b25f1"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"a7f1149b0ce3b6897bccb7f15db0f64ea6abed9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa43565c_3d0c6ff9","updated":"2024-03-24 11:56:40.000000000","message":"recheck","commit_id":"ff51414be33535fd6219ac62aa88955a3b9b25f1"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3424199e06534164105cf12c6fd6e74473f4c140","unresolved":true,"context_lines":[{"line_number":11545,"context_line":"                    \u0027%(max_attempts)s\u0027,"},{"line_number":11546,"context_line":"                    {\u0027current_attempt\u0027: current_attempt,"},{"line_number":11547,"context_line":"                     \u0027max_attempts\u0027: max_attempts}, instance\u003dinstance)"},{"line_number":11548,"context_line":"                LOG.exception()"},{"line_number":11549,"context_line":""},{"line_number":11550,"context_line":"    def post_live_migration_at_destination(self, context,"},{"line_number":11551,"context_line":"                                           instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4ab042b_d5218fd7","side":"PARENT","line":11548,"updated":"2024-03-22 02:25:30.000000000","message":"IMHO, I don\u0027t think this is unnecessary in that it will log the content of the caught exception [1] whereas the `LOG.warning` is an easy to read message about what happened.\n\n[1] https://docs.python.org/3/library/logging.html#logging.Logger.exception","commit_id":"671c4e03134db539aaabd266cbdc020b8b34d4df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"facb9c6abd92f50da6c50c4c9dcacc3a75230e20","unresolved":true,"context_lines":[{"line_number":11545,"context_line":"                    \u0027%(max_attempts)s\u0027,"},{"line_number":11546,"context_line":"                    {\u0027current_attempt\u0027: current_attempt,"},{"line_number":11547,"context_line":"                     \u0027max_attempts\u0027: max_attempts}, instance\u003dinstance)"},{"line_number":11548,"context_line":"                LOG.exception()"},{"line_number":11549,"context_line":""},{"line_number":11550,"context_line":"    def post_live_migration_at_destination(self, context,"},{"line_number":11551,"context_line":"                                           instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdb94d9_690df745","side":"PARENT","line":11548,"in_reply_to":"11f39313_fa9e1e4f","updated":"2024-03-22 12:58:08.000000000","message":"that is what stephen was suggesting\n\nthe only issue with taht is LOG.excpetion i think is at error level\n\nbut honestly we are usign Log.excption anyway so im fine with ust combining this into one call to  LOG.excpetion.","commit_id":"671c4e03134db539aaabd266cbdc020b8b34d4df"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"28145c8a676e6e18ef35f26ad14ad530ce5c1855","unresolved":true,"context_lines":[{"line_number":11545,"context_line":"                    \u0027%(max_attempts)s\u0027,"},{"line_number":11546,"context_line":"                    {\u0027current_attempt\u0027: current_attempt,"},{"line_number":11547,"context_line":"                     \u0027max_attempts\u0027: max_attempts}, instance\u003dinstance)"},{"line_number":11548,"context_line":"                LOG.exception()"},{"line_number":11549,"context_line":""},{"line_number":11550,"context_line":"    def post_live_migration_at_destination(self, context,"},{"line_number":11551,"context_line":"                                           instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"11f39313_fa9e1e4f","side":"PARENT","line":11548,"in_reply_to":"6dadf38d_7e56d3a6","updated":"2024-03-22 12:37:12.000000000","message":"IMHO, if exception context is important, why not replace the first warning with exception? LOG.exception without any input is weird...","commit_id":"671c4e03134db539aaabd266cbdc020b8b34d4df"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"aa4356dfeb6e8b1452c3548d901ede425c0da2fc","unresolved":false,"context_lines":[{"line_number":11545,"context_line":"                    \u0027%(max_attempts)s\u0027,"},{"line_number":11546,"context_line":"                    {\u0027current_attempt\u0027: current_attempt,"},{"line_number":11547,"context_line":"                     \u0027max_attempts\u0027: max_attempts}, instance\u003dinstance)"},{"line_number":11548,"context_line":"                LOG.exception()"},{"line_number":11549,"context_line":""},{"line_number":11550,"context_line":"    def post_live_migration_at_destination(self, context,"},{"line_number":11551,"context_line":"                                           instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a7d7b8f_ccebc3a0","side":"PARENT","line":11548,"in_reply_to":"9fdb94d9_690df745","updated":"2024-03-25 04:28:52.000000000","message":"Done","commit_id":"671c4e03134db539aaabd266cbdc020b8b34d4df"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d9d66fa78d98293f48811e97cb2d6343c146bcfd","unresolved":true,"context_lines":[{"line_number":11545,"context_line":"                    \u0027%(max_attempts)s\u0027,"},{"line_number":11546,"context_line":"                    {\u0027current_attempt\u0027: current_attempt,"},{"line_number":11547,"context_line":"                     \u0027max_attempts\u0027: max_attempts}, instance\u003dinstance)"},{"line_number":11548,"context_line":"                LOG.exception()"},{"line_number":11549,"context_line":""},{"line_number":11550,"context_line":"    def post_live_migration_at_destination(self, context,"},{"line_number":11551,"context_line":"                                           instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6dadf38d_7e56d3a6","side":"PARENT","line":11548,"in_reply_to":"a4ab042b_d5218fd7","updated":"2024-03-22 10:38:35.000000000","message":"This is my understanding also. We could also set `exc_info\u003dTrue` in the `LOG.warning` call above, or simply call `LOG.exception` instead of `LOG.warning`, but this is doing something useful rn","commit_id":"671c4e03134db539aaabd266cbdc020b8b34d4df"}]}