)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72d5257880637d08eff9778e192c38372a53f239","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"do not use str(url) to stringify a URL for subsequent use"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The str(url) function in SQLAlchemy hides the password."},{"line_number":10,"context_line":"For a URL string that is to be re-used, use"},{"line_number":11,"context_line":"render_as_string(hide_password\u003dFalse)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"41c7ac8f_0a24d801","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":35},"updated":"2024-03-21 16:59:25.000000000","message":"Note for reviewers: this behavior with hiding the password is new in SQLAlchemy 2.0 (that\u0027s why `str` was OK in the past).","commit_id":"819d8c29a825f4e017cfc092af6d268294989874"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c1b113babb0b2ff28b49b32d28476068b642c900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e8f656e_52c44972","updated":"2024-03-21 17:10:09.000000000","message":"I missed that there\u0027s a legit unit test failure here, test just needs to be adapted because of `render_as_string`.","commit_id":"819d8c29a825f4e017cfc092af6d268294989874"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72d5257880637d08eff9778e192c38372a53f239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02878862_a24599ab","updated":"2024-03-21 16:59:25.000000000","message":"LGTM, thanks","commit_id":"819d8c29a825f4e017cfc092af6d268294989874"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f28dfaad050724450786d74b0842855e046a663e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8410346d_3a597f31","updated":"2024-03-21 15:38:02.000000000","message":"whoops, missed this one","commit_id":"819d8c29a825f4e017cfc092af6d268294989874"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84e57b4d8c889410548a15eb33eb40c2c4716929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"38d11ac6_d7124645","updated":"2024-05-15 15:25:02.000000000","message":"Fixed the test","commit_id":"acbe3e28e5891a6f2cf2e833c301e72102200cc4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27ef9ad063dfb769c2a731d3ea0766d39f9018ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"98aa4c6d_ede94a45","updated":"2024-05-15 16:10:15.000000000","message":"LGTM. I\u0027ve updated the patches for the other repos, too...","commit_id":"acbe3e28e5891a6f2cf2e833c301e72102200cc4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3eb98fc89cbb0289efee6183de6f29b0df817274","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7f239e3_2a1fffbf","updated":"2024-05-15 17:58:33.000000000","message":"Update looks good, thanks!","commit_id":"acbe3e28e5891a6f2cf2e833c301e72102200cc4"}],"nova/db/migration.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72d5257880637d08eff9778e192c38372a53f239","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    # string using a mix of url encode styles for different parts of the url."},{"line_number":84,"context_line":"    # since we are updating the alembic config parser instance we need to"},{"line_number":85,"context_line":"    # escape \u0027%\u0027 to \u0027%%\u0027 to account for ConfigParser\u0027s string interpolation."},{"line_number":86,"context_line":"    url \u003d engine.url.render_as_string(hide_password\u003dFalse).replace(\u0027%\u0027, \u0027%%\u0027)"},{"line_number":87,"context_line":"    config.set_main_option(\u0027sqlalchemy.url\u0027, url)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # apply anything later"}],"source_content_type":"text/x-python","patch_set":1,"id":"a32e6143_8cec2d61","line":86,"updated":"2024-03-21 16:59:25.000000000","message":"Note for reviewers: this is similar to fix https://review.opendev.org/c/openstack/nova/+/880669, with SQAlchemy 2.0 `str` will mask passwords and for our config option urls, we don\u0027t want that behavior.","commit_id":"819d8c29a825f4e017cfc092af6d268294989874"}],"nova/tests/unit/db/test_migration.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27ef9ad063dfb769c2a731d3ea0766d39f9018ed","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            \u0027mysql+pymysql://nova:pass@192.168.24.3/nova?\u0027"},{"line_number":75,"context_line":"            \u0027read_default_file\u003d%2Fetc%2Fmy.cnf.d%2Fnova.cnf\u0027"},{"line_number":76,"context_line":"            \u0027\u0026read_default_group\u003dnova\u0027"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        migration.db_sync()"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d4b1d2a3_8fdc4f25","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":9},"updated":"2024-05-15 16:10:15.000000000","message":"unrelated side note: wondering why this was not caught by pep8 earlier...","commit_id":"acbe3e28e5891a6f2cf2e833c301e72102200cc4"}]}