)]}'
{"nova/network/quantum/client.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fc6ea27c572ebc793c223cfa204cc86e825b1532","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def deserialize(self, data, status_code):"},{"line_number":227,"context_line":"        if status_code \u003d\u003d 202:"},{"line_number":228,"context_line":"            return data"},{"line_number":229,"context_line":"        return JSONSerializer().deserialize(data, self.content_type())"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def content_type(self, format\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7xQ%3D","side":"PARENT","line":228,"updated":"2011-10-19 17:05:52.000000000","message":"How is this related to the change set?  Is this in preparation for future Quantum API changes?","commit_id":"821fae95d6aa86ffd14a4e48254da8ee7392c042"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"28c773c27e4a6c861aabaafad79bf6469674bb42","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def deserialize(self, data, status_code):"},{"line_number":227,"context_line":"        if status_code \u003d\u003d 202:"},{"line_number":228,"context_line":"            return data"},{"line_number":229,"context_line":"        return JSONSerializer().deserialize(data, self.content_type())"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def content_type(self, format\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7vI%3D","side":"PARENT","line":228,"in_reply_to":"AAAACX%2F%2F7xQ%3D","updated":"2011-10-19 18:29:05.000000000","message":"Yeah, at some point I\u0027m sure Salvatore will change things back to returning 202","commit_id":"821fae95d6aa86ffd14a4e48254da8ee7392c042"}],"nova/network/quantum/manager.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fc6ea27c572ebc793c223cfa204cc86e825b1532","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                                                    instance_id)"},{"line_number":203,"context_line":"        for vif in vifs:"},{"line_number":204,"context_line":"            net \u003d db.network_get(admin_context, vif[\u0027network_id\u0027])"},{"line_number":205,"context_line":"            net_id \u003d net[\u0027uuid\u0027]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            if not net_id:"},{"line_number":208,"context_line":"                # TODO(bgh): We need to figure out a way to tell if we"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7xE%3D","line":205,"updated":"2011-10-19 17:05:52.000000000","message":"My thinking was that we actually want to move away from the assumption that each Quantum network has a row in the nova networks table.  Couldn\u0027t we instead just modify the virtual_interfaces table to identify a network as a uuid, rather than an int?","commit_id":"64c034aa0a8981350bbef26cc9b9218ba87f7503"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"28c773c27e4a6c861aabaafad79bf6469674bb42","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                                                    instance_id)"},{"line_number":203,"context_line":"        for vif in vifs:"},{"line_number":204,"context_line":"            net \u003d db.network_get(admin_context, vif[\u0027network_id\u0027])"},{"line_number":205,"context_line":"            net_id \u003d net[\u0027uuid\u0027]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            if not net_id:"},{"line_number":208,"context_line":"                # TODO(bgh): We need to figure out a way to tell if we"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7vE%3D","line":205,"in_reply_to":"AAAACX%2F%2F7xE%3D","updated":"2011-10-19 18:29:05.000000000","message":"This is changed in the dhcp changes patchset -- as we talked about I\u0027m going to squash them.","commit_id":"64c034aa0a8981350bbef26cc9b9218ba87f7503"}],"nova/network/quantum/melange_ipam_lib.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fc6ea27c572ebc793c223cfa204cc86e825b1532","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        # FIXME(danwent):  Melange actually returns the subnet info"},{"line_number":143,"context_line":"        # when we query for a particular interface.  We may want to"},{"line_number":144,"context_line":"        # rework the ipam_manager python API to let us take advantage of"},{"line_number":145,"context_line":"        # this, as right now we have to get all blocks and cycle through"},{"line_number":146,"context_line":"        # them."},{"line_number":147,"context_line":"        subnet_v4 \u003d None"},{"line_number":148,"context_line":"        subnet_v6 \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7xA%3D","side":"PARENT","line":145,"updated":"2011-10-19 17:05:52.000000000","message":"Great, thanks for taking care of this.","commit_id":"821fae95d6aa86ffd14a4e48254da8ee7392c042"}],"nova/network/quantum/nova_ipam_lib.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fc6ea27c572ebc793c223cfa204cc86e825b1532","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        admin_context \u003d context.elevated()"},{"line_number":179,"context_line":"        net \u003d db.network_get_by_uuid(admin_context, quantum_net_id)"},{"line_number":180,"context_line":"        return net is not None"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def deallocate_ips_by_vif(self, context, tenant_id, net_id, vif_ref):"},{"line_number":183,"context_line":"        \"\"\"Deallocate all fixed IPs associated with the specified"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7ws%3D","line":180,"updated":"2011-10-19 17:05:52.000000000","message":"This is probably cleaner, but I think its technically not necessary as the network_get_by_uuid will either throw an exception or return a non-None value.","commit_id":"64c034aa0a8981350bbef26cc9b9218ba87f7503"}],"nova/network/quantum/quantum_connection.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fc6ea27c572ebc793c223cfa204cc86e825b1532","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        port_list_resdict \u003d self.client.list_ports(net_id, tenant\u003dtenant_id)"},{"line_number":108,"context_line":"        for p in port_list_resdict[\"ports\"]:"},{"line_number":109,"context_line":"            port_id \u003d p[\"id\"]"},{"line_number":110,"context_line":"            port_get_resdict \u003d self.client.show_port_attachment(net_id,"},{"line_number":111,"context_line":"                                port_id, tenant\u003dtenant_id)"},{"line_number":112,"context_line":"            if attachment_id \u003d\u003d port_get_resdict[\"attachment\"][\"id\"]:"},{"line_number":113,"context_line":"                return port_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F7wo%3D","line":110,"updated":"2011-10-19 17:05:52.000000000","message":"much better :)","commit_id":"64c034aa0a8981350bbef26cc9b9218ba87f7503"}]}