)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"492958f1699a7c3f1cece1986ea9e47981c10c48","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This had many of the attributes of a Controller but did not subclass it,"},{"line_number":10,"context_line":"meaning we were missing a few important attributes. Correct this"},{"line_number":11,"context_line":"oversight."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib89e2e02e8c85cc27f5b55caca5711e773959288"},{"line_number":14,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"685134bb_9287be43","line":11,"updated":"2024-03-25 12:59:25.000000000","message":"can you give any examples of what those imporant attributes might be.\n\nis this a bug that shoudl be backported or just somethign to fix going forward\nif the former can you file a bug.","commit_id":"0864473992e98b683ba4b2d26c0173f7a25a7baf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7926cf941bbbd83caac31fef3c3083cb52b379c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This had many of the attributes of a Controller but did not subclass it,"},{"line_number":10,"context_line":"meaning we were missing a few important attributes. Correct this"},{"line_number":11,"context_line":"oversight."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib89e2e02e8c85cc27f5b55caca5711e773959288"},{"line_number":14,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"187704b8_7e88b67f","line":11,"in_reply_to":"685134bb_9287be43","updated":"2024-03-27 17:35:44.000000000","message":"\u003e can you give any examples of what those imporant attributes might be.\n\nSure. Because we\u0027re not using `Controller` we don\u0027t use `ControllerMetaclass` which adds `wsgi_actions` on the created object. In additon, we don\u0027t have any of the `version_select` logic nor access to the `api_version`, `is_valid_body`, or `check_for_versions_intersection` class methods. As you might suspect, we\u0027re not using any of these right now so this isn\u0027t a bug that will have an impact on end-users. It will cause bugs later though, if we were to add microversioned behavior to this resource. More importantly (for me), it also means we need to special case this controller (but nothing else) which is annoying to say the least.\n\n\u003e is this a bug that shoudl be backported or just somethign to fix going forward\n\u003e if the former can you file a bug.\n\nThe latter.","commit_id":"0864473992e98b683ba4b2d26c0173f7a25a7baf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7926cf941bbbd83caac31fef3c3083cb52b379c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c08c3734_993e466e","updated":"2024-03-27 17:35:44.000000000","message":"Hopefully there\u0027s enough context there that I don\u0027t need to respin. This is very trivial and is mostly a quality of life improvement for moi.","commit_id":"0864473992e98b683ba4b2d26c0173f7a25a7baf"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ed79e07aeab302b0a1235a96452184383de07343","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a12ebbb_92f3118d","updated":"2024-04-19 20:42:37.000000000","message":"Looks OK to me","commit_id":"cabb6999a31603f57cbc782631daf42b3111ce02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5fe9cdae372da0b50a8e48b03df363599b532156","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b01074c_b4650b29","updated":"2024-04-15 10:52:55.000000000","message":"recheck unrelated tempest timeout","commit_id":"cabb6999a31603f57cbc782631daf42b3111ce02"}],"nova/api/openstack/compute/security_groups.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7b0e0c524411dddbee288a224beb77efad1c11e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return value"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class SecurityGroupController(SecurityGroupControllerBase, wsgi.Controller):"},{"line_number":146,"context_line":"    \"\"\"The Security group API controller for the OpenStack API.\"\"\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @wsgi.Controller.api_version(\"2.1\", MAX_PROXY_API_SUPPORT_VERSION)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b743561_dfa5a9d8","line":145,"updated":"2024-03-25 11:54:23.000000000","message":"Note that we subclass both `SecurityGroupControllerBase` and `wsgi.Controller` here...","commit_id":"0864473992e98b683ba4b2d26c0173f7a25a7baf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7b0e0c524411dddbee288a224beb77efad1c11e","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class SecurityGroupRulesController(SecurityGroupControllerBase,"},{"line_number":272,"context_line":"                                   wsgi.Controller):"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @wsgi.Controller.api_version(\"2.1\", MAX_PROXY_API_SUPPORT_VERSION)"},{"line_number":275,"context_line":"    @wsgi.expected_errors((400, 403, 404))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff190872_34ab921f","line":272,"updated":"2024-03-25 11:54:23.000000000","message":"...and here...","commit_id":"0864473992e98b683ba4b2d26c0173f7a25a7baf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7b0e0c524411dddbee288a224beb77efad1c11e","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"class ServerSecurityGroupController("},{"line_number":373,"context_line":"    SecurityGroupControllerBase, wsgi.Controller"},{"line_number":374,"context_line":"):"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @wsgi.expected_errors(404)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fc8172c9_d366003b","line":373,"updated":"2024-03-25 11:54:23.000000000","message":"...but not here.","commit_id":"0864473992e98b683ba4b2d26c0173f7a25a7baf"}]}