)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"726cb997e91af978efab33d136547cd6df2e8dc2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"(in the \u0027/action\u0027 API sense of the term). There\u0027s no reason for this"},{"line_number":11,"context_line":"delineation these days so simply remove it. This is pure code motion"},{"line_number":12,"context_line":"that doesn\u0027t do a whole lot for us right now, but it makes"},{"line_number":13,"context_line":"auto-generation much easier down the road."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia45013fc988acb9517aea42c3caa1fa45d63892e"},{"line_number":16,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"164634af_25b20af6","line":13,"range":{"start_line":13,"start_character":16,"end_line":13,"end_character":20},"updated":"2024-03-27 17:36:39.000000000","message":"emphasis on this. It means we don\u0027t need to special case the controller in external tooling and eventually in our own tests and OpenAPI spec generating tooling.","commit_id":"344d2b808718bf938e76340eb9d94c9f9f5fad00"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ec30d73948dd07fca1cbb2d2fdadcd3875c92fcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ea535bb_a0898df1","updated":"2024-04-19 20:50:21.000000000","message":"Agree this makes sense, I have found the separation to be confusing in the past","commit_id":"e504b765083a3892cf9e45001c7eb55c5eaad1e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5618d738f766370dfeaad67194992f080905c27f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a09b09e_eef3bfb0","updated":"2024-04-19 10:01:09.000000000","message":"grouping these in diffent contolere made sene when nova had extentions prior to the intoduction of microversions but now that we dont conolidating all flavor operations in a single contoller makes sense to me","commit_id":"e504b765083a3892cf9e45001c7eb55c5eaad1e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd4ffa52b8d1063f35be0c6602b80ecf1b3bb106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11782efc_ff91841c","updated":"2024-04-22 10:14:23.000000000","message":"recheck jobs were cancheled? i assume this was because of a zuul restart","commit_id":"e504b765083a3892cf9e45001c7eb55c5eaad1e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ccf287575b2bf6eb25a064e7a9d19bc444222c61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26717084_e0482920","updated":"2024-04-22 15:43:46.000000000","message":"recheck more failures","commit_id":"e504b765083a3892cf9e45001c7eb55c5eaad1e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9440ddbacb77f72f60397cb0da50a6b5017168b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"caf65539_8a14bc0f","updated":"2024-04-15 10:53:10.000000000","message":"recheck unrelated timeout in nova-next job","commit_id":"e504b765083a3892cf9e45001c7eb55c5eaad1e9"}],"nova/api/openstack/compute/flavors.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5618d738f766370dfeaad67194992f080905c27f","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # NOTE(oomichi): Return 202 for backwards compatibility but should be"},{"line_number":40,"context_line":"    # 204 as this operation complete the deletion of aggregate resource and"},{"line_number":41,"context_line":"    # return no response body."},{"line_number":42,"context_line":"    @wsgi.response(202)"},{"line_number":43,"context_line":"    @wsgi.expected_errors(404)"},{"line_number":44,"context_line":"    def delete(self, req, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab921c0_df799c6a","line":41,"updated":"2024-04-19 10:01:09.000000000","message":"204 is more explict but 202 is vaild as well\n\n202 accpeted is vaild for any successful async operation\n\n202 can be considered incorrect as this is not an async operation and the deletion is done before the reponce return which is the semantic of 204","commit_id":"e504b765083a3892cf9e45001c7eb55c5eaad1e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5618d738f766370dfeaad67194992f080905c27f","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # NOTE(oomichi): Return 200 for backwards compatibility but should be 201"},{"line_number":55,"context_line":"    # as this operation complete the creation of flavor resource."},{"line_number":56,"context_line":"    @wsgi.expected_errors((400, 409))"},{"line_number":57,"context_line":"    @validation.schema(schema.create_v20, \u00272.0\u0027, \u00272.0\u0027)"},{"line_number":58,"context_line":"    @validation.schema(schema.create, \u00272.1\u0027, \u00272.54\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"81b46037_9bf94a07","line":55,"updated":"2024-04-19 10:01:09.000000000","message":"again 201 might be more desciptive but  200 is not incorrect.","commit_id":"e504b765083a3892cf9e45001c7eb55c5eaad1e9"}]}