)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4fa04091c1411c7350f11151914b458c23b38981","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43e37ba8_9a46476f","updated":"2024-08-09 02:36:22.000000000","message":"+1 pending filing a glance bug.\n\nwe likely should also have a comment to clean this up once the glance bug is fixed as i dont think we generally should retry on a 500 so i see this really as a temporay messure","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"060300c2392bccc82c1284524d28f7bc2c8de3d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4d424f2_64a9209a","updated":"2024-08-09 15:16:13.000000000","message":"I tried to reproduce the 500 error to capture the logs to report a glance bug but eventually noticed that now the jobs are passing without any issues. I checked git logs in glance and glance_store but could not find anything apparently fixing the issue...\n# I remember the issue was caused by some timing problem caused by tricky attachment handling in cinder but didn\u0027t keep actual logs.\n\nSo probably we should close the bug and abandon the change and restore these in case we hit the same problem again.","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c6692e470dd26970fc970d3eecba906ff5a3be31","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db28dd94_360804b5","in_reply_to":"b4d424f2_64a9209a","updated":"2024-09-02 07:57:29.000000000","message":"I support this.","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90c451f836b7fcbd3fdbe66e6f3231b8fb03cbd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10c85244_653ff108","in_reply_to":"db28dd94_360804b5","updated":"2024-09-03 12:57:14.000000000","message":"So I excluded the part to handle the 500 error and now this change only handles the deprecated exceptions.","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f0f631a1da9f47e068c1d272f8831d00942d50f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4e74a1e_4c7592e4","updated":"2026-04-29 12:55:12.000000000","message":"Let\u0027s get this in","commit_id":"478e7263672d97e9d60a55e4978469164fd25354"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"890265d4c3a5f9d619259e45db441ccfe726ebca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"550f6aea_b6a5e8d6","updated":"2026-05-01 16:04:01.000000000","message":"recheck","commit_id":"478e7263672d97e9d60a55e4978469164fd25354"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aa0525644ed40bdd2e5531e9eae0c92b9f16dcaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"732e662c_280ad37c","updated":"2026-04-30 08:04:41.000000000","message":"recheck","commit_id":"478e7263672d97e9d60a55e4978469164fd25354"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40817b1e56e9906940775bdd8560f222b1e2e810","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fcfe17f8_96341380","updated":"2026-04-29 20:53:59.000000000","message":"recheck","commit_id":"478e7263672d97e9d60a55e4978469164fd25354"}],"nova/image/glance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e99fb18f779625804c977110bcee40faa29d84e6","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        args \u003d args or []"},{"line_number":178,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":179,"context_line":"        retry_excs \u003d ("},{"line_number":180,"context_line":"                glanceclient.exc.HTTPInternalServerError,"},{"line_number":181,"context_line":"                glanceclient.exc.HTTPServiceUnavailable,"},{"line_number":182,"context_line":"                glanceclient.exc.InvalidEndpoint,"},{"line_number":183,"context_line":"                glanceclient.exc.CommunicationError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a2323d1c_a6ac1573","line":180,"updated":"2024-07-17 14:58:28.000000000","message":"Is there a separate effort fixing the root cause of the 500 in glance? Otherwise this feels like we are papering over a glance bug in nova.","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90c451f836b7fcbd3fdbe66e6f3231b8fb03cbd3","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        args \u003d args or []"},{"line_number":178,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":179,"context_line":"        retry_excs \u003d ("},{"line_number":180,"context_line":"                glanceclient.exc.HTTPInternalServerError,"},{"line_number":181,"context_line":"                glanceclient.exc.HTTPServiceUnavailable,"},{"line_number":182,"context_line":"                glanceclient.exc.InvalidEndpoint,"},{"line_number":183,"context_line":"                glanceclient.exc.CommunicationError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f285e66b_2899444b","line":180,"in_reply_to":"5c417c5d_eac4d717","updated":"2024-09-03 12:57:14.000000000","message":"As is discussed, I dropped the change to handle 500 error from this change and focus on replacing the deprecated exceptions.","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"767bde8a363921a2775793f5e5ed3e105d9cd0af","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        args \u003d args or []"},{"line_number":178,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":179,"context_line":"        retry_excs \u003d ("},{"line_number":180,"context_line":"                glanceclient.exc.HTTPInternalServerError,"},{"line_number":181,"context_line":"                glanceclient.exc.HTTPServiceUnavailable,"},{"line_number":182,"context_line":"                glanceclient.exc.InvalidEndpoint,"},{"line_number":183,"context_line":"                glanceclient.exc.CommunicationError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c417c5d_eac4d717","line":180,"in_reply_to":"671a5be6_9623a0cf","updated":"2024-07-19 11:10:11.000000000","message":"I agree that it is probably safe to retry on 500, I just want to make sure that in the same time we are addressing the root case as 500 is never a valid response code, it is always a bug in my understanding.","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"819f363d89a6034fd6c5bf60f9f1bd586a63cd8a","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        args \u003d args or []"},{"line_number":178,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":179,"context_line":"        retry_excs \u003d ("},{"line_number":180,"context_line":"                glanceclient.exc.HTTPInternalServerError,"},{"line_number":181,"context_line":"                glanceclient.exc.HTTPServiceUnavailable,"},{"line_number":182,"context_line":"                glanceclient.exc.InvalidEndpoint,"},{"line_number":183,"context_line":"                glanceclient.exc.CommunicationError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"671a5be6_9623a0cf","line":180,"in_reply_to":"a2323d1c_a6ac1573","updated":"2024-07-17 15:12:48.000000000","message":"No, right now. I can probably report a bug to discuss a better status code (or possibility to implement a retry logic to avoid the immediate error).\n\nOn the other hand, I see multiple implementations in nova (eg. cinder API call and neutron API call) retries for 500 error. Most of 500 errors indicate server side problems (temporal DB unavailability for example) and retrying API call for 500 is relatively safe to be added, IMO.","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d68c72a4cb7772fb18e84f9a0f6115061d11441","unresolved":true,"context_lines":[{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"def _translate_image_exception(image_id, exc_value):"},{"line_number":1045,"context_line":"    if isinstance(exc_value, (glanceclient.exc.HTTPForbidden,"},{"line_number":1046,"context_line":"                    glanceclient.exc.HTTPUnauthorized)):"},{"line_number":1047,"context_line":"        return exception.ImageNotAuthorized(image_id\u003dimage_id)"},{"line_number":1048,"context_line":"    if isinstance(exc_value, glanceclient.exc.HTTPNotFound):"}],"source_content_type":"text/x-python","patch_set":3,"id":"41c5c434_cff5ec17","line":1045,"updated":"2024-09-03 12:48:37.000000000","message":"if we want to restore this to adress the deprecated excpetiions that vaidl but we woudl want to remove the addation of \n\n glanceclient.exc.HTTPInternalServerError on line 180\n and update teh  commit message","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90c451f836b7fcbd3fdbe66e6f3231b8fb03cbd3","unresolved":false,"context_lines":[{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"def _translate_image_exception(image_id, exc_value):"},{"line_number":1045,"context_line":"    if isinstance(exc_value, (glanceclient.exc.HTTPForbidden,"},{"line_number":1046,"context_line":"                    glanceclient.exc.HTTPUnauthorized)):"},{"line_number":1047,"context_line":"        return exception.ImageNotAuthorized(image_id\u003dimage_id)"},{"line_number":1048,"context_line":"    if isinstance(exc_value, glanceclient.exc.HTTPNotFound):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f33a9cc6_f6acb5bc","line":1045,"in_reply_to":"41c5c434_cff5ec17","updated":"2024-09-03 12:57:14.000000000","message":"Done","commit_id":"062daa7201e2af3858d9b2270fc922aa8b441109"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6aca7465c1e8bbf858d83589aa3eafdf08507080","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        args \u003d args or []"},{"line_number":178,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":179,"context_line":"        retry_excs \u003d ("},{"line_number":180,"context_line":"                glanceclient.exc.HTTPInternalServerError,"},{"line_number":181,"context_line":"                glanceclient.exc.InvalidEndpoint,"},{"line_number":182,"context_line":"                glanceclient.exc.CommunicationError,"},{"line_number":183,"context_line":"                IOError)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7aca8d9_4e7c1c94","line":180,"updated":"2024-09-03 13:20:38.000000000","message":"so this is still here.\n\nwe dont want to rety on an internal serve error (500)\n\nbut we shoudl retry if there is a 503 service unaviable.","commit_id":"b6308d1982bf99989c0f47b2b56792450708f474"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38950922d8d60124c701e8029bbb4c3b5f23fee8","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        args \u003d args or []"},{"line_number":178,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":179,"context_line":"        retry_excs \u003d ("},{"line_number":180,"context_line":"                glanceclient.exc.HTTPInternalServerError,"},{"line_number":181,"context_line":"                glanceclient.exc.InvalidEndpoint,"},{"line_number":182,"context_line":"                glanceclient.exc.CommunicationError,"},{"line_number":183,"context_line":"                IOError)"}],"source_content_type":"text/x-python","patch_set":4,"id":"634057e7_00c2bf03","line":180,"in_reply_to":"a7aca8d9_4e7c1c94","updated":"2024-09-03 14:26:56.000000000","message":"Yes I replaced it by a wrong exception... Fixed this in the latest version.","commit_id":"b6308d1982bf99989c0f47b2b56792450708f474"}]}