)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":true,"context_lines":[{"line_number":7,"context_line":"api: Add remaining missing request body schemas"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This provides us a path to generate OpenAPI schemas for the nova API."},{"line_number":10,"context_line":"Thankfully most of the API documentation is pretty darn simple. Note"},{"line_number":11,"context_line":"that we need to fix a lot of unit tests so that they pass correct bodies"},{"line_number":12,"context_line":"to the controller methods under test. Also note that the"},{"line_number":13,"context_line":"\u0027reset_server_state\u0027 module in \u0027nova.api.openstack.compute.schemas\u0027 is"},{"line_number":14,"context_line":"renamed to \u0027admin_actions\u0027 to match the name of the module containing"},{"line_number":15,"context_line":"the controller itself, as is the case for all other schemas."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba93b4fd_f0d3e91d","line":12,"range":{"start_line":10,"start_character":64,"end_line":12,"end_character":37},"updated":"2024-06-21 02:57:52.000000000","message":"yeah, most of unit test directly call controller method which should be going via API router so that correct way to passing request body can be shown there. ++ for fixing them to correct req body.","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca8e0e1f4946e6d437b3b7d12ca0aa94e3020e68","unresolved":false,"context_lines":[{"line_number":7,"context_line":"api: Add remaining missing request body schemas"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This provides us a path to generate OpenAPI schemas for the nova API."},{"line_number":10,"context_line":"Thankfully most of the API documentation is pretty darn simple. Note"},{"line_number":11,"context_line":"that we need to fix a lot of unit tests so that they pass correct bodies"},{"line_number":12,"context_line":"to the controller methods under test. Also note that the"},{"line_number":13,"context_line":"\u0027reset_server_state\u0027 module in \u0027nova.api.openstack.compute.schemas\u0027 is"},{"line_number":14,"context_line":"renamed to \u0027admin_actions\u0027 to match the name of the module containing"},{"line_number":15,"context_line":"the controller itself, as is the case for all other schemas."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"36efa2e6_b67e5b8d","line":12,"range":{"start_line":10,"start_character":64,"end_line":12,"end_character":37},"in_reply_to":"ba93b4fd_f0d3e91d","updated":"2024-06-24 10:32:04.000000000","message":"Acknowledged","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"394534b1_66482969","updated":"2024-06-21 02:57:52.000000000","message":"almost lgtm except we need to keep additionalProperties as True even for Action API just in case if anyone sending some extra param (by mistake) can continue working.","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5b2a6cc58162581c4995c28f0a31021ba9f5afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6eeb7300_641e5525","updated":"2024-06-28 02:50:51.000000000","message":"thanks Stephen for pointing your note about Action APIs. Change lgtm now.","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"}],"nova/api/openstack/compute/baremetal_nodes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"844ac6aea386a5671b737de9745af63b1b219ebc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.api.openstack.api_version_request \\"},{"line_number":23,"context_line":"    import MAX_PROXY_API_SUPPORT_VERSION"},{"line_number":24,"context_line":"from nova.api.openstack.compute.schemas \\"},{"line_number":25,"context_line":"    import baremetal_nodes as schema_baremetal_nodes"},{"line_number":26,"context_line":"from nova.api.openstack import wsgi"},{"line_number":27,"context_line":"from nova.api import validation"},{"line_number":28,"context_line":"import nova.conf"}],"source_content_type":"text/x-python","patch_set":3,"id":"29d7c132_a8123124","line":25,"range":{"start_line":25,"start_character":30,"end_line":25,"end_character":52},"updated":"2024-04-19 10:37:20.000000000","message":"whoops, should have called this `schema` for consistency. Will be addressed later as we add response body schemas anyway.","commit_id":"6d3d6bb61283f81bb1e86178fc092d7ecce91223"}],"nova/api/openstack/compute/schemas/admin_actions.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"54c5393d95c1044294b030100aff64e5f82404b6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027injectNetworkInfo\u0027: {},"},{"line_number":24,"context_line":"    },"},{"line_number":25,"context_line":"    \u0027required\u0027: [\u0027injectNetworkInfo\u0027],"},{"line_number":26,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"reset_state \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"d0f0bd38_d14d35a9","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":34},"updated":"2024-04-15 11:07:06.000000000","message":"Note for reviewers: it\u0027s okay to specify this because we already restrict the user to a single top-level key for actions [here](https://github.com/openstack/nova/blob/c199becf52267ba37c5191f6f82e29bb5232b607/nova/api/openstack/wsgi.py#L329-L332). The exact error message string will change but the response code or general format of the response body won\u0027t, so I think this is acceptable.","commit_id":"6d3d6bb61283f81bb1e86178fc092d7ecce91223"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        \u0027injectNetworkInfo\u0027: {},"},{"line_number":24,"context_line":"    },"},{"line_number":25,"context_line":"    \u0027required\u0027: [\u0027injectNetworkInfo\u0027],"},{"line_number":26,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"reset_state \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f0f9bd6_021ebb07","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":34},"updated":"2024-06-21 02:57:52.000000000","message":"unfortunately we need to keep additionalProperties True\n\nsame comment for all of the Action APIs schema","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca8e0e1f4946e6d437b3b7d12ca0aa94e3020e68","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        \u0027injectNetworkInfo\u0027: {},"},{"line_number":24,"context_line":"    },"},{"line_number":25,"context_line":"    \u0027required\u0027: [\u0027injectNetworkInfo\u0027],"},{"line_number":26,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"reset_state \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"f38376da_602336dc","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":34},"in_reply_to":"3f0f9bd6_021ebb07","updated":"2024-06-24 10:32:04.000000000","message":"Please see my note [here](https://review.opendev.org/c/openstack/nova/+/915734/3/nova/api/openstack/compute/schemas/admin_actions.py): we can use `additionalProperties` for action APIs.","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e5b2a6cc58162581c4995c28f0a31021ba9f5afc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        \u0027injectNetworkInfo\u0027: {},"},{"line_number":24,"context_line":"    },"},{"line_number":25,"context_line":"    \u0027required\u0027: [\u0027injectNetworkInfo\u0027],"},{"line_number":26,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"reset_state \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a4e6c9e_3ffe26f8","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":34},"in_reply_to":"f38376da_602336dc","updated":"2024-06-28 02:50:51.000000000","message":"ah you are right, Sorry I missed that and your note. Thanks. this lgtm","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"}],"nova/api/openstack/compute/schemas/deferred_delete.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"844ac6aea386a5671b737de9745af63b1b219ebc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0027properties\u0027: {"},{"line_number":17,"context_line":"        \u0027restore\u0027: {},"},{"line_number":18,"context_line":"    },"},{"line_number":19,"context_line":"    \u0027required\u0027: [\u0027restore\u0027],"},{"line_number":20,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# TODO(stephenfin): Restrict the value to \u0027null\u0027 in a future API version"}],"source_content_type":"text/x-python","patch_set":3,"id":"1da4cba3_18b9349d","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":34},"updated":"2024-04-19 10:37:20.000000000","message":"Same comment as [earlier](https://review.opendev.org/c/openstack/nova/+/915734/3/nova/api/openstack/compute/schemas/admin_actions.py) around this being okay because we already validate that only one top-level key is given. Ditto for all other actions.","commit_id":"6d3d6bb61283f81bb1e86178fc092d7ecce91223"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        \u0027restore\u0027: {},"},{"line_number":18,"context_line":"    },"},{"line_number":19,"context_line":"    \u0027required\u0027: [\u0027restore\u0027],"},{"line_number":20,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# TODO(stephenfin): Restrict the value to \u0027null\u0027 in a future API version"}],"source_content_type":"text/x-python","patch_set":4,"id":"bee826e7_f55a4eaa","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":34},"updated":"2024-06-21 02:57:52.000000000","message":"ditto additionalProperties True","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca8e0e1f4946e6d437b3b7d12ca0aa94e3020e68","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        \u0027restore\u0027: {},"},{"line_number":18,"context_line":"    },"},{"line_number":19,"context_line":"    \u0027required\u0027: [\u0027restore\u0027],"},{"line_number":20,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# TODO(stephenfin): Restrict the value to \u0027null\u0027 in a future API version"}],"source_content_type":"text/x-python","patch_set":4,"id":"39f2d66f_379e41b9","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":34},"in_reply_to":"bee826e7_f55a4eaa","updated":"2024-06-24 10:32:04.000000000","message":"Ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        \u0027forceDelete\u0027: {},"},{"line_number":28,"context_line":"    },"},{"line_number":29,"context_line":"    \u0027required\u0027: [\u0027forceDelete\u0027],"},{"line_number":30,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"0665098d_0bb71f6b","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":34},"updated":"2024-06-21 02:57:52.000000000","message":"ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca8e0e1f4946e6d437b3b7d12ca0aa94e3020e68","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027forceDelete\u0027: {},"},{"line_number":28,"context_line":"    },"},{"line_number":29,"context_line":"    \u0027required\u0027: [\u0027forceDelete\u0027],"},{"line_number":30,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"d88c3868_6c72078d","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":34},"in_reply_to":"0665098d_0bb71f6b","updated":"2024-06-24 10:32:04.000000000","message":"Ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"}],"nova/api/openstack/compute/schemas/floating_ips.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"844ac6aea386a5671b737de9745af63b1b219ebc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \u0027pool\u0027: {"},{"line_number":22,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":23,"context_line":"        },"},{"line_number":24,"context_line":"    },"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"add_floating_ip \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"5810f372_1f718941","line":24,"updated":"2024-04-19 10:37:20.000000000","message":"I should probably add a note here that we shouldn\u0027t make this stricter because the API is deprecated (it\u0027s a proxy API). In any case, you can see that the schema matches the logic [here](https://review.opendev.org/c/openstack/nova/+/915734/3/nova/api/openstack/compute/floating_ips.py#125), i.e. we expect either an empty body or an object with an optional key `pool`.","commit_id":"6d3d6bb61283f81bb1e86178fc092d7ecce91223"}],"nova/api/openstack/compute/schemas/lock_server.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        \u0027lock\u0027: {},"},{"line_number":17,"context_line":"    },"},{"line_number":18,"context_line":"    \u0027required\u0027: [\u0027lock\u0027],"},{"line_number":19,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"lock_v273 \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"6e323917_b2dc07f1","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":34},"updated":"2024-06-21 02:57:52.000000000","message":"ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca8e0e1f4946e6d437b3b7d12ca0aa94e3020e68","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027lock\u0027: {},"},{"line_number":17,"context_line":"    },"},{"line_number":18,"context_line":"    \u0027required\u0027: [\u0027lock\u0027],"},{"line_number":19,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"lock_v273 \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"adbf00b5_0ce46ae6","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":34},"in_reply_to":"6e323917_b2dc07f1","updated":"2024-06-24 10:32:04.000000000","message":"Ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        \u0027unlock\u0027: {},"},{"line_number":44,"context_line":"    },"},{"line_number":45,"context_line":"    \u0027required\u0027: [\u0027unlock\u0027],"},{"line_number":46,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"465be50c_2ec659a0","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":34},"updated":"2024-06-21 02:57:52.000000000","message":"ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca8e0e1f4946e6d437b3b7d12ca0aa94e3020e68","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \u0027unlock\u0027: {},"},{"line_number":44,"context_line":"    },"},{"line_number":45,"context_line":"    \u0027required\u0027: [\u0027unlock\u0027],"},{"line_number":46,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fcb5b7bc_43e695f3","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":34},"in_reply_to":"465be50c_2ec659a0","updated":"2024-06-24 10:32:04.000000000","message":"Ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"}],"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b15448315e00f27553bd6aec6b2994a285927804","unresolved":true,"context_lines":[{"line_number":511,"context_line":"        \u0027confirmResize\u0027: {}"},{"line_number":512,"context_line":"    },"},{"line_number":513,"context_line":"    \u0027required\u0027: [\u0027confirmResize\u0027],"},{"line_number":514,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":515,"context_line":"}"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"# TODO(stephenfin): Restrict the value to \u0027null\u0027 in a future API version"}],"source_content_type":"text/x-python","patch_set":4,"id":"d862f2c0_f19a3a3c","line":514,"range":{"start_line":514,"start_character":0,"end_line":514,"end_character":33},"updated":"2024-06-21 02:57:52.000000000","message":"ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca8e0e1f4946e6d437b3b7d12ca0aa94e3020e68","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        \u0027confirmResize\u0027: {}"},{"line_number":512,"context_line":"    },"},{"line_number":513,"context_line":"    \u0027required\u0027: [\u0027confirmResize\u0027],"},{"line_number":514,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":515,"context_line":"}"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"# TODO(stephenfin): Restrict the value to \u0027null\u0027 in a future API version"}],"source_content_type":"text/x-python","patch_set":4,"id":"0cb9fdfe_60ab4b1b","line":514,"range":{"start_line":514,"start_character":0,"end_line":514,"end_character":33},"in_reply_to":"d862f2c0_f19a3a3c","updated":"2024-06-24 10:32:04.000000000","message":"Ditto","commit_id":"f86cd38dfe541ec16b90eac8d6bfc1192dbe946b"}],"nova/api/openstack/compute/schemas/shelve.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"844ac6aea386a5671b737de9745af63b1b219ebc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"unshelve \u003d {"},{"line_number":38,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":39,"context_line":"    \u0027properties\u0027: {"},{"line_number":40,"context_line":"        \u0027unshelve\u0027: {},"}],"source_content_type":"text/x-python","patch_set":3,"id":"e3bbc940_43deee6f","line":37,"updated":"2024-04-19 10:37:20.000000000","message":"Missing TODO here, but this should also be updated. Heck, all empty schemas for non-deprecated APIs should be updated.","commit_id":"6d3d6bb61283f81bb1e86178fc092d7ecce91223"}]}