)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c628c38f5aa9994abec7739113e9c3bfd1ce7a44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2abe002_2295bb88","updated":"2024-07-20 07:17:09.000000000","message":"again looks fine over all just some style nit which im ok being adress in a follow up patch","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1a5780becf443b73f4b2da31efd03bfd2d6ff5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"39ba3643_a6c3d565","updated":"2024-07-19 00:17:41.000000000","message":"lgtm","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1b8433f08554925f3cef9a7194ec658923ba7f5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f0bfa38f_00a25d74","updated":"2024-08-09 02:09:41.000000000","message":"recheck single unrelated shelve failure","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c163e067564ef30eb1496f08bffe239f3aa525b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e95a6547_d7950543","updated":"2024-07-23 13:48:08.000000000","message":"recheck unrelated failure on earlier patch","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"20e4ade784fbe2dd8b1f252d76b3c4b8039a4baf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d18e1c15_c675afff","updated":"2024-07-22 10:23:04.000000000","message":"recheck unrelated failure on previous patch","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"44ac90a96d03e446daa3de0d644cdad73c52c6be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"411551a8_a0e665b5","updated":"2024-08-16 18:05:44.000000000","message":"recheck unrelated random unit test failure \n\ntest_schedule_and_build_over_quota_during_recheck\n\nTraceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/fixtures/fixture.py\", line 124, in cleanUp\n    return self._cleanups(raise_errors\u003draise_first)\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/fixtures/callmany.py\", line 84, in __call__\n    raise error[1].with_traceback(error[2])\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/fixtures/callmany.py\", line 78, in __call__\n    cleanup(*args, **kwargs)\n  File \"/home/zuul/src/opendev.org/openstack/nova/nova/service.py\", line 288, in kill\n    self.service_ref.destroy()\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/oslo_versionedobjects/base.py\", line 226, in wrapper\n    return fn(self, *args, **kwargs)\n  File \"/home/zuul/src/opendev.org/openstack/nova/nova/objects/service.py\", line 538, in destroy\n    db.service_destroy(self._context, self.id)\n  File \"/home/zuul/src/opendev.org/openstack/nova/nova/db/main/api.py\", line 206, in wrapper\n    with ctxt_mgr.writer.using(context):\n  File \"/usr/lib/python3.9/contextlib.py\", line 117, in __enter__\n    return next(self.gen)\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/oslo_db/sqlalchemy/enginefacade.py\", line 1042, in _transaction_scope\n    with current._produce_block(\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/oslo_db/sqlalchemy/enginefacade.py\", line 693, in _produce_block\n    self._writer()\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py39/lib/python3.9/site-packages/oslo_db/sqlalchemy/enginefacade.py\", line 707, in _writer\n    raise TypeError(\nTypeError: Can\u0027t upgrade a READER transaction to a WRITER mid-transaction","commit_id":"be029783ddced7277c1eee2243091348b7db843b"}],"nova/api/validation/__init__.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a2fc0abc1f70ca21c20578de40976e0f6ca37532","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                max_version,"},{"line_number":182,"context_line":"                args,"},{"line_number":183,"context_line":"                kwargs"},{"line_number":184,"context_line":"            )"},{"line_number":185,"context_line":"            return response"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        wrapper._response_schema \u003d response_body_schema"}],"source_content_type":"text/x-python","patch_set":5,"id":"093744a8_41b2c84d","line":184,"updated":"2024-05-01 11:10:00.000000000","message":"We\u0027re not actually using the `[api] response_validation` config option added in the previous patch here yet. We should, and we should wrap the error in `strutils.mask_password` to mask any potentially sensitive information here.","commit_id":"6d3c4238645aa94880a376136049a54ff3602ecd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"04a375710342694e42bc28479587ab0d149169ba","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                max_version,"},{"line_number":182,"context_line":"                args,"},{"line_number":183,"context_line":"                kwargs"},{"line_number":184,"context_line":"            )"},{"line_number":185,"context_line":"            return response"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        wrapper._response_schema \u003d response_body_schema"}],"source_content_type":"text/x-python","patch_set":5,"id":"28b75978_99173747","line":184,"in_reply_to":"093744a8_41b2c84d","updated":"2024-07-19 11:56:35.000000000","message":"Done","commit_id":"6d3c4238645aa94880a376136049a54ff3602ecd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c628c38f5aa9994abec7739113e9c3bfd1ce7a44","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"import webob"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova.api.openstack import api_version_request as api_version"},{"line_number":28,"context_line":"from nova.api.openstack import wsgi"}],"source_content_type":"text/x-python","patch_set":6,"id":"979ad3c2_927048c9","line":25,"updated":"2024-07-20 07:17:09.000000000","message":"nit: https://webob.org/\nthis is not part of openstack so this is not the correct secton\n\nit should be befor the oslo imports \n\ncan you fix this in a folloup","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e50cafe204dc4a029ef4d9411db69eb49a8fe166","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"import webob"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova.api.openstack import api_version_request as api_version"},{"line_number":28,"context_line":"from nova.api.openstack import wsgi"}],"source_content_type":"text/x-python","patch_set":6,"id":"715cf491_db3ce5d3","line":25,"in_reply_to":"979ad3c2_927048c9","updated":"2024-07-22 10:25:55.000000000","message":"That\u0027s not how we group these. It\u0027s stdlib - third-party - project. `webob` is third-party as is `oslo_log` etc so they\u0027re grouped together.","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c628c38f5aa9994abec7739113e9c3bfd1ce7a44","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from nova.api.openstack import api_version_request as api_version"},{"line_number":28,"context_line":"from nova.api.openstack import wsgi"},{"line_number":29,"context_line":"from nova.api.validation import validators"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from nova import exception"},{"line_number":32,"context_line":"from nova.i18n import _"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"63eed1c9_dd0503c0","line":30,"updated":"2024-07-20 07:17:09.000000000","message":"also please dont mix improt and form.\n\nhacking may allow it but hate it and i fix this every time its reasonable too","commit_id":"be029783ddced7277c1eee2243091348b7db843b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e50cafe204dc4a029ef4d9411db69eb49a8fe166","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from nova.api.openstack import api_version_request as api_version"},{"line_number":28,"context_line":"from nova.api.openstack import wsgi"},{"line_number":29,"context_line":"from nova.api.validation import validators"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from nova import exception"},{"line_number":32,"context_line":"from nova.i18n import _"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d24dcaed_c61f011a","line":30,"in_reply_to":"63eed1c9_dd0503c0","updated":"2024-07-22 10:25:55.000000000","message":"Again, I\u0027m following hacking to a tee here https://docs.openstack.org/hacking/latest/user/hacking.html#imports.","commit_id":"be029783ddced7277c1eee2243091348b7db843b"}]}