)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"20fc806ad13e5abf0ecb976e7be8c669cb59741c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8542a13b_17bff4b9","updated":"2024-06-27 13:46:41.000000000","message":"recheck timeout","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"38d2a97f_4415fad7","updated":"2024-11-22 05:03:29.000000000","message":"we are missing many required fields especially in the rebuild schema. Also, I think we need to add \u0027format\u0027 also for string type fields which makes our schema strict and avoid any incompatible change.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5d8127fac167e096dceadb2741e9bc0d813d671","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"76b9c65a_22e89dd3","updated":"2024-11-22 19:05:09.000000000","message":"thanks for update. Rebuild server schema is one of the most complex we have considering all microversions changes. Nice work.","commit_id":"f54e9628ea5a9f66d555f08947575cd6fce7bac6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1ff87baff08e6828e0da9b8f1bc670489102d28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cd10e872_5616973a","updated":"2024-11-22 23:49:15.000000000","message":"i fixed some functional tests for uuid only. restoring my +2","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"}],"nova/api/openstack/compute/remote_consoles.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fccf7453a04c46f0342cadabf8473e3e474a3160","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    @wsgi.expected_errors((400, 404, 409, 501))"},{"line_number":145,"context_line":"    @validation.schema(schema.create_v26, \"2.6\", \"2.7\")"},{"line_number":146,"context_line":"    @validation.schema(schema.create_v28, \"2.8\")"},{"line_number":147,"context_line":"    def create(self, req, server_id, body):"},{"line_number":148,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":149,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, server_id)"},{"line_number":150,"context_line":"        context.can(rc_policies.BASE_POLICY_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9c360a03_e8ab59d9","line":147,"range":{"start_line":147,"start_character":3,"end_line":147,"end_character":43},"updated":"2024-11-22 05:07:12.000000000","message":"we need the response schema for this also","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    @wsgi.expected_errors((400, 404, 409, 501))"},{"line_number":145,"context_line":"    @validation.schema(schema.create_v26, \"2.6\", \"2.7\")"},{"line_number":146,"context_line":"    @validation.schema(schema.create_v28, \"2.8\")"},{"line_number":147,"context_line":"    def create(self, req, server_id, body):"},{"line_number":148,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":149,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, server_id)"},{"line_number":150,"context_line":"        context.can(rc_policies.BASE_POLICY_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a6c66299_39711acc","line":147,"range":{"start_line":147,"start_character":3,"end_line":147,"end_character":43},"in_reply_to":"9c360a03_e8ab59d9","updated":"2024-11-22 15:22:30.000000000","message":"This isn\u0027t an action API and this commit focuses on those, hence we\u0027ve skipped this one for now. I have addressed it in a later change.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5d8127fac167e096dceadb2741e9bc0d813d671","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    @wsgi.expected_errors((400, 404, 409, 501))"},{"line_number":145,"context_line":"    @validation.schema(schema.create_v26, \"2.6\", \"2.7\")"},{"line_number":146,"context_line":"    @validation.schema(schema.create_v28, \"2.8\")"},{"line_number":147,"context_line":"    def create(self, req, server_id, body):"},{"line_number":148,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":149,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, server_id)"},{"line_number":150,"context_line":"        context.can(rc_policies.BASE_POLICY_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fe980af_9c4e0386","line":147,"range":{"start_line":147,"start_character":3,"end_line":147,"end_character":43},"in_reply_to":"a6c66299_39711acc","updated":"2024-11-22 19:05:09.000000000","message":"ack, thanks","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"}],"nova/api/openstack/compute/schemas/console_output.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    },"},{"line_number":46,"context_line":"    \u0027required\u0027: [\u0027output\u0027],"},{"line_number":47,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"4635e0be_5a779ebb","line":48,"updated":"2024-08-20 18:25:24.000000000","message":"yep https://docs.openstack.org/api-ref/compute/#id109","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    },"},{"line_number":43,"context_line":"    \u0027required\u0027: [\u0027output\u0027],"},{"line_number":44,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":45,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"50120dce_c6bacaf4","line":45,"updated":"2024-11-26 17:06:13.000000000","message":"ack https://docs.openstack.org/api-ref/compute/#id109","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"}],"nova/api/openstack/compute/schemas/create_backup.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":54,"context_line":"    \u0027properties\u0027: {"},{"line_number":55,"context_line":"        \u0027image_id\u0027: {"},{"line_number":56,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":57,"context_line":"            \u0027description\u0027: \u0027The UUID for the resulting image snapshot.\u0027,"},{"line_number":58,"context_line":"        },"},{"line_number":59,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"856e84e8_110f036e","line":56,"range":{"start_line":56,"start_character":28,"end_line":56,"end_character":29},"updated":"2024-11-22 05:03:29.000000000","message":"we can add \u0027format\u0027: \u0027uuid\u0027 also here","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":54,"context_line":"    \u0027properties\u0027: {"},{"line_number":55,"context_line":"        \u0027image_id\u0027: {"},{"line_number":56,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":57,"context_line":"            \u0027description\u0027: \u0027The UUID for the resulting image snapshot.\u0027,"},{"line_number":58,"context_line":"        },"},{"line_number":59,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"5babb196_d3168a5c","line":56,"range":{"start_line":56,"start_character":28,"end_line":56,"end_character":29},"in_reply_to":"856e84e8_110f036e","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \u0027required\u0027: [\u0027image_id\u0027],"},{"line_number":61,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"d2edd190_5eb62e63","line":62,"updated":"2024-08-20 18:25:24.000000000","message":"https://docs.openstack.org/api-ref/compute/#id58\n\nthis is correct for the body altought it does mak me realsise we are nto adding validation for headers.\n\nstill in 2.45 the header is nolonger used and the body has the id so this is correct.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8227ed67d92fdc36e1d1cf99275a75835dbedc35","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    },"},{"line_number":60,"context_line":"    \u0027required\u0027: [\u0027image_id\u0027],"},{"line_number":61,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"e1e57f4d_9271e3f1","line":62,"in_reply_to":"d2edd190_5eb62e63","updated":"2024-08-27 10:45:36.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"create_backup_response \u003d {"},{"line_number":49,"context_line":"    \u0027type\u0027: \u0027null\u0027,"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"create_backup_response_v245 \u003d {"},{"line_number":53,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf0a0788_8b12eeb6","line":50,"updated":"2024-11-26 17:06:13.000000000","message":"yep up to 2.44 we provide the location in a header and the body was empty","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    },"},{"line_number":57,"context_line":"    \u0027required\u0027: [\u0027image_id\u0027],"},{"line_number":58,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"6bac50cf_1ef477b1","line":59,"updated":"2024-11-26 17:06:13.000000000","message":"and as of 2.45 we provide the image_id\nhttps://docs.openstack.org/api-ref/compute/#id58\n\nthis was to prevent leaking info about the glance backend storage path","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"}],"nova/api/openstack/compute/schemas/evacuate.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":62,"context_line":"\"\"\","},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"    },"},{"line_number":65,"context_line":"    \u0027required\u0027: [\u0027adminPass\u0027],"},{"line_number":66,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2a51d092_735ac2f1","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":30},"updated":"2024-11-22 05:03:29.000000000","message":"As adminPass is depends on the configuration we should not add this in the \u0027required\u0027 field.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":62,"context_line":"\"\"\","},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"    },"},{"line_number":65,"context_line":"    \u0027required\u0027: [\u0027adminPass\u0027],"},{"line_number":66,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"488231d6_e76ba0ed","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":30},"in_reply_to":"2a51d092_735ac2f1","updated":"2024-11-22 15:22:30.000000000","message":"Good catch 👏","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    },"},{"line_number":65,"context_line":"    \u0027required\u0027: [\u0027adminPass\u0027],"},{"line_number":66,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"evacuate_response_v214 \u003d {"},{"line_number":70,"context_line":"    \u0027type\u0027: \u0027null\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"07cee0a7_6f137d37","line":67,"updated":"2024-08-20 18:25:24.000000000","message":"+1 https://docs.openstack.org/api-ref/compute/#id136","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # value depends on \u0027[api] enable_instance_password\u0027"},{"line_number":63,"context_line":"    \u0027required\u0027: [],"},{"line_number":64,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":65,"context_line":"}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"evacuate_response_v214 \u003d {"},{"line_number":68,"context_line":"    \u0027type\u0027: \u0027null\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"11e5ae34_8ca2df70","line":65,"updated":"2024-11-26 17:06:13.000000000","message":"https://docs.openstack.org/api-ref/compute/#id136\n\nyep adminPass is optional and the only valid content.\n\nas of 2.14 the response is empty.","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"}],"nova/api/openstack/compute/schemas/flavor_access.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"_common_response \u003d {"},{"line_number":63,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":64,"context_line":"    \u0027properties\u0027: {"},{"line_number":65,"context_line":"        \u0027flavor_access\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"f7db55c6_c928a45c","line":62,"updated":"2024-08-20 18:25:24.000000000","message":"+1 the respoce is common for get and the post actions so your using the same schema for all 3\n\nhttps://docs.openstack.org/api-ref/compute/#id213","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c24d4d5cbe148f22e76230cd5ade4b2b3bea1164","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"_common_response \u003d {"},{"line_number":63,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":64,"context_line":"    \u0027properties\u0027: {"},{"line_number":65,"context_line":"        \u0027flavor_access\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"f80b7692_923156a7","line":62,"in_reply_to":"f7db55c6_c928a45c","updated":"2024-08-27 10:34:35.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    },"},{"line_number":78,"context_line":"    \u0027required\u0027: [\u0027flavor_access\u0027],"},{"line_number":79,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"add_tenant_access_response \u003d copy.deepcopy(_common_response)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5b040e02_7bb470cd","line":80,"updated":"2024-11-26 17:06:13.000000000","message":"https://docs.openstack.org/api-ref/compute/#id215\nhttps://docs.openstack.org/api-ref/compute/#id217\n\nyep the responce is common for both add and remove so having a comon schema makes sense.","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"}],"nova/api/openstack/compute/schemas/remote_consoles.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"get_vnc_console_response \u003d {"},{"line_number":124,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":125,"context_line":"    \u0027properties\u0027: {"},{"line_number":126,"context_line":"        \u0027console\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ccf42f5_81ac209d","line":123,"updated":"2024-08-20 18:25:24.000000000","message":"https://docs.openstack.org/api-ref/compute/#id123","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":141,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":142,"context_line":"        },"},{"line_number":143,"context_line":"    },"},{"line_number":144,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"133c70df_cc2cd3c4","line":143,"range":{"start_line":143,"start_character":5,"end_line":143,"end_character":6},"updated":"2024-11-22 05:03:29.000000000","message":"we can add \u0027required\u0027: [\u0027console\u0027] also","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":141,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":142,"context_line":"        },"},{"line_number":143,"context_line":"    },"},{"line_number":144,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"daf6d9cd_88eedfb7","line":143,"range":{"start_line":143,"start_character":5,"end_line":143,"end_character":6},"in_reply_to":"133c70df_cc2cd3c4","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"get_spice_console_response \u003d {"},{"line_number":148,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":149,"context_line":"    \u0027properties\u0027: {"},{"line_number":150,"context_line":"        \u0027console\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"13ed5ae9_7c8c31f5","line":147,"updated":"2024-08-20 18:25:24.000000000","message":"https://docs.openstack.org/api-ref/compute/#id121","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \u0027properties\u0027: {"},{"line_number":153,"context_line":"                \u0027type\u0027: {"},{"line_number":154,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":155,"context_line":"                    \u0027enum\u0027: [\u0027spice-html5\u0027],"},{"line_number":156,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":157,"context_line":"                },"},{"line_number":158,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"efc54a76_967f9a16","line":155,"updated":"2024-08-20 18:25:24.000000000","message":"we are currnetly adding  a new spice diret type so this will need to be updated in the series bug this is correct for now.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c24d4d5cbe148f22e76230cd5ade4b2b3bea1164","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \u0027properties\u0027: {"},{"line_number":153,"context_line":"                \u0027type\u0027: {"},{"line_number":154,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":155,"context_line":"                    \u0027enum\u0027: [\u0027spice-html5\u0027],"},{"line_number":156,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":157,"context_line":"                },"},{"line_number":158,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3843684c_8d340eb0","line":155,"in_reply_to":"efc54a76_967f9a16","updated":"2024-08-27 10:34:35.000000000","message":"ack","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":164,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":165,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":166,"context_line":"        },"},{"line_number":167,"context_line":"    },"},{"line_number":168,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c0f956ec_df109c85","line":167,"range":{"start_line":167,"start_character":5,"end_line":167,"end_character":6},"updated":"2024-11-22 05:03:29.000000000","message":"ditto","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":165,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":166,"context_line":"        },"},{"line_number":167,"context_line":"    },"},{"line_number":168,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a980280_09675ab3","line":167,"range":{"start_line":167,"start_character":5,"end_line":167,"end_character":6},"in_reply_to":"c0f956ec_df109c85","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"get_serial_console_response \u003d {"},{"line_number":172,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":173,"context_line":"    \u0027properties\u0027: {"},{"line_number":174,"context_line":"        \u0027console\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"97a56d6e_fbd69d56","line":171,"updated":"2024-08-20 18:25:24.000000000","message":"https://docs.openstack.org/api-ref/compute/#id119","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":188,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":189,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":190,"context_line":"        },"},{"line_number":191,"context_line":"    },"},{"line_number":192,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":193,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"e9237226_012b50fd","line":191,"range":{"start_line":191,"start_character":5,"end_line":191,"end_character":6},"updated":"2024-11-22 05:03:29.000000000","message":"ditto","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":189,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":190,"context_line":"        },"},{"line_number":191,"context_line":"    },"},{"line_number":192,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":193,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"61f2ebcb_32295296","line":191,"range":{"start_line":191,"start_character":5,"end_line":191,"end_character":6},"in_reply_to":"e9237226_012b50fd","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":145,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"get_spice_console_response \u003d {"},{"line_number":149,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":150,"context_line":"    \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"2b06874e_1b203a98","line":147,"updated":"2024-11-26 17:06:13.000000000","message":"https://docs.openstack.org/api-ref/compute/#id123","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    },"},{"line_number":169,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":170,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":171,"context_line":"}"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"get_serial_console_response \u003d {"},{"line_number":174,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"f57d1f2e_f6bcf56f","line":171,"updated":"2024-11-26 17:06:13.000000000","message":"https://docs.openstack.org/api-ref/compute/#id121","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    },"},{"line_number":194,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":195,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":196,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"43b79588_bd30eaaf","line":196,"updated":"2024-11-26 17:06:13.000000000","message":"https://docs.openstack.org/api-ref/compute/#id119\n\nthese are all deprecated but the content is correct.\n\nin the future it might be worth investigating if we can encode deprection in the schemas","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"}],"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":782,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":783,"context_line":"            \u0027description\u0027: \u0027The UUID for the resulting image snapshot.\u0027,"},{"line_number":784,"context_line":"        },"},{"line_number":785,"context_line":"    },"},{"line_number":786,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":787,"context_line":"}"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8a3da680_73eb3d6d","line":785,"range":{"start_line":785,"start_character":5,"end_line":785,"end_character":6},"updated":"2024-11-22 05:03:29.000000000","message":"Let\u0027s add required field also\n\n        \u0027required\u0027: [\u0027image_id\u0027]","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":782,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":783,"context_line":"            \u0027description\u0027: \u0027The UUID for the resulting image snapshot.\u0027,"},{"line_number":784,"context_line":"        },"},{"line_number":785,"context_line":"    },"},{"line_number":786,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":787,"context_line":"}"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d7082dff_dc7fa6d6","line":785,"range":{"start_line":785,"start_character":5,"end_line":785,"end_character":6},"in_reply_to":"8a3da680_73eb3d6d","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        },"},{"line_number":785,"context_line":"    },"},{"line_number":786,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":787,"context_line":"}"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"rebuild_response \u003d {"},{"line_number":790,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d9203b0_bbce761d","line":787,"updated":"2024-08-20 18:25:24.000000000","message":"as with backup this was orginally returned in an haeader and then the id was returnned in the body in 2.45\nhttps://docs.openstack.org/api-ref/compute/#id60","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":786,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":787,"context_line":"}"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"rebuild_response \u003d {"},{"line_number":790,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":791,"context_line":"    \u0027properties\u0027: {"},{"line_number":792,"context_line":"        \u0027server\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e445f21_158c9cf4","line":789,"updated":"2024-08-20 18:25:24.000000000","message":"https://docs.openstack.org/api-ref/compute/#id68","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":793,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":794,"context_line":"            \u0027properties\u0027: {"},{"line_number":795,"context_line":"                \u0027accessIPv4\u0027: {"},{"line_number":796,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":797,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":798,"context_line":"IPv4 address that should be used to access this server. May be automatically"},{"line_number":799,"context_line":"set by the provider."}],"source_content_type":"text/x-python","patch_set":6,"id":"adb15bc6_10cce0f0","line":796,"range":{"start_line":796,"start_character":36,"end_line":796,"end_character":37},"updated":"2024-11-22 05:03:29.000000000","message":"We can use the format here and also allow empty string\n\n\u0027oneOf\u0027: [{\u0027format\u0027: \u0027ipv4\u0027}, {\u0027enum\u0027: [\u0027\u0027]}]","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":794,"context_line":"            \u0027properties\u0027: {"},{"line_number":795,"context_line":"                \u0027accessIPv4\u0027: {"},{"line_number":796,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":797,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":798,"context_line":"IPv4 address that should be used to access this server. May be automatically"},{"line_number":799,"context_line":"set by the provider."}],"source_content_type":"text/x-python","patch_set":6,"id":"c8222589_ab5370c8","line":796,"range":{"start_line":796,"start_character":36,"end_line":796,"end_character":37},"in_reply_to":"adb15bc6_10cce0f0","updated":"2024-11-22 15:22:30.000000000","message":"Done (but with `const` instead of `enum`)","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":800,"context_line":"\"\"\","},{"line_number":801,"context_line":"                },"},{"line_number":802,"context_line":"                \u0027accessIPv6\u0027: {"},{"line_number":803,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":804,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":805,"context_line":"IPv6 address that should be used to access this server. May be automatically"},{"line_number":806,"context_line":"set by the provider."}],"source_content_type":"text/x-python","patch_set":6,"id":"d0426a48_ead89a61","line":803,"range":{"start_line":803,"start_character":36,"end_line":803,"end_character":37},"updated":"2024-11-22 05:03:29.000000000","message":"ditto\n\n\u0027oneOf\u0027: [{\u0027format\u0027: \u0027ipv6\u0027}, {\u0027enum\u0027: [\u0027\u0027]}]","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":800,"context_line":"\"\"\","},{"line_number":801,"context_line":"                },"},{"line_number":802,"context_line":"                \u0027accessIPv6\u0027: {"},{"line_number":803,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":804,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":805,"context_line":"IPv6 address that should be used to access this server. May be automatically"},{"line_number":806,"context_line":"set by the provider."}],"source_content_type":"text/x-python","patch_set":6,"id":"6fa6f6c6_aaca9a08","line":803,"range":{"start_line":803,"start_character":36,"end_line":803,"end_character":37},"in_reply_to":"d0426a48_ead89a61","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":true,"context_lines":[{"line_number":792,"context_line":"        \u0027server\u0027: {"},{"line_number":793,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":794,"context_line":"            \u0027properties\u0027: {"},{"line_number":795,"context_line":"                \u0027accessIPv4\u0027: {"},{"line_number":796,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":797,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":798,"context_line":"IPv4 address that should be used to access this server. May be automatically"},{"line_number":799,"context_line":"set by the provider."},{"line_number":800,"context_line":"\"\"\","},{"line_number":801,"context_line":"                },"},{"line_number":802,"context_line":"                \u0027accessIPv6\u0027: {"},{"line_number":803,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":804,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":805,"context_line":"IPv6 address that should be used to access this server. May be automatically"},{"line_number":806,"context_line":"set by the provider."},{"line_number":807,"context_line":"\"\"\","},{"line_number":808,"context_line":"                },"},{"line_number":809,"context_line":"                \u0027addresses\u0027: {"},{"line_number":810,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":811,"context_line":"                    \u0027patternProperties\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"4bc8fbd6_930dec54","line":808,"range":{"start_line":795,"start_character":0,"end_line":808,"end_character":18},"updated":"2024-08-20 18:25:24.000000000","message":"side note these may or may not be present and should not be relied on in general\n\nwe support vms with out ip or without neworking\npeople shoudl get teh ip form neutron if they want it as thise may not be accesible outside of the cloud.\n\nthis is really a hold over form nova networks that mostly works with neutron.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c24d4d5cbe148f22e76230cd5ade4b2b3bea1164","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        \u0027server\u0027: {"},{"line_number":793,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":794,"context_line":"            \u0027properties\u0027: {"},{"line_number":795,"context_line":"                \u0027accessIPv4\u0027: {"},{"line_number":796,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":797,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":798,"context_line":"IPv4 address that should be used to access this server. May be automatically"},{"line_number":799,"context_line":"set by the provider."},{"line_number":800,"context_line":"\"\"\","},{"line_number":801,"context_line":"                },"},{"line_number":802,"context_line":"                \u0027accessIPv6\u0027: {"},{"line_number":803,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":804,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":805,"context_line":"IPv6 address that should be used to access this server. May be automatically"},{"line_number":806,"context_line":"set by the provider."},{"line_number":807,"context_line":"\"\"\","},{"line_number":808,"context_line":"                },"},{"line_number":809,"context_line":"                \u0027addresses\u0027: {"},{"line_number":810,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":811,"context_line":"                    \u0027patternProperties\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"9cf12e19_15087595","line":808,"range":{"start_line":795,"start_character":0,"end_line":808,"end_character":18},"in_reply_to":"4bc8fbd6_930dec54","updated":"2024-08-27 10:34:35.000000000","message":"I checked. These will always be a string:\n\n```json\n{\n    \"servers\":\n    [\n        {\n            // ...\n            \"accessIPv4\": \"\",\n            \"accessIPv6\": \"\",\n            // ...\n        }\n    ]\n}\n```\n\nCode is [here](https://github.com/openstack/nova/blob/01b207e50d307a7e7650b5839535fbd3ad40bc1b/nova/api/openstack/compute/views/servers.py#L282-L283).","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":815,"context_line":"                                \u0027type\u0027: \u0027object\u0027,"},{"line_number":816,"context_line":"                                \u0027properties\u0027: {"},{"line_number":817,"context_line":"                                    \u0027addr\u0027: {"},{"line_number":818,"context_line":"                                        \u0027type\u0027: \u0027string\u0027"},{"line_number":819,"context_line":"                                    },"},{"line_number":820,"context_line":"                                    \u0027version\u0027: {"},{"line_number":821,"context_line":"                                        \u0027type\u0027: \u0027number\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"82538c34_6df08fde","line":818,"range":{"start_line":818,"start_character":55,"end_line":818,"end_character":56},"updated":"2024-11-22 05:03:29.000000000","message":"we can also do format check here\n\n                        \u0027type\u0027: \u0027string\u0027,\n                        \u0027oneOf\u0027: [\n                            {\u0027format\u0027: \u0027ipv4\u0027},\n                            {\u0027format\u0027: \u0027ipv6\u0027}","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":815,"context_line":"                                \u0027type\u0027: \u0027object\u0027,"},{"line_number":816,"context_line":"                                \u0027properties\u0027: {"},{"line_number":817,"context_line":"                                    \u0027addr\u0027: {"},{"line_number":818,"context_line":"                                        \u0027type\u0027: \u0027string\u0027"},{"line_number":819,"context_line":"                                    },"},{"line_number":820,"context_line":"                                    \u0027version\u0027: {"},{"line_number":821,"context_line":"                                        \u0027type\u0027: \u0027number\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1b24b531_d550dccf","line":818,"range":{"start_line":818,"start_character":55,"end_line":818,"end_character":56},"in_reply_to":"82538c34_6df08fde","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":818,"context_line":"                                        \u0027type\u0027: \u0027string\u0027"},{"line_number":819,"context_line":"                                    },"},{"line_number":820,"context_line":"                                    \u0027version\u0027: {"},{"line_number":821,"context_line":"                                        \u0027type\u0027: \u0027number\u0027"},{"line_number":822,"context_line":"                                    },"},{"line_number":823,"context_line":"                                },"},{"line_number":824,"context_line":"                                \u0027required\u0027: ["}],"source_content_type":"text/x-python","patch_set":6,"id":"2563ce0c_0b4bfd91","line":821,"range":{"start_line":821,"start_character":0,"end_line":821,"end_character":56},"updated":"2024-11-22 05:03:29.000000000","message":"here we can be more specific \n\n                    \u0027version\u0027: {\u0027enum\u0027: [4, 6]},","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":818,"context_line":"                                        \u0027type\u0027: \u0027string\u0027"},{"line_number":819,"context_line":"                                    },"},{"line_number":820,"context_line":"                                    \u0027version\u0027: {"},{"line_number":821,"context_line":"                                        \u0027type\u0027: \u0027number\u0027"},{"line_number":822,"context_line":"                                    },"},{"line_number":823,"context_line":"                                },"},{"line_number":824,"context_line":"                                \u0027required\u0027: ["}],"source_content_type":"text/x-python","patch_set":6,"id":"360f7d47_f5481ab6","line":821,"range":{"start_line":821,"start_character":0,"end_line":821,"end_character":56},"in_reply_to":"2563ce0c_0b4bfd91","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":824,"context_line":"                                \u0027required\u0027: ["},{"line_number":825,"context_line":"                                    \u0027addr\u0027,"},{"line_number":826,"context_line":"                                    \u0027version\u0027"},{"line_number":827,"context_line":"                                ],"},{"line_number":828,"context_line":"                            },"},{"line_number":829,"context_line":"                        },"},{"line_number":830,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"68edbbbc_06a0d204","line":827,"range":{"start_line":827,"start_character":33,"end_line":827,"end_character":34},"updated":"2024-11-22 05:03:29.000000000","message":"let\u0027s check additionalProperties also\n\n                \u0027additionalProperties\u0027: False,","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                                \u0027required\u0027: ["},{"line_number":825,"context_line":"                                    \u0027addr\u0027,"},{"line_number":826,"context_line":"                                    \u0027version\u0027"},{"line_number":827,"context_line":"                                ],"},{"line_number":828,"context_line":"                            },"},{"line_number":829,"context_line":"                        },"},{"line_number":830,"context_line":"                    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"15bda50f_bb922fe4","line":827,"range":{"start_line":827,"start_character":33,"end_line":827,"end_character":34},"in_reply_to":"68edbbbc_06a0d204","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":840,"context_line":"                },"},{"line_number":841,"context_line":"                \u0027created\u0027: {"},{"line_number":842,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":843,"context_line":"                    \u0027format\u0027: \u0027date-time\u0027,"},{"line_number":844,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":845,"context_line":"The date and time when the resource was created. The date and time stamp format"},{"line_number":846,"context_line":"is ISO 8601::"}],"source_content_type":"text/x-python","patch_set":6,"id":"046bfed1_8be52afa","line":843,"range":{"start_line":843,"start_character":0,"end_line":843,"end_character":42},"updated":"2024-11-22 05:03:29.000000000","message":"+1","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                },"},{"line_number":841,"context_line":"                \u0027created\u0027: {"},{"line_number":842,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":843,"context_line":"                    \u0027format\u0027: \u0027date-time\u0027,"},{"line_number":844,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":845,"context_line":"The date and time when the resource was created. The date and time stamp format"},{"line_number":846,"context_line":"is ISO 8601::"}],"source_content_type":"text/x-python","patch_set":6,"id":"b489741e_6fa76263","line":843,"range":{"start_line":843,"start_character":0,"end_line":843,"end_character":42},"in_reply_to":"046bfed1_8be52afa","updated":"2024-11-22 15:22:30.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":868,"context_line":"                                \u0027type\u0027: \u0027object\u0027,"},{"line_number":869,"context_line":"                                \u0027properties\u0027: {"},{"line_number":870,"context_line":"                                    \u0027href\u0027: {"},{"line_number":871,"context_line":"                                        \u0027type\u0027: \u0027string\u0027"},{"line_number":872,"context_line":"                                    },"},{"line_number":873,"context_line":"                                    \u0027rel\u0027: {"},{"line_number":874,"context_line":"                                        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2808aa73_1c73ede6","line":871,"range":{"start_line":871,"start_character":39,"end_line":871,"end_character":56},"updated":"2024-11-22 05:03:29.000000000","message":"\u0027type\u0027: \u0027string\u0027,\n                \u0027format\u0027: \u0027uri\u0027","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":868,"context_line":"                                \u0027type\u0027: \u0027object\u0027,"},{"line_number":869,"context_line":"                                \u0027properties\u0027: {"},{"line_number":870,"context_line":"                                    \u0027href\u0027: {"},{"line_number":871,"context_line":"                                        \u0027type\u0027: \u0027string\u0027"},{"line_number":872,"context_line":"                                    },"},{"line_number":873,"context_line":"                                    \u0027rel\u0027: {"},{"line_number":874,"context_line":"                                        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0fdcc8ba_411a9a42","line":871,"range":{"start_line":871,"start_character":39,"end_line":871,"end_character":56},"in_reply_to":"2808aa73_1c73ede6","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":877,"context_line":"                                \u0027required\u0027: ["},{"line_number":878,"context_line":"                                    \u0027href\u0027,"},{"line_number":879,"context_line":"                                    \u0027rel\u0027"},{"line_number":880,"context_line":"                                ],"},{"line_number":881,"context_line":"                            },"},{"line_number":882,"context_line":"                            \u0027description\u0027: \"\"\"\\"},{"line_number":883,"context_line":"Links to the flavor resource. See API Guide / Links and References for more"}],"source_content_type":"text/x-python","patch_set":6,"id":"7de0d531_1c115ab8","line":880,"range":{"start_line":880,"start_character":33,"end_line":880,"end_character":34},"updated":"2024-11-22 05:03:29.000000000","message":"\u0027additionalProperties\u0027: False,","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":877,"context_line":"                                \u0027required\u0027: ["},{"line_number":878,"context_line":"                                    \u0027href\u0027,"},{"line_number":879,"context_line":"                                    \u0027rel\u0027"},{"line_number":880,"context_line":"                                ],"},{"line_number":881,"context_line":"                            },"},{"line_number":882,"context_line":"                            \u0027description\u0027: \"\"\"\\"},{"line_number":883,"context_line":"Links to the flavor resource. See API Guide / Links and References for more"}],"source_content_type":"text/x-python","patch_set":6,"id":"c5e99b17_5dae0b37","line":880,"range":{"start_line":880,"start_character":33,"end_line":880,"end_character":34},"in_reply_to":"7de0d531_1c115ab8","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":852,"context_line":"-05:00."},{"line_number":853,"context_line":"\"\"\","},{"line_number":854,"context_line":"                },"},{"line_number":855,"context_line":"                \u0027flavor\u0027: {"},{"line_number":856,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":857,"context_line":"                    \u0027properties\u0027: {"},{"line_number":858,"context_line":"                        \u0027id\u0027: {"},{"line_number":859,"context_line":"                            \u0027type\u0027: \u0027string\u0027,"},{"line_number":860,"context_line":"                            \u0027description\u0027: \"\"\"\\"},{"line_number":861,"context_line":"The ID of the flavor. While people often make this look like an int, this is"},{"line_number":862,"context_line":"really a string."},{"line_number":863,"context_line":"\"\"\","},{"line_number":864,"context_line":"                        },"},{"line_number":865,"context_line":"                        \u0027links\u0027: {"},{"line_number":866,"context_line":"                            \u0027type\u0027: \u0027array\u0027,"},{"line_number":867,"context_line":"                            \u0027items\u0027: {"},{"line_number":868,"context_line":"                                \u0027type\u0027: \u0027object\u0027,"},{"line_number":869,"context_line":"                                \u0027properties\u0027: {"},{"line_number":870,"context_line":"                                    \u0027href\u0027: {"},{"line_number":871,"context_line":"                                        \u0027type\u0027: \u0027string\u0027"},{"line_number":872,"context_line":"                                    },"},{"line_number":873,"context_line":"                                    \u0027rel\u0027: {"},{"line_number":874,"context_line":"                                        \u0027type\u0027: \u0027string\u0027,"},{"line_number":875,"context_line":"                                    },"},{"line_number":876,"context_line":"                                },"},{"line_number":877,"context_line":"                                \u0027required\u0027: ["},{"line_number":878,"context_line":"                                    \u0027href\u0027,"},{"line_number":879,"context_line":"                                    \u0027rel\u0027"},{"line_number":880,"context_line":"                                ],"},{"line_number":881,"context_line":"                            },"},{"line_number":882,"context_line":"                            \u0027description\u0027: \"\"\"\\"},{"line_number":883,"context_line":"Links to the flavor resource. See API Guide / Links and References for more"},{"line_number":884,"context_line":"info."},{"line_number":885,"context_line":"\"\"\","},{"line_number":886,"context_line":"                        },"},{"line_number":887,"context_line":"                    },"},{"line_number":888,"context_line":"                    \u0027additionalProperties\u0027: False,"},{"line_number":889,"context_line":"                },"},{"line_number":890,"context_line":"                \u0027hostId\u0027: {"},{"line_number":891,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":892,"context_line":"                    \u0027description\u0027: \"\"\"\\"}],"source_content_type":"text/x-python","patch_set":6,"id":"3e308d26_a474448c","line":889,"range":{"start_line":855,"start_character":0,"end_line":889,"end_character":18},"updated":"2024-08-20 18:25:24.000000000","message":"in 2.45 this is limited to the link and type\nthis then changes in 2.46 to have a summeray of the flavor.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":909,"context_line":"                        {"},{"line_number":910,"context_line":"                            \u0027type\u0027: \u0027string\u0027,"},{"line_number":911,"context_line":"                            \u0027enum\u0027: [\u0027\u0027],"},{"line_number":912,"context_line":"                        },"},{"line_number":913,"context_line":"                        {"},{"line_number":914,"context_line":"                            \u0027type\u0027: \u0027object\u0027,"},{"line_number":915,"context_line":"                            \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"802a7b54_e98a12a4","line":912,"updated":"2024-08-20 18:25:24.000000000","message":"ah right its either empty string if its boot form volume","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":916,"context_line":"                                \u0027id\u0027: {"},{"line_number":917,"context_line":"                                    \u0027type\u0027: \u0027string\u0027"},{"line_number":918,"context_line":"                                },"},{"line_number":919,"context_line":"                                \u0027links\u0027: {"},{"line_number":920,"context_line":"                                    \u0027type\u0027: \u0027array\u0027,"},{"line_number":921,"context_line":"                                    \u0027items\u0027: {"},{"line_number":922,"context_line":"                                        \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"6c6c77e7_607b65a5","line":919,"range":{"start_line":919,"start_character":30,"end_line":919,"end_character":42},"updated":"2024-11-22 05:03:29.000000000","message":"As we are using links in multiple place (it might needed in show/update servers etc), let\u0027s define this in single common place and reuse from there.\n\nIn Tempest, er define such common schemas in a common file parameter_types.py \n and use it from there- https://github.com/openstack/tempest/blob/e7b104c23cd2e1ac069bf55fb5e94a582534be81/tempest/lib/api_schema/response/compute/v2_1/parameter_types.py","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":921,"context_line":"                                    \u0027items\u0027: {"},{"line_number":922,"context_line":"                                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":923,"context_line":"                                        \u0027properties\u0027: {"},{"line_number":924,"context_line":"                                            \u0027href\u0027: {"},{"line_number":925,"context_line":"                                                \u0027type\u0027: \u0027string\u0027"},{"line_number":926,"context_line":"                                            },"},{"line_number":927,"context_line":"                                            \u0027rel\u0027: {"},{"line_number":928,"context_line":"                                                \u0027type\u0027: \u0027string\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5843a1b6_00ba878e","line":925,"range":{"start_line":924,"start_character":0,"end_line":925,"end_character":64},"updated":"2024-11-22 05:03:29.000000000","message":"\u0027type\u0027: \u0027string\u0027,\n            \u0027format\u0027: \u0027uri\u0027","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":921,"context_line":"                                    \u0027items\u0027: {"},{"line_number":922,"context_line":"                                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":923,"context_line":"                                        \u0027properties\u0027: {"},{"line_number":924,"context_line":"                                            \u0027href\u0027: {"},{"line_number":925,"context_line":"                                                \u0027type\u0027: \u0027string\u0027"},{"line_number":926,"context_line":"                                            },"},{"line_number":927,"context_line":"                                            \u0027rel\u0027: {"},{"line_number":928,"context_line":"                                                \u0027type\u0027: \u0027string\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"afe45ea5_67ddb907","line":925,"range":{"start_line":924,"start_character":0,"end_line":925,"end_character":64},"in_reply_to":"5843a1b6_00ba878e","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":931,"context_line":"                                        \u0027required\u0027: ["},{"line_number":932,"context_line":"                                            \u0027href\u0027,"},{"line_number":933,"context_line":"                                            \u0027rel\u0027"},{"line_number":934,"context_line":"                                        ],"},{"line_number":935,"context_line":"                                    },"},{"line_number":936,"context_line":"                                    \u0027description\u0027: \"\"\"\\"},{"line_number":937,"context_line":"Links pertaining to the server. See API Guide / Links and References for more"}],"source_content_type":"text/x-python","patch_set":6,"id":"91fb0745_658b8cac","line":934,"range":{"start_line":934,"start_character":40,"end_line":934,"end_character":42},"updated":"2024-11-22 05:03:29.000000000","message":"\u0027additionalProperties\u0027: False,","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":931,"context_line":"                                        \u0027required\u0027: ["},{"line_number":932,"context_line":"                                            \u0027href\u0027,"},{"line_number":933,"context_line":"                                            \u0027rel\u0027"},{"line_number":934,"context_line":"                                        ],"},{"line_number":935,"context_line":"                                    },"},{"line_number":936,"context_line":"                                    \u0027description\u0027: \"\"\"\\"},{"line_number":937,"context_line":"Links pertaining to the server. See API Guide / Links and References for more"}],"source_content_type":"text/x-python","patch_set":6,"id":"6c077fb2_8ffe8a9d","line":934,"range":{"start_line":934,"start_character":40,"end_line":934,"end_character":42},"in_reply_to":"91fb0745_658b8cac","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":true,"context_lines":[{"line_number":942,"context_line":"                            \u0027description\u0027: \"\"\"\\"},{"line_number":943,"context_line":"The UUID and links for the image for your server instance. The object will be"},{"line_number":944,"context_line":"an empty string when you boot the server from a volume."},{"line_number":945,"context_line":"\"\"\","},{"line_number":946,"context_line":"                            \u0027additionalProperties\u0027: False,"},{"line_number":947,"context_line":"                        },"},{"line_number":948,"context_line":"                    ],"}],"source_content_type":"text/x-python","patch_set":6,"id":"392d50b8_30857f89","line":945,"updated":"2024-08-20 18:25:24.000000000","message":"or the id and links for boot form image.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8227ed67d92fdc36e1d1cf99275a75835dbedc35","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                            \u0027description\u0027: \"\"\"\\"},{"line_number":943,"context_line":"The UUID and links for the image for your server instance. The object will be"},{"line_number":944,"context_line":"an empty string when you boot the server from a volume."},{"line_number":945,"context_line":"\"\"\","},{"line_number":946,"context_line":"                            \u0027additionalProperties\u0027: False,"},{"line_number":947,"context_line":"                        },"},{"line_number":948,"context_line":"                    ],"}],"source_content_type":"text/x-python","patch_set":6,"id":"7daf83a6_ed6d1997","line":945,"in_reply_to":"392d50b8_30857f89","updated":"2024-08-27 10:45:36.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":953,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":954,"context_line":"                        \u0027properties\u0027: {"},{"line_number":955,"context_line":"                            \u0027href\u0027: {"},{"line_number":956,"context_line":"                                \u0027type\u0027: \u0027string\u0027"},{"line_number":957,"context_line":"                            },"},{"line_number":958,"context_line":"                            \u0027rel\u0027: {"},{"line_number":959,"context_line":"                                \u0027type\u0027: \u0027string\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"b7aca8d4_38c3418c","line":956,"range":{"start_line":956,"start_character":0,"end_line":956,"end_character":48},"updated":"2024-11-22 05:03:29.000000000","message":"\u0027type\u0027: \u0027string\u0027,\n        \u0027format\u0027: \u0027uri\u0027","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":959,"context_line":"                                \u0027type\u0027: \u0027string\u0027"},{"line_number":960,"context_line":"                            },"},{"line_number":961,"context_line":"                        },"},{"line_number":962,"context_line":"                        \u0027required\u0027: ["},{"line_number":963,"context_line":"                            \u0027href\u0027,"},{"line_number":964,"context_line":"                            \u0027rel\u0027"},{"line_number":965,"context_line":"                        ],"},{"line_number":966,"context_line":"                        \u0027additionalProperties\u0027: False,"},{"line_number":967,"context_line":"                    },"},{"line_number":968,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":969,"context_line":"Links pertaining to the server. See API Guide / Links and References for more"}],"source_content_type":"text/x-python","patch_set":6,"id":"539b520d_5ce54405","line":966,"range":{"start_line":962,"start_character":0,"end_line":966,"end_character":54},"updated":"2024-11-22 05:03:29.000000000","message":"++","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                                \u0027type\u0027: \u0027string\u0027"},{"line_number":960,"context_line":"                            },"},{"line_number":961,"context_line":"                        },"},{"line_number":962,"context_line":"                        \u0027required\u0027: ["},{"line_number":963,"context_line":"                            \u0027href\u0027,"},{"line_number":964,"context_line":"                            \u0027rel\u0027"},{"line_number":965,"context_line":"                        ],"},{"line_number":966,"context_line":"                        \u0027additionalProperties\u0027: False,"},{"line_number":967,"context_line":"                    },"},{"line_number":968,"context_line":"                    \u0027description\u0027: \"\"\"\\"},{"line_number":969,"context_line":"Links pertaining to the server. See API Guide / Links and References for more"}],"source_content_type":"text/x-python","patch_set":6,"id":"8e88e68a_0effb365","line":966,"range":{"start_line":962,"start_character":0,"end_line":966,"end_character":54},"in_reply_to":"539b520d_5ce54405","updated":"2024-11-22 15:22:30.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1035,"context_line":"- ``MANUAL``: The API builds the server by using the partition scheme and file"},{"line_number":1036,"context_line":"  system that is in the source image. If the target flavor disk is larger, The"},{"line_number":1037,"context_line":"  API does not partition the remaining disk space."},{"line_number":1038,"context_line":"\"\"\","},{"line_number":1039,"context_line":"                },"},{"line_number":1040,"context_line":"            },"},{"line_number":1041,"context_line":"            \u0027required\u0027: ["},{"line_number":1042,"context_line":"                \u0027accessIPv4\u0027,"},{"line_number":1043,"context_line":"                \u0027accessIPv6\u0027,"},{"line_number":1044,"context_line":"                \u0027addresses\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"87145bcd_4725af19","line":1041,"range":{"start_line":1038,"start_character":0,"end_line":1041,"end_character":16},"updated":"2024-11-22 05:03:29.000000000","message":"this return \u0027fault\u0027 field also which is not required but it can return in response.\n\nhttps://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L297","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"- ``MANUAL``: The API builds the server by using the partition scheme and file"},{"line_number":1036,"context_line":"  system that is in the source image. If the target flavor disk is larger, The"},{"line_number":1037,"context_line":"  API does not partition the remaining disk space."},{"line_number":1038,"context_line":"\"\"\","},{"line_number":1039,"context_line":"                },"},{"line_number":1040,"context_line":"            },"},{"line_number":1041,"context_line":"            \u0027required\u0027: ["},{"line_number":1042,"context_line":"                \u0027accessIPv4\u0027,"},{"line_number":1043,"context_line":"                \u0027accessIPv6\u0027,"},{"line_number":1044,"context_line":"                \u0027addresses\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4f98bb47_0dd6ca53","line":1041,"range":{"start_line":1038,"start_character":0,"end_line":1041,"end_character":16},"in_reply_to":"87145bcd_4725af19","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"                },"},{"line_number":1040,"context_line":"            },"},{"line_number":1041,"context_line":"            \u0027required\u0027: ["},{"line_number":1042,"context_line":"                \u0027accessIPv4\u0027,"},{"line_number":1043,"context_line":"                \u0027accessIPv6\u0027,"},{"line_number":1044,"context_line":"                \u0027addresses\u0027,"},{"line_number":1045,"context_line":"                \u0027created\u0027,"},{"line_number":1046,"context_line":"                \u0027flavor\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d59d6b62_fc2da29b","line":1043,"range":{"start_line":1042,"start_character":7,"end_line":1043,"end_character":29},"updated":"2024-08-20 18:25:24.000000000","message":"these are not required or at least can be empty string\nif you do not have a netork on the vm or dont have a ip address.\n\ni guess these will be the empty string in that case?\n\n\n+1 is because of this as im not sure this is correct to include in the requried list","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ceda5231763ff52579167ec5a90b562f3ce392bf","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                },"},{"line_number":1040,"context_line":"            },"},{"line_number":1041,"context_line":"            \u0027required\u0027: ["},{"line_number":1042,"context_line":"                \u0027accessIPv4\u0027,"},{"line_number":1043,"context_line":"                \u0027accessIPv6\u0027,"},{"line_number":1044,"context_line":"                \u0027addresses\u0027,"},{"line_number":1045,"context_line":"                \u0027created\u0027,"},{"line_number":1046,"context_line":"                \u0027flavor\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da33eb46_5ac6875a","line":1043,"range":{"start_line":1042,"start_character":7,"end_line":1043,"end_character":29},"in_reply_to":"ae58bc39_16033453","updated":"2024-08-27 11:20:53.000000000","message":"yep i agree i just was not sure we had that defaulting in the api side\nthanks for the link.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8227ed67d92fdc36e1d1cf99275a75835dbedc35","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                },"},{"line_number":1040,"context_line":"            },"},{"line_number":1041,"context_line":"            \u0027required\u0027: ["},{"line_number":1042,"context_line":"                \u0027accessIPv4\u0027,"},{"line_number":1043,"context_line":"                \u0027accessIPv6\u0027,"},{"line_number":1044,"context_line":"                \u0027addresses\u0027,"},{"line_number":1045,"context_line":"                \u0027created\u0027,"},{"line_number":1046,"context_line":"                \u0027flavor\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ae58bc39_16033453","line":1043,"range":{"start_line":1042,"start_character":7,"end_line":1043,"end_character":29},"in_reply_to":"d59d6b62_fc2da29b","updated":"2024-08-27 10:45:36.000000000","message":"As noted elsewhere, this is always a string. It\u0027ll also always be included in a response, as you can see in [the code](https://github.com/openstack/nova/blob/01b207e50d307a7e7650b5839535fbd3ad40bc1b/nova/api/openstack/compute/views/servers.py#L282-L283), hence this is \"required\" in a response (think of required as meaning \"this will 100% be in the response\" when it comes to response schemas)","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1070,"context_line":"rebuild_response_v29[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027locked\u0027] \u003d {"},{"line_number":1071,"context_line":"    \u0027type\u0027: \u0027boolean\u0027,"},{"line_number":1072,"context_line":"    \u0027description\u0027: \u0027True if the instance is locked otherwise False.\u0027,"},{"line_number":1073,"context_line":"}"},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"rebuild_response_v219 \u003d copy.deepcopy(rebuild_response_v29)"},{"line_number":1076,"context_line":"rebuild_response_v219[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027description\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"e09eeb06_c0a2e820","line":1073,"range":{"start_line":1073,"start_character":0,"end_line":1073,"end_character":1},"updated":"2024-11-22 05:03:29.000000000","message":"\u0027locked\u0027 is always returned after microversion 2.9, we need to update the \u0027required\u0027 field also\n\nrebuild_response_v29[\u0027properties\u0027][\u0027server\u0027][\n    \u0027required\u0027].append(\u0027locked\u0027)","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"rebuild_response_v29[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027locked\u0027] \u003d {"},{"line_number":1071,"context_line":"    \u0027type\u0027: \u0027boolean\u0027,"},{"line_number":1072,"context_line":"    \u0027description\u0027: \u0027True if the instance is locked otherwise False.\u0027,"},{"line_number":1073,"context_line":"}"},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"rebuild_response_v219 \u003d copy.deepcopy(rebuild_response_v29)"},{"line_number":1076,"context_line":"rebuild_response_v219[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027description\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"d562f15d_f2384bf2","line":1073,"range":{"start_line":1073,"start_character":0,"end_line":1073,"end_character":1},"in_reply_to":"e09eeb06_c0a2e820","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1079,"context_line":"The description of the server. Before microversion 2.19 this was set to the"},{"line_number":1080,"context_line":"server name."},{"line_number":1081,"context_line":"\"\"\","},{"line_number":1082,"context_line":"}"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"rebuild_response_v226 \u003d copy.deepcopy(rebuild_response_v219)"},{"line_number":1085,"context_line":"rebuild_response_v226[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027tags\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"8eb56147_d9da9393","line":1082,"range":{"start_line":1082,"start_character":0,"end_line":1082,"end_character":1},"updated":"2024-11-22 05:03:29.000000000","message":"ditto\n\nrebuild_response_v219[\u0027properties\u0027][\u0027server\u0027][\n    \u0027required\u0027].append(\u0027description\u0027)","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"The description of the server. Before microversion 2.19 this was set to the"},{"line_number":1080,"context_line":"server name."},{"line_number":1081,"context_line":"\"\"\","},{"line_number":1082,"context_line":"}"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"rebuild_response_v226 \u003d copy.deepcopy(rebuild_response_v219)"},{"line_number":1085,"context_line":"rebuild_response_v226[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027tags\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a9f56f6_e27732b5","line":1082,"range":{"start_line":1082,"start_character":0,"end_line":1082,"end_character":1},"in_reply_to":"8eb56147_d9da9393","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1087,"context_line":"    \u0027items\u0027: {"},{"line_number":1088,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":1089,"context_line":"    },"},{"line_number":1090,"context_line":"    \u0027maxLength\u0027: 50,"},{"line_number":1091,"context_line":"    \u0027description\u0027: \"\"\"\\"},{"line_number":1092,"context_line":"A list of tags. The maximum count of tags in this list is 50.\"\"\","},{"line_number":1093,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"e658a895_e111fd5c","line":1090,"range":{"start_line":1090,"start_character":5,"end_line":1090,"end_character":14},"updated":"2024-11-22 05:03:29.000000000","message":"maxlength is for string length check, for array length we need to use maxItems\n\n- https://json-schema.org/understanding-json-schema/reference/array#length","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"    \u0027items\u0027: {"},{"line_number":1088,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":1089,"context_line":"    },"},{"line_number":1090,"context_line":"    \u0027maxLength\u0027: 50,"},{"line_number":1091,"context_line":"    \u0027description\u0027: \"\"\"\\"},{"line_number":1092,"context_line":"A list of tags. The maximum count of tags in this list is 50.\"\"\","},{"line_number":1093,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5abc56dd_89ac175e","line":1090,"range":{"start_line":1090,"start_character":5,"end_line":1090,"end_character":14},"in_reply_to":"e658a895_e111fd5c","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1090,"context_line":"    \u0027maxLength\u0027: 50,"},{"line_number":1091,"context_line":"    \u0027description\u0027: \"\"\"\\"},{"line_number":1092,"context_line":"A list of tags. The maximum count of tags in this list is 50.\"\"\","},{"line_number":1093,"context_line":"}"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"# NOTE(stephenfin): We overwrite rather than extend \u0027flavor\u0027, since we now"},{"line_number":1096,"context_line":"# embed the flavor in this version"}],"source_content_type":"text/x-python","patch_set":6,"id":"325175ce_caa11d9e","line":1093,"range":{"start_line":1093,"start_character":0,"end_line":1093,"end_character":1},"updated":"2024-11-22 05:03:29.000000000","message":"ditto\n\nrebuild_response_v226[\u0027properties\u0027][\u0027server\u0027][\n    \u0027required\u0027].append(\u0027tags\u0027)","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1090,"context_line":"    \u0027maxLength\u0027: 50,"},{"line_number":1091,"context_line":"    \u0027description\u0027: \"\"\"\\"},{"line_number":1092,"context_line":"A list of tags. The maximum count of tags in this list is 50.\"\"\","},{"line_number":1093,"context_line":"}"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"# NOTE(stephenfin): We overwrite rather than extend \u0027flavor\u0027, since we now"},{"line_number":1096,"context_line":"# embed the flavor in this version"}],"source_content_type":"text/x-python","patch_set":6,"id":"e35a0665_39c23e13","line":1093,"range":{"start_line":1093,"start_character":0,"end_line":1093,"end_character":1},"in_reply_to":"325175ce_caa11d9e","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":true,"context_lines":[{"line_number":1093,"context_line":"}"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"# NOTE(stephenfin): We overwrite rather than extend \u0027flavor\u0027, since we now"},{"line_number":1096,"context_line":"# embed the flavor in this version"},{"line_number":1097,"context_line":"rebuild_response_v246 \u003d copy.deepcopy(rebuild_response_v226)"},{"line_number":1098,"context_line":"rebuild_response_v246[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027flavor\u0027] \u003d {"},{"line_number":1099,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f3779b28_3d435249","line":1096,"updated":"2024-08-20 18:25:24.000000000","message":"+1","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"39afcbb5860943a4f5deade41e5dcbba1f3084f4","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"}"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"# NOTE(stephenfin): We overwrite rather than extend \u0027flavor\u0027, since we now"},{"line_number":1096,"context_line":"# embed the flavor in this version"},{"line_number":1097,"context_line":"rebuild_response_v246 \u003d copy.deepcopy(rebuild_response_v226)"},{"line_number":1098,"context_line":"rebuild_response_v246[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027flavor\u0027] \u003d {"},{"line_number":1099,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2367a2eb_4441fb0e","line":1096,"in_reply_to":"f3779b28_3d435249","updated":"2024-08-27 10:46:42.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1148,"context_line":"rebuild_response_v254[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027key_name\u0027] \u003d {"},{"line_number":1149,"context_line":"    \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1150,"context_line":"    \u0027description\u0027: \u0027The name of associated key pair, if any.\u0027,"},{"line_number":1151,"context_line":"}"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"rebuild_response_v257 \u003d copy.deepcopy(rebuild_response_v254)"},{"line_number":1154,"context_line":"rebuild_response_v257[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027user_data\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"fcb3e60d_decab9d9","line":1151,"range":{"start_line":1151,"start_character":0,"end_line":1151,"end_character":1},"updated":"2024-11-22 05:03:29.000000000","message":"ditto\n\nrebuild_response_v254[\u0027properties\u0027][\u0027server\u0027][\n    \u0027required\u0027].append(\u0027key_name\u0027)","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"rebuild_response_v254[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027key_name\u0027] \u003d {"},{"line_number":1149,"context_line":"    \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1150,"context_line":"    \u0027description\u0027: \u0027The name of associated key pair, if any.\u0027,"},{"line_number":1151,"context_line":"}"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"rebuild_response_v257 \u003d copy.deepcopy(rebuild_response_v254)"},{"line_number":1154,"context_line":"rebuild_response_v257[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027user_data\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"664aa60b_5d6a840d","line":1151,"range":{"start_line":1151,"start_character":0,"end_line":1151,"end_character":1},"in_reply_to":"fcb3e60d_decab9d9","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1157,"context_line":"        {\u0027type\u0027: \u0027null\u0027},"},{"line_number":1158,"context_line":"    ],"},{"line_number":1159,"context_line":"    \u0027description\u0027: \u0027The current user_data for the instance.\u0027,"},{"line_number":1160,"context_line":"}"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"rebuild_response_v263 \u003d copy.deepcopy(rebuild_response_v257)"},{"line_number":1163,"context_line":"rebuild_response_v263[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027].update("}],"source_content_type":"text/x-python","patch_set":6,"id":"5ca3d207_043e5553","line":1160,"range":{"start_line":1160,"start_character":0,"end_line":1160,"end_character":1},"updated":"2024-11-22 05:03:29.000000000","message":"rebuild_response_v257[\u0027properties\u0027][\u0027server\u0027][\n    \u0027required\u0027].append(\u0027user_data\u0027)","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1157,"context_line":"        {\u0027type\u0027: \u0027null\u0027},"},{"line_number":1158,"context_line":"    ],"},{"line_number":1159,"context_line":"    \u0027description\u0027: \u0027The current user_data for the instance.\u0027,"},{"line_number":1160,"context_line":"}"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"rebuild_response_v263 \u003d copy.deepcopy(rebuild_response_v257)"},{"line_number":1163,"context_line":"rebuild_response_v263[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027].update("}],"source_content_type":"text/x-python","patch_set":6,"id":"da275801_05815ee6","line":1160,"range":{"start_line":1160,"start_character":0,"end_line":1160,"end_character":1},"in_reply_to":"5ca3d207_043e5553","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1174,"context_line":"set."},{"line_number":1175,"context_line":"\"\"\","},{"line_number":1176,"context_line":"        },"},{"line_number":1177,"context_line":"    },"},{"line_number":1178,"context_line":")"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"rebuild_response_v271 \u003d copy.deepcopy(rebuild_response_v263)"}],"source_content_type":"text/x-python","patch_set":6,"id":"01b4c96b_1a97bce9","line":1177,"range":{"start_line":1177,"start_character":0,"end_line":1177,"end_character":6},"updated":"2024-11-22 05:03:29.000000000","message":"ditto, need to add \u0027trusted_image_certificates\u0027 in required field\n\n\nI think same for many of the microversion schema, we need to add mandatory returned field in required field","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"set."},{"line_number":1175,"context_line":"\"\"\","},{"line_number":1176,"context_line":"        },"},{"line_number":1177,"context_line":"    },"},{"line_number":1178,"context_line":")"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"rebuild_response_v271 \u003d copy.deepcopy(rebuild_response_v263)"}],"source_content_type":"text/x-python","patch_set":6,"id":"238006ce_fc469f05","line":1177,"range":{"start_line":1177,"start_character":0,"end_line":1177,"end_character":6},"in_reply_to":"01b4c96b_1a97bce9","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1192,"context_line":"contain at most one entry."},{"line_number":1193,"context_line":"\"\"\","},{"line_number":1194,"context_line":"        },"},{"line_number":1195,"context_line":"    },"},{"line_number":1196,"context_line":")"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"rebuild_response_v273 \u003d copy.deepcopy(rebuild_response_v271)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e4a71ed8_c890411e","line":1195,"range":{"start_line":1195,"start_character":0,"end_line":1195,"end_character":6},"updated":"2024-11-22 05:03:29.000000000","message":"ditto, need to add in \u0027required\u0027 field","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"contain at most one entry."},{"line_number":1193,"context_line":"\"\"\","},{"line_number":1194,"context_line":"        },"},{"line_number":1195,"context_line":"    },"},{"line_number":1196,"context_line":")"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"rebuild_response_v273 \u003d copy.deepcopy(rebuild_response_v271)"}],"source_content_type":"text/x-python","patch_set":6,"id":"de8c3539_85fa1001","line":1195,"range":{"start_line":1195,"start_character":0,"end_line":1195,"end_character":6},"in_reply_to":"e4a71ed8_c890411e","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1202,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1203,"context_line":"            \u0027description\u0027: \u0027The reason behind locking a server.\u0027,"},{"line_number":1204,"context_line":"        },"},{"line_number":1205,"context_line":"    },"},{"line_number":1206,"context_line":")"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"rebuild_response_v275 \u003d copy.deepcopy(rebuild_response_v273)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d5cb64aa_bdba8222","line":1205,"range":{"start_line":1205,"start_character":0,"end_line":1205,"end_character":6},"updated":"2024-11-22 05:03:29.000000000","message":"ditto, need to add in \u0027required\u0027 field","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1203,"context_line":"            \u0027description\u0027: \u0027The reason behind locking a server.\u0027,"},{"line_number":1204,"context_line":"        },"},{"line_number":1205,"context_line":"    },"},{"line_number":1206,"context_line":")"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"rebuild_response_v275 \u003d copy.deepcopy(rebuild_response_v273)"}],"source_content_type":"text/x-python","patch_set":6,"id":"14cb2b19_7067b90d","line":1205,"range":{"start_line":1205,"start_character":0,"end_line":1205,"end_character":6},"in_reply_to":"d5cb64aa_bdba8222","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1208,"context_line":"rebuild_response_v275 \u003d copy.deepcopy(rebuild_response_v273)"},{"line_number":1209,"context_line":"rebuild_response_v275[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027].update("},{"line_number":1210,"context_line":"    {"},{"line_number":1211,"context_line":"        \u0027config_drive\u0027: {"},{"line_number":1212,"context_line":"            # TODO(stephenfin): Our tests return null but this shouldn\u0027t happen"},{"line_number":1213,"context_line":"            # in practice, apparently?"},{"line_number":1214,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"620d3036_6328ab93","line":1211,"range":{"start_line":1211,"start_character":6,"end_line":1211,"end_character":25},"updated":"2024-11-22 05:03:29.000000000","message":"this is always returned after microversion 2.75 and we can add in \u0027required\u0027 field\n\n- https://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L314","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"rebuild_response_v275 \u003d copy.deepcopy(rebuild_response_v273)"},{"line_number":1209,"context_line":"rebuild_response_v275[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027].update("},{"line_number":1210,"context_line":"    {"},{"line_number":1211,"context_line":"        \u0027config_drive\u0027: {"},{"line_number":1212,"context_line":"            # TODO(stephenfin): Our tests return null but this shouldn\u0027t happen"},{"line_number":1213,"context_line":"            # in practice, apparently?"},{"line_number":1214,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"eb16b333_0596d20f","line":1211,"range":{"start_line":1211,"start_character":6,"end_line":1211,"end_character":25},"in_reply_to":"620d3036_6328ab93","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":true,"context_lines":[{"line_number":1211,"context_line":"        \u0027config_drive\u0027: {"},{"line_number":1212,"context_line":"            # TODO(stephenfin): Our tests return null but this shouldn\u0027t happen"},{"line_number":1213,"context_line":"            # in practice, apparently?"},{"line_number":1214,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027],"},{"line_number":1215,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1216,"context_line":"Indicates whether or not a config drive was used for this server. The value is"},{"line_number":1217,"context_line":"``True`` or an empty string. An empty string stands for ``False``."}],"source_content_type":"text/x-python","patch_set":6,"id":"0d61cfef_ba9c9581","line":1214,"updated":"2024-08-20 18:25:24.000000000","message":"so config drive can be null if it\u0027s not forced and not enabled in the request.\nhowever a long time ago i change nova to record if the instnace was first booted with a config drive or not by recording it in the instance_system_metadata.\n\nso i belive this will alwyas be true or false now in server show.\n\nin rebuild it could possible be null as that only take effect when spawnign the instnace but it might now happen by the time we are genreating this reponce.\n\ni dont think it will be null but i cant say for certin\n\nit wont be a string anymore as that was only supported i think for xen for rackspace. youuse to be abel to provide a url/volume/swift objuecct uuid or something like that but that only worked pre nova api 2.0 i think.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"39afcbb5860943a4f5deade41e5dcbba1f3084f4","unresolved":true,"context_lines":[{"line_number":1211,"context_line":"        \u0027config_drive\u0027: {"},{"line_number":1212,"context_line":"            # TODO(stephenfin): Our tests return null but this shouldn\u0027t happen"},{"line_number":1213,"context_line":"            # in practice, apparently?"},{"line_number":1214,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027],"},{"line_number":1215,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1216,"context_line":"Indicates whether or not a config drive was used for this server. The value is"},{"line_number":1217,"context_line":"``True`` or an empty string. An empty string stands for ``False``."}],"source_content_type":"text/x-python","patch_set":6,"id":"e4cba13b_a152a0eb","line":1214,"in_reply_to":"0d61cfef_ba9c9581","updated":"2024-08-27 10:46:42.000000000","message":"Ack. If it works for you, I\u0027m going to leave this as a TODO for now. We can always make a schema more strict down the line.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"        \u0027config_drive\u0027: {"},{"line_number":1212,"context_line":"            # TODO(stephenfin): Our tests return null but this shouldn\u0027t happen"},{"line_number":1213,"context_line":"            # in practice, apparently?"},{"line_number":1214,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027],"},{"line_number":1215,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1216,"context_line":"Indicates whether or not a config drive was used for this server. The value is"},{"line_number":1217,"context_line":"``True`` or an empty string. An empty string stands for ``False``."}],"source_content_type":"text/x-python","patch_set":6,"id":"2a79805d_21b08ad1","line":1214,"in_reply_to":"810bac5e_aeac625c","updated":"2024-11-22 15:22:30.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ceda5231763ff52579167ec5a90b562f3ce392bf","unresolved":true,"context_lines":[{"line_number":1211,"context_line":"        \u0027config_drive\u0027: {"},{"line_number":1212,"context_line":"            # TODO(stephenfin): Our tests return null but this shouldn\u0027t happen"},{"line_number":1213,"context_line":"            # in practice, apparently?"},{"line_number":1214,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027boolean\u0027, \u0027null\u0027],"},{"line_number":1215,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1216,"context_line":"Indicates whether or not a config drive was used for this server. The value is"},{"line_number":1217,"context_line":"``True`` or an empty string. An empty string stands for ``False``."}],"source_content_type":"text/x-python","patch_set":6,"id":"810bac5e_aeac625c","line":1214,"in_reply_to":"e4cba13b_a152a0eb","updated":"2024-08-27 11:20:53.000000000","message":"yep leaving it as a todo is fine.\n\nwe can make this more stirct later as you said.","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1217,"context_line":"``True`` or an empty string. An empty string stands for ``False``."},{"line_number":1218,"context_line":"\"\"\","},{"line_number":1219,"context_line":"        },"},{"line_number":1220,"context_line":"        \u0027OS-EXT-AZ:availability_zone\u0027: {"},{"line_number":1221,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1222,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1223,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":6,"id":"91852dff_efd9d340","line":1220,"range":{"start_line":1220,"start_character":8,"end_line":1220,"end_character":38},"updated":"2024-11-22 05:03:29.000000000","message":"this is always returned after microversion 2.75 and we can add in \u0027required\u0027 field\n\n- https://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L308","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"``True`` or an empty string. An empty string stands for ``False``."},{"line_number":1218,"context_line":"\"\"\","},{"line_number":1219,"context_line":"        },"},{"line_number":1220,"context_line":"        \u0027OS-EXT-AZ:availability_zone\u0027: {"},{"line_number":1221,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1222,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1223,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":6,"id":"aae8dbe8_56a74c41","line":1220,"range":{"start_line":1220,"start_character":8,"end_line":1220,"end_character":38},"in_reply_to":"91852dff_efd9d340","updated":"2024-11-26 17:06:13.000000000","message":"done https://review.opendev.org/c/openstack/nova/+/915743/8/nova/api/openstack/compute/schemas/servers.py#1204","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1222,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1223,"context_line":"\"\"\","},{"line_number":1224,"context_line":"        },"},{"line_number":1225,"context_line":"        \u0027OS-EXT-SRV-ATTR:host\u0027: {"},{"line_number":1226,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":1227,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1228,"context_line":"The name of the compute host on which this instance is running. Appears in the"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a3b32c7_bf280884","line":1225,"range":{"start_line":1225,"start_character":8,"end_line":1225,"end_character":31},"updated":"2024-11-22 05:03:29.000000000","message":"all the exteneded attr are added if policy is passed so they are not always returned and we do not need to add them in required field.\n\n- https://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L331","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1223,"context_line":"\"\"\","},{"line_number":1224,"context_line":"        },"},{"line_number":1225,"context_line":"        \u0027OS-EXT-SRV-ATTR:host\u0027: {"},{"line_number":1226,"context_line":"            \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":1227,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1228,"context_line":"The name of the compute host on which this instance is running. Appears in the"}],"source_content_type":"text/x-python","patch_set":6,"id":"969c7c93_5930ac47","line":1225,"range":{"start_line":1225,"start_character":8,"end_line":1225,"end_character":31},"in_reply_to":"9a3b32c7_bf280884","updated":"2024-11-26 17:06:13.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1244,"context_line":"instance name template. Appears in the response for administrative users only."},{"line_number":1245,"context_line":"\"\"\","},{"line_number":1246,"context_line":"        },"},{"line_number":1247,"context_line":"        \u0027OS-EXT-STS:power_state\u0027: {"},{"line_number":1248,"context_line":"            \u0027type\u0027: \u0027integer\u0027,"},{"line_number":1249,"context_line":"            \u0027enum\u0027: [0, 1, 3, 4, 6, 7],"},{"line_number":1250,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1251,"context_line":"The power state of the instance. This is an enum value that is mapped as::"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"    0: NOSTATE"},{"line_number":1254,"context_line":"    1: RUNNING"},{"line_number":1255,"context_line":"    3: PAUSED"},{"line_number":1256,"context_line":"    4: SHUTDOWN"},{"line_number":1257,"context_line":"    6: CRASHED"},{"line_number":1258,"context_line":"    7: SUSPENDED"},{"line_number":1259,"context_line":"\"\"\","},{"line_number":1260,"context_line":"        },"},{"line_number":1261,"context_line":"        \u0027OS-EXT-STS:task_state\u0027: {"},{"line_number":1262,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1263,"context_line":"            \u0027description\u0027: \u0027The task state of the instance.\u0027,"},{"line_number":1264,"context_line":"        },"},{"line_number":1265,"context_line":"        \u0027OS-EXT-STS:vm_state\u0027: {"},{"line_number":1266,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1267,"context_line":"            \u0027description\u0027: \u0027The VM state.\u0027,"},{"line_number":1268,"context_line":"        },"},{"line_number":1269,"context_line":"        \u0027OS-EXT-SRV-ATTR:hostname\u0027: {"},{"line_number":1270,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"166aa63f_2c9071d4","line":1267,"range":{"start_line":1247,"start_character":8,"end_line":1267,"end_character":43},"updated":"2024-11-22 05:03:29.000000000","message":"these are always returned after microversion 2.75 and we can add in \u0027required\u0027 field\n- https://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L366","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"instance name template. Appears in the response for administrative users only."},{"line_number":1245,"context_line":"\"\"\","},{"line_number":1246,"context_line":"        },"},{"line_number":1247,"context_line":"        \u0027OS-EXT-STS:power_state\u0027: {"},{"line_number":1248,"context_line":"            \u0027type\u0027: \u0027integer\u0027,"},{"line_number":1249,"context_line":"            \u0027enum\u0027: [0, 1, 3, 4, 6, 7],"},{"line_number":1250,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1251,"context_line":"The power state of the instance. This is an enum value that is mapped as::"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"    0: NOSTATE"},{"line_number":1254,"context_line":"    1: RUNNING"},{"line_number":1255,"context_line":"    3: PAUSED"},{"line_number":1256,"context_line":"    4: SHUTDOWN"},{"line_number":1257,"context_line":"    6: CRASHED"},{"line_number":1258,"context_line":"    7: SUSPENDED"},{"line_number":1259,"context_line":"\"\"\","},{"line_number":1260,"context_line":"        },"},{"line_number":1261,"context_line":"        \u0027OS-EXT-STS:task_state\u0027: {"},{"line_number":1262,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1263,"context_line":"            \u0027description\u0027: \u0027The task state of the instance.\u0027,"},{"line_number":1264,"context_line":"        },"},{"line_number":1265,"context_line":"        \u0027OS-EXT-STS:vm_state\u0027: {"},{"line_number":1266,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1267,"context_line":"            \u0027description\u0027: \u0027The VM state.\u0027,"},{"line_number":1268,"context_line":"        },"},{"line_number":1269,"context_line":"        \u0027OS-EXT-SRV-ATTR:hostname\u0027: {"},{"line_number":1270,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"758982ac_855299f5","line":1267,"range":{"start_line":1247,"start_character":8,"end_line":1267,"end_character":43},"in_reply_to":"166aa63f_2c9071d4","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1317,"context_line":"for administrative users only."},{"line_number":1318,"context_line":"\"\"\","},{"line_number":1319,"context_line":"        },"},{"line_number":1320,"context_line":"        \u0027os-extended-volumes:volumes_attached\u0027: {"},{"line_number":1321,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":1322,"context_line":"            \u0027items\u0027: {"},{"line_number":1323,"context_line":"                \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0ba53415_8f21d7c4","line":1320,"range":{"start_line":1320,"start_character":0,"end_line":1320,"end_character":49},"updated":"2024-11-22 05:03:29.000000000","message":"this is always returned after microversion 2.75\n\n- https://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L777","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"for administrative users only."},{"line_number":1318,"context_line":"\"\"\","},{"line_number":1319,"context_line":"        },"},{"line_number":1320,"context_line":"        \u0027os-extended-volumes:volumes_attached\u0027: {"},{"line_number":1321,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":1322,"context_line":"            \u0027items\u0027: {"},{"line_number":1323,"context_line":"                \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0fdada3e_cf6bd051","line":1320,"range":{"start_line":1320,"start_character":0,"end_line":1320,"end_character":49},"in_reply_to":"0ba53415_8f21d7c4","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1340,"context_line":"            },"},{"line_number":1341,"context_line":"            \u0027description\u0027: \u0027The attached volumes, if any.\u0027,"},{"line_number":1342,"context_line":"        },"},{"line_number":1343,"context_line":"        \u0027OS-SRV-USG:launched_at\u0027: {"},{"line_number":1344,"context_line":"            \u0027oneOf\u0027: ["},{"line_number":1345,"context_line":"                {\u0027type\u0027: \u0027null\u0027},"},{"line_number":1346,"context_line":"                {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027date-time\u0027},"},{"line_number":1347,"context_line":"            ],"},{"line_number":1348,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1349,"context_line":"The date and time when the server was launched."},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"The date and time stamp format is ISO 8601::"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"    CCYY-MM-DDThh:mm:ss±hh:mm"},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"The ``hh±:mm`` value, if included, is the time zone as an offset from UTC. If"},{"line_number":1358,"context_line":"the ``deleted_at`` date and time stamp is not set, its value is ``null``."},{"line_number":1359,"context_line":"\"\"\","},{"line_number":1360,"context_line":"        },"},{"line_number":1361,"context_line":"        \u0027OS-SRV-USG:terminated_at\u0027: {"},{"line_number":1362,"context_line":"            \u0027oneOf\u0027: ["},{"line_number":1363,"context_line":"                {\u0027type\u0027: \u0027null\u0027},"},{"line_number":1364,"context_line":"                {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027date-time\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"2bc290ea_c7243a0d","line":1361,"range":{"start_line":1343,"start_character":0,"end_line":1361,"end_character":37},"updated":"2024-11-22 05:03:29.000000000","message":"server usage also returned always\n- https://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L326","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1340,"context_line":"            },"},{"line_number":1341,"context_line":"            \u0027description\u0027: \u0027The attached volumes, if any.\u0027,"},{"line_number":1342,"context_line":"        },"},{"line_number":1343,"context_line":"        \u0027OS-SRV-USG:launched_at\u0027: {"},{"line_number":1344,"context_line":"            \u0027oneOf\u0027: ["},{"line_number":1345,"context_line":"                {\u0027type\u0027: \u0027null\u0027},"},{"line_number":1346,"context_line":"                {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027date-time\u0027},"},{"line_number":1347,"context_line":"            ],"},{"line_number":1348,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1349,"context_line":"The date and time when the server was launched."},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"The date and time stamp format is ISO 8601::"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"    CCYY-MM-DDThh:mm:ss±hh:mm"},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"For example, ``2015-08-27T09:49:58-05:00``."},{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"The ``hh±:mm`` value, if included, is the time zone as an offset from UTC. If"},{"line_number":1358,"context_line":"the ``deleted_at`` date and time stamp is not set, its value is ``null``."},{"line_number":1359,"context_line":"\"\"\","},{"line_number":1360,"context_line":"        },"},{"line_number":1361,"context_line":"        \u0027OS-SRV-USG:terminated_at\u0027: {"},{"line_number":1362,"context_line":"            \u0027oneOf\u0027: ["},{"line_number":1363,"context_line":"                {\u0027type\u0027: \u0027null\u0027},"},{"line_number":1364,"context_line":"                {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027date-time\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"a197ca13_b451a27d","line":1361,"range":{"start_line":1343,"start_character":0,"end_line":1361,"end_character":37},"in_reply_to":"2bc290ea_c7243a0d","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1376,"context_line":"the ``deleted_at`` date and time stamp is not set, its value is ``null``."},{"line_number":1377,"context_line":"\"\"\","},{"line_number":1378,"context_line":"        },"},{"line_number":1379,"context_line":"        \u0027security_groups\u0027: {"},{"line_number":1380,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":1381,"context_line":"            \u0027items\u0027: {"},{"line_number":1382,"context_line":"                \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c123be83_c9b23633","line":1379,"range":{"start_line":1379,"start_character":0,"end_line":1379,"end_character":28},"updated":"2024-11-22 05:03:29.000000000","message":"this is only returned if SG are present so not required in \u0027required\u0027 field\n\nhttps://github.com/openstack/nova/blob/9a1872d30e98aa5b10afd6c1c42f29904f7ed6cb/nova/api/openstack/compute/views/servers.py#L717","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"the ``deleted_at`` date and time stamp is not set, its value is ``null``."},{"line_number":1377,"context_line":"\"\"\","},{"line_number":1378,"context_line":"        },"},{"line_number":1379,"context_line":"        \u0027security_groups\u0027: {"},{"line_number":1380,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":1381,"context_line":"            \u0027items\u0027: {"},{"line_number":1382,"context_line":"                \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bc6ea9a7_737cf3ed","line":1379,"range":{"start_line":1379,"start_character":0,"end_line":1379,"end_character":28},"in_reply_to":"c123be83_c9b23633","updated":"2024-11-22 15:22:30.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1391,"context_line":"            },"},{"line_number":1392,"context_line":"            \u0027description\u0027: \u0027One or more security groups objects.\u0027,"},{"line_number":1393,"context_line":"        },"},{"line_number":1394,"context_line":"        \u0027host_status\u0027: {"},{"line_number":1395,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1396,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1397,"context_line":"The host status. Values where next value in list can override the previous:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3bc4f4f0_1b39a6fc","line":1394,"range":{"start_line":1394,"start_character":0,"end_line":1394,"end_character":24},"updated":"2024-11-22 05:03:29.000000000","message":"this is also added based on the policy check so not required in \u0027required\u0027 field","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"            },"},{"line_number":1392,"context_line":"            \u0027description\u0027: \u0027One or more security groups objects.\u0027,"},{"line_number":1393,"context_line":"        },"},{"line_number":1394,"context_line":"        \u0027host_status\u0027: {"},{"line_number":1395,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1396,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1397,"context_line":"The host status. Values where next value in list can override the previous:"}],"source_content_type":"text/x-python","patch_set":6,"id":"4c8091c2_4192e9de","line":1394,"range":{"start_line":1394,"start_character":0,"end_line":1394,"end_character":24},"in_reply_to":"3bc4f4f0_1b39a6fc","updated":"2024-11-22 15:22:30.000000000","message":"Acknowledged","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6054f2a2d746eed5fb47cacce90372a2e38e0576","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"\"\"\","},{"line_number":1408,"context_line":"        },"},{"line_number":1409,"context_line":"    },"},{"line_number":1410,"context_line":")"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"rebuild_response_v296 \u003d copy.deepcopy(rebuild_response_v275)"},{"line_number":1413,"context_line":"rebuild_response_v296[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027].update("}],"source_content_type":"text/x-python","patch_set":6,"id":"42442809_90e20f7e","line":1410,"updated":"2024-08-20 18:25:24.000000000","message":"we did a lot in 2.75","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"166d1ab6e41a5124cae5e8c756ddc134ba4e52ba","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"rebuild_response_v296 \u003d copy.deepcopy(rebuild_response_v275)"},{"line_number":1413,"context_line":"rebuild_response_v296[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027].update("},{"line_number":1414,"context_line":"    {"},{"line_number":1415,"context_line":"        \u0027pinned_availability_zone\u0027: {"},{"line_number":1416,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1417,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1418,"context_line":"This is the availability zone requested during server creation."}],"source_content_type":"text/x-python","patch_set":6,"id":"5dcc496d_a0df2399","line":1415,"range":{"start_line":1415,"start_character":0,"end_line":1415,"end_character":37},"updated":"2024-11-22 05:03:29.000000000","message":"ditto this is always returned after microversion 2.96","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0f3c47cd225862befd9d5b10f40871ed9e1e276","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"rebuild_response_v296 \u003d copy.deepcopy(rebuild_response_v275)"},{"line_number":1413,"context_line":"rebuild_response_v296[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027].update("},{"line_number":1414,"context_line":"    {"},{"line_number":1415,"context_line":"        \u0027pinned_availability_zone\u0027: {"},{"line_number":1416,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":1417,"context_line":"            \u0027description\u0027: \"\"\"\\"},{"line_number":1418,"context_line":"This is the availability zone requested during server creation."}],"source_content_type":"text/x-python","patch_set":6,"id":"6e76a292_7eb00aaa","line":1415,"range":{"start_line":1415,"start_character":0,"end_line":1415,"end_character":37},"in_reply_to":"5dcc496d_a0df2399","updated":"2024-11-22 15:22:30.000000000","message":"Done","commit_id":"846e8175ed1c2ac099b4a028cee690556f627aeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027base64\u0027, \u0027maxLength\u0027: 65535},"},{"line_number":243,"context_line":"        {\u0027type\u0027: \u0027null\u0027},"},{"line_number":244,"context_line":"    ],"},{"line_number":245,"context_line":"}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"create_v219 \u003d copy.deepcopy(create)"},{"line_number":248,"context_line":"create_v219[\u0027properties\u0027][\u0027server\u0027]["}],"source_content_type":"text/x-python","patch_set":8,"id":"96bf78cc_822cfe31","line":245,"updated":"2024-11-26 17:06:13.000000000","message":"ack just a formating change.","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":281,"context_line":"# 3. server.networks.uuid is now required to be a uuid"},{"line_number":282,"context_line":"create_v237 \u003d copy.deepcopy(create_v233)"},{"line_number":283,"context_line":"create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027required\u0027].append(\u0027networks\u0027)"},{"line_number":284,"context_line":"create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027networks\u0027] \u003d {"},{"line_number":285,"context_line":"    \u0027oneOf\u0027: ["},{"line_number":286,"context_line":"        {"},{"line_number":287,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":288,"context_line":"            \u0027items\u0027: {"},{"line_number":289,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":290,"context_line":"                \u0027properties\u0027: {"},{"line_number":291,"context_line":"                    \u0027fixed_ip\u0027: parameter_types.ip_address,"},{"line_number":292,"context_line":"                    \u0027port\u0027: {"},{"line_number":293,"context_line":"                        \u0027oneOf\u0027: [{\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":294,"context_line":"                                  {\u0027type\u0027: \u0027null\u0027}]"},{"line_number":295,"context_line":"                    },"},{"line_number":296,"context_line":"                    \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":297,"context_line":"                },"},{"line_number":298,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":299,"context_line":"            },"},{"line_number":300,"context_line":"        },"},{"line_number":301,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":302,"context_line":"    ],"},{"line_number":303,"context_line":"}"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"# 2.42 builds on 2.37 and re-introduces the tag field to the list of network"},{"line_number":306,"context_line":"# objects."},{"line_number":307,"context_line":"create_v242 \u003d copy.deepcopy(create_v237)"},{"line_number":308,"context_line":"create_v242[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027networks\u0027] \u003d {"},{"line_number":309,"context_line":"    \u0027oneOf\u0027: ["},{"line_number":310,"context_line":"        {"},{"line_number":311,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":312,"context_line":"            \u0027items\u0027: {"},{"line_number":313,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":314,"context_line":"                \u0027properties\u0027: {"},{"line_number":315,"context_line":"                    \u0027fixed_ip\u0027: parameter_types.ip_address,"},{"line_number":316,"context_line":"                    \u0027port\u0027: {"},{"line_number":317,"context_line":"                        \u0027oneOf\u0027: [{\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":318,"context_line":"                                  {\u0027type\u0027: \u0027null\u0027}]"},{"line_number":319,"context_line":"                    },"},{"line_number":320,"context_line":"                    \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":321,"context_line":"                    \u0027tag\u0027: parameter_types.tag,"},{"line_number":322,"context_line":"                },"},{"line_number":323,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":324,"context_line":"            },"},{"line_number":325,"context_line":"        },"},{"line_number":326,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":327,"context_line":"    ],"},{"line_number":328,"context_line":"}"},{"line_number":329,"context_line":"create_v242[\u0027properties\u0027][\u0027server\u0027]["},{"line_number":330,"context_line":"    \u0027properties\u0027][\u0027block_device_mapping_v2\u0027][\u0027items\u0027]["},{"line_number":331,"context_line":"    \u0027properties\u0027][\u0027tag\u0027] \u003d parameter_types.tag"}],"source_content_type":"text/x-python","patch_set":8,"id":"56f213a3_4a5a3c3f","line":328,"range":{"start_line":284,"start_character":0,"end_line":328,"end_character":1},"updated":"2024-11-26 17:06:13.000000000","message":"also just a formatting change,\nit more readable but does not change behaviour.\n\nwith that said i tend not to add trailing commas but its fine.","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":787,"context_line":"    },"},{"line_number":788,"context_line":"    \u0027required\u0027: [\u0027image_id\u0027],"},{"line_number":789,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":790,"context_line":"}"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"rebuild_response \u003d {"},{"line_number":793,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"2665a7ab_427c5471","line":790,"updated":"2024-11-26 17:06:13.000000000","message":"https://docs.openstack.org/api-ref/compute/#id60\n\nyep we did the same change hear of movign form a location header to a id in the body","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8c826fafd14f900725a44c2b7657f62411747d2","unresolved":false,"context_lines":[{"line_number":789,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":790,"context_line":"}"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"rebuild_response \u003d {"},{"line_number":793,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":794,"context_line":"    \u0027properties\u0027: {"},{"line_number":795,"context_line":"        \u0027server\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"f2ca4bd2_db03bf90","line":792,"updated":"2024-11-26 17:06:13.000000000","message":"we have discussed this speratly but rebuild\u0027s reponce effectily embds all of the server show output whishc is why its so long\n\nhttps://docs.openstack.org/api-ref/compute/#id68","commit_id":"b967f2a693b372c6d85e0933b4829bb48e692c3a"}]}