)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff2e741d4a1ff4c43e4a94ddac5cbbcc5348087a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api: Migrate to JSON Schema Draft 2019-09"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenAPI 3.1 is a superset of JSON Schema Draft 2019-09. As a result, we"},{"line_number":10,"context_line":"wish to migrate our current schemas to this. There are a couple of"},{"line_number":11,"context_line":"issues to address:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"71cc53da_9c143b97","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":54},"updated":"2024-04-26 17:35:14.000000000","message":"It\u0027s actually a superset of 2020-12. I read the wrong blog 🙈 Fixed in PS3","commit_id":"085292224a0cda5b390e24ebbd399ebe0cb8e51d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3516ae2e0477506c79e8579d485e03b731183b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4250624_f38940c8","updated":"2024-06-28 14:25:52.000000000","message":"can you point out where in the vmware driver this is required to be larger then 1","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0927bdee9f98af6a5f62581891a7626cf8ca333f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ea8b4fe_4e191815","updated":"2024-06-21 03:40:48.000000000","message":"lgtm","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82b57acac86d71096e2ecad225fbb8683de156d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72d2d2ae_f4852d93","updated":"2024-07-01 10:34:45.000000000","message":"ok im fine with updating this in a followup to avoid re-basing the entire series.","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aec5016810dfc350cada60ac2d5e28bb6ad5bfa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a32bc28a_c660ec9d","updated":"2024-07-03 09:37:38.000000000","message":"recheck","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94a4430210f5398764ee8e1462912065a0c09567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28bfb7a4_0146ab52","updated":"2024-06-21 03:41:28.000000000","message":"recheck integrated-compute job timeout","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"efe39dab40c1e0ea763257220018f6fd399a6797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"54b2a5bc_30beead0","updated":"2024-07-04 17:09:23.000000000","message":"recheck timeout in tempest-integrated-compute-enforce-scope-new-defaults and sean already working on the timeout issues for its base job so I am going to re run the test.","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5730da24d901cad884766256969d0b881561729","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a75c8b2_f33dba95","updated":"2024-07-02 12:27:30.000000000","message":"recheck unrelated failure in base patch","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5c3a549ee50f35c61f6f587bb4efc7a862610fc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f7ee712a_d8ffd667","in_reply_to":"72d2d2ae_f4852d93","updated":"2024-07-01 10:41:31.000000000","message":"Ack, done here https://review.opendev.org/c/openstack/nova/+/923144","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"}],"nova/api/openstack/compute/schemas/flavors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0927bdee9f98af6a5f62581891a7626cf8ca333f","unresolved":true,"context_lines":[{"line_number":50,"context_line":"                \u0027rxtx_factor\u0027: {"},{"line_number":51,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":52,"context_line":"                    \u0027pattern\u0027: r\u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":53,"context_line":"                    \u0027minimum\u0027: 1,"},{"line_number":54,"context_line":"                    # maximum\u0027s value is limited to db constant\u0027s"},{"line_number":55,"context_line":"                    # SQL_SP_FLOAT_MAX (in nova/db/constants.py)"},{"line_number":56,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"}],"source_content_type":"text/x-python","patch_set":4,"id":"c01b3824_8450cef2","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":33},"updated":"2024-06-21 03:40:48.000000000","message":"++, exclusiveMinimum/Max as bool was actually hard to read. this is simple now.","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3516ae2e0477506c79e8579d485e03b731183b9","unresolved":true,"context_lines":[{"line_number":50,"context_line":"                \u0027rxtx_factor\u0027: {"},{"line_number":51,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":52,"context_line":"                    \u0027pattern\u0027: r\u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":53,"context_line":"                    \u0027minimum\u0027: 1,"},{"line_number":54,"context_line":"                    # maximum\u0027s value is limited to db constant\u0027s"},{"line_number":55,"context_line":"                    # SQL_SP_FLOAT_MAX (in nova/db/constants.py)"},{"line_number":56,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"}],"source_content_type":"text/x-python","patch_set":4,"id":"916aa9cc_c0c23a48","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":33},"in_reply_to":"306a55fd_d137e3b5","updated":"2024-06-28 14:25:52.000000000","message":"i think this is wrong\n\nthis is a float an dim not sure 1 is the correct minium\n0.1 ectra i think is valid.","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1d079545a67bd6e0d1bbd69e9383b5e4cce98155","unresolved":true,"context_lines":[{"line_number":50,"context_line":"                \u0027rxtx_factor\u0027: {"},{"line_number":51,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":52,"context_line":"                    \u0027pattern\u0027: r\u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":53,"context_line":"                    \u0027minimum\u0027: 1,"},{"line_number":54,"context_line":"                    # maximum\u0027s value is limited to db constant\u0027s"},{"line_number":55,"context_line":"                    # SQL_SP_FLOAT_MAX (in nova/db/constants.py)"},{"line_number":56,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"}],"source_content_type":"text/x-python","patch_set":4,"id":"56f3fb6e_aa8aa108","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":33},"in_reply_to":"5978ac6e_72853307","updated":"2024-07-01 10:14:24.000000000","message":"Good catch. I had ignored the name (which would have given things away) and wrongly assumed this was a whole integer, not a float. Will updated a follow-up.","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"052294d4f6dd03bfaa9e9e6b9ad9262277824479","unresolved":true,"context_lines":[{"line_number":50,"context_line":"                \u0027rxtx_factor\u0027: {"},{"line_number":51,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":52,"context_line":"                    \u0027pattern\u0027: r\u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":53,"context_line":"                    \u0027minimum\u0027: 1,"},{"line_number":54,"context_line":"                    # maximum\u0027s value is limited to db constant\u0027s"},{"line_number":55,"context_line":"                    # SQL_SP_FLOAT_MAX (in nova/db/constants.py)"},{"line_number":56,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"}],"source_content_type":"text/x-python","patch_set":4,"id":"5978ac6e_72853307","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":33},"in_reply_to":"916aa9cc_c0c23a48","updated":"2024-06-28 14:28:33.000000000","message":"https://opendev.org/openstack/nova/src/branch/master/nova/compute/flavors.py#L103-L110\n\nthis is the validation logci we have\n\nwe also default to 1.0 if not set but technially we are chanigign the api behvior here.\n\nthis is unlikely to break any real world useage but just want to call that out before we proceed with this.","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e696d8131f6eb8cef74bf8d6bb338c42bdc9d760","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                \u0027rxtx_factor\u0027: {"},{"line_number":51,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":52,"context_line":"                    \u0027pattern\u0027: r\u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":53,"context_line":"                    \u0027minimum\u0027: 1,"},{"line_number":54,"context_line":"                    # maximum\u0027s value is limited to db constant\u0027s"},{"line_number":55,"context_line":"                    # SQL_SP_FLOAT_MAX (in nova/db/constants.py)"},{"line_number":56,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"}],"source_content_type":"text/x-python","patch_set":4,"id":"306a55fd_d137e3b5","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":33},"in_reply_to":"c01b3824_8450cef2","updated":"2024-06-24 10:34:07.000000000","message":"Acknowledged","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"}],"nova/api/validation/validators.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0927bdee9f98af6a5f62581891a7626cf8ca333f","unresolved":true,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    \"\"\""},{"line_number":281,"context_line":"    validator \u003d None"},{"line_number":282,"context_line":"    validator_org \u003d jsonschema.Draft202012Validator"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def __init__(self, schema, relax_additional_properties\u003dFalse,"},{"line_number":285,"context_line":"                 is_body\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"59cb4cda_dd9070e3","line":282,"range":{"start_line":282,"start_character":0,"end_line":282,"end_character":51},"updated":"2024-06-21 03:40:48.000000000","message":"++, I thought of moving this to the latest one many times but did not get time.","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e696d8131f6eb8cef74bf8d6bb338c42bdc9d760","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    \"\"\""},{"line_number":281,"context_line":"    validator \u003d None"},{"line_number":282,"context_line":"    validator_org \u003d jsonschema.Draft202012Validator"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def __init__(self, schema, relax_additional_properties\u003dFalse,"},{"line_number":285,"context_line":"                 is_body\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2b0bb6c3_67a9fb00","line":282,"range":{"start_line":282,"start_character":0,"end_line":282,"end_character":51},"in_reply_to":"59cb4cda_dd9070e3","updated":"2024-06-24 10:34:07.000000000","message":"Acknowledged","commit_id":"7491417323a38b2d95dafe49d6883a45faa5455d"}]}