)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c84a728912bd05e867fac2dd30bda7527a32ef21","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Max Lamprecht \u003cmax.lamprecht@mail.schwarz\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-24 17:31:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat: nova-manage db instace events cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This introduces a new \"nova-manage db clear_events\" option"},{"line_number":10,"context_line":"that cleans instance events. This can be helpful to run regulary"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a8a7744f_4827cb06","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":28},"updated":"2024-05-30 17:18:20.000000000","message":"instance","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"121ea25681fa2866fd9672d59139a3fffa8e804d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"to reduce database size if you have many instance-actions on long"},{"line_number":12,"context_line":"existing VMs e.g. live-migration/migrations"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2063342"},{"line_number":15,"context_line":"Change-Id: I6c858f312a2b6d5799a14d2b688b7c5cbdbe0328"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"33b35260_446ce278","line":14,"updated":"2025-02-27 01:21:06.000000000","message":"this is a minor feature rather then a bug\n\ncurrently the event form part of the audit history of the instance so they are inteniolaly not cleanable.\n\nand in general knowing the overall history of the insance can sometimes be impornat when determining how it got into an error state so this was not orginally implemtned on those grounds.\n\nwe should like track this properly as a specless blueprint.\n\nwhile this might be reasonabe in some cloud envionment i dont think this is generally something we would recomemnd operators use.\n\nthis patch should proably also have a release note for the new feature.","commit_id":"87f93627b8bb1daea13540171752d2103cc4aa35"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c84a728912bd05e867fac2dd30bda7527a32ef21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8185894d_04f8139c","updated":"2024-05-30 17:18:20.000000000","message":"Overall I think the idea here is reasonable. At first I thought this was about archiving deleted records (which we already have) but the bug report makes it clear this is about long-lived instances that are not deleted.\n\nMinor comments inline and also this change is currently missing test coverage and a docs entry.","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"6ee5e22d1c1ba9aae930c4220611c4ac1b231198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2cb57f75_8f49e979","updated":"2024-04-25 07:21:55.000000000","message":"recheck","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"2e411fe773f3f26451f7fce1ce3cbae2f198a18d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b1d5052_753f850e","updated":"2024-05-07 11:08:18.000000000","message":"recheck","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"}],"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c84a728912bd05e867fac2dd30bda7527a32ef21","unresolved":true,"context_lines":[{"line_number":391,"context_line":"   * - 4"},{"line_number":392,"context_line":"     - No connection to the API database could be established using"},{"line_number":393,"context_line":"       :oslo.config:option:`api_database.connection`."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"db online_data_migrations"},{"line_number":396,"context_line":"-------------------------"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f125f2e8_06becdca","line":394,"updated":"2024-05-30 17:18:20.000000000","message":"You\u0027ll want to add documentation here and use ``.. versionadded::`` to show the command is new in \u003cversion\u003e. We are now on 30.0.0 (2024.2 Dalmatian).","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"121ea25681fa2866fd9672d59139a3fffa8e804d","unresolved":true,"context_lines":[{"line_number":521,"context_line":""},{"line_number":522,"context_line":"This is can be useful to reduce the size of the database if your environment"},{"line_number":523,"context_line":"has many long lived instances with many events."},{"line_number":524,"context_line":"E.g. many live-migration events due to regulary host maintenance"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":".. versionadded:: 31.0.0 (2025.1 Epoxy)"},{"line_number":527,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f8a5bb0_09c9a258","line":524,"range":{"start_line":524,"start_character":39,"end_line":524,"end_character":47},"updated":"2025-02-27 01:21:06.000000000","message":"regular","commit_id":"87f93627b8bb1daea13540171752d2103cc4aa35"}],"nova/cmd/manage.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c84a728912bd05e867fac2dd30bda7527a32ef21","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            return 3"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    @args(\u0027--before\u0027, metavar\u003d\u0027\u003cbefore\u003e\u0027, dest\u003d\u0027before\u0027,"},{"line_number":562,"context_line":"        help\u003d\u0027If specified, purge rows from shadow tables that are older \u0027"},{"line_number":563,"context_line":"             \u0027than this. Accepts date strings in the default format output \u0027"},{"line_number":564,"context_line":"             \u0027by the ``date`` command, as well as ``YYYY-MM-DD \u0027"},{"line_number":565,"context_line":"             \u0027[HH:mm:ss]``.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"94aee29e_fbc164ce","line":562,"range":{"start_line":562,"start_character":28,"end_line":562,"end_character":57},"updated":"2024-05-30 17:18:20.000000000","message":"Copy paste error? Also, later in the method it says that --before is required, so the wording \"if specified\" is making it sound like it\u0027s optional.\n\nFor a required option, it may be simpler to use the kwarg ``required\u003dTrue`` here instead of checking manually later.\n\n[1] https://docs.python.org/3/library/argparse.html#required","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c84a728912bd05e867fac2dd30bda7527a32ef21","unresolved":true,"context_lines":[{"line_number":564,"context_line":"             \u0027by the ``date`` command, as well as ``YYYY-MM-DD \u0027"},{"line_number":565,"context_line":"             \u0027[HH:mm:ss]``.\u0027)"},{"line_number":566,"context_line":"    @args(\u0027--verbose\u0027, dest\u003d\u0027verbose\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":567,"context_line":"        help\u003d\u0027Print information about purged records\u0027)"},{"line_number":568,"context_line":"    @args(\u0027--all-cells\u0027, dest\u003d\u0027all_cells\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":569,"context_line":"        help\u003d\u0027Run against all cell databases\u0027)"},{"line_number":570,"context_line":"    @args(\u0027--sleep\u0027, type\u003dint, metavar\u003d\u0027\u003cseconds\u003e\u0027, dest\u003d\u0027sleep\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0b735fc_b42fb188","line":567,"range":{"start_line":567,"start_character":38,"end_line":567,"end_character":44},"updated":"2024-05-30 17:18:20.000000000","message":"Same?","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"}],"nova/db/main/api.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c84a728912bd05e867fac2dd30bda7527a32ef21","unresolved":true,"context_lines":[{"line_number":4671,"context_line":"    :param context: nova.context.RequestContext for database access"},{"line_number":4672,"context_line":"    :param before_date: datetime which when specified filters the records"},{"line_number":4673,"context_line":"        to only delete records before the given date"},{"line_number":4674,"context_line":"    :param max_rows: Maximum number of rows to archive (required)"},{"line_number":4675,"context_line":"    :param sleep: The amount of time in seconds to sleep between batches"},{"line_number":4676,"context_line":"    :param only_migration_events: Delete only live-migration and migration"},{"line_number":4677,"context_line":"        events"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6cf1b4b_2bd4bb0c","line":4674,"range":{"start_line":4674,"start_character":47,"end_line":4674,"end_character":54},"updated":"2024-05-30 17:18:20.000000000","message":"Copy paste error?","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c84a728912bd05e867fac2dd30bda7527a32ef21","unresolved":true,"context_lines":[{"line_number":4735,"context_line":"            status_fn("},{"line_number":4736,"context_line":"                _("},{"line_number":4737,"context_line":"                    \"Deleted %(rows)i rows from %(ia_table)s based on\""},{"line_number":4738,"context_line":"                    \" timestamp column %(col)s and there corresponding\""},{"line_number":4739,"context_line":"                    \" %(iae_table)s events\""},{"line_number":4740,"context_line":"                )"},{"line_number":4741,"context_line":"                % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"88860317_bf1b3e4e","line":4738,"range":{"start_line":4738,"start_character":51,"end_line":4738,"end_character":56},"updated":"2024-05-30 17:18:20.000000000","message":"their","commit_id":"2a3b970b2427a410619c01477c49b67d7fcc3eb3"}]}