)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3aa8ffd4eb127fcd5cb8e6482efbaf151da5c4d3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the ability to manage devices by alias instead of serial, but to"},{"line_number":12,"context_line":"fully enable this use-case we need to avoid putting serial in the"},{"line_number":13,"context_line":"XML to appease libvirt."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ifa2df89f27e58e1e64ce046edeaf6e49a7c89490"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a03f63b3_4be36f01","line":14,"updated":"2024-05-07 11:51:07.000000000","message":"i was checking and we only have downstream bug reporsts/feature request for this so there is not upstream but to reference.\n\nif you respien you could add one but i dont think we need to backport this.\n\nthis proably worked in the distact before times prior to qemu/libvirt blocking this behavior but that happened so long ago that i dont think its reasonable to consider this a regression still.\n\nits been proably 5-6 years or more where this has not worked so this is really\na minor enhancement rahter then a bug.","commit_id":"b207cf703a7d3a3c202d1c9f9c105079ee50db29"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3aa8ffd4eb127fcd5cb8e6482efbaf151da5c4d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aa9fe02c_9d5dd770","updated":"2024-05-07 11:51:07.000000000","message":"you could add a release note to this to call out the fact that this now works again but over all this looks ok.\n\nit would be nice to seperately add a tempest test to valididate this\n\ni.e. boot a vm and attach a lun type volume or create a lun type bfv guest \nbut we can do that as a follow on.","commit_id":"b207cf703a7d3a3c202d1c9f9c105079ee50db29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f00125d575ce9d1a7191ebf5d399395061c4d00e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65baaf2c_05a64570","in_reply_to":"4a62c535_424a3dd0","updated":"2024-05-07 14:23:41.000000000","message":"\u003e \u003e \u003e i.e. boot a vm and attach a lun type volume or create a lun type bfv guest \n\u003e \u003e \u003e but we can do that as a follow on.\n\u003e \u003e \n\u003e \u003e Well, I guess I can do that. The problem is that I have to add an image property to tickle it and I also figured it\u0027s possible that it won\u0027t worth with all the backends. I can poke at that and see.\n\u003e \n\u003e Actually, I guess it wouldn\u0027t necessarily hurt to have `hw_scsi_model\u003dvirtio-scsi` on all the time in a tempest job such that I could avoid re-adding the image. But in that case I probably need to add a compute feature flag and/or check the image for that property and skip the test if it\u0027s missing.\n\n\n... i lost my reply so take two.\n\nyes you coudl do that but if i was to do that i woudl proably make it configurabel per job.\n\nwe have a compute feature flag for ide based testing which was needed for q35\n\nso having one for \"suppoprt lun\" is not too out of place \n\nhttps://github.com/openstack/tempest/blob/master/tempest/config.py#L598-L601\n\nwe also have one for multi attach\n\nhttps://github.com/openstack/tempest/blob/master/tempest/config.py#L593-L597\n\nso ya in my mind there would be three parts to testing this in tempest\n\n1 modifying devstack upload image to add the disk bus\nhttps://github.com/openstack/devstack/blob/9be4ceeaa10f6ed92291e77ec52794acfb67c147/functions#L131\n\nwe already set it to scsi for arm images https://github.com/openstack/devstack/blob/9be4ceeaa10f6ed92291e77ec52794acfb67c147/functions#L401\n\n\n2 adding a compute feature flag and test to tempest\n\n3 enableing both in one or several of our jobs.","commit_id":"b207cf703a7d3a3c202d1c9f9c105079ee50db29"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2db36382a208b1cfffa7a567952df69adfe2ba7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a62c535_424a3dd0","in_reply_to":"514600f0_932be4fb","updated":"2024-05-07 14:08:51.000000000","message":"\u003e \u003e i.e. boot a vm and attach a lun type volume or create a lun type bfv guest \n\u003e \u003e but we can do that as a follow on.\n\u003e \n\u003e Well, I guess I can do that. The problem is that I have to add an image property to tickle it and I also figured it\u0027s possible that it won\u0027t worth with all the backends. I can poke at that and see.\n\nActually, I guess it wouldn\u0027t necessarily hurt to have `hw_scsi_model\u003dvirtio-scsi` on all the time in a tempest job such that I could avoid re-adding the image. But in that case I probably need to add a compute feature flag and/or check the image for that property and skip the test if it\u0027s missing.","commit_id":"b207cf703a7d3a3c202d1c9f9c105079ee50db29"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2d8e45aa31e8484178e228e4c9b22ef2b4a03df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"514600f0_932be4fb","in_reply_to":"aa9fe02c_9d5dd770","updated":"2024-05-07 13:37:39.000000000","message":"\u003e you could add a release note to this to call out the fact that this now works again but over all this looks ok.\n\nWell, I was hoping to get someone to validate that this actually brings the raw-scsi behavior we\u0027re looking for (that looks like it might happen downstream actually). It\u0027s clearly working in LUN mode now, so perhaps it\u0027s worth the reno just for that, but yeah it seemed too minor.\n\n\u003e it would be nice to seperately add a tempest test to valididate this\n\u003e \n\u003e i.e. boot a vm and attach a lun type volume or create a lun type bfv guest \n\u003e but we can do that as a follow on.\n\nWell, I guess I can do that. The problem is that I have to add an image property to tickle it and I also figured it\u0027s possible that it won\u0027t worth with all the backends. I can poke at that and see.","commit_id":"b207cf703a7d3a3c202d1c9f9c105079ee50db29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de4cb8ddeb3932c79543171a4e6c45245648c4f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3840348c_3a2922f1","updated":"2024-05-08 11:19:42.000000000","message":"this looks ok and based on the results of the last patch that verifies the series in tempest this is at least functional form a qemu/libvirt point of view.","commit_id":"575ff86a4f1572786d66639f774405fbc074fdb1"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1fb8861df274611db2c1f5539a747c0794c57c35","unresolved":true,"context_lines":[{"line_number":1309,"context_line":"                                     bus\u003dself.target_bus))"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        if self.serial is not None and self.source_device !\u003d \u0027lun\u0027:"},{"line_number":1312,"context_line":"            dev.append(self._text_node(\"serial\", self.serial))"},{"line_number":1313,"context_line":""},{"line_number":1314,"context_line":"        self._format_iotune(dev)"},{"line_number":1315,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ea900c7f_3752b0df","line":1312,"updated":"2024-05-04 14:08:59.000000000","message":"ah yep we do need this edge case.\n\nill look at this again properly on tuesday when im back","commit_id":"b207cf703a7d3a3c202d1c9f9c105079ee50db29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de4cb8ddeb3932c79543171a4e6c45245648c4f6","unresolved":false,"context_lines":[{"line_number":1309,"context_line":"                                     bus\u003dself.target_bus))"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        if self.serial is not None and self.source_device !\u003d \u0027lun\u0027:"},{"line_number":1312,"context_line":"            dev.append(self._text_node(\"serial\", self.serial))"},{"line_number":1313,"context_line":""},{"line_number":1314,"context_line":"        self._format_iotune(dev)"},{"line_number":1315,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e4361338_95fad4f0","line":1312,"in_reply_to":"ea900c7f_3752b0df","updated":"2024-05-08 11:19:42.000000000","message":"Acknowledged","commit_id":"b207cf703a7d3a3c202d1c9f9c105079ee50db29"}]}