)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0d3da4e5d2bd73feb435eb0138eb85b3f398a8c3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-04 19:45:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ironic] Fix rebooting VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The correct state for hard and soft reboots are rebooting [0]"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0dd52f24_efa0ee67","line":7,"updated":"2024-05-06 21:26:57.000000000","message":"Shouldn\u0027t this be s/VM/node/ or \"instance\" or something? Isn\u0027t an \"ironic VM\" an contradiction?","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c5eff9f8a691f40bfc0703a6bdfb80f58d8ec235","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-04 19:45:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ironic] Fix rebooting VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The correct state for hard and soft reboots are rebooting [0]"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"45aa9a38_857c693b","line":7,"in_reply_to":"0dd52f24_efa0ee67","updated":"2024-05-06 21:41:10.000000000","message":"++ instance is maximally accurate, node would be inaccurate in the other direction :D","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"09aec34cf79c7c487f3d47af822fac7d98df15d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-04 19:45:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[ironic] Fix rebooting VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The correct state for hard and soft reboots are rebooting [0]"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a89c1c36_3160d0e6","line":7,"in_reply_to":"45aa9a38_857c693b","updated":"2024-05-07 05:25:07.000000000","message":"Done","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b49f41686bebb8f3a017f3ceb5964dee1b0c7e41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06acdb24_1a0208db","updated":"2024-05-04 19:30:51.000000000","message":"Good, but a suggestion for completeness","commit_id":"715b2744945211d8865e34ef968e328d45c50c37"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ea306773fe1cdb64aebb7ad83f93433d9f5f4b19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"602e3604_42d348ae","updated":"2024-05-04 19:34:59.000000000","message":"thanks for review.","commit_id":"761f1d08b909246d74f3e7881f6b9dc431883cbc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"560c3d805bf0ae33df80446ec72400b9125b49f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7c5b38fa_b08c465a","updated":"2024-05-04 23:56:24.000000000","message":"Please also consider this for backport once merged.","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c5eff9f8a691f40bfc0703a6bdfb80f58d8ec235","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6bad8652_f907fe8c","updated":"2024-05-06 21:41:10.000000000","message":"Vasyl, I\u0027m happy to perform the requested updates. I\u0027ll do so in a couple of days if you haven\u0027t yet 😊","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ca083ff677d004d6e74b3dd4e6aa933b0f7b70d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a0441030_c5beff35","in_reply_to":"7c5b38fa_b08c465a","updated":"2024-05-05 06:23:45.000000000","message":"Acknowledged","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e87a0173ee8e7811dbf40f2a1eeaa5f2db5f5c9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f9f501f5_7ea6800f","updated":"2024-05-07 09:06:18.000000000","message":"recheck unrelated failure","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ea3261e0c299384fcbae0e33859d7009241d6c4f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"96069e15_b467c609","updated":"2024-05-08 01:00:54.000000000","message":"Noting that we\u0027re already working on tempest coverage for rebooting: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/918462","commit_id":"0e766885f65068559f6680116db6dad898ad5b8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e0f1d36f7ba123733ad771ef713945da9c343770","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"26d01a40_1ffbc69b","updated":"2024-05-07 18:19:31.000000000","message":"jay was fine with this before and now we are just using the constants for the sdk so i think this looks ok.\n\nim a liggel sad we dont have coverage for this in our ci in tempest but we can look at adding some reboot test to the existing ironic jobs in the future.\n\ncurrently it only runs\n\nronic_tempest_plugin.tests.scenario.test_baremetal_basic_ops.BaremetalBasicOpsAndRescue.test_baremetal_server_ops_wholedisk_image","commit_id":"0e766885f65068559f6680116db6dad898ad5b8c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"28a83a63d0f83a2685cb8122cb0085847d8bc78e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4b596aa7_afcd7658","updated":"2024-05-07 21:15:53.000000000","message":"recheck nova-grenade-multinode","commit_id":"0e766885f65068559f6680116db6dad898ad5b8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d52a6fe25a3a82764e747a3558d1cca601f18b0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0fefbccf_31ef52c0","in_reply_to":"9259720b_412ccf84","updated":"2024-05-08 10:39:35.000000000","message":"ya adding it is not hard we just need to enable it in the existing job\n\nwe just need the ironic job to use an ironic flavor and then we can use all the normal tempest test with that for any nova operation that is supported by ironic.\nwe do not need a sepcial irionc tempest plugin to validate that.\n\nmost of the nova opettions wont work with ironic but the basics of start/stop/reboot should all work fine.","commit_id":"0e766885f65068559f6680116db6dad898ad5b8c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5a9d16d93e260f9e11b10ef8930b9ba37b6ca7f8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9259720b_412ccf84","in_reply_to":"96069e15_b467c609","updated":"2024-05-08 05:14:07.000000000","message":"the rebooting tests are already in tempest we just need to run nova smoke tests (which actually what we do in downstream)","commit_id":"0e766885f65068559f6680116db6dad898ad5b8c"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b49f41686bebb8f3a017f3ceb5964dee1b0c7e41","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft reboot\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f407b48_9bf7a003","line":1410,"updated":"2024-05-04 19:30:51.000000000","message":"looks like from https://github.com/openstack/openstacksdk/blob/master/openstack/baremetal/v1/node.py#L50 this is \u0027soft rebooting\u0027","commit_id":"715b2744945211d8865e34ef968e328d45c50c37"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"425461b9fcd63e51de228af8422bd25f82956a42","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft reboot\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3cc2b42_4be9158d","line":1410,"in_reply_to":"036c8674_e57ce0d4","updated":"2024-05-04 19:40:59.000000000","message":"Done","commit_id":"715b2744945211d8865e34ef968e328d45c50c37"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ea306773fe1cdb64aebb7ad83f93433d9f5f4b19","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft reboot\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"036c8674_e57ce0d4","line":1410,"in_reply_to":"6f407b48_9bf7a003","updated":"2024-05-04 19:34:59.000000000","message":"nice catch! fixed.","commit_id":"715b2744945211d8865e34ef968e328d45c50c37"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"408811e3a0bf7f23340796824c7225c39178d00c","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"cd97f2f0_b8e504cd","line":1410,"updated":"2024-05-07 11:16:43.000000000","message":"vm statuse are generally defiened here \nhttps://github.com/openstack/nova/blob/master/nova/compute/vm_states.py#L34-L79\n\nwith refernce to this enum\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L990-L1009\n\nthe task states are defiend here\nhttps://github.com/openstack/nova/blob/master/nova/compute/task_states.py#L26-L132\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L1011-L1068\n\n\nwith the relenvet once for reboot being\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L1031-L1036\n\n\nand the power states are defiend here\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/power_state.py#L27-L46\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L1071-L1112\n\nsoft rebooting is not an instnace power state.\nit may be in ironci but its not in nova.\n\nin general if an instance is active we expect the power state to be RUNNING \n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4313-L4319\n\nwe do not note if its rebooting or not in the power state we track that its rebooting and the kind via / progress in the task state.\n\nit looks like the ironic driver is trying to reflect the nova task state in the ironic api is that the intent?\n\ni was going to suggest using one of those filed enuma rather then strings to avoid typos like this but since we are setting values in the ironic node the enum that nova has for tis filed may not apply\n\n\nlooking at the commit you link to this enum in ironic the sdk\n\nis there a reason you ar enot just importing that and using it?\nwe are usign the sdk now any i would prefer to use the constants rather then raw strings.","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2dbff19a4088942dacd4227e92ef7d85a72095fb","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"8c15b6cf_04df3e1f","line":1410,"in_reply_to":"1e86f07a_30c2f799","updated":"2024-05-07 17:06:32.000000000","message":"Ironic API uses own power states https://github.com/openstack/ironic/blob/5717c7e599dad0b8f4697603e760de0554e4424d/ironic/common/states.py#L309 which are actually the same as in openstacksdk. The ironic virt driver module is a translation layer between nova and ironic. I think that having ironic power states aligned with nova as it was in the ironicclient is an overkill.\n\nUpdated patch to use Enum items.","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4c9740e5b441bc20d060a4131f68f4f68cc2d0b2","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ce5f1e44_0f6a6df2","line":1410,"in_reply_to":"399c152d_9c225987","updated":"2024-05-07 13:32:27.000000000","message":"I thought this was some ironic enum value, is it not? Isn\u0027t that the fix, that it was \"reboot\" before and not \"reboot-ing\"?","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c2dd28240eaab1695dc7de9343a1a4ab0cb8e13","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"a0a18f78_f67934a0","line":1410,"in_reply_to":"6916e44e_b7673f92","updated":"2024-05-07 13:47:55.000000000","message":"specificaly this one that was referenced in the commit message\n\nhttps://github.com/openstack/openstacksdk/blob/master/openstack/baremetal/v1/node.py#L36-L51","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e0f1d36f7ba123733ad771ef713945da9c343770","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da5caf63_6b6c48a2","line":1410,"in_reply_to":"8c15b6cf_04df3e1f","updated":"2024-05-07 18:19:31.000000000","message":"Done","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66d4a5233052c991851263f55777d8a9408ecd0","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1e86f07a_30c2f799","line":1410,"in_reply_to":"990b32b3_fa546472","updated":"2024-05-07 14:09:14.000000000","message":"i was orginally trying t make the point that powerstate in nova does not have a rebooting value.\n\nand was asking if powerstate in ironic is actully mapping to task_state in nova\n\n\ni.e. when rebooting i belive vm status remains ACTIVE\nand power_state remians RUNNING in nova but the task_state changes\n\nin ironic it looks like setting the power state via set_node_power_state\nhas the sideefect fo performing tha power action which is what is defiend in that enum.\n\nbaiscally it think this bug was introduced by the removal of the use of ironci clinet and the intoduction of the sdk.\n\nhttps://github.com/openstack/nova/commit/4bffd6fc2108ee94f264d2b6f77bff6c5aff163a\n\nthe ironic clinet had a translation layer\n\nhttps://github.com/openstack/python-ironicclient/blob/5.0.1/ironicclient/v1/node.py#L27-L33\n\n\nstephen explcitly noted this in his commit\n\n\nNote that SDK does not expose a \u0027soft\u0027 flag on the\n\u0027set_node_power_state\u0027 method. Instead, it simply expects the real power\nstate strings rather than a combination of strings with the flag like\nironicclient [1]\n\n\n[1] https://github.com/openstack/python-ironicclient/blob/5.0.1/ironicclient/v1/node.py#L27-L33\n\n\nso he was assertign that reboot not rebooting was the correct value to use in his change.\n\nwe are now reverting that it seams but perhspas he copied the keys form that dict and should have copied the values.\n\n_power_states \u003d {\n    \u0027on\u0027: \u0027power on\u0027,\n    \u0027off\u0027: \u0027power off\u0027,\n    \u0027reboot\u0027: \u0027rebooting\u0027,\n    \u0027soft off\u0027: \u0027soft power off\u0027,\n    \u0027soft reboot\u0027: \u0027soft rebooting\u0027,\n}\n\n\nhe is explcitly changing \nself.ironicclient.call(\"node.set_power_state\", node.uuid, \u0027off\u0027)\nto \nself.ironic_connection.set_node_power_state(node.uuid, \u0027power off\u0027)\n\nwhich implies in this case that the value is the correct thing to use\n\nhowever he did nto update reboot-\u003erebooting\n\n\nso this may have just been an oversight.","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0307c6f2467b2507460b6a0638e916f023ed1b54","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"990b32b3_fa546472","line":1410,"in_reply_to":"a0a18f78_f67934a0","updated":"2024-05-07 13:51:56.000000000","message":"Okay I thought you were arguing about *our* vm_state not matching what he\u0027s doing here, and I\u0027m not sure how that\u0027s relevant. If there\u0027s an ironic enum in the SDK, then sure, I was just not sure what the point of the references to our vm and task states was about.","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c1306a1805e39e70f8f0b255cfabeb410b4320ab","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"399c152d_9c225987","line":1410,"in_reply_to":"cd97f2f0_b8e504cd","updated":"2024-05-07 13:13:47.000000000","message":"ok, lets import and use enum value.","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"48159768dc0ee38ba52ce58969cf38b7fd6d7889","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1409,"context_line":"                    node.id,"},{"line_number":1410,"context_line":"                    \u0027soft rebooting\u0027,"},{"line_number":1411,"context_line":"                )"},{"line_number":1412,"context_line":"                hard \u003d False"},{"line_number":1413,"context_line":"            except sdk_exc.BadRequestException as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6916e44e_b7673f92","line":1410,"in_reply_to":"ce5f1e44_0f6a6df2","updated":"2024-05-07 13:47:00.000000000","message":"there is an ironic emnum value but there is also a copy of that in the sdk\n\nand we now using the sdk to talk to ironic so that why i want use to use the sdk\u0027s enum","commit_id":"fde4e4957425c97272e9c853ad9f144a237c8b8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"26a867a0cd1ac7b3eb6c72d6931b6fb614f6738f","unresolved":true,"context_lines":[{"line_number":1451,"context_line":"                # polling interval"},{"line_number":1452,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1453,"context_line":"                    node.id,"},{"line_number":1454,"context_line":"                    \u0027soft power off\u0027,"},{"line_number":1455,"context_line":"                    timeout\u003dtimeout,"},{"line_number":1456,"context_line":"                )"},{"line_number":1457,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fb792ea_5366a89c","line":1454,"range":{"start_line":1454,"start_character":19,"end_line":1454,"end_character":37},"updated":"2024-05-07 17:07:21.000000000","message":"it would be nice to convert the other cases as well","commit_id":"ab605a62cca3b4fd78086767bc6f36a1a2147500"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"18ff7e3e1e65a108408362a4c96d40d27bf79067","unresolved":false,"context_lines":[{"line_number":1451,"context_line":"                # polling interval"},{"line_number":1452,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1453,"context_line":"                    node.id,"},{"line_number":1454,"context_line":"                    \u0027soft power off\u0027,"},{"line_number":1455,"context_line":"                    timeout\u003dtimeout,"},{"line_number":1456,"context_line":"                )"},{"line_number":1457,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e97a6350_f72b5ea5","line":1454,"range":{"start_line":1454,"start_character":19,"end_line":1454,"end_character":37},"in_reply_to":"3fb792ea_5366a89c","updated":"2024-05-07 17:23:45.000000000","message":"Acknowledged","commit_id":"ab605a62cca3b4fd78086767bc6f36a1a2147500"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d2303e213e20d7930dee8726097aa3f6096ec53b","unresolved":false,"context_lines":[{"line_number":1451,"context_line":"                # polling interval"},{"line_number":1452,"context_line":"                self.ironic_connection.set_node_power_state("},{"line_number":1453,"context_line":"                    node.id,"},{"line_number":1454,"context_line":"                    \u0027soft power off\u0027,"},{"line_number":1455,"context_line":"                    timeout\u003dtimeout,"},{"line_number":1456,"context_line":"                )"},{"line_number":1457,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"372c87a8_9370577e","line":1454,"range":{"start_line":1454,"start_character":19,"end_line":1454,"end_character":37},"in_reply_to":"e97a6350_f72b5ea5","updated":"2024-05-07 17:40:37.000000000","message":"done","commit_id":"ab605a62cca3b4fd78086767bc6f36a1a2147500"}],"releasenotes/notes/fix-hard-rebooting-ironic-vm-c270477b4262592b.yaml":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0d3da4e5d2bd73feb435eb0138eb85b3f398a8c3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hard and soft rebooting of VM with ironic virt driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"02fe0d06_dc69def9","line":4,"updated":"2024-05-06 21:26:57.000000000","message":"We usually add a little more information for things like this. I\u0027m not sure a reno is really required for this, but if it is, can you add some more detail? from the bug, it looks like this was just an oversight and thus a straightforward correction. We don\u0027t need a reno for every such fix.","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c5eff9f8a691f40bfc0703a6bdfb80f58d8ec235","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hard and soft rebooting of VM with ironic virt driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"caf03c56_4dda8263","line":4,"in_reply_to":"02fe0d06_dc69def9","updated":"2024-05-06 21:41:10.000000000","message":"This is a straightforward bug, if you don\u0027t use renos in nova for that this should be removed.","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"09aec34cf79c7c487f3d47af822fac7d98df15d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hard and soft rebooting of VM with ironic virt driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e8afd1f0_dd685c62","line":4,"in_reply_to":"caf03c56_4dda8263","updated":"2024-05-07 05:25:07.000000000","message":"Done","commit_id":"53cd88d0c26b15268fd9d51bccb3a62eeb2e6b11"}]}