)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58931187c3c4ddca60126b7f61cb5bb84febd3b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27f2a0ba_2ed67258","updated":"2024-05-08 11:17:03.000000000","message":"im not sure if it matter but if we have two disk with the same boot index does libvirt complain?","commit_id":"2f0c340d3910f48ab4609f477b76aa69da2f2bbb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"06e291bdcbaf25269340c1902e12d07c35a571b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"95276f08_83ba0dba","updated":"2024-05-09 13:37:14.000000000","message":"recheck failed to install cephadm from mirrors","commit_id":"2f0c340d3910f48ab4609f477b76aa69da2f2bbb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44b34d902561489a627538ff17aa47085bc8e052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c2e62b63_ae47aa38","updated":"2024-05-08 19:42:48.000000000","message":"recheck guest kernel crash","commit_id":"2f0c340d3910f48ab4609f477b76aa69da2f2bbb"}],"nova/tests/unit/virt/libvirt/test_blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58931187c3c4ddca60126b7f61cb5bb84febd3b7","unresolved":true,"context_lines":[{"line_number":1380,"context_line":"            \u0027disk\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":1381,"context_line":"                     \u0027type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: \u00271\u0027},"},{"line_number":1382,"context_line":"            \u0027root\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":1383,"context_line":"                     \u0027type\u0027: \u0027lun\u0027, \u0027boot_index\u0027: \u00271\u0027},"},{"line_number":1384,"context_line":"            }"},{"line_number":1385,"context_line":"        }"},{"line_number":1386,"context_line":"        expected_order \u003d [\u0027hd\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"c36f45f3_60753203","line":1383,"range":{"start_line":1383,"start_character":51,"end_line":1383,"end_character":52},"updated":"2024-05-08 11:17:03.000000000","message":"should one of these be 0?","commit_id":"2f0c340d3910f48ab4609f477b76aa69da2f2bbb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f9a550c6820f2c5790978bcefb61318794add2b","unresolved":true,"context_lines":[{"line_number":1380,"context_line":"            \u0027disk\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":1381,"context_line":"                     \u0027type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: \u00271\u0027},"},{"line_number":1382,"context_line":"            \u0027root\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":1383,"context_line":"                     \u0027type\u0027: \u0027lun\u0027, \u0027boot_index\u0027: \u00271\u0027},"},{"line_number":1384,"context_line":"            }"},{"line_number":1385,"context_line":"        }"},{"line_number":1386,"context_line":"        expected_order \u003d [\u0027hd\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"68471c06_c1c9f697","line":1383,"range":{"start_line":1383,"start_character":51,"end_line":1383,"end_character":52},"in_reply_to":"34292334_e3a6f278","updated":"2024-05-08 15:36:31.000000000","message":"ok not great but its at least consitent and change that in general is out of scope of your change so i gues this is fine as is","commit_id":"2f0c340d3910f48ab4609f477b76aa69da2f2bbb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"192523d41ed25fe80924207b3b0b177047979f21","unresolved":true,"context_lines":[{"line_number":1380,"context_line":"            \u0027disk\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":1381,"context_line":"                     \u0027type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: \u00271\u0027},"},{"line_number":1382,"context_line":"            \u0027root\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027vda\u0027,"},{"line_number":1383,"context_line":"                     \u0027type\u0027: \u0027lun\u0027, \u0027boot_index\u0027: \u00271\u0027},"},{"line_number":1384,"context_line":"            }"},{"line_number":1385,"context_line":"        }"},{"line_number":1386,"context_line":"        expected_order \u003d [\u0027hd\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"34292334_e3a6f278","line":1383,"range":{"start_line":1383,"start_character":51,"end_line":1383,"end_character":52},"in_reply_to":"c36f45f3_60753203","updated":"2024-05-08 13:42:27.000000000","message":"This is copied from L1321. Yes, we have other code that checks that the boot index makes sense, but it\u0027s in a different method. Since this is just testing `get_boot_order()` the index is irrelevant. I can change this if I rebase, but as noted, there are a few others above with the same thing. The \"overlapping\" test above has one is checking for overlapping *device names* not indexes, so all these tests have re-used `boot_index` values :)","commit_id":"2f0c340d3910f48ab4609f477b76aa69da2f2bbb"}]}