)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"411805ac4e503ab2c66df272ae5a194ad15cf858","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Since we already talk about time of deletion when describing"},{"line_number":15,"context_line":"--before argument of \"nova-manage db archive_deleted_rows\" rows,"},{"line_number":16,"context_line":"it make sense to not provide extra details here as well."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib5940e88a52dc8d32303e27237e567c3481fc3dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5540f046_2019f305","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":20},"updated":"2024-05-15 19:42:03.000000000","message":"\"makes sense to provide\" or \"makes sense to not provide\"? Not sure I\u0027m reading this right.","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"d8780d642dec95adae43dc7eaf0e4661d1b4a914","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Since we already talk about time of deletion when describing"},{"line_number":15,"context_line":"--before argument of \"nova-manage db archive_deleted_rows\" rows,"},{"line_number":16,"context_line":"it make sense to not provide extra details here as well."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib5940e88a52dc8d32303e27237e567c3481fc3dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a9308bd8_4e9a9fe5","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":20},"in_reply_to":"5540f046_2019f305","updated":"2024-05-17 12:23:15.000000000","message":"First of all, thank you very much for review.\n\nI tried to say here that for archive_deleted_rows command there are cases where we use updated_at field to match time provided via --before argument [1]. So while we have similar situation for purge command as well [2], we can only talk about deletion time for simplicity, so users will not be be confused...\n\n[1]\nhttps://github.com/openstack/nova/blob/ab3ca1e2059f951b44d723c15a5065c6532540da/nova/db/main/api.py#L4408C43-L4408C53\n\n[2]\nhttps://github.com/openstack/nova/blob/ab3ca1e2059f951b44d723c15a5065c6532540da/nova/db/main/api.py#L4622-L4638","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"32585bbee75fc13428874e3950c0c0a6e85e2e18","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Since we already talk about time of deletion when describing"},{"line_number":15,"context_line":"--before argument of \"nova-manage db archive_deleted_rows\" rows,"},{"line_number":16,"context_line":"it make sense to not provide extra details here as well."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib5940e88a52dc8d32303e27237e567c3481fc3dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0c563dd5_a34ac7a3","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":20},"in_reply_to":"a9308bd8_4e9a9fe5","updated":"2024-05-17 22:01:52.000000000","message":"OK, I think I see what you mean. Because \"archived\" is incorrect, I didn\u0027t think about it as an extra detail but rather as a wrong detail 🙂\n\nI agree using consistent text for both purge and archive is best for making the doc clear.","commit_id":"7d8b027053f3f686018fac328157181466530262"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"1d5f292a493eb678401d42d6325839f9aa2ecb29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6727b20_3e319b93","updated":"2024-05-20 17:10:10.000000000","message":"Hi Sean and Gibi. Please take a look at small docfix related to nova-manage db command if you have a minute.","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"feb11f7b2b6d8207966044f6457b4ce57b5b4d82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f84b513e_b0f3e136","updated":"2024-05-15 19:14:05.000000000","message":"I have found disparity in the docs and kindly ask you to take a look. Thanks in advance!","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"411805ac4e503ab2c66df272ae5a194ad15cf858","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de9b5383_92f955c7","updated":"2024-05-15 19:42:03.000000000","message":"LGTM","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"d41767f2aea8331c460900be5f385e8e84d471f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c954b6f_28cd7b2d","updated":"2024-05-21 18:19:07.000000000","message":"Thank you very much for review Sean. Your version is indeed more accurate when it comes to reflecting nova-manage\u0027s actions. I will upload new version shortly.","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"68f133aadc7b862c11d0a1cfa3111524ed3c6614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8da2dce5_363f339c","updated":"2024-05-22 02:19:23.000000000","message":"This is good I think, thanks!","commit_id":"ac8729ac87ced81c959d4aa482e2c3f02661eace"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fbf798ef9b51024aede714ecd9615a17dd70f68c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"33e22be7_9804b659","updated":"2024-05-22 01:52:57.000000000","message":"melanine was +2 before and this only a minor tweak but ill give her a day or two to loop back otherwise ill proxy her vote on monday\n\nthanks alex this looks good to me now","commit_id":"ac8729ac87ced81c959d4aa482e2c3f02661eace"}],"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"02e5a81ec17a0b1fab2af604478dd3db579bca2c","unresolved":true,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":".. option:: --before \u003cdate\u003e"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    Delete data that was deleted from Nova before ``\u003cdate\u003e``. Accepts date"},{"line_number":351,"context_line":"    strings in the default format output by the ``date`` command, as well as"},{"line_number":352,"context_line":"    ``YYYY-MM-DD[HH:mm:ss]``. For example::"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b06f6aa0_a0cb3586","line":350,"updated":"2024-05-21 10:03:11.000000000","message":"is this right? we dont consider it to be fully deleted when its archived and we are purgin the archive rows.\n\nthis update feels semanticaly wrong to me even if its almost equivlent.\n\nthe instnace is certenly still deleted in either case but we are always careful to say we “archive deleted rows” then “purge archived rows”\n\ni would proably write this as \n\n“Delete archived rows that were deleted from Nova before ``\u003cdate\u003e``”\n\nwe wont delete non archived rows with this operation so calling out archive is imporant.","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"d41767f2aea8331c460900be5f385e8e84d471f2","unresolved":true,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":".. option:: --before \u003cdate\u003e"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    Delete data that was deleted from Nova before ``\u003cdate\u003e``. Accepts date"},{"line_number":351,"context_line":"    strings in the default format output by the ``date`` command, as well as"},{"line_number":352,"context_line":"    ``YYYY-MM-DD[HH:mm:ss]``. For example::"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bea68c10_eed2d36f","line":350,"in_reply_to":"b06f6aa0_a0cb3586","updated":"2024-05-21 18:19:07.000000000","message":"Makes sense, will update text accordingly.","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"7964a0c74c4e78dbb52ba63d039e0314d06a470f","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":".. option:: --before \u003cdate\u003e"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    Delete data that was deleted from Nova before ``\u003cdate\u003e``. Accepts date"},{"line_number":351,"context_line":"    strings in the default format output by the ``date`` command, as well as"},{"line_number":352,"context_line":"    ``YYYY-MM-DD[HH:mm:ss]``. For example::"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"21c62bf3_a899303d","line":350,"in_reply_to":"bea68c10_eed2d36f","updated":"2024-05-21 18:20:16.000000000","message":"Done","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"411805ac4e503ab2c66df272ae5a194ad15cf858","unresolved":true,"context_lines":[{"line_number":351,"context_line":"    strings in the default format output by the ``date`` command, as well as"},{"line_number":352,"context_line":"    ``YYYY-MM-DD[HH:mm:ss]``. For example::"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        # Purge shadow table rows deleted before specified date"},{"line_number":355,"context_line":"        nova-manage db purge --before 2015-10-21"},{"line_number":356,"context_line":"        # or"},{"line_number":357,"context_line":"        nova-manage db purge --before \"Oct 21 2015\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"547f4c76_53f7e351","line":354,"updated":"2024-05-15 19:42:03.000000000","message":"This looks correct to me. During archive I don\u0027t see us overwriting `deleted_at` with utcnow().\n\n(And I think it\u0027s correct not to, since the point of the shadow tables is to be able to go back and audit things that happened in the cloud before permanently deleting them).\n\nThe `created_at` and `updated_at` fields are automatically set at row creation time [1] if they are not yet set. So those will also not reflect anything about time of the archive because they are also not overwritten at archive time.\n\n[1] https://github.com/openstack/oslo.db/blob/e502313ac677c92fd02a2b81975d7e6e1b8314ed/oslo_db/sqlalchemy/models.py#L124","commit_id":"7d8b027053f3f686018fac328157181466530262"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"02e5a81ec17a0b1fab2af604478dd3db579bca2c","unresolved":true,"context_lines":[{"line_number":351,"context_line":"    strings in the default format output by the ``date`` command, as well as"},{"line_number":352,"context_line":"    ``YYYY-MM-DD[HH:mm:ss]``. For example::"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        # Purge shadow table rows deleted before specified date"},{"line_number":355,"context_line":"        nova-manage db purge --before 2015-10-21"},{"line_number":356,"context_line":"        # or"},{"line_number":357,"context_line":"        nova-manage db purge --before \"Oct 21 2015\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0da7bb41_134ae1bf","line":354,"in_reply_to":"547f4c76_53f7e351","updated":"2024-05-21 10:03:11.000000000","message":"this part i think is likely an improvement.","commit_id":"7d8b027053f3f686018fac328157181466530262"}]}