)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aea7ebbc749525e1b15b122b27ee0b486ddcfd4b","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron does verify MAC being valid with netaddr.EUI, and dash-separated"},{"line_number":13,"context_line":"MAC does conform the standard."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"With that MAC is always stored in a lower case and semi-colon separated"},{"line_number":16,"context_line":"inside libvirt, which causes key error during live migrations."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"72a26e05_ab163889","line":14,"updated":"2024-05-21 10:11:55.000000000","message":"so i think the problem is that while neutron accpate it nova does not.\nto me this is a neuton api bug and they should be normalising the mac internally\nlike libvirt does","commit_id":"7cce26e5d081d13974f0b754eaaeff461434c5aa"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"fee5647afd7ff2d2d381af4603b2c7e12171d81f","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Neutron does verify MAC being valid with netaddr.EUI, and dash-separated"},{"line_number":13,"context_line":"MAC does conform the standard."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"With that MAC is always stored in a lower case and semi-colon separated"},{"line_number":16,"context_line":"inside libvirt, which causes key error during live migrations."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"51ac6360_57926c9a","line":14,"in_reply_to":"72a26e05_ab163889","updated":"2024-06-01 07:09:56.000000000","message":"I don\u0027t think it\u0027s a neutron problem at all.\n\nStandard for MAC address even somehow encourage using `-` as MAC address separator.\nAlso, I assume that issue can even be a driver-specific. As I don\u0027t think we normalize MAC when passing to libvirt on domxml creation - though it is changed on fetch of domain data. Can be missing smth there for sure.","commit_id":"7cce26e5d081d13974f0b754eaaeff461434c5aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aea7ebbc749525e1b15b122b27ee0b486ddcfd4b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"inside libvirt, which causes key error during live migrations."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This is a follow-up for [2] where upper/lower-case difference was"},{"line_number":19,"context_line":"handled."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://opendev.org/openstack/neutron-lib/src/commit/8b6c76978995fe3b669ddf0689ac358d12174de7/neutron_lib/objects/common_types.py#L273"},{"line_number":22,"context_line":"[2] https://review.opendev.org/q/Ie3129ee395427337e9abcef2f938012608f643e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"87fdade6_6488a68f","line":19,"updated":"2024-05-21 10:11:55.000000000","message":"right so nova should not need to do this\nit would be better to fix this in neutron so that it normalises the macs","commit_id":"7cce26e5d081d13974f0b754eaaeff461434c5aa"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"fee5647afd7ff2d2d381af4603b2c7e12171d81f","unresolved":true,"context_lines":[{"line_number":16,"context_line":"inside libvirt, which causes key error during live migrations."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This is a follow-up for [2] where upper/lower-case difference was"},{"line_number":19,"context_line":"handled."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://opendev.org/openstack/neutron-lib/src/commit/8b6c76978995fe3b669ddf0689ac358d12174de7/neutron_lib/objects/common_types.py#L273"},{"line_number":22,"context_line":"[2] https://review.opendev.org/q/Ie3129ee395427337e9abcef2f938012608f643e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8c745118_ea45a831","line":19,"in_reply_to":"87fdade6_6488a68f","updated":"2024-06-01 07:09:56.000000000","message":"This is very arguable kinda. as this can vary from driver to driver in nova, imo. I did not test other drivers for sure, but right now nova does not look to normalize mac passed to libvirt, right? But it still ends up as colon separated.\n\nWith that doing on a neutron side is also weird for me.","commit_id":"7cce26e5d081d13974f0b754eaaeff461434c5aa"}],"nova/tests/unit/virt/libvirt/test_migration.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aea7ebbc749525e1b15b122b27ee0b486ddcfd4b","unresolved":true,"context_lines":[{"line_number":1184,"context_line":"         \u003cuuid\u003e3de6550a-8596-4937-8046-9d862036bca5\u003c/uuid\u003e"},{"line_number":1185,"context_line":"         \u003cdevices\u003e"},{"line_number":1186,"context_line":"            \u003cinterface type\u003d\"bridge\"\u003e"},{"line_number":1187,"context_line":"                \u003cmac address\u003d\"DE-AD-BE-EF-CA-FE\"/\u003e"},{"line_number":1188,"context_line":"                \u003cmodel type\u003d\"virtio\"/\u003e"},{"line_number":1189,"context_line":"                \u003csource bridge\u003d\"qbra188171c-ea\"/\u003e"},{"line_number":1190,"context_line":"                \u003ctarget dev\u003d\"tapa188171c-ea\"/\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ca6cacd_49673f61","line":1187,"updated":"2024-05-21 10:11:55.000000000","message":"we should be generating the normalised xml\nif we are modifying nova we should not be relying on libvirt doing the normalisation","commit_id":"7cce26e5d081d13974f0b754eaaeff461434c5aa"}]}