)]}'
{"id":"openstack%2Fnova~919949","triplet_id":"openstack%2Fnova~master~I6bf1189c178085df010d9dad15f3e10fc534574c","project":"openstack/nova","branch":"master","topic":"disabled-cpu-features-enable-traits","attention_set":{},"removed_from_attention_set":{"6962":{"account":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"last_update":"2024-12-02 19:46:15.000000000","reason":"Change was abandoned"},"28621":{"account":{"_account_id":28621,"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","username":"mfo"},"last_update":"2024-12-02 19:46:15.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I6bf1189c178085df010d9dad15f3e10fc534574c","subject":"libvirt: Filter out disabled guest CPU features in _get_cpu_feature_traits()","status":"ABANDONED","created":"2024-05-17 13:13:29.000000000","updated":"2024-12-02 19:46:15.000000000","total_comment_count":3,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"b58dd8438e42aab9a6f0b16e11ae8478382b25c4","_number":919949,"virtual_id_number":919949,"owner":{"_account_id":28621,"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","username":"mfo"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2024-05-17 15:25:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":-1,"date":"2024-05-17 14:09:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-17 13:18:31.000000000","updated_by":{"_account_id":28621,"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","username":"mfo"},"reviewer":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"state":"REVIEWER"},{"updated":"2024-05-17 13:27:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-05-17 13:27:29.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-05-17 14:09:35.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2024-05-17 15:25:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3cdad917c54d7a687aeaccb7954dda9d5393302f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28621,"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","username":"mfo"},"date":"2024-05-17 13:13:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43e2c6546bd9c68d354a2742edfc582f38b869eb","author":{"_account_id":28621,"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","username":"mfo"},"date":"2024-05-17 13:18:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bf8fd847a094dfd727ec30192f94f0851ad1d019","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-17 13:27:22.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1d34184c93d249da90d2b133ae28e539\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/44802b4863a74712afe9e4310a31cd9b : SUCCESS in 13m 03s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/b2b87176b6e347369bad15d59a58ed68 : SUCCESS in 10m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d3adc781aec36f6c44acee1ec2e688ebc43e86ec","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-05-17 13:27:29.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-919949-8zrxn/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"626ac64c046cd0837c20b239d88b2652dfa7edad","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-05-17 14:09:35.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2bacd4214fb5864754fe01706ebf93572543d140","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-05-17 15:25:25.000000000","message":"Patch Set 1: Verified-1\n\n(4 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/3ba4005e53ed4336a10f3b2c2f356a81\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/35e5f6b2105f4710b43d397e0235167e : POST_FAILURE in 1h 13m 30s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/d677eb98303840c5a97a271eb1142f0a : SUCCESS in 1h 59m 12s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/6babcf1a245e4fb19907a1e67f6efadb : SUCCESS in 1h 05m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a43c21f19d154f8fad5856b83348d29a : SUCCESS in 21m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/357d16deecee407abfedabba17e874e9 : FAILURE in 8m 01s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ccf15de252d74a708e15d47fe7097aa8 : SUCCESS in 12m 55s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/4aa615becf65486786ecd2b16d93fcd4 : SUCCESS in 14m 21s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/1ff4c02b14a14259ae5112b50ba8768d : SUCCESS in 18m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/08dde5c209304d93ae629dc87d2d9e69 : SUCCESS in 12m 55s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/deef654e15da462ba37c06318d3e8695 : SUCCESS in 54m 45s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/334fcae12bfd4c2d9796cb4e9e54e136 : SUCCESS in 1h 42m 24s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7fd7536138f848c1b19f950de65ba42a : SUCCESS in 41m 45s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/06b9f772b78a44b986943e8014c27613 : SUCCESS in 51m 49s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/27e6045cce9e436385916380cf011d01 : FAILURE in 52m 29s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/78178e90d13643cda01394d890a65f86 : SUCCESS in 1h 31m 42s\n- nova-next https://zuul.opendev.org/t/openstack/build/6fcfa6350ecf4e7389c69e0576e75ef3 : FAILURE in 1h 45m 32s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/fe475b4248b14a0c98b96e2378c87cb5 : SUCCESS in 36m 08s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/4bac5d19a95d4eaea1f14e7a9909035f : SUCCESS in 5m 02s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/01421f6b2ff144b3909a6c2ea7e91c2a : SUCCESS in 19m 11s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/14811c10909844c08358cf51af2ae847 : SUCCESS in 19m 15s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/3418c76116cd4fd084a5b442292eab4f : SUCCESS in 15m 43s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/2db67bde8bb24ca48da4e63e2502ff5d : TIMED_OUT in 2h 05m 09s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/16b4df59e867424283c40cf2241f1c0c : SUCCESS in 1h 41m 14s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/aff0727e789a4456b04a39fda8b631dc : SUCCESS in 1h 02m 40s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/bded1c37cf384717be2f69acf2b9d342 : SUCCESS in 1h 05m 16s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/68d93650ba3d446d83de3ec5e4ec23ac : SUCCESS in 31m 44s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/d9b0b00e538a40d7a539faf289910297 : SUCCESS in 38m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b58dd8438e42aab9a6f0b16e11ae8478382b25c4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":28621,"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","username":"mfo"},"date":"2024-12-02 19:46:15.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e9dfbedeac842c9c543f75126902534131dbeb3","revisions":{"3e9dfbedeac842c9c543f75126902534131dbeb3":{"kind":"REWORK","_number":1,"created":"2024-05-17 13:13:29.000000000","uploader":{"_account_id":28621,"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","username":"mfo"},"ref":"refs/changes/49/919949/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/49/919949/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/919949/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/919949/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/919949/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/49/919949/1"}}},"commit":{"parents":[{"commit":"ab3ca1e2059f951b44d723c15a5065c6532540da","subject":"Merge \"Make python 3.12 unit and functional voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ab3ca1e2059f951b44d723c15a5065c6532540da"}]}],"author":{"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","date":"2024-05-17 13:09:09.000000000","tz":-180},"committer":{"name":"Mauricio Faria de Oliveira","email":"mfo@canonical.com","date":"2024-05-17 13:10:45.000000000","tz":-180},"subject":"libvirt: Filter out disabled guest CPU features in _get_cpu_feature_traits()","message":"libvirt: Filter out disabled guest CPU features in _get_cpu_feature_traits()\n\nCurrently, `_get_cpu_feature_traits()` considers all `cpu.features`\nas enabled, but some may be disabled in `cpu_model_extra_flags` [1].\n\nThis seems like false-positive traits (enabled w/ feature disabled).\n\nSo, filter out disabled features, like LibvirtConfigCPU.parse_dom().\n\nP.S.: the `caps.host.cpu.features` are already filtered out, since\n`Host.get_capabilities()` calls `LibvirtConfigObject.parse_str()`,\nwhich calls `LibvirtConfigCPU.parse_dom()` mentioned above.\n\nTests:\n-----\n\n`test_cpu_traits_with_mode_{passthrough,custom,not_set}_and_extra_flags`\nreproduce the problem with a disabled feature (e.g., add \u0027-AVX\u0027 to list):\n\t```\n\t{0} ...test_cpu_traits_with_mode_not_set_and_extra_flags ... FAILED\n\t...\n\tExpected: cpu_features_to_traits(ItemsMatcher([\u0027pcid\u0027, \u0027erms\u0027]))\n\tActual: cpu_features_to_traits({\u0027erms\u0027, \u0027pcid\u0027, \u0027avx\u0027})\n\n\t{2} ...test_cpu_traits_with_mode_custom_and_extra_flags ... FAILED\n\t...\n\tExpected: cpu_features_to_traits(ItemsMatcher([\u0027pcid\u0027, \u0027erms\u0027]))\n\tActual: cpu_features_to_traits({\u0027pcid\u0027, \u0027erms\u0027, \u0027avx\u0027})\n\n\t{1} ...test_cpu_traits_with_mode_passthrough_and_extra_flags ... FAILED\n\t...\n\tExpected: cpu_features_to_traits(ItemsMatcher([\u0027pcid\u0027, \u0027erms\u0027]))\n\tActual: cpu_features_to_traits({\u0027erms\u0027, \u0027pcid\u0027, \u0027avx\u0027})\n\t```\n\nThe 1st `if` fixes `passthrough` and `not_set`; the 2nd `if` fixes `custom`:\n\t```\n\t{0} ...test_cpu_traits_with_mode_custom_and_extra_flags ... ok\n\t{1} ...test_cpu_traits_with_mode_passthrough_and_extra_flags ... ok\n\t{2} ...test_cpu_traits_with_mode_not_set_and_extra_flags ... ok\n\t```\n\nAll unit tests with tox:\n\t```\n\t - Passed: 2941\n\t - Skipped: 2\n\t - Expected Fail: 3\n\t - Unexpected Success: 0\n\t - Failed: 0\n\t```\n\n[1] https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.cpu_model_extra_flags\n\nSigned-off-by: Mauricio Faria de Oliveira \u003cmfo@canonical.com\u003e\nChange-Id: I6bf1189c178085df010d9dad15f3e10fc534574c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e9dfbedeac842c9c543f75126902534131dbeb3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e9dfbedeac842c9c543f75126902534131dbeb3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}