)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"651d57db1da50282946bf48eb8d7b17ee23137bb","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Port dns_names are cleared when instances are shelved in order to fix"},{"line_number":10,"context_line":"https://bugs.launchpad.net/nova/+bug/1572593. This has the unwanted"},{"line_number":11,"context_line":"side-effect of not restoring the dns_name when an instance is"},{"line_number":12,"context_line":"unshelved."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch uses the same procedure as other code paths to restore a"},{"line_number":15,"context_line":"dns_name matching the instance hostname for internal DNS integration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f16c0149_b68c0925","line":12,"updated":"2024-05-21 08:38:35.000000000","message":"so thats an incorrect fix to the orginal bug.\n\nvms that are shelved still have the interfacces attahced and we should not be clearing the dns_name when we shelve.","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"973fcaa8bd3c7e88d057c9edd20b337a88b9c412","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Port dns_names are cleared when instances are shelved in order to fix"},{"line_number":10,"context_line":"https://bugs.launchpad.net/nova/+bug/1572593. This has the unwanted"},{"line_number":11,"context_line":"side-effect of not restoring the dns_name when an instance is"},{"line_number":12,"context_line":"unshelved."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch uses the same procedure as other code paths to restore a"},{"line_number":15,"context_line":"dns_name matching the instance hostname for internal DNS integration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f18ad22_2be7dc09","line":12,"in_reply_to":"f16c0149_b68c0925","updated":"2025-03-11 13:56:39.000000000","message":"Done","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"8f69a5e2cb3090d79b84f80efb2da5a524675412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f50f3663_df20f597","updated":"2024-05-21 07:51:03.000000000","message":"Feedback welcome. As noted in the commit message this doesn\u0027t cover external DNS integration yet as I\u0027m not aware if it\u0027s possible to obtain a user context for this operation.","commit_id":"77a984acae2178c640c42b0ead8ed53a5822d49f"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"f3b5abc605db0943f0b2c6dad80b5c316cace736","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f5799d5_eb36417c","updated":"2024-05-21 08:46:17.000000000","message":"Thanks Sean. I\u0027ll try revising based upon that feedback.","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6eba860a5554bba8822d76ef5f036749e14aec79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a7255d50_6702ad87","updated":"2024-05-21 09:22:19.000000000","message":"+1 for now lets see what ci thinks.","commit_id":"f8ef77929314b5aa2a400549c9fa48da7cb38a9c"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"f7d001f0e1c970930e30e469906b925f245bca1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"052bdff5_6c6b7258","updated":"2024-12-17 15:36:14.000000000","message":"@smooney@redhat.com would you mind taking another look at this if you have time? It would be nice to get it merged.","commit_id":"5f2cddd42805376ea3af7bac09ca25814c9d57e3"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"2432c9f724fe9262a62b30c7085d4fb540dabf11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa969018_bfd2755b","updated":"2024-10-04 06:50:01.000000000","message":"recheck - multi-cell cinder issue","commit_id":"5f2cddd42805376ea3af7bac09ca25814c9d57e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80e7629dccfc4e3979f9287061c4c0cef7d2512b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"68cb658a_b9c091a0","updated":"2025-03-11 11:50:26.000000000","message":"still +1 on the general direction i think this need a little more test coverage however","commit_id":"5f2cddd42805376ea3af7bac09ca25814c9d57e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2afb57b1b028750d447a266215b573cf2cf6f1bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9d7f3501_eaef79d7","updated":"2025-07-30 14:28:08.000000000","message":"Looks good.","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"0bb6270848184d73c9df81403229643369fa1863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"efa3e813_1614d6fd","updated":"2025-03-11 15:58:46.000000000","message":"recheck - nova-next issue \u0027Unable to connect to port 22 on 172.24.5.216\u0027","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef34aa7a6dfc7f91f28183121b797b480da2bd53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bf0eaac4_f03bc553","updated":"2025-03-12 12:16:24.000000000","message":"thanks the changes i requested before have been made\n\nthis looks good to me over all.\nas noted on irc if you need to respin this for other feedback adding a fixes release note could be a good improvement but i think we can proceed with this as is.","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cb94d313a3af819a7e99ff40669a46185a38b820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"07b7a4d1_3602e3d4","updated":"2025-07-30 19:05:26.000000000","message":"Thanks for adding the missing assert","commit_id":"593ac130b6182dc59439e1af6b5f1d4732b430e1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0480df6127e0541bbc77d27ba1ec7a98317dd787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5059e204_a8787837","updated":"2025-07-30 18:21:52.000000000","message":"recheck Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000","commit_id":"593ac130b6182dc59439e1af6b5f1d4732b430e1"}],"nova/network/neutron.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"651d57db1da50282946bf48eb8d7b17ee23137bb","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        neutron \u003d get_client(context)"},{"line_number":626,"context_line":"        self._unbind_ports(context, ports, neutron, detach\u003ddetach)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def _unbind_ports(self, context, ports,"},{"line_number":629,"context_line":"                      neutron, port_client\u003dNone, detach\u003dTrue):"},{"line_number":630,"context_line":"        \"\"\"Unbind and detach the given ports by clearing their"},{"line_number":631,"context_line":"        device_owner and dns_name."}],"source_content_type":"text/x-python","patch_set":3,"id":"2bf9f6f3_0a24c3c3","line":628,"updated":"2024-05-21 08:38:35.000000000","message":"i have discuss this in other reviews this is both unbinding adnd detaching depending on how its called","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80e7629dccfc4e3979f9287061c4c0cef7d2512b","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        neutron \u003d get_client(context)"},{"line_number":626,"context_line":"        self._unbind_ports(context, ports, neutron, detach\u003ddetach)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def _unbind_ports(self, context, ports,"},{"line_number":629,"context_line":"                      neutron, port_client\u003dNone, detach\u003dTrue):"},{"line_number":630,"context_line":"        \"\"\"Unbind and detach the given ports by clearing their"},{"line_number":631,"context_line":"        device_owner and dns_name."}],"source_content_type":"text/x-python","patch_set":3,"id":"f5972e6a_77348d06","line":628,"in_reply_to":"2bf9f6f3_0a24c3c3","updated":"2025-03-11 11:50:26.000000000","message":"Acknowledged","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"651d57db1da50282946bf48eb8d7b17ee23137bb","unresolved":true,"context_lines":[{"line_number":703,"context_line":"                if profile_key in port_profile:"},{"line_number":704,"context_line":"                    del port_profile[profile_key]"},{"line_number":705,"context_line":"            port_req_body[\u0027port\u0027][constants.BINDING_PROFILE] \u003d port_profile"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            # NOTE: For internal DNS integration (network does not have a"},{"line_number":708,"context_line":"            # dns_domain), or if we cannot retrieve network info, we use the"},{"line_number":709,"context_line":"            # admin client to reset dns_name."}],"source_content_type":"text/x-python","patch_set":3,"id":"0f79c116_0f2af0df","line":706,"updated":"2024-05-21 08:38:35.000000000","message":"the fix is to wrap everything after this in an if","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80e7629dccfc4e3979f9287061c4c0cef7d2512b","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                if profile_key in port_profile:"},{"line_number":704,"context_line":"                    del port_profile[profile_key]"},{"line_number":705,"context_line":"            port_req_body[\u0027port\u0027][constants.BINDING_PROFILE] \u003d port_profile"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            # NOTE: For internal DNS integration (network does not have a"},{"line_number":708,"context_line":"            # dns_domain), or if we cannot retrieve network info, we use the"},{"line_number":709,"context_line":"            # admin client to reset dns_name."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa837d5f_b45e6a0c","line":706,"in_reply_to":"0f79c116_0f2af0df","updated":"2025-03-11 11:50:26.000000000","message":"Acknowledged","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"651d57db1da50282946bf48eb8d7b17ee23137bb","unresolved":true,"context_lines":[{"line_number":724,"context_line":"            # NOTE: For external DNS integration, we use the neutron client"},{"line_number":725,"context_line":"            # with user\u0027s context to reset the dns_name since the recordset is"},{"line_number":726,"context_line":"            # under user\u0027s zone."},{"line_number":727,"context_line":"            self._reset_port_dns_name(network, port_id, neutron)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    def _validate_requested_port_ids(self, context, instance, neutron,"},{"line_number":730,"context_line":"                                     requested_networks):"}],"source_content_type":"text/x-python","patch_set":3,"id":"141f45d5_be318b2d","line":727,"updated":"2024-05-21 08:38:35.000000000","message":"this should only be called if detach\u003d\u003dtrue.\nthis is the cause of the bug for shelve.","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6eba860a5554bba8822d76ef5f036749e14aec79","unresolved":false,"context_lines":[{"line_number":724,"context_line":"            # NOTE: For external DNS integration, we use the neutron client"},{"line_number":725,"context_line":"            # with user\u0027s context to reset the dns_name since the recordset is"},{"line_number":726,"context_line":"            # under user\u0027s zone."},{"line_number":727,"context_line":"            self._reset_port_dns_name(network, port_id, neutron)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    def _validate_requested_port_ids(self, context, instance, neutron,"},{"line_number":730,"context_line":"                                     requested_networks):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c2284a77_ef1b61d7","line":727,"in_reply_to":"141f45d5_be318b2d","updated":"2024-05-21 09:22:19.000000000","message":"Done","commit_id":"bf40d994628298c4aacdec91b768848334d7914b"}],"nova/tests/unit/network/test_neutron.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80e7629dccfc4e3979f9287061c4c0cef7d2512b","unresolved":true,"context_lines":[{"line_number":6241,"context_line":"                                  \u0027binding:profile\u0027: {}}}"},{"line_number":6242,"context_line":"        port_client.update_port.assert_called_once_with("},{"line_number":6243,"context_line":"            uuids.port_id, port_req_body)"},{"line_number":6244,"context_line":"        neutron.update_port.assert_not_called()"},{"line_number":6245,"context_line":""},{"line_number":6246,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"},{"line_number":6247,"context_line":"                new\u003dmock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"83ca4e4a_8da342ae","line":6244,"range":{"start_line":6244,"start_character":0,"end_line":6244,"end_character":2},"updated":"2025-03-11 11:50:26.000000000","message":"a more direct test would be to assert \n\n_reset_port_dns_name is not called.\n\nti would also be good to have a functional test to assert when we shelve it keeps the dns name.\n\nthat not strictly required but it would be nice to have more testing then just this unit test in its current form","commit_id":"5f2cddd42805376ea3af7bac09ca25814c9d57e3"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"973fcaa8bd3c7e88d057c9edd20b337a88b9c412","unresolved":false,"context_lines":[{"line_number":6241,"context_line":"                                  \u0027binding:profile\u0027: {}}}"},{"line_number":6242,"context_line":"        port_client.update_port.assert_called_once_with("},{"line_number":6243,"context_line":"            uuids.port_id, port_req_body)"},{"line_number":6244,"context_line":"        neutron.update_port.assert_not_called()"},{"line_number":6245,"context_line":""},{"line_number":6246,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"},{"line_number":6247,"context_line":"                new\u003dmock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"961ff85b_75b58a31","line":6244,"range":{"start_line":6244,"start_character":0,"end_line":6244,"end_character":2},"in_reply_to":"83ca4e4a_8da342ae","updated":"2025-03-11 13:56:39.000000000","message":"Acknowledged","commit_id":"5f2cddd42805376ea3af7bac09ca25814c9d57e3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5e31dee5a8b61f2dda10a7820f92edbc42451a1a","unresolved":true,"context_lines":[{"line_number":6245,"context_line":"                                  \u0027binding:profile\u0027: {}}}"},{"line_number":6246,"context_line":"        port_client.update_port.assert_called_once_with("},{"line_number":6247,"context_line":"            uuids.port_id, port_req_body)"},{"line_number":6248,"context_line":"        mock_reset_dns.assert_not_called()"},{"line_number":6249,"context_line":""},{"line_number":6250,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"},{"line_number":6251,"context_line":"                new\u003dmock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"9635fa87_5367a43b","line":6248,"updated":"2025-07-30 14:29:12.000000000","message":"I don\u0027t see in any of the tests around here assertion of the positive (i.e. existing) case. Am I missing it?","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"380bd563da507a9fd4c011871e2851a4ae8eb17f","unresolved":false,"context_lines":[{"line_number":6245,"context_line":"                                  \u0027binding:profile\u0027: {}}}"},{"line_number":6246,"context_line":"        port_client.update_port.assert_called_once_with("},{"line_number":6247,"context_line":"            uuids.port_id, port_req_body)"},{"line_number":6248,"context_line":"        mock_reset_dns.assert_not_called()"},{"line_number":6249,"context_line":""},{"line_number":6250,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"},{"line_number":6251,"context_line":"                new\u003dmock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":6,"id":"309fa3ae_b1a4c234","line":6248,"in_reply_to":"9635fa87_5367a43b","updated":"2025-07-30 15:55:09.000000000","message":"Done","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1d63062024a9379125bac510e3dda78eb20d19fe","unresolved":true,"context_lines":[{"line_number":6267,"context_line":"                                  \u0027device_id\u0027: \u0027\u0027,"},{"line_number":6268,"context_line":"                                  \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":6269,"context_line":"                                  \u0027dns_name\u0027: \u0027\u0027}}"},{"line_number":6270,"context_line":"        port_client.update_port.assert_called_once_with("},{"line_number":6271,"context_line":"            uuids.port_id, port_req_body)"},{"line_number":6272,"context_line":"        neutron.update_port.assert_not_called()"},{"line_number":6273,"context_line":""},{"line_number":6274,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bd6ab3e6_e94641df","line":6271,"range":{"start_line":6270,"start_character":7,"end_line":6271,"end_character":41},"updated":"2025-07-30 15:22:49.000000000","message":"does this not cover the other case?","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58b789598a8136a6e03355f8c0975cdd5483676c","unresolved":false,"context_lines":[{"line_number":6267,"context_line":"                                  \u0027device_id\u0027: \u0027\u0027,"},{"line_number":6268,"context_line":"                                  \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":6269,"context_line":"                                  \u0027dns_name\u0027: \u0027\u0027}}"},{"line_number":6270,"context_line":"        port_client.update_port.assert_called_once_with("},{"line_number":6271,"context_line":"            uuids.port_id, port_req_body)"},{"line_number":6272,"context_line":"        neutron.update_port.assert_not_called()"},{"line_number":6273,"context_line":""},{"line_number":6274,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"53b0b038_219a29af","line":6271,"range":{"start_line":6270,"start_character":7,"end_line":6271,"end_character":41},"in_reply_to":"5fc4553d_b5af28ea","updated":"2025-07-30 15:55:49.000000000","message":"Acknowledged","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"34d9f60c15ca33d659370aaafb1bbc1466542523","unresolved":true,"context_lines":[{"line_number":6267,"context_line":"                                  \u0027device_id\u0027: \u0027\u0027,"},{"line_number":6268,"context_line":"                                  \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":6269,"context_line":"                                  \u0027dns_name\u0027: \u0027\u0027}}"},{"line_number":6270,"context_line":"        port_client.update_port.assert_called_once_with("},{"line_number":6271,"context_line":"            uuids.port_id, port_req_body)"},{"line_number":6272,"context_line":"        neutron.update_port.assert_not_called()"},{"line_number":6273,"context_line":""},{"line_number":6274,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc4553d_b5af28ea","line":6271,"range":{"start_line":6270,"start_character":7,"end_line":6271,"end_character":41},"in_reply_to":"bd6ab3e6_e94641df","updated":"2025-07-30 15:27:49.000000000","message":"No, this is the same assertion as the  new test above. The `assert_not_called()` on `mock_reset_dns` is the thing above that I don\u0027t see asserted anywhere else (either that a mock was called or that some side effect of the real thing being called happened).","commit_id":"31a42cf1cf726d96cbd3ef75c4d89b6f3e4315c5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58b789598a8136a6e03355f8c0975cdd5483676c","unresolved":true,"context_lines":[{"line_number":6274,"context_line":"        neutron.update_port.assert_not_called()"},{"line_number":6275,"context_line":"        mock_reset_dns.assert_called_once_with("},{"line_number":6276,"context_line":"            neutron.show_network.return_value[\u0027network\u0027],"},{"line_number":6277,"context_line":"            uuids.port_id, neutron)"},{"line_number":6278,"context_line":""},{"line_number":6279,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"},{"line_number":6280,"context_line":"                new\u003dmock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9c01da5c_151a38bc","line":6277,"updated":"2025-07-30 15:55:49.000000000","message":"+1\n\ni was contemplationg pushing a follwo up but assuemign this passes i think we are good to proceed with this.","commit_id":"593ac130b6182dc59439e1af6b5f1d4732b430e1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"380bd563da507a9fd4c011871e2851a4ae8eb17f","unresolved":true,"context_lines":[{"line_number":6274,"context_line":"        neutron.update_port.assert_not_called()"},{"line_number":6275,"context_line":"        mock_reset_dns.assert_called_once_with("},{"line_number":6276,"context_line":"            neutron.show_network.return_value[\u0027network\u0027],"},{"line_number":6277,"context_line":"            uuids.port_id, neutron)"},{"line_number":6278,"context_line":""},{"line_number":6279,"context_line":"    @mock.patch(\u0027nova.network.neutron.API.has_dns_extension\u0027,"},{"line_number":6280,"context_line":"                new\u003dmock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":7,"id":"30cb2647_a11dbd5b","line":6277,"updated":"2025-07-30 15:55:09.000000000","message":"This is the assertion I think we need. Note that it should also be added below in the non-admin case, but the mocking seems to cause the test to fail, which is somewhat concerning. I have to run to a meeting and ran out of time to figure out why.","commit_id":"593ac130b6182dc59439e1af6b5f1d4732b430e1"}]}