)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"981a99bc0311925f8834df9877532934241a44b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e13fe0e2_77947bee","updated":"2024-06-11 15:32:22.000000000","message":"recheck","commit_id":"7ea38d717a60e3a5c35dda02d79b7acaaf6b31a5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b057ea7d1169b19c4d5c8963e7f5244a71a0acc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"01115b8a_03c9f85f","updated":"2024-06-12 16:59:13.000000000","message":"some minor nits but i think this is mostly ok","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b0f824f5d84c63e70295e29d55badf55617bcf2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6841aec2_ab954510","updated":"2024-06-13 13:41:21.000000000","message":"Thanks Sean I have resolved all your requests feel free to reopen if I have missed something :-)","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"02d232e21d723b7c06d8a21a718bce40aefea115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3185ec21_b1258485","updated":"2024-06-13 13:48:40.000000000","message":"i think im ok with this as is thanks for updating it.","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0d82dbb6d5d5edafd8ab78b42a16f64a2308ee97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7f841604_bc2f9e8b","updated":"2024-06-13 17:20:30.000000000","message":"recheck grenade timeout","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"84e9f968ca0fb45a4f4087d107da5e5e8c812894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eb02b4e2_5e87f0d8","updated":"2024-06-14 13:09:55.000000000","message":"recheck timeout","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f920da3e84f987b5d242a6bd60fc8e275c9f95f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0406ec94_cfac37b9","updated":"2024-06-18 11:12:01.000000000","message":"still happy with this over all but i want to see what gibi thinks of building a set and returnign the result to adress there issue.\n\ni dont think its likely to happen and proably a bug in nova/neutorn or whatever created that toplgy in placement but placement would allow it.","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9316bd96841309774b156b9adbac9f6679f429e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7f4017ff_109b5b3f","in_reply_to":"0406ec94_cfac37b9","updated":"2024-06-18 12:49:58.000000000","message":"If this happens that does not look like a fix to be in placement?","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cce52f816bd9bea9063ff7820074b8fd941bd84a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"82883538_176d0f6c","in_reply_to":"0406ec94_cfac37b9","updated":"2024-06-19 09:39:25.000000000","message":"If this happens that does not look like a fix to be in placement?","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0a8116ee434574d9157ff9ea84ba14e5f57acd06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8a46f44f_d949a571","updated":"2024-07-02 09:25:13.000000000","message":"recheck","commit_id":"953855b29efa7b602b5bd628bd012e8a08d70813"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6a1d785e2ad0079efd9a637e1f2384e7e95db388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ba06de86_989d74f0","updated":"2024-07-03 10:35:52.000000000","message":"recheck","commit_id":"953855b29efa7b602b5bd628bd012e8a08d70813"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e866d9990321ee20d1bb124aed8d77e31e5a0303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"05b45e29_cc2502fa","updated":"2024-06-21 15:19:43.000000000","message":"recheck POST_FAILURE","commit_id":"953855b29efa7b602b5bd628bd012e8a08d70813"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b21eb0aa4cb7a09ebaee231ba1c0c167223dbec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fa01af2c_b72968e8","updated":"2024-06-22 11:29:25.000000000","message":"recheck tempest timeout","commit_id":"953855b29efa7b602b5bd628bd012e8a08d70813"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5da6de0e3dfb6be504f811aae647ae3466532f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e3efa17f_4ff2becd","updated":"2024-06-21 08:29:45.000000000","message":"recheck tempest-integrated-compute-enforce-scope-new-defaults time out","commit_id":"953855b29efa7b602b5bd628bd012e8a08d70813"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e7528f7893900eb670005d6c71435c9f9fe56bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b13f755d_a87acbfb","updated":"2024-06-20 10:30:25.000000000","message":"recheck timeout","commit_id":"953855b29efa7b602b5bd628bd012e8a08d70813"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38684281dde1b1d3841387006d72e57439928924","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"25cf18de_5e212783","updated":"2024-06-24 08:00:04.000000000","message":"thanks. Looks good.","commit_id":"953855b29efa7b602b5bd628bd012e8a08d70813"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4720a190e14440d16f375343cf54e987f792a208","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"decfb97c_3e60f467","updated":"2024-07-04 09:59:21.000000000","message":"recheck multi-cells","commit_id":"f254729a565222be00cf2fe1edc44e6cf10bfae6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6e16a800c8104318c7810ad0ee40db5ab3039a06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"afc54f92_0c941786","updated":"2024-07-06 19:36:38.000000000","message":"recheck multi-store ceph","commit_id":"f254729a565222be00cf2fe1edc44e6cf10bfae6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"063ab58b8565ba13c4312d8ad355b2a3eefea92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3e8762c7_54f3fb61","updated":"2024-07-03 21:29:17.000000000","message":"recheck timeout","commit_id":"f254729a565222be00cf2fe1edc44e6cf10bfae6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"95aa99e83645bb613847c0fad2d2160d9ac6b258","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fdc0608d_48d74fa5","updated":"2024-07-05 06:26:31.000000000","message":"recheck unrelated","commit_id":"f254729a565222be00cf2fe1edc44e6cf10bfae6"}],"nova/conf/compute.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b057ea7d1169b19c4d5c8963e7f5244a71a0acc2","unresolved":true,"context_lines":[{"line_number":790,"context_line":""},{"line_number":791,"context_line":"In deployments with a large number of aggregates, a \u0027Request-Too-Long\u0027 error"},{"line_number":792,"context_line":"may be raised by the web server or load balancer."},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"Possible values:"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"* Any positive integer."}],"source_content_type":"text/x-python","patch_set":7,"id":"974b620c_c61bb94e","line":793,"updated":"2024-06-12 16:59:13.000000000","message":"nit: In deployments with a large number of aggregates, a \u0027Request-Too-Long\u0027 error\nmay be raised by the web server or load balancer. This value allows setting the batch size to limit the query length.","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b0f824f5d84c63e70295e29d55badf55617bcf2f","unresolved":false,"context_lines":[{"line_number":790,"context_line":""},{"line_number":791,"context_line":"In deployments with a large number of aggregates, a \u0027Request-Too-Long\u0027 error"},{"line_number":792,"context_line":"may be raised by the web server or load balancer."},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"Possible values:"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"* Any positive integer."}],"source_content_type":"text/x-python","patch_set":7,"id":"98b8c43b_e8ceec67","line":793,"in_reply_to":"974b620c_c61bb94e","updated":"2024-06-13 13:41:21.000000000","message":"Done","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a751ab7dc5ac65f5c34451645c603d785b78a7dc","unresolved":true,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        resource_providers \u003d []"},{"line_number":502,"context_line":"        for i in range(0, len(agg_uuids), MAX_INQUERY_SIZE):"},{"line_number":503,"context_line":"            aggs \u003d \u0027,\u0027.join(agg_uuids[i:i + MAX_INQUERY_SIZE])"},{"line_number":504,"context_line":"            url \u003d \"/resource_providers?member_of\u003din:%s\u0026required\u003d%s\" % ("},{"line_number":505,"context_line":"                aggs, os_traits.MISC_SHARES_VIA_AGGREGATE)"},{"line_number":506,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbfdcb45_56077561","line":503,"updated":"2024-06-10 13:59:44.000000000","message":"This changes the meaning of the query.\nBefore the PRs returned needed to be in *all* the aggregates. Now it is enough to be in a subset of the aggregates.","commit_id":"32329f153f490e5ee3b6060b90019fdb42099bd8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f425e6e3b4b2d39f7d5daa944b64676a0c7e1087","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        resource_providers \u003d []"},{"line_number":502,"context_line":"        for i in range(0, len(agg_uuids), MAX_INQUERY_SIZE):"},{"line_number":503,"context_line":"            aggs \u003d \u0027,\u0027.join(agg_uuids[i:i + MAX_INQUERY_SIZE])"},{"line_number":504,"context_line":"            url \u003d \"/resource_providers?member_of\u003din:%s\u0026required\u003d%s\" % ("},{"line_number":505,"context_line":"                aggs, os_traits.MISC_SHARES_VIA_AGGREGATE)"},{"line_number":506,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a49cdf6a_b134a5a7","line":503,"in_reply_to":"5540cf8a_f47e52dd","updated":"2024-06-11 08:10:25.000000000","message":"Done","commit_id":"32329f153f490e5ee3b6060b90019fdb42099bd8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e1a4e89b797c5270d90c4aace7c487db78d2279e","unresolved":true,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        resource_providers \u003d []"},{"line_number":502,"context_line":"        for i in range(0, len(agg_uuids), MAX_INQUERY_SIZE):"},{"line_number":503,"context_line":"            aggs \u003d \u0027,\u0027.join(agg_uuids[i:i + MAX_INQUERY_SIZE])"},{"line_number":504,"context_line":"            url \u003d \"/resource_providers?member_of\u003din:%s\u0026required\u003d%s\" % ("},{"line_number":505,"context_line":"                aggs, os_traits.MISC_SHARES_VIA_AGGREGATE)"},{"line_number":506,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5540cf8a_f47e52dd","line":503,"in_reply_to":"6f2d3b19_196edbd5","updated":"2024-06-11 08:10:15.000000000","message":"sure no worries :-)","commit_id":"32329f153f490e5ee3b6060b90019fdb42099bd8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2def35cea62aca7c80fb5f237dadcdf1f360103a","unresolved":true,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        resource_providers \u003d []"},{"line_number":502,"context_line":"        for i in range(0, len(agg_uuids), MAX_INQUERY_SIZE):"},{"line_number":503,"context_line":"            aggs \u003d \u0027,\u0027.join(agg_uuids[i:i + MAX_INQUERY_SIZE])"},{"line_number":504,"context_line":"            url \u003d \"/resource_providers?member_of\u003din:%s\u0026required\u003d%s\" % ("},{"line_number":505,"context_line":"                aggs, os_traits.MISC_SHARES_VIA_AGGREGATE)"},{"line_number":506,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f2d3b19_196edbd5","line":503,"in_reply_to":"dbfdcb45_56077561","updated":"2024-06-10 14:28:58.000000000","message":"Sorry. I was wrong. I thought member_of\u003din: as AND but it is OR. So this change just split up the query and combine the result of an OR query. That is correct and does not change the meaning of the funcion.","commit_id":"32329f153f490e5ee3b6060b90019fdb42099bd8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"80339918e2e44d6285e78601359e8d4baa9caff2","unresolved":true,"context_lines":[{"line_number":508,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"},{"line_number":509,"context_line":"                            global_request_id\u003dcontext.global_id)"},{"line_number":510,"context_line":"            if resp.status_code \u003d\u003d 200:"},{"line_number":511,"context_line":"                resource_providers +\u003d resp.json()[\u0027resource_providers\u0027]"},{"line_number":512,"context_line":"            else:"},{"line_number":513,"context_line":"                msg \u003d _(\"[%(placement_req_id)s] %(iquery)s/%(isize)s Failed \""},{"line_number":514,"context_line":"                        \"to retrieve sharing resource providers associated \""}],"source_content_type":"text/x-python","patch_set":8,"id":"fee4a7a4_3b9f4d6c","line":511,"updated":"2024-06-18 08:42:44.000000000","message":"I think this can generate duplicate resource_providers in the list. E.g. if a RP is in two aggregates and therefore returned from two of these queries. I suggest to make the list unique by RP uuid before return it.","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"20482452a272cbcc52ba223496f97313b4c8faa2","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"},{"line_number":509,"context_line":"                            global_request_id\u003dcontext.global_id)"},{"line_number":510,"context_line":"            if resp.status_code \u003d\u003d 200:"},{"line_number":511,"context_line":"                resource_providers +\u003d resp.json()[\u0027resource_providers\u0027]"},{"line_number":512,"context_line":"            else:"},{"line_number":513,"context_line":"                msg \u003d _(\"[%(placement_req_id)s] %(iquery)s/%(isize)s Failed \""},{"line_number":514,"context_line":"                        \"to retrieve sharing resource providers associated \""}],"source_content_type":"text/x-python","patch_set":8,"id":"b0c90f71_a834d4e9","line":511,"in_reply_to":"2393950d_db26dd80","updated":"2024-06-24 09:52:53.000000000","message":"Done","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cce52f816bd9bea9063ff7820074b8fd941bd84a","unresolved":true,"context_lines":[{"line_number":508,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"},{"line_number":509,"context_line":"                            global_request_id\u003dcontext.global_id)"},{"line_number":510,"context_line":"            if resp.status_code \u003d\u003d 200:"},{"line_number":511,"context_line":"                resource_providers +\u003d resp.json()[\u0027resource_providers\u0027]"},{"line_number":512,"context_line":"            else:"},{"line_number":513,"context_line":"                msg \u003d _(\"[%(placement_req_id)s] %(iquery)s/%(isize)s Failed \""},{"line_number":514,"context_line":"                        \"to retrieve sharing resource providers associated \""}],"source_content_type":"text/x-python","patch_set":8,"id":"2393950d_db26dd80","line":511,"in_reply_to":"6d08d94a_035c7c51","updated":"2024-06-19 09:39:25.000000000","message":"sure I will do that so","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"736043997b77da620d0657f7646b09e83b4eab32","unresolved":true,"context_lines":[{"line_number":508,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"},{"line_number":509,"context_line":"                            global_request_id\u003dcontext.global_id)"},{"line_number":510,"context_line":"            if resp.status_code \u003d\u003d 200:"},{"line_number":511,"context_line":"                resource_providers +\u003d resp.json()[\u0027resource_providers\u0027]"},{"line_number":512,"context_line":"            else:"},{"line_number":513,"context_line":"                msg \u003d _(\"[%(placement_req_id)s] %(iquery)s/%(isize)s Failed \""},{"line_number":514,"context_line":"                        \"to retrieve sharing resource providers associated \""}],"source_content_type":"text/x-python","patch_set":8,"id":"6d08d94a_035c7c51","line":511,"in_reply_to":"821c8da0_bb780ad4","updated":"2024-06-19 09:24:49.000000000","message":"from an api perspective its allowed so there may be an upgrade impact to adding that new constrait at that level.\nso my incliantion is to say even if we dont have a use case for it now we should make nova accpet it.\n\n\ni dont think having duplict RP would actully break antying in nova but if we do swap the list for a set interanlly i think we should be fine, you can convert backj to a list when returning form the function","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9316bd96841309774b156b9adbac9f6679f429e1","unresolved":true,"context_lines":[{"line_number":508,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"},{"line_number":509,"context_line":"                            global_request_id\u003dcontext.global_id)"},{"line_number":510,"context_line":"            if resp.status_code \u003d\u003d 200:"},{"line_number":511,"context_line":"                resource_providers +\u003d resp.json()[\u0027resource_providers\u0027]"},{"line_number":512,"context_line":"            else:"},{"line_number":513,"context_line":"                msg \u003d _(\"[%(placement_req_id)s] %(iquery)s/%(isize)s Failed \""},{"line_number":514,"context_line":"                        \"to retrieve sharing resource providers associated \""}],"source_content_type":"text/x-python","patch_set":8,"id":"821c8da0_bb780ad4","line":511,"in_reply_to":"ebab7dff_821b93aa","updated":"2024-06-18 12:49:58.000000000","message":"If this happens that does not look like a fix to be in placement?","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f920da3e84f987b5d242a6bd60fc8e275c9f95f","unresolved":true,"context_lines":[{"line_number":508,"context_line":"            resp \u003d self.get(url, version\u003d\u00271.18\u0027,"},{"line_number":509,"context_line":"                            global_request_id\u003dcontext.global_id)"},{"line_number":510,"context_line":"            if resp.status_code \u003d\u003d 200:"},{"line_number":511,"context_line":"                resource_providers +\u003d resp.json()[\u0027resource_providers\u0027]"},{"line_number":512,"context_line":"            else:"},{"line_number":513,"context_line":"                msg \u003d _(\"[%(placement_req_id)s] %(iquery)s/%(isize)s Failed \""},{"line_number":514,"context_line":"                        \"to retrieve sharing resource providers associated \""}],"source_content_type":"text/x-python","patch_set":8,"id":"ebab7dff_821b93aa","line":511,"in_reply_to":"fee4a7a4_3b9f4d6c","updated":"2024-06-18 11:12:01.000000000","message":"so it shouldn\u0027t it technicaly coudl but a sharing resouce providerr with the misc shares via aggrate trait is not ment ot be in two aggreates and there is only ment to be one sharing RP in any one aggreate.\n\nhowever nothing in placment enforces that it just not how it was intended to be used.\n\nthecnically it would not break anything if we did have multipel sharing RPs i guess\n\nso i guess we shoudl build this up as a set and then convert it to a list when we return.","commit_id":"8a6c553e9a5c5ba7be3a235066b26ea2b0d0806c"}],"nova/tests/unit/scheduler/client/test_report.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b057ea7d1169b19c4d5c8963e7f5244a71a0acc2","unresolved":true,"context_lines":[{"line_number":2336,"context_line":""},{"line_number":2337,"context_line":"    def test_get_sharing_providers(self):"},{"line_number":2338,"context_line":"        self.flags("},{"line_number":2339,"context_line":"            sharing_providers_max_uuids_per_request\u003d3, group\u003d\u0027compute\u0027)"},{"line_number":2340,"context_line":""},{"line_number":2341,"context_line":"        resp_mock \u003d mock.Mock(status_code\u003d200)"},{"line_number":2342,"context_line":"        rpjson1 \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"f30db119_3fe37262","line":2339,"updated":"2024-06-12 16:59:13.000000000","message":"ok so you are simulating 4 aggreates\n\nand setting the batch size to 3","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b0f824f5d84c63e70295e29d55badf55617bcf2f","unresolved":false,"context_lines":[{"line_number":2336,"context_line":""},{"line_number":2337,"context_line":"    def test_get_sharing_providers(self):"},{"line_number":2338,"context_line":"        self.flags("},{"line_number":2339,"context_line":"            sharing_providers_max_uuids_per_request\u003d3, group\u003d\u0027compute\u0027)"},{"line_number":2340,"context_line":""},{"line_number":2341,"context_line":"        resp_mock \u003d mock.Mock(status_code\u003d200)"},{"line_number":2342,"context_line":"        rpjson1 \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"b802a0db_219388af","line":2339,"in_reply_to":"f30db119_3fe37262","updated":"2024-06-13 13:41:21.000000000","message":"Done","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b057ea7d1169b19c4d5c8963e7f5244a71a0acc2","unresolved":true,"context_lines":[{"line_number":2384,"context_line":"            self.context, [uuids.agg1, uuids.agg2,"},{"line_number":2385,"context_line":"                           uuids.agg3, uuids.agg4])"},{"line_number":2386,"context_line":""},{"line_number":2387,"context_line":"        self.assertEqual("},{"line_number":2388,"context_line":"            ["},{"line_number":2389,"context_line":"                mock.call("},{"line_number":2390,"context_line":"                    \u0027/resource_providers?member_of\u003din:\u0027 +"}],"source_content_type":"text/x-python","patch_set":7,"id":"7fbb6144_dc1d8d02","line":2387,"range":{"start_line":2387,"start_character":4,"end_line":2387,"end_character":25},"updated":"2024-06-12 16:59:13.000000000","message":"you should not use assertEqual for this\n\nyou should use \n\n self.ks_adap_mock.get.assert_has_calls([...])","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b0f824f5d84c63e70295e29d55badf55617bcf2f","unresolved":false,"context_lines":[{"line_number":2384,"context_line":"            self.context, [uuids.agg1, uuids.agg2,"},{"line_number":2385,"context_line":"                           uuids.agg3, uuids.agg4])"},{"line_number":2386,"context_line":""},{"line_number":2387,"context_line":"        self.assertEqual("},{"line_number":2388,"context_line":"            ["},{"line_number":2389,"context_line":"                mock.call("},{"line_number":2390,"context_line":"                    \u0027/resource_providers?member_of\u003din:\u0027 +"}],"source_content_type":"text/x-python","patch_set":7,"id":"cfa7b411_91d8eb85","line":2387,"range":{"start_line":2387,"start_character":4,"end_line":2387,"end_character":25},"in_reply_to":"7fbb6144_dc1d8d02","updated":"2024-06-13 13:41:21.000000000","message":"Sure It\u0027s better.","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b057ea7d1169b19c4d5c8963e7f5244a71a0acc2","unresolved":true,"context_lines":[{"line_number":2399,"context_line":"                    \u0027\u0026required\u003dMISC_SHARES_VIA_AGGREGATE\u0027,"},{"line_number":2400,"context_line":"                    microversion\u003d\u00271.18\u0027,"},{"line_number":2401,"context_line":"                    global_request_id\u003dself.context.global_id),"},{"line_number":2402,"context_line":"                mock.call().json(),"},{"line_number":2403,"context_line":"            ],"},{"line_number":2404,"context_line":"        self.ks_adap_mock.get.mock_calls)"},{"line_number":2405,"context_line":"        self.assertEqual(rpjson1 + rpjson2, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"77add98e_cf090307","line":2402,"updated":"2024-06-12 16:59:13.000000000","message":"and then asserting that there are 2 seperate requests.\n\ni guess this is fine but it would have been nice to have a repducer test first.\n\nthis is a relitivly simple change however","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b0f824f5d84c63e70295e29d55badf55617bcf2f","unresolved":false,"context_lines":[{"line_number":2399,"context_line":"                    \u0027\u0026required\u003dMISC_SHARES_VIA_AGGREGATE\u0027,"},{"line_number":2400,"context_line":"                    microversion\u003d\u00271.18\u0027,"},{"line_number":2401,"context_line":"                    global_request_id\u003dself.context.global_id),"},{"line_number":2402,"context_line":"                mock.call().json(),"},{"line_number":2403,"context_line":"            ],"},{"line_number":2404,"context_line":"        self.ks_adap_mock.get.mock_calls)"},{"line_number":2405,"context_line":"        self.assertEqual(rpjson1 + rpjson2, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fd3acef0_6bb28dfd","line":2402,"in_reply_to":"77add98e_cf090307","updated":"2024-06-13 13:41:21.000000000","message":"I have added a comment to make it clear.","commit_id":"65739e8ab186d8774e4302e87b88d7eaad08c302"}]}