)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82a4114f8cf81437ab65bb09e5e0cbda17bdd285","unresolved":true,"context_lines":[{"line_number":21,"context_line":"data that may be slightly stale should have minimal impact compared to"},{"line_number":22,"context_line":"the performance benefits."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Conflicts:"},{"line_number":25,"context_line":"  nova/tests/unit/virt/ironic/test_driver.py"},{"line_number":26,"context_line":"  nova/virt/ironic/driver.py"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"NOTE(elod.illes): conflict is caused by openstacksdk related feature"},{"line_number":29,"context_line":"patch (I9fb5a385487f601329bccc9efde325d86be397b6) which was merged in"},{"line_number":30,"context_line":"development branch (2024.1 Caracal), hence it does not exist in 2023.2."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-bug: #2043036"},{"line_number":33,"context_line":"Change-Id: If31158e3269e5e06848c29294fdaa147beedb5a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"136dd5d3_6c417363","line":30,"range":{"start_line":24,"start_character":0,"end_line":30,"end_character":71},"updated":"2024-06-18 00:21:08.000000000","message":"nit: technially you could drop this now since the conflict was resolved in the previous 2023.2 branch\n\nim gnerealy ok kepping it the same unless there was a new conflict however.","commit_id":"5e1e5caa20a571b6f8af07c4e1d5f59de1174ef4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"14f53a4f40d3c63aaad31cadda24ed2800cb28fc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"data that may be slightly stale should have minimal impact compared to"},{"line_number":22,"context_line":"the performance benefits."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Conflicts:"},{"line_number":25,"context_line":"  nova/tests/unit/virt/ironic/test_driver.py"},{"line_number":26,"context_line":"  nova/virt/ironic/driver.py"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"NOTE(elod.illes): conflict is caused by openstacksdk related feature"},{"line_number":29,"context_line":"patch (I9fb5a385487f601329bccc9efde325d86be397b6) which was merged in"},{"line_number":30,"context_line":"development branch (2024.1 Caracal), hence it does not exist in 2023.2."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-bug: #2043036"},{"line_number":33,"context_line":"Change-Id: If31158e3269e5e06848c29294fdaa147beedb5a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"404b369a_471eea21","line":30,"range":{"start_line":24,"start_character":0,"end_line":30,"end_character":71},"in_reply_to":"136dd5d3_6c417363","updated":"2024-06-18 08:30:35.000000000","message":"we usually ask folks to remove it, so I\u0027ve removed it now o:)","commit_id":"5e1e5caa20a571b6f8af07c4e1d5f59de1174ef4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82a4114f8cf81437ab65bb09e5e0cbda17bdd285","unresolved":true,"context_lines":[{"line_number":32,"context_line":"Closes-bug: #2043036"},{"line_number":33,"context_line":"Change-Id: If31158e3269e5e06848c29294fdaa147beedb5a5"},{"line_number":34,"context_line":"(cherry picked from commit fa3cf7d50cba921ea67eb161e6a199067ea62deb)"},{"line_number":35,"context_line":"(cherry picked from commit 555d7d0ad02d31476e2d751aa52be4087878f1a2)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4bd17f_dee1ee17","line":35,"updated":"2024-06-18 00:21:08.000000000","message":"the new cherry pick line is the only change to this review\nso this looks good to me","commit_id":"5e1e5caa20a571b6f8af07c4e1d5f59de1174ef4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"14f53a4f40d3c63aaad31cadda24ed2800cb28fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Closes-bug: #2043036"},{"line_number":33,"context_line":"Change-Id: If31158e3269e5e06848c29294fdaa147beedb5a5"},{"line_number":34,"context_line":"(cherry picked from commit fa3cf7d50cba921ea67eb161e6a199067ea62deb)"},{"line_number":35,"context_line":"(cherry picked from commit 555d7d0ad02d31476e2d751aa52be4087878f1a2)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"010c8361_46a0ecf6","line":35,"in_reply_to":"5f4bd17f_dee1ee17","updated":"2024-06-18 08:30:35.000000000","message":"✔","commit_id":"5e1e5caa20a571b6f8af07c4e1d5f59de1174ef4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"501442051bcd840f9ebe220e7634f6802a202c78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c886a48_2e6fa4cc","updated":"2024-06-17 21:34:06.000000000","message":"Thanks for getting this in 2023.2! It needs to keep going back.","commit_id":"5e1e5caa20a571b6f8af07c4e1d5f59de1174ef4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82a4114f8cf81437ab65bb09e5e0cbda17bdd285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8ce7b760_20af3c67","updated":"2024-06-18 00:21:08.000000000","message":"ill leave it to elod and other to decide if we should drop the conflict message but this looks fine to me. its now merged in 2023.2 so im fine with continuring with the back port as is.","commit_id":"5e1e5caa20a571b6f8af07c4e1d5f59de1174ef4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"14f53a4f40d3c63aaad31cadda24ed2800cb28fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0578f118_774c78b2","updated":"2024-06-18 08:30:35.000000000","message":"This is a clean cherry pick from stable/2023.2, where the patch has merged. I\u0027ve removed the conflict lines that were written for the bobcat backport, so the patch is the same, so considering this and Sean\u0027s +2 for PS1, I\u0027m approving this. Thanks Jay for working on this!","commit_id":"3226318b534847a5c553f2d94f9df19a631fd617"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"66b9320ad91395b47ed3af82539d491117d20fec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ca82d09_4779e928","updated":"2024-06-18 19:38:39.000000000","message":"recheck - nova-live-migration-ceph job TIMED_OUT","commit_id":"3226318b534847a5c553f2d94f9df19a631fd617"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"387446bf6766f685f4c8d54906638e6e653e5866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cdfa5ef3_7bf8eb41","updated":"2024-06-18 14:01:13.000000000","message":"recheck - nova-next - guest kernel panic :/","commit_id":"3226318b534847a5c553f2d94f9df19a631fd617"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f4cc93f1ac59250c0a1b17ca603d046b199b42d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f15ed58_398d604a","updated":"2024-06-19 07:54:07.000000000","message":"recheck - nova-next job failed with test case: \n\ntest_snapshot_volume_backed_multiattach\n\nDetails: {\u0027code\u0027: 400, \u0027message\u0027: \u0027Invalid volume: Volume status must be available or error or error_restoring or error_extending or error_managing and must not be migrating, attached, belong to a group, have snapshots, awaiting a transfer, or be disassociated from snapshots after volume transfer.\u0027}","commit_id":"3226318b534847a5c553f2d94f9df19a631fd617"}]}