)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aa3be27f28f4f1cc9a3aadd2d3be303e1e291602","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a473989_063b76b7","updated":"2024-06-18 16:31:14.000000000","message":"settign this to -1 for now since i do not have time currently to work on the correct fix","commit_id":"7c37992b1b47f5fe4452c1e0cef87fff87ea8d99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83bfb007e5314578d6908ff29b474fc1df2db2c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b53f8b6c_0e164934","updated":"2024-06-18 16:30:38.000000000","message":"the correct fix is really to make this condtional on why we are undefiening the domain and we shoudl make use of the livbrit flags as noted in the bug\n\nsee \nhttps://bugs.launchpad.net/nova/+bug/1997352/comments/12\nhttps://bugs.launchpad.net/nova/+bug/1997352/comments/13\nand https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainUndefineFlagsValues\n\n```\nenum virDomainUndefineFlagsValues {\n\nVIR_DOMAIN_UNDEFINE_MANAGED_SAVE\t\u003d \t1 (0x1; 1 \u003c\u003c 0)\t\nAlso remove any managed save\nVIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA\t\u003d \t2 (0x2; 1 \u003c\u003c 1)\t\nIf last use of domain, then also remove any snapshot metadata\nVIR_DOMAIN_UNDEFINE_NVRAM\t\u003d \t4 (0x4; 1 \u003c\u003c 2)\t\nAlso remove any nvram file\nVIR_DOMAIN_UNDEFINE_KEEP_NVRAM\t\u003d \t8 (0x8; 1 \u003c\u003c 3)\t\nKeep nvram file\nVIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA\t\u003d \t16 (0x10; 1 \u003c\u003c 4)\t\nIf last use of domain, then also remove any checkpoint metadata\nVIR_DOMAIN_UNDEFINE_TPM\t\u003d \t32 (0x20; 1 \u003c\u003c 5)\t\nAlso remove any TPM state\nVIR_DOMAIN_UNDEFINE_KEEP_TPM\t\u003d \t64 (0x40; 1 \u003c\u003c 6)\t\nKeep TPM state Future undefine control flags should come here.\n\n}\n\n```\n\nwe should be passign VIR_DOMAIN_UNDEFINE_NVRAM and VIR_DOMAIN_UNDEFINE_KEEP_NVRAM\ninstead as requried to fix this properly without losing guest data stored in the nvram file.","commit_id":"7c37992b1b47f5fe4452c1e0cef87fff87ea8d99"}]}