)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c266a3b2781fe61027089475995e85d287b30738","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cgibi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-04-23 16:33:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"split monkey_patching form import"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change separates the evetlet monkey patching"},{"line_number":10,"context_line":"from importing the module and add a module level"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff900345_5ba7b242","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"updated":"2025-04-25 08:46:28.000000000","message":"nit: from","commit_id":"f524bee47e6998621121edcccce53cebff13c48f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c67a298d4635178acb526027f5259513529514d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9958d858_c7829dbe","updated":"2024-06-20 22:36:41.000000000","message":"re","commit_id":"8b249f8c2b64c94ecad7a81a56bb7a534c9be22a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ba53be6cf0701dff2a1a15d9a7d01a6763386384","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f411f4db_2e59afb8","updated":"2024-06-21 03:29:57.000000000","message":"recheck volume tests be flaky.\n\n1 volume test in 4 diffenrt jobs failed all different\n \n1 kernel panic\n\ninfo: initramfs loading root from /dev/vda1\n/sbin/init: can\u0027t load library \u0027libtirpc.so.3\u0027\n[   10.791874] Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000\n\n\none got a device busy error\n\ntempest.lib.exceptions.SSHExecCommandFailed: Command \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; sudo mount /dev/vdb /mnt/vdb\u0027, exit status: 255, stderr:\nmount: mounting /dev/vdb on /mnt/vdb failed: Device or resource busy\n\nanother didnt get netowrking in time\n\nStarting acpid: OK\nStarting network: dhcpcd-9.4.1 starting\nDUID 00:04:f7:b5:8a:51:a7:ff:4a:f2:be:9d:96:07:5b:d6:15:29\nforked to background, child pid 249\nOK\nchecking http://169.254.169.254/2009-04-04/instance-id\nfailed 1/20: up 24.89. request failed\nfailed 2/20: up 27.22. request failed\nfailed 3/20: up 29.53. request failed\nfailed 4/20: up 31.80. request failed\nfailed 5/20: up 81.08. request failed\nfailed 6/20: up 130.40. request failed","commit_id":"ffa245e961d8270ec0d8d3a52442e7c8adeee489"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51d65c82c749bf44e93f6cf3e8f08a76f45f4895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"077e659a_57e07fe5","updated":"2024-07-01 16:16:43.000000000","message":"recheck /sbin/init: can\u0027t load library \u0027libtirpc.so.3\u0027\n\nthis is one of the normal kernel panics we see.","commit_id":"d9653ea2f98a536b60ea95debb15d3ce139f7958"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"443075c86dbe7b8afe9f5dd8e5bb18ecd0942164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91273988_012617e4","updated":"2024-08-26 13:30:55.000000000","message":"I have one request about the remote debugger support.","commit_id":"633188f74f22874de6c362758674e96916d4e9b1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45922c0c973835488a8c592ffeb7dee34dfde3d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4424d040_0698f225","updated":"2024-08-20 15:56:44.000000000","message":"recheck networking was down \n\n\nStarting network: dhcpcd-9.4.1 starting\nDUID 00:04:f4:13:38:e7:49:b4:4e:90:9a:13:8a:4c:71:4b:da:75\nforked to background, child pid 250\nno interfaces have a carrier\nOK\nchecking http://169.254.169.254/2009-04-04/instance-id\nfailed 1/20: up 29.06. request failed\nfailed 2/20: up 31.38. request failed\nfailed 3/20: up 33.67. request failed\nfailed 4/20: up 83.21. request failed\nfailed 5/20: up 132.52. request failed","commit_id":"633188f74f22874de6c362758674e96916d4e9b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"00d6595d01e0daed45cac51f3a322d98743ff144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"040b895f_caa84c04","updated":"2025-04-02 13:55:19.000000000","message":"rebased and improved the pep8 handling a bit","commit_id":"a9042e058c730ebe9ad284b4c018a9c61a925603"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"17a24b6a3ef0007ef03c88b418974caee750b021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"77cf0bad_c5a201b4","updated":"2025-04-24 07:53:02.000000000","message":"recheck nova-next instance took longer time to hard reboot","commit_id":"f524bee47e6998621121edcccce53cebff13c48f"}],"nova/api/openstack/__init__.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c67a298d4635178acb526027f5259513529514d4","unresolved":true,"context_lines":[{"line_number":26,"context_line":"from nova.api import wsgi as base_wsgi"},{"line_number":27,"context_line":"import nova.conf"},{"line_number":28,"context_line":"from nova.i18n import translate"},{"line_number":29,"context_line":"from nova import monkey_patch"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"monkey_patch.patch()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e3e1f619_48a16cc3","line":29,"updated":"2024-06-20 22:36:41.000000000","message":"the order is actuly proably imporant here so this might be why we are seeing the failure.\n\nif we are going to patch it must be very early to avoid importing modules like urlib3 that are know to break if patching later os this is likely the problem in the jobs","commit_id":"8b249f8c2b64c94ecad7a81a56bb7a534c9be22a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"16cc5d67ebb7c35001717f93092a31b64baf384a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from nova.api import wsgi as base_wsgi"},{"line_number":27,"context_line":"import nova.conf"},{"line_number":28,"context_line":"from nova.i18n import translate"},{"line_number":29,"context_line":"from nova import monkey_patch"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"monkey_patch.patch()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ac514d92_6e87fc1d","line":29,"in_reply_to":"e3e1f619_48a16cc3","updated":"2024-06-21 03:30:15.000000000","message":"Done","commit_id":"8b249f8c2b64c94ecad7a81a56bb7a534c9be22a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c266a3b2781fe61027089475995e85d287b30738","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"# autopep8: off"},{"line_number":21,"context_line":"from nova import monkey_patch ; monkey_patch.patch()  # noqa"},{"line_number":22,"context_line":"# autopep8: on"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"import routes"}],"source_content_type":"text/x-python","patch_set":8,"id":"de4828ab_46e04cd6","line":22,"updated":"2025-04-25 08:46:28.000000000","message":"👌","commit_id":"f524bee47e6998621121edcccce53cebff13c48f"}],"nova/test.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5a023f9a7ddd56acc0fe1818236e52967098cc8c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":"# autopep8: off"},{"line_number":24,"context_line":"from nova import monkey_patch ; monkey_patch.patch()  # noqa"},{"line_number":25,"context_line":"# autopep8: on"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import abc"},{"line_number":28,"context_line":"import builtins"}],"source_content_type":"text/x-python","patch_set":6,"id":"069774c8_de0cc5f3","line":25,"updated":"2025-04-02 14:27:32.000000000","message":"this is your solution? if so thats fine by me.","commit_id":"ac37d5f21ae373a088ceb68c89ebad21ce45995f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57c50b4a006386e962daec2464c56b2ac559a6dc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":"# autopep8: off"},{"line_number":24,"context_line":"from nova import monkey_patch ; monkey_patch.patch()  # noqa"},{"line_number":25,"context_line":"# autopep8: on"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import abc"},{"line_number":28,"context_line":"import builtins"}],"source_content_type":"text/x-python","patch_set":6,"id":"eeedd4cb_3ae4d7a8","line":25,"in_reply_to":"03cf98ce_d0ee0b39","updated":"2025-04-25 12:54:22.000000000","message":"Acknowledged","commit_id":"ac37d5f21ae373a088ceb68c89ebad21ce45995f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5f034a4445708fe3d39b10ea857c937ef2d1234c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":"# autopep8: off"},{"line_number":24,"context_line":"from nova import monkey_patch ; monkey_patch.patch()  # noqa"},{"line_number":25,"context_line":"# autopep8: on"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import abc"},{"line_number":28,"context_line":"import builtins"}],"source_content_type":"text/x-python","patch_set":6,"id":"03cf98ce_d0ee0b39","line":25,"in_reply_to":"069774c8_de0cc5f3","updated":"2025-04-14 14:06:37.000000000","message":"yeah this is the only way I found to silence the import check. But at least it is a local one instead of a global one. (and eventually we will drop it anyhow)","commit_id":"ac37d5f21ae373a088ceb68c89ebad21ce45995f"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"443075c86dbe7b8afe9f5dd8e5bb18ecd0942164","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"    \"\"\""},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"    def __init__(self, *a, **kw):"},{"line_number":1870,"context_line":"        eventlet_patched \u003d monkey_patch.is_patched()"},{"line_number":1871,"context_line":"        mpatch \u003d fixtures.MonkeyPatch("},{"line_number":1872,"context_line":"            \u0027threading.current_thread\u0027, eventlet.getcurrent)"},{"line_number":1873,"context_line":"        with mpatch if eventlet_patched else contextlib.ExitStack():"}],"source_content_type":"text/x-python","patch_set":4,"id":"e67f721c_9e012698","line":1870,"updated":"2024-08-26 13:30:55.000000000","message":"This is now a wider check than before. If remove debugger is enabled (whatever it is) then threads will not be monkey patched. So I guess after this point the remote debugger will not work as we blindly try to modify an unpatched threading module as well. See https://review.opendev.org/c/openstack/nova/+/922425/4/nova/monkey_patch.py#52\n\nEither we need to add a release notes that nova.debugger is not supported any more or we need to now break it here.","commit_id":"633188f74f22874de6c362758674e96916d4e9b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"00d6595d01e0daed45cac51f3a322d98743ff144","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"    \"\"\""},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"    def __init__(self, *a, **kw):"},{"line_number":1870,"context_line":"        eventlet_patched \u003d monkey_patch.is_patched()"},{"line_number":1871,"context_line":"        mpatch \u003d fixtures.MonkeyPatch("},{"line_number":1872,"context_line":"            \u0027threading.current_thread\u0027, eventlet.getcurrent)"},{"line_number":1873,"context_line":"        with mpatch if eventlet_patched else contextlib.ExitStack():"}],"source_content_type":"text/x-python","patch_set":4,"id":"165f81c7_ac1a1cf3","line":1870,"in_reply_to":"aea099fe_c73c6a8c","updated":"2025-04-02 13:55:19.000000000","message":"the debugger removal is now happens before this patch so this comment is not applicable any more.","commit_id":"633188f74f22874de6c362758674e96916d4e9b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0778d1207758f0ef673cd3be03e3d977bad45626","unresolved":true,"context_lines":[{"line_number":1867,"context_line":"    \"\"\""},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"    def __init__(self, *a, **kw):"},{"line_number":1870,"context_line":"        eventlet_patched \u003d monkey_patch.is_patched()"},{"line_number":1871,"context_line":"        mpatch \u003d fixtures.MonkeyPatch("},{"line_number":1872,"context_line":"            \u0027threading.current_thread\u0027, eventlet.getcurrent)"},{"line_number":1873,"context_line":"        with mpatch if eventlet_patched else contextlib.ExitStack():"}],"source_content_type":"text/x-python","patch_set":4,"id":"aea099fe_c73c6a8c","line":1870,"in_reply_to":"e67f721c_9e012698","updated":"2024-08-26 13:51:45.000000000","message":"Ah I see you have a separate patch to remove it https://review.opendev.org/c/openstack/nova/+/922496 I would pull that patch before this.","commit_id":"633188f74f22874de6c362758674e96916d4e9b1"}],"tox.ini":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"443075c86dbe7b8afe9f5dd8e5bb18ecd0942164","unresolved":true,"context_lines":[{"line_number":294,"context_line":"# these that have to be fixed"},{"line_number":295,"context_line":"# E402 module level import not at top of file"},{"line_number":296,"context_line":"# E402 is skipped because of how we monkeypatch we can remove this"},{"line_number":297,"context_line":"# when we remove eventlet monkey patching."},{"line_number":298,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":299,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238,E402"},{"line_number":300,"context_line":"exclude \u003d  .venv,.git,.tox,dist,*lib/python*,*egg,build,releasenotes"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1da51443_8ce305d7","line":297,"updated":"2024-08-26 13:30:55.000000000","message":"I guess we cannot selectively add noqa to the monkey_patch call to silence this. :/","commit_id":"633188f74f22874de6c362758674e96916d4e9b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"00d6595d01e0daed45cac51f3a322d98743ff144","unresolved":true,"context_lines":[{"line_number":294,"context_line":"# these that have to be fixed"},{"line_number":295,"context_line":"# E402 module level import not at top of file"},{"line_number":296,"context_line":"# E402 is skipped because of how we monkeypatch we can remove this"},{"line_number":297,"context_line":"# when we remove eventlet monkey patching."},{"line_number":298,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":299,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238,E402"},{"line_number":300,"context_line":"exclude \u003d  .venv,.git,.tox,dist,*lib/python*,*egg,build,releasenotes"}],"source_content_type":"text/x-properties","patch_set":4,"id":"79272285_fe26afc7","line":297,"in_reply_to":"1da51443_8ce305d7","updated":"2025-04-02 13:55:19.000000000","message":"I found a way to keep E402 only ignored on the specific monkey patching calls. Let me know how you feel about it.","commit_id":"633188f74f22874de6c362758674e96916d4e9b1"}]}