)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d5fadf4874869f891675a93cd418f2b2f9fd1968","unresolved":false,"context_lines":[{"line_number":11,"context_line":"never been reliable due to our use of eventlet and is generally"},{"line_number":12,"context_line":"not required when not using eventlet. I.e. you can just"},{"line_number":13,"context_line":"run the nova console-scripts form a debugger or add pdb"},{"line_number":14,"context_line":"statements as required."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As part of the eventlet removal the debugger functionality is"},{"line_number":17,"context_line":"removed given its untested and undocumented."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"09ba6c3a_fb08da25","line":14,"updated":"2025-04-23 16:08:40.000000000","message":"that is true, opening a debugging path directly was nice for checking the memory usage but people can still run nova-compute (or other services) on top of a debugger.","commit_id":"445b405a6de7bf11e678cea1fd727d1ed41719f0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98e1b6c829ffdd0078d5871d7df0efa70838c3e3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"never been reliable due to our use of eventlet and is generally"},{"line_number":12,"context_line":"not required when not using eventlet. I.e. you can just"},{"line_number":13,"context_line":"run the nova console-scripts form a debugger or add pdb"},{"line_number":14,"context_line":"statements as required."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As part of the eventlet removal the debugger functionality is"},{"line_number":17,"context_line":"removed given its untested and undocumented."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"2c9c1cd2_4cb7f1cf","line":14,"in_reply_to":"09ba6c3a_fb08da25","updated":"2025-04-25 12:38:32.000000000","message":"yepp","commit_id":"445b405a6de7bf11e678cea1fd727d1ed41719f0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9360cf38c933af0cd7dfda5b23318ff5255411c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"91edaf72_24a8e971","updated":"2024-07-01 21:53:54.000000000","message":"this is not strictly needed an i apare to have som eissues in the docs so im debating if i will fix those or move this to later in the series","commit_id":"c64e7ccc2d35e35ba5ff89e961fb595f06c25760"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"20d44c727dd110032d49d2e28e769ce0fd99446e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c280b93b_dee3d9ac","updated":"2024-08-26 13:51:00.000000000","message":"I suggest to add a release notes about the removal just to signal that the removal is intentional. \n\nAlso I think this patch breaks running nova on windows.","commit_id":"e84a9d13281c91411da7ddc16b91b72c90d33161"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d3a9620bebb48eea10b0c76ba6cbc8e86cb29eba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8c8d1dd9_846cfa4e","updated":"2024-10-15 15:21:51.000000000","message":"I haven\u0027t reviewed this, but I will once the conflict is resolved. That said, I\u0027ve literally never used this in 12+ years of nova development, so I think this is fine from my perspective.","commit_id":"fc579957717102b674b0297611d778d892906992"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"79c24f447cce87babf7b6ec0989015efc148af80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"56efd2e8_f93aa3d3","updated":"2025-04-02 12:23:36.000000000","message":"rebased and adapted to the current master.","commit_id":"40a4568d02b8802a5bd49d2151d81ef100bfffdc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9dd801ffe12c15c96ec36d431ad912859be6d4d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1e9a229e_c08c5088","updated":"2025-04-14 13:47:34.000000000","message":"recheck post failure in sdk job","commit_id":"d9f0b346891105ec039070cf8b3006fd66c8c7f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d526ec0d5e1b0a6df8e0a762430abdebd5fcc43b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ac2e1594_8ee1c297","updated":"2025-04-25 12:51:38.000000000","message":"Sylvain was previously +2 on this\n\nthis is a trivial rebase because we merged the removal of the eventlet api console script and with it the docs were removed.","commit_id":"02d72b9d56f44481ff3971ec4c1aa87ad6c06775"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"54428936edb3104ec625d8672360eac5bb82c7a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"eb41bb83_06b8001a","updated":"2025-04-25 15:13:52.000000000","message":"recheck multistore \n```\nDetails: {\u0027message\u0027: \u0027Image 8d671dc3-ca28-4787-acde-6a15973b4a6d could not be deleted because it is in use: The image cannot be deleted because it is in use through the backend store outside of Glance.\u003cbr /\u003e\u003cbr /\u003e\\n\\n\\n\u0027, \u0027code\u0027: \u0027409 Conflict\u0027, \u0027title\u0027: \u0027Conflict\u0027}\n```","commit_id":"02d72b9d56f44481ff3971ec4c1aa87ad6c06775"}],"nova/cmd/standalone/baseproxy.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"991b1991cbcea91d38e5483da8cae9ec3b7a2ec9","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":36,"context_line":"remote_debug.register_cli_opts(CONF)"},{"line_number":37,"context_line":"novnc.register_cli_opts(CONF)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"gmr_opts.set_defaults(CONF)"},{"line_number":40,"context_line":"objects.register_all()"}],"source_content_type":"text/x-python","patch_set":2,"id":"73383a58_87e0924c","side":"PARENT","line":37,"updated":"2024-07-01 16:26:37.000000000","message":"i wonder if this is why the novnc proxy is failing ill readd this but it feels like there shoudl atleast be a commet explaing why this need to be in the base proxy","commit_id":"06970281d51304c4ce2d91eaa0eff2834d3c46f5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71c81767b14f22050121d8e98267871b64a2f38b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":36,"context_line":"remote_debug.register_cli_opts(CONF)"},{"line_number":37,"context_line":"novnc.register_cli_opts(CONF)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"gmr_opts.set_defaults(CONF)"},{"line_number":40,"context_line":"objects.register_all()"}],"source_content_type":"text/x-python","patch_set":2,"id":"894524b1_313b7a5b","side":"PARENT","line":37,"in_reply_to":"5ec78f13_479174c4","updated":"2024-08-26 16:42:15.000000000","message":"Done","commit_id":"06970281d51304c4ce2d91eaa0eff2834d3c46f5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c1e766c485e1e639ee3f744d3d88573e2978a51b","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":36,"context_line":"remote_debug.register_cli_opts(CONF)"},{"line_number":37,"context_line":"novnc.register_cli_opts(CONF)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"gmr_opts.set_defaults(CONF)"},{"line_number":40,"context_line":"objects.register_all()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ec78f13_479174c4","side":"PARENT","line":37,"in_reply_to":"73383a58_87e0924c","updated":"2024-07-01 16:40:09.000000000","message":"ya its for this https://github.com/openstack/nova/blob/bb15d7aab855e1947c71acd15f06173377deb3a1/nova/conf/novnc.py#L61-L64","commit_id":"06970281d51304c4ce2d91eaa0eff2834d3c46f5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c1e766c485e1e639ee3f744d3d88573e2978a51b","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        exit_with_error(\"SSL only and %s not found\" % CONF.cert)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Check to see if tty html/js/css files are present"},{"line_number":62,"context_line":"    if CONF.web and not os.path.exists(CONF.web):"},{"line_number":63,"context_line":"        exit_with_error(\"Can not find html/js files at %s.\" % CONF.web)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    logging.setup(CONF, \"nova\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"89a26b36_7cf31c98","line":62,"updated":"2024-07-01 16:40:09.000000000","message":"which is used here but i have no idea why this is in teh novnc section.\n\nsepeically when the default is /usr/share/spice-html5\n\ni feel like this should be under the console section to something else.","commit_id":"c64e7ccc2d35e35ba5ff89e961fb595f06c25760"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71c81767b14f22050121d8e98267871b64a2f38b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        exit_with_error(\"SSL only and %s not found\" % CONF.cert)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Check to see if tty html/js/css files are present"},{"line_number":62,"context_line":"    if CONF.web and not os.path.exists(CONF.web):"},{"line_number":63,"context_line":"        exit_with_error(\"Can not find html/js files at %s.\" % CONF.web)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    logging.setup(CONF, \"nova\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f163c1a_8c6ebd65","line":62,"in_reply_to":"89a26b36_7cf31c98","updated":"2024-08-26 16:42:15.000000000","message":"Done","commit_id":"c64e7ccc2d35e35ba5ff89e961fb595f06c25760"}],"nova/monkey_patch.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"20d44c727dd110032d49d2e28e769ce0fd99446e","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    if debugger.enabled():"},{"line_number":51,"context_line":"        # turn off thread patching to enable the remote debugger"},{"line_number":52,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":53,"context_line":"    elif os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":54,"context_line":"        # for nova-compute running on Windows(Hyper-v)"},{"line_number":55,"context_line":"        # pipes don\u0027t support non-blocking I/O"},{"line_number":56,"context_line":"        eventlet.monkey_patch(os\u003dFalse)"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        eventlet.monkey_patch()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7383a0d1_648ec9d5","side":"PARENT","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":39},"updated":"2024-08-26 13:51:00.000000000","message":"Do we just silently remove support for running nova services on windows?","commit_id":"b4e560473524570c2e90ae299b865ab00e06e012"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"661e33aa61dfc8efaed313ea460e8723b40736be","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if debugger.enabled():"},{"line_number":51,"context_line":"        # turn off thread patching to enable the remote debugger"},{"line_number":52,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":53,"context_line":"    elif os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":54,"context_line":"        # for nova-compute running on Windows(Hyper-v)"},{"line_number":55,"context_line":"        # pipes don\u0027t support non-blocking I/O"},{"line_number":56,"context_line":"        eventlet.monkey_patch(os\u003dFalse)"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        eventlet.monkey_patch()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fd72632_e2c55dfe","side":"PARENT","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":39},"in_reply_to":"22adaf3c_c2f22219","updated":"2025-04-02 12:23:13.000000000","message":"This is removed independently in I69b049d13556efe87f4be32f5e6e7f88e42f3b2a","commit_id":"b4e560473524570c2e90ae299b865ab00e06e012"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cdca24a17c9f351e370d3052b7bada9ace7a63ea","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    if debugger.enabled():"},{"line_number":51,"context_line":"        # turn off thread patching to enable the remote debugger"},{"line_number":52,"context_line":"        eventlet.monkey_patch(thread\u003dFalse)"},{"line_number":53,"context_line":"    elif os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":54,"context_line":"        # for nova-compute running on Windows(Hyper-v)"},{"line_number":55,"context_line":"        # pipes don\u0027t support non-blocking I/O"},{"line_number":56,"context_line":"        eventlet.monkey_patch(os\u003dFalse)"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        eventlet.monkey_patch()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"22adaf3c_c2f22219","side":"PARENT","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":39},"in_reply_to":"7383a0d1_648ec9d5","updated":"2024-08-27 09:06:34.000000000","message":"I guess I\u0027m OK to remove it but lets make it explicit and add a release notes","commit_id":"b4e560473524570c2e90ae299b865ab00e06e012"}],"releasenotes/notes/remote-debugger-removal-07e26d43c561d495.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"661e33aa61dfc8efaed313ea460e8723b40736be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"538b4c54_423540be","line":16,"range":{"start_line":10,"start_character":0,"end_line":16,"end_character":0},"updated":"2025-04-02 12:23:13.000000000","message":"Dropped this as it was cleaned up separately by I69b049d13556efe87f4be32f5e6e7f88e42f3b2a","commit_id":"fc579957717102b674b0297611d778d892906992"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"79c24f447cce87babf7b6ec0989015efc148af80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97a10d28_0a3ad939","line":16,"range":{"start_line":10,"start_character":0,"end_line":16,"end_character":0},"in_reply_to":"538b4c54_423540be","updated":"2025-04-02 12:23:36.000000000","message":"Done","commit_id":"fc579957717102b674b0297611d778d892906992"}]}