)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"7562d4feb987a987d4b61c4c26212e7173a8e1cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"300576f5_7050f7f7","updated":"2024-07-22 07:18:59.000000000","message":"recheck nova-live-migration-ceph","commit_id":"da87750d1b1650d964a63ed7c1da65272b2e85bf"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3ac64e80aa2d2e4cbda2e0a39dd378c1091dedb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b7bddc2_fd3b2677","updated":"2024-07-23 22:14:13.000000000","message":"recheck","commit_id":"10a1dc5b6e698b03b8e6967e63785a70cb32681c"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"309eb8416d8a9c9ce5c3d5a2c33d69893c2d8484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1ba5cfa6_f9bbdd28","updated":"2024-08-12 10:51:04.000000000","message":"Sorry, these got clogged because I forgot to hit the \"reply\" button.","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ea0a064de26d8876c3119e8994660534bb4f17c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ae3c02f0_3ae634ea","updated":"2024-08-12 11:28:52.000000000","message":"by the way i see you removed the release note in this version.\n\ni was more or less fine with what you previously had\nbut we can also just have the release note at the end of the series\n\nif you want to repine an reintroduce it its fine but im ok to have it in the follow up patches too hench +2","commit_id":"bc25b15227f3cea86a5b8738066eb634fbdd21e4"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"cf0f3267948afc3e1240e5b1e1b314c0a7def93e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1ec2a999_7e6eb29c","in_reply_to":"ae3c02f0_3ae634ea","updated":"2024-08-12 23:15:53.000000000","message":"Oh, that was not intentional, I must have messed up the rebase somewhere. I\u0027ll fix.","commit_id":"bc25b15227f3cea86a5b8738066eb634fbdd21e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c86a779117048ffc526f1df3774327ac8fd68fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8cbf0824_506ee7bb","updated":"2024-08-13 11:30:38.000000000","message":"i have not rechecked as the test failure is a job config issue due to new test that were added to tempest.\n\nill follow up on that seperatly.","commit_id":"4c3638259cbf818c2f8acc6c7b2fca93e0f72eff"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f2f3c4651d25d2ebf337fb0e663cc3d4a348ba36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"138bca79_307b8480","updated":"2024-08-30 00:56:40.000000000","message":"I keep promising to do more end to end testing here, but I haven\u0027t managed to get to it yet. Its not ignored, just not at the top of the list yet. I am happy enough to add some form of websocket proxy testing to that when I get to it too.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6fcafb2f026e0693d4ee5dd8c552fe3e81336c7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"75353765_e633b885","updated":"2024-08-29 04:11:23.000000000","message":"This looks OK to me but I\u0027m not 100% clear on whether this option works with both current SPICE and future direct SPICE? If it\u0027s only for direct, I would hold off on approving until we have approved the patch that adds direct SPICE functionality. (Basically don\u0027t want to have merged the config option if we\u0027re not ready to merge the actual direct console).","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9c406bc863770e5247071f61f1d6498519052bbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d2c6c981_e1af5b9d","updated":"2024-08-29 22:26:03.000000000","message":"Upgrading to +2+W to as this config option and libvirt config code is generally useful standalone and does not depend on spice-direct.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"c06e0379f42ecc7ee9b49e717dd217e678d94f2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b1a82889_dbb5031f","updated":"2024-08-22 10:10:16.000000000","message":"recheck docs build environment failed","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"db8e2c14ac967ddd6f9e316a4b2b18a983ffe084","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"771d26bf_024fe340","in_reply_to":"75353765_e633b885","updated":"2024-08-29 07:12:06.000000000","message":"My original thinking is that you\u0027d have one or the other. I\u0027m having some trouble testing what actually happens right now in my homelab, but I can beat on it if its important.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a0c59c19af6f9c03629fc33859b0ca2d42d7ccf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b26d394e_0e089e51","in_reply_to":"771d26bf_024fe340","updated":"2024-08-29 17:34:26.000000000","message":"No I was just trying to say I think this config option patch should be approved at the same time as the later spice-direct patch, if the config option only makes sense for spice-direct. I assumed this config option isn\u0027t useful for anything other than spice-direct but wanted to ask in case I was mistaken.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc893f5493e48bfcb663c4c57edbdb62bf92c427","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f7e905eb_c54fef47","in_reply_to":"b26d394e_0e089e51","updated":"2024-08-29 19:18:01.000000000","message":"i belive the secure options will require the connecction form the html5 spice proxy to use ssl so i belive it applicable to both and the setup would be almost the same for both.\n\ni.e. both the qemu instance and proxy would have to both turst the ca the cert was issueed form  ectra","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f2f3c4651d25d2ebf337fb0e663cc3d4a348ba36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"48a93905_399f9b97","in_reply_to":"c2275571_18eacacb","updated":"2024-08-30 00:56:40.000000000","message":"I tried to test this yesterday, but I can\u0027t get the HTML5 proxy to work in Kolla-Ansible _at_all_ at the moment when with require_secure turned off and am not entirely sure why.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9c406bc863770e5247071f61f1d6498519052bbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e3dd5f2b_a8f1e3d2","in_reply_to":"c2275571_18eacacb","updated":"2024-08-29 22:26:03.000000000","message":"Thanks Sean, that\u0027s exactly what I was wondering. I had thought this patch looked like something in general that could be used with the currently available spice support and is not exclusive to spice-direct.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a428c01cfe0e80f78fe86d74cd798f441602ffc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"dfd61587_98061286","in_reply_to":"e3dd5f2b_a8f1e3d2","updated":"2024-08-30 00:49:24.000000000","message":"its certenly usabel on the comptue irrespective of the poxy used.\n\nsince we dont have end to end testing with a spice the html5 proxy we dont quite knwo if there is somethign addtional requried there to cross the Ts and dot he Is\nbut it would be an incremental cange to adress any gap with that approch if needed.\n\n\nthe shadow gameign folks might know more \nhttps://review.opendev.org/c/openstack/nova-specs/+/920687\n\nthey have their own client and may be able to leaverage this if they were inclined to do so to ensure a secure conenction between the proxy and the vm\n\nin there case due to thet latency requiremetns of cloud gaming they plan to run the proxy on each compute node so they dont really need a secure conenction between the proxy and the vm but they might use it if it did nto have much overhead adn was effectivly free for them to enabel.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b23a035ebe0834fa695231bcc433d1757260da05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c2275571_18eacacb","in_reply_to":"f7e905eb_c54fef47","updated":"2024-08-29 19:20:42.000000000","message":"keep in mind nova\u0027s proxies just expost the raw spice connection tunneled into a websockt instead of tcp \n\nif your spice client support runwrapping the websocet and connecting to the underlying tcp stream it would work liek spice-direct\n\nmost spice client cant do that however\n\nspice direct is jsut allowing a tcp/udp proxy, in this case kerbside to forward a raw spice session instead fo wrapping it.","commit_id":"e06890d10105a198404348d6fe9899a549387b7d"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"60efc6d2c289c2db49fd787dd295a30d5f8975aa","unresolved":true,"context_lines":[{"line_number":2180,"context_line":"                    \u0027streaming\u0027, mode\u003dself.streaming_mode))"},{"line_number":2181,"context_line":"            if self.secure:"},{"line_number":2182,"context_line":"                for channel in [\u0027main\u0027, \u0027display\u0027, \u0027inputs\u0027, \u0027cursor\u0027,"},{"line_number":2183,"context_line":"                                \u0027playback\u0027, \u0027record\u0027, \u0027smartcard\u0027, \u0027usbredir\u0027]:"},{"line_number":2184,"context_line":"                    dev.append(etree.Element(\u0027channel\u0027, name\u003dchannel,"},{"line_number":2185,"context_line":"                                             mode\u003d\u0027secure\u0027))"},{"line_number":2186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f305106_df4b6232","line":2183,"updated":"2024-08-09 02:18:58.000000000","message":"are there any version considerations with regards to the avialable channels and which ones are supported with regards to the qemu adn libvirt versions in use?\n\nif not i guess im fine with hard coding these.","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"309eb8416d8a9c9ce5c3d5a2c33d69893c2d8484","unresolved":true,"context_lines":[{"line_number":2180,"context_line":"                    \u0027streaming\u0027, mode\u003dself.streaming_mode))"},{"line_number":2181,"context_line":"            if self.secure:"},{"line_number":2182,"context_line":"                for channel in [\u0027main\u0027, \u0027display\u0027, \u0027inputs\u0027, \u0027cursor\u0027,"},{"line_number":2183,"context_line":"                                \u0027playback\u0027, \u0027record\u0027, \u0027smartcard\u0027, \u0027usbredir\u0027]:"},{"line_number":2184,"context_line":"                    dev.append(etree.Element(\u0027channel\u0027, name\u003dchannel,"},{"line_number":2185,"context_line":"                                             mode\u003d\u0027secure\u0027))"},{"line_number":2186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fb50e512_68f8a2b0","line":2183,"in_reply_to":"3f305106_df4b6232","updated":"2024-08-12 10:51:04.000000000","message":"I think this list is effectively fixed at this point. It hasn\u0027t changed in a long time, and clients would need to know about new channels if they were added.","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"db41ed0003b227d4089de64d3b1b562ab43ae0b7","unresolved":false,"context_lines":[{"line_number":2180,"context_line":"                    \u0027streaming\u0027, mode\u003dself.streaming_mode))"},{"line_number":2181,"context_line":"            if self.secure:"},{"line_number":2182,"context_line":"                for channel in [\u0027main\u0027, \u0027display\u0027, \u0027inputs\u0027, \u0027cursor\u0027,"},{"line_number":2183,"context_line":"                                \u0027playback\u0027, \u0027record\u0027, \u0027smartcard\u0027, \u0027usbredir\u0027]:"},{"line_number":2184,"context_line":"                    dev.append(etree.Element(\u0027channel\u0027, name\u003dchannel,"},{"line_number":2185,"context_line":"                                             mode\u003d\u0027secure\u0027))"},{"line_number":2186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"04cc786b_18978156","line":2183,"in_reply_to":"fb50e512_68f8a2b0","updated":"2024-08-12 11:26:20.000000000","message":"Ack this was why i was +1 and not +2 by the way i wanted to ensure this would not be an upgrade impact or break with new releases.\n\nlooking at \nhttps://libvirt.org/formatdomain.html#graphical-framebuffers\n\nwe see spice support in general was added in 0.8.6\nValid channel names include main, display, inputs, cursor, playback, record (all since 0.8.6 ); smartcard ( since 0.8.8 ); and usbredir ( since 0.9.12 ).\n\nnova current min libvirt requirement is 7.0.0\nhttps://github.com/openstack/nova/blob/7399728e8937c31b7e92ed8fa7f9ce860c9a3b9f/nova/virt/libvirt/driver.py#L219\nso i agree we do not need to have any kind of version check here and we can proceed with this hardcoded list.","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"}],"releasenotes/notes/spice-direct-consoles-4bee40633633c971.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"60efc6d2c289c2db49fd787dd295a30d5f8975aa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release adds a new flag require_secure to the spice configuration"},{"line_number":5,"context_line":"    group. Defaulting to false to match the previous behavior, if set to"},{"line_number":6,"context_line":"    true the SPICE consoles will require TLS protected connections."},{"line_number":7,"context_line":"    Unencrypted connections will be gracefully redirected to the TLS port"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0b4730aa_009cfeb8","line":4,"updated":"2024-08-09 02:18:58.000000000","message":"nit: adds a new config option.","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f0d7d25edc98598a41f79cff9716ce4d5b60427","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release adds a new flag require_secure to the spice configuration"},{"line_number":5,"context_line":"    group. Defaulting to false to match the previous behavior, if set to"},{"line_number":6,"context_line":"    true the SPICE consoles will require TLS protected connections."},{"line_number":7,"context_line":"    Unencrypted connections will be gracefully redirected to the TLS port"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4eef20a2_9385b8c6","line":4,"in_reply_to":"0a199519_0dd3818e","updated":"2024-08-13 09:11:00.000000000","message":"Done","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"309eb8416d8a9c9ce5c3d5a2c33d69893c2d8484","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release adds a new flag require_secure to the spice configuration"},{"line_number":5,"context_line":"    group. Defaulting to false to match the previous behavior, if set to"},{"line_number":6,"context_line":"    true the SPICE consoles will require TLS protected connections."},{"line_number":7,"context_line":"    Unencrypted connections will be gracefully redirected to the TLS port"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"38758630_b4ecc0a6","line":4,"in_reply_to":"0b4730aa_009cfeb8","updated":"2024-08-12 10:51:04.000000000","message":"I\u0027m happy to tweak this, do you have an example of what you consider a \"good\" similar entry?","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"db41ed0003b227d4089de64d3b1b562ab43ae0b7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release adds a new flag require_secure to the spice configuration"},{"line_number":5,"context_line":"    group. Defaulting to false to match the previous behavior, if set to"},{"line_number":6,"context_line":"    true the SPICE consoles will require TLS protected connections."},{"line_number":7,"context_line":"    Unencrypted connections will be gracefully redirected to the TLS port"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0a199519_0dd3818e","line":4,"in_reply_to":"38758630_b4ecc0a6","updated":"2024-08-12 11:26:20.000000000","message":"its not wrong i just prefer not to use the term flag and instead use the term \"config option\" instead when referring to config options being explicit\n\n\nflag could mane cli argument, flavour extra spec, image property ectra so i just try to be explicit here.\n\nyou have disambiguated it by saying spice configuration group later which is why i considered it a nit.","commit_id":"981d6f20a3dcddea66962e3c934c84b51deadfdc"}]}