)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6149555a2e50f93b32fad8bd40a65565f12b352d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecaed912_07a12dd3","updated":"2024-07-02 14:15:05.000000000","message":"This was pre-approved as part of the embargo process for security bug 2059809","commit_id":"0b0edae94fbc1057d94fe64745125270659e4ca1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6d9867b84386ac73455e62c081d24a19b526e0af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b977cc7e_f4287752","updated":"2024-07-03 08:16:53.000000000","message":"recheck b/c of dependent change failed","commit_id":"b1b88bf001757546fbbea959f4b73cb344407dfb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1ae6243c45052c95f1086b496310531f2b219085","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38a4810f_6929487e","updated":"2024-07-03 11:17:55.000000000","message":"recheck first patch failed","commit_id":"b1b88bf001757546fbbea959f4b73cb344407dfb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a95949abacf0ea716b7f83ef4b8b7cb19fcb50f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9577b323_7cd06ed9","updated":"2024-07-03 01:46:03.000000000","message":"recheck messaging timeout in grenade again, but different test/scenario","commit_id":"b1b88bf001757546fbbea959f4b73cb344407dfb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"62303c92acd6ef9192fe86f427f760ea712f5b54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1e5cbce_9c631566","updated":"2024-07-02 23:20:00.000000000","message":"recheck messagingtimeout in grenade job","commit_id":"b1b88bf001757546fbbea959f4b73cb344407dfb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"af08b63114d5c23454031ada3dc30dc33fa6ad9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"832a87c5_d50ff20d","updated":"2024-07-03 18:16:52.000000000","message":"recheck same new-defaults timeout we keep seeing","commit_id":"b1b88bf001757546fbbea959f4b73cb344407dfb"}],"nova/image/format_inspector.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e2ecaf66c07ec61c25fdb5d273e7ddee328b4500","unresolved":true,"context_lines":[{"line_number":363,"context_line":"        return \u0027qcow2\u0027"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def safety_check(self):"},{"line_number":366,"context_line":"        return (not self.has_backing_file and"},{"line_number":367,"context_line":"                not self.has_data_file and"},{"line_number":368,"context_line":"                not self.has_unknown_features)"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bedfb5a8_63c864ec","line":366,"updated":"2024-07-02 14:35:03.000000000","message":"note for later if we ever want to support thing snapshots instead of the fat one we fcurrently do this will need to be revisited.\n\nbut given the security implications of that im inclidne to say this is just one more reason not to supprot thin snapshots.","commit_id":"0b0edae94fbc1057d94fe64745125270659e4ca1"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e2ecaf66c07ec61c25fdb5d273e7ddee328b4500","unresolved":true,"context_lines":[{"line_number":687,"context_line":"                # by qemu_img_info() if the disk format was unreadable or"},{"line_number":688,"context_line":"                # otherwise unsuitable."},{"line_number":689,"context_line":"                raise exception.InvalidDiskInfo("},{"line_number":690,"context_line":"                    reason\u003d_(\u0027Base image failed safety check\u0027))"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        # NOTE(ankit): Update the mtime of the base file so the image"},{"line_number":693,"context_line":"        # cache manager knows it is in use."}],"source_content_type":"text/x-python","patch_set":1,"id":"1cbfff40_a1701e29","line":690,"updated":"2024-07-02 14:35:03.000000000","message":"what you are doing here is more indept but we shoudl have been at lest checking this with file in the past.\n\n\n[stack@c9s-devstack ~]$ qemu-img convert -f qcow2 -O raw bad.qcow2 converted.raw\n[stack@c9s-devstack ~]$ file converted.raw \nconverted.raw: ASCII text\n[stack@c9s-devstack ~]$ cp bad.qcow2 bad.raw\n[stack@c9s-devstack ~]$ file bad.qcow2 \nbad.qcow2: QEMU QCOW2 Image (v3), 1073741824 bytes\n[stack@c9s-devstack ~]$ file bad.raw \nbad.raw: QEMU QCOW2 Image (v3), 1073741824 bytes\n\n+1 to actully validating the format and not trusting that glance did it.","commit_id":"0b0edae94fbc1057d94fe64745125270659e4ca1"}]}