)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"69d4f8ea567fc456eb8f8d7f1ca6102d360abe85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"159b9aa5_a9c5e26f","updated":"2024-07-04 16:10:25.000000000","message":"Appears to reproduce the issue, so looks good to me. We might want to hold off merging until we see the fix and make sure all that is required in the follow-on patch is to remove the `assertRaises`","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c5acc58f327e71c3ef6abd5cd2a2e1a7711566d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77a4a81e_153d3eb6","updated":"2024-07-04 16:21:33.000000000","message":"just a small nit but overall looks good.","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdc56e338d4c45dbaee512665c4a92ef797795f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"39e972bc_c87c7b54","in_reply_to":"159b9aa5_a9c5e26f","updated":"2024-07-05 00:58:47.000000000","message":"yep let hold this till we are happy with the rest of the follwo up patch.","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"}],"nova/tests/unit/image/test_format_inspector.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c5acc58f327e71c3ef6abd5cd2a2e1a7711566d","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        size \u003d image_size // units.Mi"},{"line_number":67,"context_line":"        base_cmd \u003d \"mkisofs\""},{"line_number":68,"context_line":"        if subformat \u003d\u003d \u0027udf\u0027:"},{"line_number":69,"context_line":"            # mkisofs does not support UDF, so we use genisoimage"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                subprocess.check_output("},{"line_number":72,"context_line":"                    \u0027mkisofs --help 2\u003e\u00261 | grep udf\u0027, shell\u003dTrue)"},{"line_number":73,"context_line":"            except Exception:"},{"line_number":74,"context_line":"                self.skipTest(\u0027mkisofs does not support udf format\u0027)"},{"line_number":75,"context_line":"            base_cmd +\u003d \" -udf\""}],"source_content_type":"text/x-python","patch_set":1,"id":"b5b57913_842b8b8b","line":72,"range":{"start_line":69,"start_character":0,"end_line":72,"end_character":65},"updated":"2024-07-04 16:21:33.000000000","message":"nit: the comment is not aligned with the code as we don\u0027t use genisoimage.","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdc56e338d4c45dbaee512665c4a92ef797795f3","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        size \u003d image_size // units.Mi"},{"line_number":67,"context_line":"        base_cmd \u003d \"mkisofs\""},{"line_number":68,"context_line":"        if subformat \u003d\u003d \u0027udf\u0027:"},{"line_number":69,"context_line":"            # mkisofs does not support UDF, so we use genisoimage"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                subprocess.check_output("},{"line_number":72,"context_line":"                    \u0027mkisofs --help 2\u003e\u00261 | grep udf\u0027, shell\u003dTrue)"},{"line_number":73,"context_line":"            except Exception:"},{"line_number":74,"context_line":"                self.skipTest(\u0027mkisofs does not support udf format\u0027)"},{"line_number":75,"context_line":"            base_cmd +\u003d \" -udf\""}],"source_content_type":"text/x-python","patch_set":1,"id":"f03b93b1_310aa515","line":72,"range":{"start_line":69,"start_character":0,"end_line":72,"end_character":65},"in_reply_to":"b5b57913_842b8b8b","updated":"2024-07-05 00:58:47.000000000","message":"actully we do depending on your distro but your right.\n\nmkisofs on my system is actually genisoimage but\nthe comemnt is also still incorrect \n\ni orginally tought mkisofs didnt supprot UDF but that was because\ni did not have `2\u003e\u00261`\n\ni dont know why the help prints to stderr but it does.","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b95c81f8f7ee720196441e940401091b8c05459","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        size \u003d image_size // units.Mi"},{"line_number":67,"context_line":"        base_cmd \u003d \"mkisofs\""},{"line_number":68,"context_line":"        if subformat \u003d\u003d \u0027udf\u0027:"},{"line_number":69,"context_line":"            # mkisofs does not support UDF, so we use genisoimage"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                subprocess.check_output("},{"line_number":72,"context_line":"                    \u0027mkisofs --help 2\u003e\u00261 | grep udf\u0027, shell\u003dTrue)"},{"line_number":73,"context_line":"            except Exception:"},{"line_number":74,"context_line":"                self.skipTest(\u0027mkisofs does not support udf format\u0027)"},{"line_number":75,"context_line":"            base_cmd +\u003d \" -udf\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ef3da4ef_66bc8e68","line":72,"range":{"start_line":69,"start_character":0,"end_line":72,"end_character":65},"in_reply_to":"f03b93b1_310aa515","updated":"2024-07-08 12:03:12.000000000","message":"Done","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"69d4f8ea567fc456eb8f8d7f1ca6102d360abe85","unresolved":true,"context_lines":[{"line_number":207,"context_line":"    def test_iso_9660(self):"},{"line_number":208,"context_line":"        # reproduce iso-9660 format regression"},{"line_number":209,"context_line":"        self.assertRaises("},{"line_number":210,"context_line":"            TypeError, self._test_format, \u0027iso\u0027, subformat\u003d\u0027iso-9660\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_udf(self):"},{"line_number":213,"context_line":"        # reproduce udf format regression"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a7eae5d_e126e638","line":210,"range":{"start_line":210,"start_character":12,"end_line":210,"end_character":21},"updated":"2024-07-04 16:10:25.000000000","message":"I assume because we\u0027re doing `None.safety_check()` ?","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdc56e338d4c45dbaee512665c4a92ef797795f3","unresolved":true,"context_lines":[{"line_number":207,"context_line":"    def test_iso_9660(self):"},{"line_number":208,"context_line":"        # reproduce iso-9660 format regression"},{"line_number":209,"context_line":"        self.assertRaises("},{"line_number":210,"context_line":"            TypeError, self._test_format, \u0027iso\u0027, subformat\u003d\u0027iso-9660\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_udf(self):"},{"line_number":213,"context_line":"        # reproduce udf format regression"}],"source_content_type":"text/x-python","patch_set":1,"id":"6fbdf993_97aeca18","line":210,"range":{"start_line":210,"start_character":12,"end_line":210,"end_character":21},"in_reply_to":"6a7eae5d_e126e638","updated":"2024-07-05 00:58:47.000000000","message":"get_inspector(\u0027iso\u0027) returned non and then we called a function on that i belive i would have to double check but ill do that tommorow and let you know.","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b95c81f8f7ee720196441e940401091b8c05459","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def test_iso_9660(self):"},{"line_number":208,"context_line":"        # reproduce iso-9660 format regression"},{"line_number":209,"context_line":"        self.assertRaises("},{"line_number":210,"context_line":"            TypeError, self._test_format, \u0027iso\u0027, subformat\u003d\u0027iso-9660\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_udf(self):"},{"line_number":213,"context_line":"        # reproduce udf format regression"}],"source_content_type":"text/x-python","patch_set":1,"id":"83d38f6a_973de532","line":210,"range":{"start_line":210,"start_character":12,"end_line":210,"end_character":21},"in_reply_to":"6fbdf993_97aeca18","updated":"2024-07-08 12:03:12.000000000","message":"Acknowledged","commit_id":"beba2d79383bb901512a8d5a9737b7679637f6c2"}]}