)]}'
{"id":"openstack%2Fnova~923722","triplet_id":"openstack%2Fnova~stable%2F2024.1~Ia34203f246f0bc574e11476287dfb33fda7954fe","project":"openstack/nova","branch":"stable/2024.1","topic":"format-inspector","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2024-07-11 14:01:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia34203f246f0bc574e11476287dfb33fda7954fe","subject":"port format inspector tests from glance","status":"MERGED","created":"2024-07-09 09:41:58.000000000","updated":"2024-07-11 14:03:19.000000000","submitted":"2024-07-11 14:01:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"923722-format-inspector","meta_rev_id":"ba6044019af2dcb6c7d821fd5b5e92afb85dd5e7","_number":923722,"virtual_id_number":923722,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-07-11 14:01:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2024-07-11 11:58:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2024-07-09 11:40:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2024-07-11 11:58:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-09 09:47:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-09 10:12:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-09 11:40:50.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2024-07-11 11:58:46.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"e6e2a92859e16af95dedfcbb9b3cb36dc83b2002","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-07-09 09:41:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8f141fa89c200c458166d2f7fb69b16f87d173a3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 09:47:02.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/161cb99e770d4e7588db4c40520ed6fb\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/94617d2545fa49c098800f45a28a3465 : FAILURE in 3m 37s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/7c0e8e8b1b0c4cd0ae0a2644667887fb : FAILURE in 3m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e0c9cc70f7c575a8b873e668c6a3497093ee2d81","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 10:12:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9604711ce44b4b5d98b2d3ba92f454b9\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ed2fea095af8487d904f3ccc14102aa5 : SUCCESS in 22m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef1f20c1b390420d8e5d4ea6479905f8 : SUCCESS in 7m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/da6e9028775b4260a4c04c58d1580d41 : SUCCESS in 13m 12s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2d8d0c8b6bf14925a7fddce73df9199b : SUCCESS in 11m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5b03507607b24f71b051443da7812bd7 : SUCCESS in 9m 49s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/afffc1358d6c4eb79d375e0ab7b64f45 : SUCCESS in 4m 50s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/3013712e1d01448dac4591f4c2b119c3 : SUCCESS in 24m 28s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a5788b892c1a491584e8311a723c99d3 : SUCCESS in 25m 50s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/a4894d6309fb4df8b2ff58b6a3319846 : SUCCESS in 25m 23s","accounts_in_message":[],"_revision_number":1},{"id":"df5fe839d8aad4021a998f15fa0263729634e9a2","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-07-09 11:40:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c497b46b80fae8a7d3ab6ce10da586b297fba536","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-07-11 11:58:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ad03d79b7ce1a7945d28940b3694d2054502b6d3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-11 11:59:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cc471fb6d2eeccfc96436a28491bfe844f779a92","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-11 14:01:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0286f803e5584f7e8fcf58d825d21f66\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1fc645a1c6a54d2597753b1f3d5048b1 : SUCCESS in 7m 33s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5fd21acec8d14d4bba5384e3921523dc : SUCCESS in 13m 05s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/d2fed697a5df43e5850ca8c7de6c0fc4 : SUCCESS in 12m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/014c6efe574b4bf1bf048e7573ce2f37 : SUCCESS in 11m 09s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/00a5c36629bc44879603333d6d3e3917 : SUCCESS in 24m 41s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/6e4755ba9cb34cd78ecbe0447370fadc : SUCCESS in 23m 07s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/8bfc6aa0c8674f9eb401332913482c6a : SUCCESS in 25m 35s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/48de8ff8690c4033bc0e1d5b6c237250 : SUCCESS in 5m 21s","accounts_in_message":[],"_revision_number":1},{"id":"36dd82a742d048692fb3b645175bd8f95581fe6f","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-11 14:01:50.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"ba6044019af2dcb6c7d821fd5b5e92afb85dd5e7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-11 14:03:19.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a3df851bb0e3455a963e67c269debe87\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a13875f789b84a129ab5c68186a83aa9 : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"66205be426028f8b7d16163ca6901bc181d703b6","revisions":{"66205be426028f8b7d16163ca6901bc181d703b6":{"kind":"REWORK","_number":1,"created":"2024-07-09 09:41:58.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/22/923722/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/22/923722/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/923722/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/923722/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/923722/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/22/923722/1"}}},"commit":{"parents":[{"commit":"8459a6af900d975c56179bd7643a052c51c4cf15","subject":"Merge \"retry write_sys call on device busy\" into stable/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8459a6af900d975c56179bd7643a052c51c4cf15"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-04 11:38:39.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-09 09:40:36.000000000","tz":60},"subject":"port format inspector tests from glance","message":"port format inspector tests from glance\n\nThis commit is a direct port of the format inspector\nunit tests from glance as of commit\n0d8e79b713bc31a78f0f4eac14ee594ca8520999\n\nthe only changes to the test are as follows\n\n\"from glance.common import format_inspector\" was updated to\n\"from nova.image import format_inspector\"\n\n\"from glance.tests import utils as test_utils\"\nwas replaced with \"from nova import test\"\n\n\"test_utils.BaseTestCase\" was replaced with \"test.NoDBTestCase\"\n\n\"glance-unittest-formatinspector-\" was replaced with\n\"nova-unittest-formatinspector-\"\n\nThis makes the test funtional in nova.\n\nTestFormatInspectors requries qemu-img to be installed on the\nhost which would be a new depency for executing unit tests.\nto avoid that we skip TestFormatInspectors if qemu-img\nis not installed.\nTestFormatInspectorInfra and TestFormatInspectorsTargeted\ndo not have a qemu-img dependency so\nno changes to the test assertions were required.\n\nChange-Id: Ia34203f246f0bc574e11476287dfb33fda7954fe\n(cherry picked from commit 838daa3cad5fb3cdd10fb7aa76c647330a66939e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/66205be426028f8b7d16163ca6901bc181d703b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/66205be426028f8b7d16163ca6901bc181d703b6"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}