)]}'
{"id":"openstack%2Fnova~923727","triplet_id":"openstack%2Fnova~stable%2F2023.2~Ia34203f246f0bc574e11476287dfb33fda7954fe","project":"openstack/nova","branch":"stable/2023.2","topic":"format-inspector","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2024-07-12 10:27:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia34203f246f0bc574e11476287dfb33fda7954fe","subject":"port format inspector tests from glance","status":"MERGED","created":"2024-07-09 10:37:32.000000000","updated":"2024-07-12 10:28:25.000000000","submitted":"2024-07-12 10:27:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"923727-format-inspector","meta_rev_id":"6e45637916df03c8d7b6b56d52d4c21ec70244fc","_number":923727,"virtual_id_number":923727,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-07-12 10:27:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2024-07-12 07:20:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2024-07-09 11:42:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2024-07-12 07:20:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-09 11:05:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-09 11:42:56.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2024-07-12 07:20:20.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2024-07-12 09:53:33.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"7670d4eb0b3fe31712a99fcbd9e65ff338dd429d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-07-09 10:37:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3cfb5cf1bb5d374e7a8de7d5d6b621225d1fca72","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 11:05:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d5d23511588e4ab99a58388a0905fa6e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c3cbfb7c949d48a4a4c1425f7c0fd280 : SUCCESS in 18m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9325056fe4c74339b6c75bbed987faaf : SUCCESS in 10m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/47c231fcc6314160a4373f197048f89b : SUCCESS in 16m 22s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5b0d6a0d34c648e3924c557160a9a294 : SUCCESS in 12m 30s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c57a28532e2f4c5ca076cbbaadc5250e : SUCCESS in 13m 44s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/3dd525a890094eb79b4454d5b2505745 : SUCCESS in 13m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/78c4bd2d1bb24176a110caf2e3a36f75 : SUCCESS in 10m 19s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/392672eae68043c493a85db3a27316cd : FAILURE in 4m 39s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1dd2549886be43529d9f8288a6652327 : SUCCESS in 26m 11s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d23f91db8c774bbcb281db49ddde0473 : SUCCESS in 23m 06s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/645a7c0f88e546afba97b3a258eb70d0 : SUCCESS in 25m 40s","accounts_in_message":[],"_revision_number":1},{"id":"7fb884dff1aa188e6892408d6077e79b0d162d05","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 11:09:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1796293f6b844d53970b81ad9d8d51e3\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/639af753f45f476da1bb537aeda7f519 : FAILURE in 4m 59s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/4f37941ae9184eb9bbba341ba84785ac : FAILURE in 4m 38s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/da5eb52cf02a4bc28362418e125cd2c1 : SUCCESS in 30m 32s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/942dab2da6244754af1209e38cb876ed : FAILURE in 4m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e383630fb2e53f986da38b34f1804c5286ace49d","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-07-09 11:42:56.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d2cbe8bd3b236e3496d63eae2dfdb480ca715ec6","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-07-12 07:20:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"07053227711d49e8ceaa3a946b80e202cf038f69","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 07:20:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"228e0aa0d440c55f45ff59839b59fb138cc3fda5","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-07-12 09:53:33.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-923727-mcb5k/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"92dcb8751acd4822c2f408818666c7131a03826b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 10:27:07.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/86fcce4c38d44ed1888376c52e5086e8\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b9116bcdf4fc435b85b6c9b3b85c4b4c : SUCCESS in 9m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/db1d737e5084499ca4e9257c12d71955 : SUCCESS in 11m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ffe9c06435e24abbbd8d584ea4e0a191 : SUCCESS in 13m 40s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/8865ac7dc4b942ea8ddedfd5744158d4 : SUCCESS in 14m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39f228fbf8ef407f8398096a6034ac11 : SUCCESS in 10m 19s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/96e134e0a58045e2bb6330cdff5cd3a8 : SUCCESS in 23m 16s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/9263cd71879c466490b856a8e785277a : SUCCESS in 22m 29s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/1ee28d5f98ed4dfdbe2302ac65fc8993 : SUCCESS in 26m 23s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/c62df2f840ff46f6a901a33a071a3a52 : SUCCESS in 5m 33s","accounts_in_message":[],"_revision_number":1},{"id":"5f49b393e1ce5b4f3d3aa3aa7ec2d09c1dadd34b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 10:27:07.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"6e45637916df03c8d7b6b56d52d4c21ec70244fc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 10:28:25.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/37fe0c70f10a40d18072b7d26dbb2b8f\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/90b2ebe087484f7893da81a88214d10c : SUCCESS in 53s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"497abea5a189cc7043766273e9d17571f722190a","revisions":{"497abea5a189cc7043766273e9d17571f722190a":{"kind":"REWORK","_number":1,"created":"2024-07-09 10:37:32.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/27/923727/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/27/923727/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/27/923727/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/27/923727/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/27/923727/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/27/923727/1"}}},"commit":{"parents":[{"commit":"70a435fd519a0ebcc3ac9ad5254fefbf19c93e48","subject":"Fix vmdk_allowed_types checking","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/70a435fd519a0ebcc3ac9ad5254fefbf19c93e48"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-04 11:38:39.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-09 10:37:04.000000000","tz":60},"subject":"port format inspector tests from glance","message":"port format inspector tests from glance\n\nThis commit is a direct port of the format inspector\nunit tests from glance as of commit\n0d8e79b713bc31a78f0f4eac14ee594ca8520999\n\nthe only changes to the test are as follows\n\n\"from glance.common import format_inspector\" was updated to\n\"from nova.image import format_inspector\"\n\n\"from glance.tests import utils as test_utils\"\nwas replaced with \"from nova import test\"\n\n\"test_utils.BaseTestCase\" was replaced with \"test.NoDBTestCase\"\n\n\"glance-unittest-formatinspector-\" was replaced with\n\"nova-unittest-formatinspector-\"\n\nThis makes the test funtional in nova.\n\nTestFormatInspectors requries qemu-img to be installed on the\nhost which would be a new depency for executing unit tests.\nto avoid that we skip TestFormatInspectors if qemu-img\nis not installed.\nTestFormatInspectorInfra and TestFormatInspectorsTargeted\ndo not have a qemu-img dependency so\nno changes to the test assertions were required.\n\nChange-Id: Ia34203f246f0bc574e11476287dfb33fda7954fe\n(cherry picked from commit 838daa3cad5fb3cdd10fb7aa76c647330a66939e)\n(cherry picked from commit 66205be426028f8b7d16163ca6901bc181d703b6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/497abea5a189cc7043766273e9d17571f722190a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/497abea5a189cc7043766273e9d17571f722190a"}]},"branch":"refs/heads/stable/2023.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}