)]}'
{"id":"openstack%2Fnova~923731","triplet_id":"openstack%2Fnova~stable%2F2023.1~Ia34203f246f0bc574e11476287dfb33fda7954fe","project":"openstack/nova","branch":"stable/2023.1","topic":"format-inspector","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2024-07-12 11:20:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia34203f246f0bc574e11476287dfb33fda7954fe","subject":"port format inspector tests from glance","status":"MERGED","created":"2024-07-09 10:38:36.000000000","updated":"2024-07-12 11:22:16.000000000","submitted":"2024-07-12 11:20:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"923731-format-inspector","meta_rev_id":"0a26e4f41178d0d7d3dd380c318403e9c6082cd2","_number":923731,"virtual_id_number":923731,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-07-12 11:20:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2024-07-12 10:33:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2024-07-09 11:44:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2024-07-12 10:33:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-09 11:08:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-09 11:13:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-09 11:44:32.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2024-07-11 20:50:55.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-12 10:33:24.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"5a139cfbaefe6145f9380c053a096fff2f9438ce","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-07-09 10:38:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2a74361058589e71ae06dfec5dcae8786d0fb46","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 11:08:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/db31818bf8e0447d8213359d7749b2ad\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/2b7f1a4684d54afaa6281f061f5167eb : SUCCESS in 28m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4dcebeaa400edd3249153e2eeaa2243cf3718c34","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 11:13:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c0c0d032abb54841ae07b986663a17a2\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/93280772d74d476c800db75f4225a42b : SUCCESS in 17m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f56e4f3c8bb744a0ad6f2a09a0ec857e : SUCCESS in 11m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8ae9cbdfdf8c4668a6d64bb05a42b394 : SUCCESS in 13m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2d585c9597c14f7da70f636604bd50ad : SUCCESS in 10m 06s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/3baf08edcd6b4ab1b27b051c2cd99e59 : FAILURE in 4m 27s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5229822416234628b092832dd2e68c49 : SUCCESS in 23m 29s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a66455fa6cd3477f86c8ba324d9969f7 : SUCCESS in 26m 28s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/d0e8765c046840a986e25ce35e4a7960 : SUCCESS in 26m 13s","accounts_in_message":[],"_revision_number":1},{"id":"8bf06c2dca31b1068a810337c16689784723a7f9","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-07-09 11:44:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"78bbf46fe19319ffe8050e797178358b4548f0e3","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-07-11 20:50:55.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-923731-5wm2t/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"78c7237dcbbf69c022abd5cd427d2eb46079a697","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-07-12 10:33:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c8cdf3e66c8b2839b93ed11c5a2806dc0c5fae4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 10:33:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6e8bff7c4f97c0433c3c3ee187b3753f936d5b73","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 11:20:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/df423dd614004133b7da6fa524aceee3\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/29d37448c0fd4b5eb1e5b4325f4feb57 : SUCCESS in 9m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fd3e3392c5d2454cb606b6a3a49fe36c : SUCCESS in 13m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/32abc97eadc34a999fea0abe93cac42e : SUCCESS in 9m 58s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/166ff4a287314fe19cc652b18d21483a : SUCCESS in 25m 40s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/212ebac25af44203a22a62c855b58def : SUCCESS in 23m 54s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/b6f38b19fa98487cafc41576fe84a9ce : SUCCESS in 4m 44s","accounts_in_message":[],"_revision_number":1},{"id":"6f05dbe7b22e439f879f5a1544c5b49ef53edf9e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 11:20:52.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"0a26e4f41178d0d7d3dd380c318403e9c6082cd2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 11:22:16.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a2ca87be710649a7b04ef8d1f18f8452\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ca069155d794f5ca3bc8b4346590ac2 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"58cd955c7d4848ed8da71f3c0352a5303cae6200","revisions":{"58cd955c7d4848ed8da71f3c0352a5303cae6200":{"kind":"REWORK","_number":1,"created":"2024-07-09 10:38:36.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/31/923731/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/31/923731/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/31/923731/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/31/923731/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/31/923731/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/31/923731/1"}}},"commit":{"parents":[{"commit":"f732f8476851e6272d8ad9937f54b918795844e8","subject":"Fix vmdk_allowed_types checking","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f732f8476851e6272d8ad9937f54b918795844e8"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-04 11:38:39.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-09 10:38:14.000000000","tz":60},"subject":"port format inspector tests from glance","message":"port format inspector tests from glance\n\nThis commit is a direct port of the format inspector\nunit tests from glance as of commit\n0d8e79b713bc31a78f0f4eac14ee594ca8520999\n\nthe only changes to the test are as follows\n\n\"from glance.common import format_inspector\" was updated to\n\"from nova.image import format_inspector\"\n\n\"from glance.tests import utils as test_utils\"\nwas replaced with \"from nova import test\"\n\n\"test_utils.BaseTestCase\" was replaced with \"test.NoDBTestCase\"\n\n\"glance-unittest-formatinspector-\" was replaced with\n\"nova-unittest-formatinspector-\"\n\nThis makes the test funtional in nova.\n\nTestFormatInspectors requries qemu-img to be installed on the\nhost which would be a new depency for executing unit tests.\nto avoid that we skip TestFormatInspectors if qemu-img\nis not installed.\nTestFormatInspectorInfra and TestFormatInspectorsTargeted\ndo not have a qemu-img dependency so\nno changes to the test assertions were required.\n\nChange-Id: Ia34203f246f0bc574e11476287dfb33fda7954fe\n(cherry picked from commit 838daa3cad5fb3cdd10fb7aa76c647330a66939e)\n(cherry picked from commit 66205be426028f8b7d16163ca6901bc181d703b6)\n(cherry picked from commit 497abea5a189cc7043766273e9d17571f722190a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58cd955c7d4848ed8da71f3c0352a5303cae6200"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58cd955c7d4848ed8da71f3c0352a5303cae6200"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}