)]}'
{"id":"openstack%2Fnova~923733","triplet_id":"openstack%2Fnova~stable%2F2023.1~I7e12718fb3e1f77eb8d1cfcb9fa64e8ddeb9e712","project":"openstack/nova","branch":"stable/2023.1","topic":"format-inspector","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2024-07-12 18:16:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7e12718fb3e1f77eb8d1cfcb9fa64e8ddeb9e712","subject":"Add iso file format inspector","status":"MERGED","created":"2024-07-09 10:38:36.000000000","updated":"2024-07-12 18:18:38.000000000","submitted":"2024-07-12 18:16:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"923733-format-inspector","meta_rev_id":"ef510c1bfdce22153cbe4955480fe793025aceff","_number":923733,"virtual_id_number":923733,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-07-12 18:16:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2024-07-12 15:42:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2024-07-09 11:44:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2024-07-12 15:42:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-09 11:14:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-09 11:44:52.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2024-07-09 12:44:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-11 20:23:58.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-12 15:42:13.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"e249612702e31f7a19757cb1976d3490ec3fcde0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-07-09 10:38:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6e148151083b4365b991a390819e0e0547083a56","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 11:14:50.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7baeb9db7c4a47d6aaf9e230703ccc1a\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/bfeb9cd9562e4ed3ab5b0efb51f58ac4 : SUCCESS in 33m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b70c428d95da3e83d2a84ede90806bde8882e53d","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-07-09 11:44:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"68aeb4f4ba8f5afdc99933f31c24823bd8c15a11","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 12:44:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d6c880ad9d5f4cdf8d4bcd5f121e5fef\n\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/89005aa519e04cf8aedb76b477d3fe14 : SUCCESS in 53m 22s (non-voting)\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/a24f69e218d54be2bb3291a7ca4a6cbf : SUCCESS in 1h 17m 51s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3b4ab41ab7b844a2ac8d91d7ce2b6255 : SUCCESS in 53m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0024b46fd7d4403bb2f2b75208d152c0 : SUCCESS in 16m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9d5eea62ba9f4965a70f36778c3b58b4 : SUCCESS in 8m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/45e3522b29cf4b0889179f9fc7598110 : SUCCESS in 11m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4d9a34e35dc74ab683ac06948f80f4e3 : SUCCESS in 8m 54s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/180882603fea4aeeba3ba42f87374ad4 : SUCCESS in 1h 02m 52s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/d87bdb0d75b44109b064cbaa6f284617 : SUCCESS in 1h 59m 27s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e3881345a696434398c088025bd33856 : SUCCESS in 43m 55s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/8528f1ffabc94fbda5fca436aebc2b23 : SUCCESS in 51m 21s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/da43f90ea8ca42b09c823299c596b769 : SUCCESS in 1h 25m 41s\n- nova-next https://zuul.opendev.org/t/openstack/build/73046c17927746e38a0418e853e8ae30 : SUCCESS in 1h 54m 16s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/9ef4b37bc8524184b8e6d743316ba3b9 : SUCCESS in 57m 35s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/ddf54ec9625f4cf59fdba8898deb4390 : FAILURE in 4m 27s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1b14dfc5c1ad45b89384d6ae85250609 : SUCCESS in 26m 06s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/f5dc4d870f9349a784eadaf15323fefd : SUCCESS in 23m 54s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/886de8981527481a9d0fa19ed20cbf86 : SUCCESS in 22m 35s\n- tempest-integrated-compute-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fe5a194857b14ad9a0168c28df1c51be : SUCCESS in 1h 14m 28s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/ee6385b85ad1490ab302774b197345b1 : SUCCESS in 1h 27m 10s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a785e16b3c61465b9603db23440f5624 : SUCCESS in 1h 14m 44s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/576dab242b9b4f118d4e8d58f6f946a2 : SUCCESS in 39m 32s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/9a9342e3accc45eba371e36f96639959 : SUCCESS in 33m 37s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/adc7cebd71074393b062250bbb941a55 : SUCCESS in 37m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cff54506c15baff67e0a2f6ea365023a1a204ebb","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-07-11 20:23:58.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-923733-wcq67/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"a88200e04707f4a66d638c6156a98eee1cf3ec53","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-07-12 15:42:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dc2c85d5a9363c2315495e50e8c2b555ee5ce319","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 15:42:57.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f8d73824e2b09d07f7007e10594ce564ddeca220","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 18:16:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/970ab37cce4f4f328544decf410202ef\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0e83860be2024c0daee80688f03d7303 : SUCCESS in 1h 37m 56s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3fd10582bc674fd3ae455af5c4ce5041 : SUCCESS in 1h 00m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/17c0c35579924c9e915c0f0e81f33336 : SUCCESS in 11m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a5798aab33b24157941f189b5fb8f010 : SUCCESS in 14m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a38ccac8ba1248e9875ec6b5198329cf : SUCCESS in 11m 26s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/68764b97499d4ebcb931610aaee35fb9 : SUCCESS in 40m 30s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/488a5ac6838c4173a2a4ce701dddc0d0 : SUCCESS in 38m 43s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c43cadf9a348466aaf366a3171de26d1 : SUCCESS in 26m 46s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/af44aaed7679488cb5eadf3d7d26d911 : SUCCESS in 23m 59s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/609a3dbd3fa1413393227547810931ce : SUCCESS in 1h 55m 48s\n- nova-next https://zuul.opendev.org/t/openstack/build/36430c531301460082857a31d70e8626 : SUCCESS in 1h 31m 33s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/d79c50a9caac4b22a90114d782a22bc6 : SUCCESS in 5m 07s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/73653c4e42ec4beea4c6abd0fa10651d : SUCCESS in 1h 44m 18s\n- tempest-integrated-compute-ubuntu-focal https://zuul.opendev.org/t/openstack/build/063289d323e444e189e296311b4429a8 : SUCCESS in 1h 37m 32s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/346cdc92d73b43c0811ec1c635db9b10 : SUCCESS in 1h 16m 49s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/14a245e3fdcd40e19bafd533fcf64b9a : SUCCESS in 1h 00m 39s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ce3284eb06d141ae9a4f02b7d4172505 : SUCCESS in 1h 00m 18s","accounts_in_message":[],"_revision_number":1},{"id":"10952993c4fa1708261ed52d914d3fe65dc9f3b8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 18:16:40.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"ef510c1bfdce22153cbe4955480fe793025aceff","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-12 18:18:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b65cfd775fef45299195959be1c0e88e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5a4fac6bc2f74c9bbb3c452238af3f34 : SUCCESS in 1m 25s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"65f0789df05e2ba7f11c0eaf2c6959367acbced2","revisions":{"65f0789df05e2ba7f11c0eaf2c6959367acbced2":{"kind":"REWORK","_number":1,"created":"2024-07-09 10:38:36.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/33/923733/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/923733/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/923733/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/923733/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/923733/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/923733/1"}}},"commit":{"parents":[{"commit":"1233d7b935c018e79728c5691216fa2569affe08","subject":"Reproduce iso regression with deep format inspection","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1233d7b935c018e79728c5691216fa2569affe08"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-04 19:09:31.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-07-09 10:38:24.000000000","tz":60},"subject":"Add iso file format inspector","message":"Add iso file format inspector\n\nThis change includes unit tests for the ISO\nformat inspector using mkisofs to generate\nthe iso files.\n\nA test for stashing qcow content in the system_area\nof an iso file is also included.\n\nThis change modifies format_inspector.detect_file_format\nto evaluate all inspectors until they are complete and\nraise an InvalidDiskInfo exception if multiple formats\nmatch.\n\nRelated-Bug: #2059809\nChange-Id: I7e12718fb3e1f77eb8d1cfcb9fa64e8ddeb9e712\n(cherry picked from commit b1cc39848ebe9b9cb63141a647bda52a2842ee4b)\n(cherry picked from commit eeda7c333c773216c216159926673874ce4843ba)\n(cherry picked from commit 24628ecbbe9d5fdd4fe6767ca92395f0d3da9e48)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/65f0789df05e2ba7f11c0eaf2c6959367acbced2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/65f0789df05e2ba7f11c0eaf2c6959367acbced2"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}