)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fec37b103da3177e6b11ec39497736cd3548b6c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ce29df4_5f65dd05","updated":"2024-07-09 15:36:24.000000000","message":"Can bump to +2 but I think we might want to narrow that exception somewhat.","commit_id":"cc2514d02e0b0ebaf60a46d02732f7f8facc3191"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c42212a475ad89e0b2a824232689eba87de440c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05940b34_e225d116","updated":"2024-07-09 18:02:07.000000000","message":"Looks good. We can do a cleanup of the tests when we move this to oslo","commit_id":"cc2514d02e0b0ebaf60a46d02732f7f8facc3191"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c85dae8f7e45ef99144665dccafa67c74e62b4fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c21efd7f_f4608c93","updated":"2024-07-09 15:48:04.000000000","message":"discussed on IRC","commit_id":"cc2514d02e0b0ebaf60a46d02732f7f8facc3191"}],"nova/tests/unit/image/test_format_inspector.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fec37b103da3177e6b11ec39497736cd3548b6c9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # the help output."},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            subprocess.check_output("},{"line_number":125,"context_line":"                \u0027qemu-img --help | grep %s\u0027 % fmt, shell\u003dTrue)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            self.skipTest("},{"line_number":128,"context_line":"                \u0027qemu-img not installed or does not support %s format\u0027 % fmt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5308982f_ad0ce4c7","line":125,"updated":"2024-07-09 15:36:24.000000000","message":"Not for now, but we should probably avoid passing `shell\u003dTrue` and do the filtering in Python instead","commit_id":"cc2514d02e0b0ebaf60a46d02732f7f8facc3191"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c42212a475ad89e0b2a824232689eba87de440c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # the help output."},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            subprocess.check_output("},{"line_number":125,"context_line":"                \u0027qemu-img --help | grep %s\u0027 % fmt, shell\u003dTrue)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            self.skipTest("},{"line_number":128,"context_line":"                \u0027qemu-img not installed or does not support %s format\u0027 % fmt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0f4ae9a_020ca8bf","line":125,"in_reply_to":"5308982f_ad0ce4c7","updated":"2024-07-09 18:02:07.000000000","message":"I think the better solution would be not to depend on external binary in unit test. But that is for later when we move format_inspector to oslo.","commit_id":"cc2514d02e0b0ebaf60a46d02732f7f8facc3191"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fec37b103da3177e6b11ec39497736cd3548b6c9","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            subprocess.check_output("},{"line_number":125,"context_line":"                \u0027qemu-img --help | grep %s\u0027 % fmt, shell\u003dTrue)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            self.skipTest("},{"line_number":128,"context_line":"                \u0027qemu-img not installed or does not support %s format\u0027 % fmt)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0c06a716_146ceaf6","line":126,"range":{"start_line":126,"start_character":15,"end_line":126,"end_character":24},"updated":"2024-07-09 15:36:24.000000000","message":"```suggestion\n        except subprocess.CalledProcessError:\n```","commit_id":"cc2514d02e0b0ebaf60a46d02732f7f8facc3191"}]}