)]}'
{"id":"openstack%2Fnova~923781","triplet_id":"openstack%2Fnova~master~Icf9882f5f8421b150c308eb2502623f2fcb6cff6","project":"openstack/nova","branch":"master","attention_set":{},"removed_from_attention_set":{"10342":{"account":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"last_update":"2024-07-09 19:11:48.000000000","reason":"Change was submitted"},"1004":{"account":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"last_update":"2024-07-09 19:11:48.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Icf9882f5f8421b150c308eb2502623f2fcb6cff6","subject":"[ironic] Ensure we test iterators when needed","status":"MERGED","created":"2024-07-09 17:51:20.000000000","updated":"2024-07-09 19:12:59.000000000","submitted":"2024-07-09 19:11:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"923781","meta_rev_id":"bd511071ca7a07fb65f309222663bba0722c6d30","_number":923781,"virtual_id_number":923781,"owner":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-07-09 19:11:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2024-07-09 17:56:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2024-07-09 17:56:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"}],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-09 17:54:04.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2024-07-09 17:56:24.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2024-07-09 17:56:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-07-09 18:22:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a5659b8a95d29a97eb2182f3f9ed642bc924604b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2024-07-09 17:51:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"79fc3870ade8ae33a3272764a9ccbc3cec4231d5","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2024-07-09 17:54:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6bf891fff4db175217a3eed696c80ac621c060a0","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-07-09 17:56:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"747840fabc049b83a2fcd8fe7f46be5fa08470c8","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 17:56:46.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/778d942fc66142c3b4ac5bcf28825e0b\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/d9c5a0ca0f1449a2956d0966410bb7bb : FAILURE in 4m 36s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/dbcd5124aa844d578a217a4d90300b41 : FAILURE in 3m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b3421e7057ea9ce8bdb46ef349656f38eee747a8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 18:22:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/76dd43c3b58548819c2c65adfb988222\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f14bef712858403a9a156627b4af8f61 : SUCCESS in 19m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b38e492ccaf847b4821c498f36e28133 : SUCCESS in 7m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0063f231b19f41ce9de730c9b9362697 : SUCCESS in 13m 54s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/96b3efcdf24d414682079732307871a5 : SUCCESS in 9m 54s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/4eef2f91ed4e4583bf08aab8d0b36f34 : SUCCESS in 17m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8398905570884c8bb80b96cf06c8c9cb : SUCCESS in 9m 10s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/b9cf4027d9da4158b4d9ef1d460a1e20 : SUCCESS in 4m 36s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/4d09b4ef3de34c1e941b1a716afa2a75 : SUCCESS in 26m 12s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/ded645f15c6845ccb153da0b60f01b69 : SUCCESS in 24m 43s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/65b83ba9eed748b0824e0fb07fb00031 : SUCCESS in 25m 14s","accounts_in_message":[],"_revision_number":1},{"id":"fdf56ecfdb8e37dfb2ce8cec5049ae787de99722","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 18:23:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c3f3f07026bffb1d1dfa222917b5f4102b800ba3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 19:11:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/af621b5cb9e94743933d84f5b915223e\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d093259858da4517ba9b80b2c5ad4a9b : SUCCESS in 6m 03s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b0303c059cd341349ae271607728acce : SUCCESS in 14m 25s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/3032da9b51474e13a52b14212fddc2a8 : SUCCESS in 13m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/df4c0493b1c940bc82974dea227c063b : SUCCESS in 11m 52s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/c35c399f39184d3abe0616ad4bbf8590 : SUCCESS in 24m 27s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/72af3d9c39444c73b48a9f59a8a3b095 : SUCCESS in 25m 47s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/900cc608be844efab2ce48d27305cfe7 : SUCCESS in 24m 05s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/2c95123c83ec4918ae46edab514de4b5 : SUCCESS in 5m 11s","accounts_in_message":[],"_revision_number":1},{"id":"a148fd7956f29776e5caea00e37edf4381a2b162","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 19:11:48.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"bd511071ca7a07fb65f309222663bba0722c6d30","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-09 19:12:59.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/55c73846d3384f1485c96b819f1f0d61\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9830f55c05654653930c6019598287d8 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ee3ec9b8f2b0809fcd44a2f66b718ff1ee335ce3","revisions":{"ee3ec9b8f2b0809fcd44a2f66b718ff1ee335ce3":{"kind":"REWORK","_number":1,"created":"2024-07-09 17:51:20.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/81/923781/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/81/923781/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/81/923781/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/81/923781/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/81/923781/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/81/923781/1"}}},"commit":{"parents":[{"commit":"78ae23807c14c51e0dc84bb8bc626f15f0a3b237","subject":"Merge \"Fix port group network metadata generation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/78ae23807c14c51e0dc84bb8bc626f15f0a3b237"}]}],"author":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2024-07-09 17:46:16.000000000","tz":-420},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2024-07-09 17:48:28.000000000","tz":-420},"subject":"[ironic] Ensure we test iterators when needed","message":"[ironic] Ensure we test iterators when needed\n\nBug #2071972 brought it to light that we may have had some unit tests\nimproperly operating against lists, when generators are used by the SDK.\nAs a result of auditing remaining unit tests, this one instance was\nfound of improper testing. Fixing this should avoid future bugs like\n2071972.\n\nRelated-Bug: #2071972\nChange-Id: Icf9882f5f8421b150c308eb2502623f2fcb6cff6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ee3ec9b8f2b0809fcd44a2f66b718ff1ee335ce3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ee3ec9b8f2b0809fcd44a2f66b718ff1ee335ce3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}