)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ca4d183b28c41a6cede38b4741ba78ffa476db20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d0a4acd_cc7f7d4a","updated":"2024-07-17 14:49:55.000000000","message":"just some points, not really an issue","commit_id":"a032648541766a199cacedd811f8915568a58d9e"}],"nova/tests/unit/image/test_format_inspector.py":[{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"889ecf828150b4811d77e00efaeaa5ca23699a7e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        # if it is not installed, skip"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            subprocess.check_output("},{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027 % ("},{"line_number":188,"context_line":"                    subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"914996e9_45443ab6","line":187,"in_reply_to":"e89dd749_dbbe457c","updated":"2024-07-15 15:34:32.000000000","message":"\u003e pep8: E501 line too long (80 \u003e 79 characters)\n\nPlease fix.","commit_id":"60c3cb033128b44677103d0bf9aedaa9838fe596"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ca4d183b28c41a6cede38b4741ba78ffa476db20","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\u0027qemu-img not installed\u0027)"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2f95366b_99ff2016","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":24},"updated":"2024-07-17 14:49:55.000000000","message":"could you please create a Launchpad bug report providing the specific exception we get in case qemu-img isn\u0027t used ?\n\nAlso, I\u0027d prefer to only check that specific exception, not the larged ``Exception`` one.","commit_id":"a032648541766a199cacedd811f8915568a58d9e"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"d1f51be461b1044a3f51388642b67a769690ba11","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\u0027qemu-img not installed\u0027)"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"55bf3ac9_be5b9b50","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":24},"in_reply_to":"2f95366b_99ff2016","updated":"2024-07-17 15:26:01.000000000","message":"Actually I\u0027ve just copied/pasted what it has been done in other tests for the same exception.\nMaybe it should be done in another more global patch to replace all these bare exceptions by a specific one ?","commit_id":"a032648541766a199cacedd811f8915568a58d9e"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"21dc4c594dc60adddec80bffbb506c4b71ef55ac","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\u0027qemu-img not installed\u0027)"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"92de03ef_078602b4","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":24},"in_reply_to":"34a412de_b03f44d0","updated":"2024-07-23 09:55:32.000000000","message":"I have created the bug report: https://bugs.launchpad.net/nova/+bug/2073862\n\nUpdating my change with your remarks.","commit_id":"a032648541766a199cacedd811f8915568a58d9e"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"d82418e7c67613ee7f932c03dd8b8dfd2125725a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\u0027qemu-img not installed\u0027)"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6301a47f_d242f26d","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":24},"in_reply_to":"55bf3ac9_be5b9b50","updated":"2024-07-22 15:38:21.000000000","message":"So, it\u0027s the subprocess.CalledProcessError exception which is raised in case of qemu-img binary is missing. Problem is that\u0027s the same exception for any other issues, I mean real ones even if qemu-img binary is present, so it is not easy to detect if a binary is missing except by parsing the output and looking for the string \"command not found\". Not sure it\u0027s a good idea, and that\u0027s why no one did that in other tests.","commit_id":"a032648541766a199cacedd811f8915568a58d9e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"6e076261565961600ac1301c3a34988ff4911a90","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\u0027qemu-img not installed\u0027)"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"34a412de_b03f44d0","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":24},"in_reply_to":"6301a47f_d242f26d","updated":"2024-07-23 09:09:26.000000000","message":"\u003e Problem is that\u0027s the same exception for any other issues\n\nI think you are refereing in same test_file only, like at L68, it might have missed/not-considered that time, because of priority of CVE, but it should be fixed.\nfor this one, you can go with `except subprocess.CalledProcessError as e` which you already found out, and print the content of \"e\" instead of `qemu-img not installed`. I think its enough, because it will tell the exact reason why cmd failed, as we see in cmd-shell.\n\nAlso, as Sylvain mentioned, we need a bug for this, you can create one from https://bugs.launchpad.net/nova","commit_id":"a032648541766a199cacedd811f8915568a58d9e"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"63cc95fbb2e1b6e4922698c9ce1051dd8275e3b9","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\u0027qemu-img not installed\u0027)"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"79c8611c_98d0e3a4","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":24},"in_reply_to":"896c5f98_04002aa3","updated":"2024-07-23 13:16:18.000000000","message":"Done","commit_id":"a032648541766a199cacedd811f8915568a58d9e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"dfd5f7eeddc7d16a8e69432cf0eb0bfa32db4899","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\u0027qemu-img not installed\u0027)"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"896c5f98_04002aa3","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":24},"in_reply_to":"92de03ef_078602b4","updated":"2024-07-23 10:16:25.000000000","message":"ack, JFYI in case you are not aware, you also need to mention the bug in comit msg\nCloses-Bug: #2073862","commit_id":"a032648541766a199cacedd811f8915568a58d9e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"225668291cb377b8bcd48f1bc773a8a15ec1d941","unresolved":true,"context_lines":[{"line_number":126,"context_line":"        # distribution so we need to check if the format is supported via"},{"line_number":127,"context_line":"        # the help output."},{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            subprocess.check_output("},{"line_number":130,"context_line":"                \u0027qemu-img --help | grep %s\u0027 % fmt, shell\u003dTrue)"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.skipTest("}],"source_content_type":"text/x-python","patch_set":3,"id":"a21a6b5a_50373938","line":129,"updated":"2024-07-23 13:22:25.000000000","message":"i think i would prefer to skip them like this instead","commit_id":"364e704f36f213b7a5f92a2618b204cc84cb2e11"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"74994176019896aa1cb3f538644c15dc02f5d60b","unresolved":true,"context_lines":[{"line_number":126,"context_line":"        # distribution so we need to check if the format is supported via"},{"line_number":127,"context_line":"        # the help output."},{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            subprocess.check_output("},{"line_number":130,"context_line":"                \u0027qemu-img --help | grep %s\u0027 % fmt, shell\u003dTrue)"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.skipTest("}],"source_content_type":"text/x-python","patch_set":3,"id":"a2d1bced_238dc542","line":129,"in_reply_to":"a21a6b5a_50373938","updated":"2024-07-23 13:31:49.000000000","message":"You mean with a Bare Exception ? As @sbauza@redhat.com told me to not use it ?","commit_id":"364e704f36f213b7a5f92a2618b204cc84cb2e11"},{"author":{"_account_id":34378,"name":"Julien LE JEUNE","email":"julien.le-jeune@mailops.fr","username":"jlejeune"},"change_message_id":"b1aa7a8be025fa24a3e6f5e6cadea3ca5c710f08","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        # distribution so we need to check if the format is supported via"},{"line_number":127,"context_line":"        # the help output."},{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            subprocess.check_output("},{"line_number":130,"context_line":"                \u0027qemu-img --help | grep %s\u0027 % fmt, shell\u003dTrue)"},{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            self.skipTest("}],"source_content_type":"text/x-python","patch_set":3,"id":"def3cdbe_ccb04d87","line":129,"in_reply_to":"a2d1bced_238dc542","updated":"2024-07-23 14:28:10.000000000","message":"Done","commit_id":"364e704f36f213b7a5f92a2618b204cc84cb2e11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7c8bcbffff06f6f25fbd132435711ae9fa5fceb2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                \u0027qemu-img convert -f raw -O vmdk -o subformat\u003d%s -S 0 %s %s\u0027"},{"line_number":188,"context_line":"                % (subformat, raw, fn),"},{"line_number":189,"context_line":"                shell\u003dTrue)"},{"line_number":190,"context_line":"        except Exception:"},{"line_number":191,"context_line":"            self.skipTest(\"qemu-img not installed\")"},{"line_number":192,"context_line":"        return fn"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f31c23b2_69ac873d","line":190,"updated":"2024-07-26 11:39:54.000000000","message":"we agreed on it by IRC, sorry for the confusion","commit_id":"a3202f7bf9f1aecc7d0632011167d38a1698f0a0"}]}