)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ab37c3aac065354f014a84c85b650333b3d8ebd7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"And the migration is based on request_specs, so the same image"},{"line_number":15,"context_line":"properties are also written to request_specs."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id36ecd022cb6f7f9a0fb131b0d202b79715870a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3d02c041_5375021d","line":17,"updated":"2024-09-04 00:23:26.000000000","message":"this is technically a bug so we should have a bug number associated with this as we likely should backport it.\n\nif we are going to backport it it would also be good to add a small release note","commit_id":"1a7bcb63b733a745641544a80caa7e844b17a39b"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"50fef2a114341f05c3a88d197a1f59cae63f1f91","unresolved":false,"context_lines":[{"line_number":14,"context_line":"And the migration is based on request_specs, so the same image"},{"line_number":15,"context_line":"properties are also written to request_specs."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id36ecd022cb6f7f9a0fb131b0d202b79715870a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"d0f0d25b_78f4c12f","line":17,"in_reply_to":"3d02c041_5375021d","updated":"2024-09-05 12:10:36.000000000","message":"Done","commit_id":"1a7bcb63b733a745641544a80caa7e844b17a39b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bfa965ce8930f2ff17b3cb0682603bf55d5080e3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"And the migration is based on request_specs, so the same image"},{"line_number":15,"context_line":"properties are also written to request_specs."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: 2078999"},{"line_number":18,"context_line":"Change-Id: Id36ecd022cb6f7f9a0fb131b0d202b79715870a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bd57690e_736b46d3","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":11},"updated":"2024-09-05 18:41:55.000000000","message":"FYI this should be `Closes-Bug` if it is the complete fix for a bug. That way the CI automation will mark it as Fix Released when the patch merges. If it does not have `Closes-Bug`, a person will have to mark the bug as closed (Fix Released) manually.\n\nThe `Related-Bug` tag means \"this patch is related to this bug but is not the actual fix for it\".","commit_id":"631b0a3fdb3d760b2e49e57d693a180ea1c972ee"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"cc46589227bae3b3aefb9d9f7f4363aca8704a4d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"And the migration is based on request_specs, so the same image"},{"line_number":15,"context_line":"properties are also written to request_specs."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: 2078999"},{"line_number":18,"context_line":"Change-Id: Id36ecd022cb6f7f9a0fb131b0d202b79715870a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"ca198e5a_0dc06006","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":11},"in_reply_to":"bd57690e_736b46d3","updated":"2024-09-09 11:13:41.000000000","message":"Done","commit_id":"631b0a3fdb3d760b2e49e57d693a180ea1c972ee"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"336e79980ed95f8d1350e8ad60e1fa58fe68c36b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"591eeb16_5461920b","updated":"2024-08-29 23:29:38.000000000","message":"Actual fix looks good. Soft -1 bc I think the test should also check that the image property was correctly set in the request spec.","commit_id":"3e614ebd8444150f99e1c5eded22373d2e30ffaf"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0c7ec57c673fd22a66de5ce9d3b51248f2fa90d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"12c996ec_281a94f2","updated":"2024-09-04 16:26:06.000000000","message":"I think Sean\u0027s request for a bug reference and release note makes sense, so downgrading to +1 pending those changes","commit_id":"1a7bcb63b733a745641544a80caa7e844b17a39b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a6c9992c2e0a964aa7b9f58efc0ed76952c15251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f300f98b_96e7d3cb","updated":"2024-09-03 21:26:16.000000000","message":"Thanks, LGTM","commit_id":"1a7bcb63b733a745641544a80caa7e844b17a39b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ab37c3aac065354f014a84c85b650333b3d8ebd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ec8b7ffc_27dc6752","updated":"2024-09-04 00:23:26.000000000","message":"holding +2w as we are in a freeze period\n\nit would also be nice to have a small fixes release note and a bug to associate this with.","commit_id":"1a7bcb63b733a745641544a80caa7e844b17a39b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bfa965ce8930f2ff17b3cb0682603bf55d5080e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c54404a0_cd47911c","updated":"2024-09-05 18:41:55.000000000","message":"The release note preview looks good to me:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9dc/924319/13/check/build-openstack-releasenotes/9dc3d7a/docs/unreleased.html#bug-fixes\n\n+1 for now until Sean can re-review","commit_id":"631b0a3fdb3d760b2e49e57d693a180ea1c972ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a400720341d2135ce2327243dd766dc9f3a0a3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"21bd944a_b6a3e73d","updated":"2024-09-05 19:49:15.000000000","message":"also +1\n\ni think we could have a better explaintion in the release note and it woudl be nice to adresss melaines commit message comment.\n\nwith that said im not sure we shoudl hold on that alone so if other are ok with it im not agaisnt upgrading to a +2","commit_id":"631b0a3fdb3d760b2e49e57d693a180ea1c972ee"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"90416fd9d15922257d42956b33f71c1a632cbcbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"92cccf2b_d079d272","updated":"2024-09-09 16:11:10.000000000","message":"It appears my and Sean\u0027s comments have been addressed, LGTM","commit_id":"52d010a6c02282adf2c5451b58bc820a8ff15f9e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"901d8d9e482d0cb64e17f926140e5517b69a69ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"392762a6_a99f863b","updated":"2024-09-09 17:21:32.000000000","message":"give we are before RC1 which ll be thursday and this is a bug not a feature im appoving this to include it in RC1.\n\nthanks for working on this.","commit_id":"52d010a6c02282adf2c5451b58bc820a8ff15f9e"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"841e9868c28ed57b5463cf2a72d7a5e716cc85f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"baccc496_3d44c917","updated":"2024-09-10 02:38:01.000000000","message":"recheck for gate job tempest-integrated-compute-rbac-old-defaults","commit_id":"52d010a6c02282adf2c5451b58bc820a8ff15f9e"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"f524f6b66287f023aa01ae64d6c6dbcaabd2b269","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"05e65793_eef70c21","updated":"2024-09-19 11:31:16.000000000","message":"Recheck","commit_id":"2a1fad41453ca7ce15b1cd9b517055c4ccdd12cf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d62f40466acae5379625ac6d941b5286e26d1cb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"39fa722d_2c0d2241","updated":"2024-09-10 14:16:07.000000000","message":"ill reapply -w for now but keep in mind that RC1 is ment to happen on thrusday so we shoudl avoid rebasing this or we will have to wait until after dalmation is relesed to backport it to dalmation","commit_id":"2a1fad41453ca7ce15b1cd9b517055c4ccdd12cf"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"09a2585c5ce858983cffff360ff3bc45ded36eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"069f712f_fd107bb7","updated":"2024-09-20 02:19:28.000000000","message":"recheck","commit_id":"2a1fad41453ca7ce15b1cd9b517055c4ccdd12cf"}],"nova/cmd/manage.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8ee7a766c4fc9735094c3334f8e0be24e74cfd86","unresolved":true,"context_lines":[{"line_number":3372,"context_line":"        # Update the image properties and save the instance record"},{"line_number":3373,"context_line":"        for image_property, value in image_properties.items():"},{"line_number":3374,"context_line":"            instance.system_metadata[f\u0027image_{image_property}\u0027] \u003d value"},{"line_number":3375,"context_line":"            request_spec.image.properties[image_property] \u003d value"},{"line_number":3376,"context_line":""},{"line_number":3377,"context_line":"        # Save and return 0"},{"line_number":3378,"context_line":"        instance.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"cdbb06ae_0b2207a1","line":3375,"updated":"2024-07-17 11:11:55.000000000","message":"i wonder if instead of doing this in the loop we would be better off just copying the image porperties form the instance and savign them to the request spec so that it sync all existing properties back to the request spec not just newlly set ones","commit_id":"0c7e9d114a98b9cf29edb532900790367a034bd5"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"99012de0543e9d78010942481639c2f159821653","unresolved":false,"context_lines":[{"line_number":3372,"context_line":"        # Update the image properties and save the instance record"},{"line_number":3373,"context_line":"        for image_property, value in image_properties.items():"},{"line_number":3374,"context_line":"            instance.system_metadata[f\u0027image_{image_property}\u0027] \u003d value"},{"line_number":3375,"context_line":"            request_spec.image.properties[image_property] \u003d value"},{"line_number":3376,"context_line":""},{"line_number":3377,"context_line":"        # Save and return 0"},{"line_number":3378,"context_line":"        instance.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf98ed72_d225d816","line":3375,"in_reply_to":"cdbb06ae_0b2207a1","updated":"2024-07-17 11:44:48.000000000","message":"Done","commit_id":"0c7e9d114a98b9cf29edb532900790367a034bd5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5c60c2a5476cd6765446c379b25208e1d6b9f8c3","unresolved":true,"context_lines":[{"line_number":3411,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":3412,"context_line":"                    cctxt, instance_uuid, expected_attrs\u003d[\u0027system_metadata\u0027])"},{"line_number":3413,"context_line":"                return self._update_image_properties(ctxt, instance,"},{"line_number":3414,"context_line":"                                                     image_properties)"},{"line_number":3415,"context_line":"        except ValueError as e:"},{"line_number":3416,"context_line":"            print(str(e))"},{"line_number":3417,"context_line":"            return 6"}],"source_content_type":"text/x-python","patch_set":2,"id":"b604418d_45ab6284","line":3414,"updated":"2024-07-17 11:09:19.000000000","message":"you should not reformat this as you have.\nour convetion is if you hae to reflow due to a line wrap you should move all arguemnt to the new line to minimise the whitespace indention.","commit_id":"0c7e9d114a98b9cf29edb532900790367a034bd5"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"99012de0543e9d78010942481639c2f159821653","unresolved":false,"context_lines":[{"line_number":3411,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":3412,"context_line":"                    cctxt, instance_uuid, expected_attrs\u003d[\u0027system_metadata\u0027])"},{"line_number":3413,"context_line":"                return self._update_image_properties(ctxt, instance,"},{"line_number":3414,"context_line":"                                                     image_properties)"},{"line_number":3415,"context_line":"        except ValueError as e:"},{"line_number":3416,"context_line":"            print(str(e))"},{"line_number":3417,"context_line":"            return 6"}],"source_content_type":"text/x-python","patch_set":2,"id":"14c2ddc2_359906da","line":3414,"in_reply_to":"b604418d_45ab6284","updated":"2024-07-17 11:44:48.000000000","message":"Done","commit_id":"0c7e9d114a98b9cf29edb532900790367a034bd5"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"260ae5b83a497274b5a2a9589158740cc698ab6c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"from nova.compute import api"},{"line_number":52,"context_line":"from nova.compute import instance_actions"},{"line_number":53,"context_line":"from nova.compute import rpcapi"},{"line_number":54,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":55,"context_line":"import nova.conf"},{"line_number":56,"context_line":"from nova import config"},{"line_number":57,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"d7f01e88_14c9f41a","line":54,"in_reply_to":"2f021f26_b9aef68a","updated":"2024-07-18 02:43:47.000000000","message":"Done","commit_id":"97fb9292c9db4696a36af348cfa91ae1dc5cf8f8"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"7587aeeb3ddd1c5d390ab573fa48abcbb2076d29","unresolved":true,"context_lines":[{"line_number":51,"context_line":"from nova.compute import api"},{"line_number":52,"context_line":"from nova.compute import instance_actions"},{"line_number":53,"context_line":"from nova.compute import rpcapi"},{"line_number":54,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":55,"context_line":"import nova.conf"},{"line_number":56,"context_line":"from nova import config"},{"line_number":57,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"2f021f26_b9aef68a","line":54,"in_reply_to":"9ef66010_75a3baaf","updated":"2024-07-18 02:43:37.000000000","message":"\u003e pep8: F401 \u0027nova.compute.utils as compute_utils\u0027 imported but unused\n\nPlease fix.","commit_id":"97fb9292c9db4696a36af348cfa91ae1dc5cf8f8"}],"nova/objects/image_meta.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5c60c2a5476cd6765446c379b25208e1d6b9f8c3","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"@base.NovaObjectRegistry.register"},{"line_number":158,"context_line":"class ImageMetaProps(base.NovaObject, base.NovaObjectDictCompat):"},{"line_number":159,"context_line":"    # Version 1.0: Initial version"},{"line_number":160,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":161,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"}],"source_content_type":"text/x-python","patch_set":2,"id":"87a4503d_9e1e485c","line":158,"range":{"start_line":158,"start_character":37,"end_line":158,"end_character":63},"updated":"2024-07-17 11:09:19.000000000","message":"we are trying to remove the dict compat logic so we shoudl not do this","commit_id":"0c7e9d114a98b9cf29edb532900790367a034bd5"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"99012de0543e9d78010942481639c2f159821653","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"@base.NovaObjectRegistry.register"},{"line_number":158,"context_line":"class ImageMetaProps(base.NovaObject, base.NovaObjectDictCompat):"},{"line_number":159,"context_line":"    # Version 1.0: Initial version"},{"line_number":160,"context_line":"    # Version 1.1: added os_require_quiesce field"},{"line_number":161,"context_line":"    # Version 1.2: added img_hv_type and img_hv_requested_version fields"}],"source_content_type":"text/x-python","patch_set":2,"id":"05de24f4_a3d67b6c","line":158,"range":{"start_line":158,"start_character":37,"end_line":158,"end_character":63},"in_reply_to":"87a4503d_9e1e485c","updated":"2024-07-17 11:44:48.000000000","message":"Done","commit_id":"0c7e9d114a98b9cf29edb532900790367a034bd5"}],"nova/tests/unit/cmd/test_manage.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"336e79980ed95f8d1350e8ad60e1fa58fe68c36b","unresolved":true,"context_lines":[{"line_number":4259,"context_line":"            \u0027image_hw_disk_bus\u0027"},{"line_number":4260,"context_line":"        )"},{"line_number":4261,"context_line":"        mock_instance_save.assert_called_once()"},{"line_number":4262,"context_line":"        mock_request_spec_save.assert_called_once()"},{"line_number":4263,"context_line":""},{"line_number":4264,"context_line":"    @mock.patch(\u0027nova.objects.Instance.get_by_uuid\u0027)"},{"line_number":4265,"context_line":"    @mock.patch(\u0027nova.objects.InstanceMapping.get_by_instance_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a362baa7_6906a979","line":4262,"updated":"2024-08-29 23:29:38.000000000","message":"This is good but we should also verify that the RequestSpec now contains the set image properties, similar to how we verified the instance system metadata was updated with the expected value.","commit_id":"3e614ebd8444150f99e1c5eded22373d2e30ffaf"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"b8277762323cdd734f009712288ec19c35e6875c","unresolved":false,"context_lines":[{"line_number":4259,"context_line":"            \u0027image_hw_disk_bus\u0027"},{"line_number":4260,"context_line":"        )"},{"line_number":4261,"context_line":"        mock_instance_save.assert_called_once()"},{"line_number":4262,"context_line":"        mock_request_spec_save.assert_called_once()"},{"line_number":4263,"context_line":""},{"line_number":4264,"context_line":"    @mock.patch(\u0027nova.objects.Instance.get_by_uuid\u0027)"},{"line_number":4265,"context_line":"    @mock.patch(\u0027nova.objects.InstanceMapping.get_by_instance_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad37d6b_96e5c968","line":4262,"in_reply_to":"a362baa7_6906a979","updated":"2024-08-30 05:53:19.000000000","message":"Done","commit_id":"3e614ebd8444150f99e1c5eded22373d2e30ffaf"}],"releasenotes/notes/nova-manage-image-property-bug-2078999-c493fc259d316c24.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a400720341d2135ce2327243dd766dc9f3a0a3f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 2078999 \u003chttps://bugs.launchpad.net/nova/+bug/2078999\u003e`_, fixing"},{"line_number":5,"context_line":"    unexpected rollback of image properties modified by"},{"line_number":6,"context_line":"    ``nova-manage image_property set`` after instance migration."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"e01912c1_7384670a","line":5,"updated":"2024-09-05 19:49:15.000000000","message":"so that not really what the bug is about\n\nthe bug is not that the image properties were rolled back\n\nthe bug is that when the embed properties were updated we never\nupdated the ones in the request spec.\n\neverything else is a side effect of that deeper bug.","commit_id":"631b0a3fdb3d760b2e49e57d693a180ea1c972ee"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"cc46589227bae3b3aefb9d9f7f4363aca8704a4d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 2078999 \u003chttps://bugs.launchpad.net/nova/+bug/2078999\u003e`_, fixing"},{"line_number":5,"context_line":"    unexpected rollback of image properties modified by"},{"line_number":6,"context_line":"    ``nova-manage image_property set`` after instance migration."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fc84dc12_0e10ac3a","line":5,"in_reply_to":"47b56958_31d2745c","updated":"2024-09-09 11:13:41.000000000","message":"Done","commit_id":"631b0a3fdb3d760b2e49e57d693a180ea1c972ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45484420a8ac4c78a0b867ae3b7907d32942c572","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 2078999 \u003chttps://bugs.launchpad.net/nova/+bug/2078999\u003e`_, fixing"},{"line_number":5,"context_line":"    unexpected rollback of image properties modified by"},{"line_number":6,"context_line":"    ``nova-manage image_property set`` after instance migration."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"47b56958_31d2745c","line":5,"in_reply_to":"e01912c1_7384670a","updated":"2024-09-05 19:52:25.000000000","message":"by the way the reason im not -1 is this is technially not incorrect\n\nits just a sideffect of the underlying bug so if other are ok with that then im fine with it too","commit_id":"631b0a3fdb3d760b2e49e57d693a180ea1c972ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"901d8d9e482d0cb64e17f926140e5517b69a69ef","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    the ``nova-manage image_property set`` command would update the image properties"},{"line_number":6,"context_line":"    embedded in the instance but would not update the ones in the request specs. This"},{"line_number":7,"context_line":"    led to an unexpected rollback of the image properties that were updated by the"},{"line_number":8,"context_line":"    command after an instance migration."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3e96bec9_ef78e35c","line":8,"updated":"2024-09-09 17:21:32.000000000","message":"+1 thanks\n\nthat is short and too the point conveying both the reason why adn the impact/side effect","commit_id":"52d010a6c02282adf2c5451b58bc820a8ff15f9e"}]}