)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1cceeaac00a05c7272afa869b2ab17071b1763e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"69009201_97e8abeb","updated":"2024-11-22 23:08:23.000000000","message":"I did not rebase it as there is one more update needed","commit_id":"93651c74e72df29a09e9571365d84e695fd9fbe5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b465f7bde2f51c30891070fa085cc57f4723605a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ed21288_6849b141","updated":"2024-11-25 18:48:05.000000000","message":"lgtm","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b2f142481daaebae240ec54c85416a6f1ae84483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"419995de_dbc25534","updated":"2024-12-02 17:26:01.000000000","message":"recheck","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a289c270dbdf5a1cf6d2093e2a7544b128cc9813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f7660242_d5ab911a","updated":"2024-12-06 16:43:03.000000000","message":"recheck","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"74cdd2cf6433f9f737e2ce181ba07b89cada9a4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cfd74e92_455a146a","updated":"2024-11-30 00:03:00.000000000","message":"recheck nova-next failed with 14.070990] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000 ]---","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"}],"nova/api/openstack/compute/schemas/attach_interfaces.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1cceeaac00a05c7272afa869b2ab17071b1763e8","unresolved":true,"context_lines":[{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"_interface_attachment_v270 \u003d copy.deepcopy(_interface_attachment)"},{"line_number":98,"context_line":"_interface_attachment_v270[\u0027properties\u0027][\u0027tag\u0027] \u003d {"},{"line_number":99,"context_line":"    \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":"_interface_attachment_v270[\u0027required\u0027].append(\u0027tag\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d7fbdac1_7461bed1","line":99,"range":{"start_line":98,"start_character":40,"end_line":99,"end_character":31},"updated":"2024-11-22 23:08:23.000000000","message":"we need to add it in required field","commit_id":"93651c74e72df29a09e9571365d84e695fd9fbe5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b465f7bde2f51c30891070fa085cc57f4723605a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"_interface_attachment_v270 \u003d copy.deepcopy(_interface_attachment)"},{"line_number":98,"context_line":"_interface_attachment_v270[\u0027properties\u0027][\u0027tag\u0027] \u003d {"},{"line_number":99,"context_line":"    \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":"_interface_attachment_v270[\u0027required\u0027].append(\u0027tag\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2f8a1a72_ecfcf951","line":99,"range":{"start_line":98,"start_character":40,"end_line":99,"end_character":31},"in_reply_to":"d1e43806_2fef970c","updated":"2024-11-25 18:48:05.000000000","message":"ah, I missed that. all good here.","commit_id":"93651c74e72df29a09e9571365d84e695fd9fbe5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c550ac353a426f3967f40fcdc59cec9c21cf3152","unresolved":true,"context_lines":[{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"_interface_attachment_v270 \u003d copy.deepcopy(_interface_attachment)"},{"line_number":98,"context_line":"_interface_attachment_v270[\u0027properties\u0027][\u0027tag\u0027] \u003d {"},{"line_number":99,"context_line":"    \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":"_interface_attachment_v270[\u0027required\u0027].append(\u0027tag\u0027)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d1e43806_2fef970c","line":99,"range":{"start_line":98,"start_character":40,"end_line":99,"end_character":31},"in_reply_to":"d7fbdac1_7461bed1","updated":"2024-11-25 11:49:36.000000000","message":"Is that not what I\u0027m doing two lines down?","commit_id":"93651c74e72df29a09e9571365d84e695fd9fbe5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aab7d492e4519e983a4b30a1911821a4bb2f43f5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    },"},{"line_number":93,"context_line":"    \u0027required\u0027: [\u0027fixed_ips\u0027, \u0027mac_addr\u0027, \u0027net_id\u0027, \u0027port_id\u0027, \u0027port_state\u0027],"},{"line_number":94,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"_interface_attachment_v270 \u003d copy.deepcopy(_interface_attachment)"},{"line_number":98,"context_line":"_interface_attachment_v270[\u0027properties\u0027][\u0027tag\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"8fac57b1_e901188b","line":95,"updated":"2024-11-30 00:02:02.000000000","message":"https://docs.openstack.org/api-ref/compute/#id174\n\nthis is our legacy proxy api for listign interface attached to vms.","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aab7d492e4519e983a4b30a1911821a4bb2f43f5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"_interface_attachment_v270[\u0027properties\u0027][\u0027tag\u0027] \u003d {"},{"line_number":99,"context_line":"    \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":"_interface_attachment_v270[\u0027required\u0027].append(\u0027tag\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"index_response \u003d {"},{"line_number":104,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"79a3bb0c_05420af4","line":101,"updated":"2024-11-30 00:02:02.000000000","message":"and yes tags were added in 2.70","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aab7d492e4519e983a4b30a1911821a4bb2f43f5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    _interface_attachment_v270"},{"line_number":132,"context_line":")"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# create responses are identical to show, including microversions"},{"line_number":135,"context_line":"create_response \u003d copy.deepcopy(show_response)"},{"line_number":136,"context_line":"create_response_v270 \u003d copy.deepcopy(show_response_v270)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"48491f01_4b204026","line":134,"updated":"2024-11-30 00:02:02.000000000","message":"https://docs.openstack.org/api-ref/compute/#id176\n\nyes although it annoys me that we list the field in a different order in the api ref but the content schema is identical.","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"}],"nova/tests/unit/api/openstack/compute/test_attach_interfaces.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aab7d492e4519e983a4b30a1911821a4bb2f43f5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \"mac_address\": \"aa:aa:aa:aa:aa:aa\","},{"line_number":51,"context_line":"    \"fixed_ips\": ["},{"line_number":52,"context_line":"        {\"ip_address\": \"10.0.1.2\", \"subnet_id\": FAKE_UUID2},"},{"line_number":53,"context_line":"    ],"},{"line_number":54,"context_line":"    \"device_id\": FAKE_UUID1,"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6361a307_21240948","line":53,"updated":"2024-11-30 00:02:02.000000000","message":"ack ya if the port has a fixed ip it is always assocated with the subnet it was assigned form.","commit_id":"af537d8b3af3860de73424ab3f860a9cf7359331"}]}