)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e031df6d7686aa6f371b3dfbde722f8c12b0f63","unresolved":false,"context_lines":[{"line_number":11,"context_line":"are stored as strings (like all properties). We also document this in"},{"line_number":12,"context_line":"our API docs. However, if we don\u0027t find these we return an integer"},{"line_number":13,"context_line":"value, 0. This can be considered a corner case/bug and is corrected"},{"line_number":14,"context_line":"here."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie38a7b6777d96075abc07eab4567d706ff8cd032"},{"line_number":17,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"06ace37b_bf3d4774","line":14,"updated":"2024-11-30 00:13:38.000000000","message":"Im not sure we even have that info any more given we change the host manager and no use custom resoucs classes for ironic nodes so i would be surprised if this was broken in weird ways with things likje the mvoe to the sdk or the srbac changes that have happend over the years.","commit_id":"52e00f8db9d3a215ee11f600f2fa943f8c686523"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b400bc9892c9bb7a22c45685531764c90f17594a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aca62b4b_531f3948","updated":"2024-11-30 00:14:27.000000000","message":"by the way thanks for breakign this up into small patces.\n\nim out of mental energy to continue review these today but ill see if i can complete the set before i go on pto.","commit_id":"52e00f8db9d3a215ee11f600f2fa943f8c686523"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e103d5a80e5a0e6be7cc74a08f37969f0b515772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e1d71f2_46ee4838","updated":"2024-11-25 18:48:57.000000000","message":"lgtm","commit_id":"52e00f8db9d3a215ee11f600f2fa943f8c686523"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e7a793860bda1f2dc799f712287735f743e33be9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"15b158b4_bfe43105","updated":"2024-12-09 09:57:37.000000000","message":"recheck","commit_id":"52e00f8db9d3a215ee11f600f2fa943f8c686523"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1167ae9a43332434d5ed772ea9ffbadcd98ef2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"21cb5835_07379ee5","updated":"2024-12-06 16:43:10.000000000","message":"recheck","commit_id":"52e00f8db9d3a215ee11f600f2fa943f8c686523"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"637ff9e59535a59979c6c880bc0f88759bb40ae7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3df6d8ce_928b3909","updated":"2024-12-02 17:26:08.000000000","message":"recheck","commit_id":"52e00f8db9d3a215ee11f600f2fa943f8c686523"}],"nova/api/openstack/compute/schemas/baremetal_nodes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4b13b0cb197012b9da19988bd0061aca10179cb6","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        \u0027cpus\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":41,"context_line":"        \u0027memory_mb\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":42,"context_line":"        \u0027disk_gb\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":43,"context_line":"    },"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":"_node_detail \u003d copy.deepcopy(_node)"},{"line_number":46,"context_line":"_node_detail[\u0027properties\u0027][\u0027instance_uuid\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ec30f67_355d9869","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":6},"updated":"2024-11-22 23:13:14.000000000","message":"we also need to add them in required field\n\n    \u0027additionalProperties\u0027: False,\n    \u0027required\u0027: [\u0027id\u0027, \u0027interfaces\u0027, \u0027host\u0027, \u0027task_state\u0027, \u0027cpus\u0027, \u0027memory_mb\u0027,\n                 \u0027disk_gb\u0027]","commit_id":"d3a6ce4f955f12b7ebcd9189148a7839b7021c78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37de5601d84ee959770f230a1dd22b8fa3324202","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \u0027cpus\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":41,"context_line":"        \u0027memory_mb\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":42,"context_line":"        \u0027disk_gb\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":43,"context_line":"    },"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":"_node_detail \u003d copy.deepcopy(_node)"},{"line_number":46,"context_line":"_node_detail[\u0027properties\u0027][\u0027instance_uuid\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ab89e3af_b9234e37","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":6},"in_reply_to":"1ec30f67_355d9869","updated":"2024-11-25 11:55:05.000000000","message":"Done (in alphabetical order)","commit_id":"d3a6ce4f955f12b7ebcd9189148a7839b7021c78"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4b13b0cb197012b9da19988bd0061aca10179cb6","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    },"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":"_node_detail \u003d copy.deepcopy(_node)"},{"line_number":46,"context_line":"_node_detail[\u0027properties\u0027][\u0027instance_uuid\u0027] \u003d {"},{"line_number":47,"context_line":"    \u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf85dfb9_3bfa356a","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":43},"updated":"2024-11-22 23:13:14.000000000","message":"ditto","commit_id":"d3a6ce4f955f12b7ebcd9189148a7839b7021c78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37de5601d84ee959770f230a1dd22b8fa3324202","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    },"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":"_node_detail \u003d copy.deepcopy(_node)"},{"line_number":46,"context_line":"_node_detail[\u0027properties\u0027][\u0027instance_uuid\u0027] \u003d {"},{"line_number":47,"context_line":"    \u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ec641410_b78af952","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":43},"in_reply_to":"bf85dfb9_3bfa356a","updated":"2024-11-25 11:55:05.000000000","message":"Done","commit_id":"d3a6ce4f955f12b7ebcd9189148a7839b7021c78"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e031df6d7686aa6f371b3dfbde722f8c12b0f63","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027task_state\u0027,"},{"line_number":52,"context_line":"    ],"},{"line_number":53,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":"_node_detail \u003d copy.deepcopy(_node)"},{"line_number":56,"context_line":"_node_detail[\u0027properties\u0027][\u0027instance_uuid\u0027] \u003d {"},{"line_number":57,"context_line":"    \u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"841882ee_b29e46c3","line":54,"updated":"2024-11-30 00:13:38.000000000","message":"https://docs.openstack.org/api-ref/compute/#id463\n\nthis will also 404 after 2.36 so in reality this endpoint is unlikely to be used anymore.","commit_id":"52e00f8db9d3a215ee11f600f2fa943f8c686523"}]}