)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a7bf0c95d6a28105587b528667ef71a75eeff620","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4d04f6ca_de0f6371","updated":"2024-11-25 18:49:34.000000000","message":"lgtm","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"}],"nova/api/openstack/compute/schemas/flavors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d24e500b5b484ac3bbd145e262c4064b880bcc87","unresolved":true,"context_lines":[{"line_number":158,"context_line":"                    \u0027href\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uri\u0027},"},{"line_number":159,"context_line":"                    \u0027rel\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":160,"context_line":"                },"},{"line_number":161,"context_line":"                \u0027required\u0027: [\u0027href\u0027, \u0027rel\u0027],"},{"line_number":162,"context_line":"            },"},{"line_number":163,"context_line":"        },"},{"line_number":164,"context_line":"        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":165,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":3,"id":"f891e91b_5ae48d6b","line":162,"range":{"start_line":161,"start_character":43,"end_line":162,"end_character":14},"updated":"2024-11-22 23:43:04.000000000","message":"\u0027additionalProperties\u0027: False,","commit_id":"f357215e4df58a1f59f9d88446a5c441b183b82d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c0e72faa0dacc7082466a114e9fe7467eeaffe8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                    \u0027href\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uri\u0027},"},{"line_number":159,"context_line":"                    \u0027rel\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":160,"context_line":"                },"},{"line_number":161,"context_line":"                \u0027required\u0027: [\u0027href\u0027, \u0027rel\u0027],"},{"line_number":162,"context_line":"            },"},{"line_number":163,"context_line":"        },"},{"line_number":164,"context_line":"        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":165,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":3,"id":"6346f9c1_93979252","line":162,"range":{"start_line":161,"start_character":43,"end_line":162,"end_character":14},"in_reply_to":"f891e91b_5ae48d6b","updated":"2024-11-25 12:05:21.000000000","message":"Done","commit_id":"f357215e4df58a1f59f9d88446a5c441b183b82d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d24e500b5b484ac3bbd145e262c4064b880bcc87","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        },"},{"line_number":164,"context_line":"        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":165,"context_line":"    },"},{"line_number":166,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027links\u0027, \u0027name\u0027],"},{"line_number":167,"context_line":"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"_flavor_basic_v255 \u003d copy.deepcopy(_flavor_basic)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f69a4eeb_32069f3a","line":166,"range":{"start_line":166,"start_character":39,"end_line":166,"end_character":40},"updated":"2024-11-22 23:43:04.000000000","message":"\u0027additionalProperties\u0027: False,","commit_id":"f357215e4df58a1f59f9d88446a5c441b183b82d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c0e72faa0dacc7082466a114e9fe7467eeaffe8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        },"},{"line_number":164,"context_line":"        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":165,"context_line":"    },"},{"line_number":166,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027links\u0027, \u0027name\u0027],"},{"line_number":167,"context_line":"}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"_flavor_basic_v255 \u003d copy.deepcopy(_flavor_basic)"}],"source_content_type":"text/x-python","patch_set":3,"id":"71944f6c_ed6c16ac","line":166,"range":{"start_line":166,"start_character":39,"end_line":166,"end_character":40},"in_reply_to":"f69a4eeb_32069f3a","updated":"2024-11-25 12:05:21.000000000","message":"Done","commit_id":"f357215e4df58a1f59f9d88446a5c441b183b82d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f7b06ae43249c04ff9f41084b5f37d7a582d559","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    \u0027required\u0027: [\u0027id\u0027, \u0027links\u0027, \u0027name\u0027],"},{"line_number":168,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"_flavor_basic_v255 \u003d copy.deepcopy(_flavor_basic)"},{"line_number":172,"context_line":"_flavor_basic_v255[\u0027properties\u0027][\u0027description\u0027] \u003d {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":173,"context_line":"_flavor_basic_v255[\u0027required\u0027].append(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b255c716_076d8642","line":170,"updated":"2024-12-09 10:56:12.000000000","message":"https://docs.openstack.org/api-ref/compute/#id196\n\nbefore 2.55 this is all that is allowed. a array for flagor each with an id name an d links keys","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f7b06ae43249c04ff9f41084b5f37d7a582d559","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"_flavor_basic_v255 \u003d copy.deepcopy(_flavor_basic)"},{"line_number":172,"context_line":"_flavor_basic_v255[\u0027properties\u0027][\u0027description\u0027] \u003d {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":173,"context_line":"_flavor_basic_v255[\u0027required\u0027].append(\u0027description\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"_flavor \u003d {"},{"line_number":176,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"07ba96e7_e3cc091d","line":173,"updated":"2024-12-09 10:56:12.000000000","message":"as of 2.55 descirptioj is then included","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f7b06ae43249c04ff9f41084b5f37d7a582d559","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        \u0027OS-FLV-EXT-DATA:ephemeral\u0027,"},{"line_number":217,"context_line":"    ],"},{"line_number":218,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":219,"context_line":"}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"_flavor_v255 \u003d copy.deepcopy(_flavor)"},{"line_number":222,"context_line":"_flavor_v255[\u0027properties\u0027][\u0027description\u0027] \u003d {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ab09f1c_ad70e0c5","line":219,"updated":"2024-12-09 10:56:12.000000000","message":"https://docs.openstack.org/api-ref/compute/#id205\n\non the flaovr its self yes these are the only field aviabel prior to 2.55\n\n\u0027OS-FLV-DISABLED:disabled\u0027 is optional according to the api ref however as it  only avaiable to adminsitartor so it problay shoudl not be in requried.","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e4a898a102e233ae536d33784ce24eb9e18ef69","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        \u0027OS-FLV-EXT-DATA:ephemeral\u0027,"},{"line_number":217,"context_line":"    ],"},{"line_number":218,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":219,"context_line":"}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"_flavor_v255 \u003d copy.deepcopy(_flavor)"},{"line_number":222,"context_line":"_flavor_v255[\u0027properties\u0027][\u0027description\u0027] \u003d {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2d7a1a0_071f2b7b","line":219,"in_reply_to":"0ab09f1c_ad70e0c5","updated":"2024-12-09 11:02:53.000000000","message":"The api-ref appears to be incorrect. The [create](https://github.com/openstack/nova/blob/338cbea72ae55dca287b02559265a8ab77efd606/nova/api/openstack/compute/flavors.py#L106-L107), [update](https://github.com/openstack/nova/blob/338cbea72ae55dca287b02559265a8ab77efd606/nova/api/openstack/compute/flavors.py#L131-L132), and [show](https://github.com/openstack/nova/blob/338cbea72ae55dca287b02559265a8ab77efd606/nova/api/openstack/compute/flavors.py#L174-L176) views all make use of the `show` function from `nova.api.openstack.compute.views.flavors`. If you look at that [here](https://github.com/openstack/nova/blob/338cbea72ae55dca287b02559265a8ab77efd606/nova/api/openstack/compute/views/flavors.py#L57), you\u0027ll see that `OS-FLV-DISABLED:disabled` is always returned.","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"08046d36e8784fef1ad5811f58bac4544088c6b1","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        \u0027OS-FLV-EXT-DATA:ephemeral\u0027,"},{"line_number":217,"context_line":"    ],"},{"line_number":218,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":219,"context_line":"}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"_flavor_v255 \u003d copy.deepcopy(_flavor)"},{"line_number":222,"context_line":"_flavor_v255[\u0027properties\u0027][\u0027description\u0027] \u003d {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"838247c1_0222259a","line":219,"in_reply_to":"f2d7a1a0_071f2b7b","updated":"2024-12-09 11:48:35.000000000","message":"ack it woudl be good to have a follow up to update the api refe then but lets proceed with this as is so.","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f7b06ae43249c04ff9f41084b5f37d7a582d559","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"_flavor_v255 \u003d copy.deepcopy(_flavor)"},{"line_number":222,"context_line":"_flavor_v255[\u0027properties\u0027][\u0027description\u0027] \u003d {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]}"},{"line_number":223,"context_line":"_flavor_v255[\u0027required\u0027].append(\u0027description\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"_flavor_v261 \u003d copy.deepcopy(_flavor_v255)"},{"line_number":226,"context_line":"_flavor_v261[\u0027properties\u0027][\u0027extra_specs\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"60159f18_7f9b81e0","line":223,"updated":"2024-12-09 10:56:12.000000000","message":"+1 added in 2.55 and it shoudl always be present even if null\nnote that its listed as a string and not optional so i assume we are returing null in cases where its not set at all instead of the empty string.","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f7b06ae43249c04ff9f41084b5f37d7a582d559","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        \u0027^[a-zA-Z0-9-_:. ]{1,255}$\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027maxLength\u0027: 255},"},{"line_number":230,"context_line":"    },"},{"line_number":231,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":232,"context_line":"}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"_flavor_v275 \u003d copy.deepcopy(_flavor_v261)"},{"line_number":235,"context_line":"# we completely overwrite this since the new variant is much simpler"}],"source_content_type":"text/x-python","patch_set":4,"id":"75859464_b56806e7","line":232,"updated":"2024-12-09 10:56:12.000000000","message":"yep these were added in 2.61\nthey are configurabl via policy but shown by default with project reader access","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f7b06ae43249c04ff9f41084b5f37d7a582d559","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"_flavor_v275 \u003d copy.deepcopy(_flavor_v261)"},{"line_number":235,"context_line":"# we completely overwrite this since the new variant is much simpler"},{"line_number":236,"context_line":"_flavor_v275[\u0027properties\u0027][\u0027swap\u0027] \u003d {\u0027type\u0027: \u0027integer\u0027}"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"_flavors_links \u003d {"},{"line_number":239,"context_line":"    \u0027type\u0027: \u0027array\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"422aecf0_86305de6","line":236,"updated":"2024-12-09 10:56:12.000000000","message":"ack we changed form \u0027\u0027 to 0 for no swap in 2.75","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f7b06ae43249c04ff9f41084b5f37d7a582d559","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"882c6133_f5ecbef1","line":345,"updated":"2024-12-09 10:56:12.000000000","message":"the reset all looks fine","commit_id":"4404790656b7a6f7c15ed2eb3faf226c28965c23"}]}