)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1cb64afddbbf737f1014b182ac2f954386eae538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ac48942_518a68e4","updated":"2024-07-23 08:24:30.000000000","message":"can you please add tempest test well","commit_id":"ec614562778db7f359f9905358a1dd998dac9779"}],"nova/conf/libvirt.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1cb64afddbbf737f1014b182ac2f954386eae538","unresolved":true,"context_lines":[{"line_number":760,"context_line":"This option allows you to present the uuid_number also in"},{"line_number":761,"context_line":"```/sys/class/dmi/id/board_asset_tag```, which is readable by nonroot users."},{"line_number":762,"context_line":"\"\"\""},{"line_number":763,"context_line":"               ),"},{"line_number":764,"context_line":"    cfg.IntOpt(\u0027mem_stats_period_seconds\u0027,"},{"line_number":765,"context_line":"               default\u003d10,"},{"line_number":766,"context_line":"               help\u003d\u0027A number of seconds to memory usage statistics period. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"0038c14c_cc55360e","line":763,"updated":"2024-07-23 08:24:30.000000000","message":"right now,  nova instances do not have file `/sys/class/dmi/id/board_asset_tag` except cirros images.","commit_id":"afc2888db0d94f309ed8922ca0ba70aa60544850"},{"author":{"_account_id":37175,"name":"Alexander Hild","display_name":"hildale","email":"alexander.hild@stackit.cloud","username":"hildale"},"change_message_id":"906bd011a971a91f61cd9cbaf01631b54016051d","unresolved":true,"context_lines":[{"line_number":760,"context_line":"This option allows you to present the uuid_number also in"},{"line_number":761,"context_line":"```/sys/class/dmi/id/board_asset_tag```, which is readable by nonroot users."},{"line_number":762,"context_line":"\"\"\""},{"line_number":763,"context_line":"               ),"},{"line_number":764,"context_line":"    cfg.IntOpt(\u0027mem_stats_period_seconds\u0027,"},{"line_number":765,"context_line":"               default\u003d10,"},{"line_number":766,"context_line":"               help\u003d\u0027A number of seconds to memory usage statistics period. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"4fd6c3b0_958ed08d","line":763,"in_reply_to":"0038c14c_cc55360e","updated":"2024-07-23 09:56:13.000000000","message":"nova compute configures libvirt xml file for every vm.\nexample:\n  \u003cbaseBoard\u003e\n    \u003centry name\u003d\u0027manufacturer\u0027\u003eLENOVO\u003c/entry\u003e\n    \u003centry name\u003d\u0027product\u0027\u003e20BE0061MC\u003c/entry\u003e\n    \u003centry name\u003d\u0027version\u0027\u003e0B98401 Pro\u003c/entry\u003e\n    \u003centry name\u003d\u0027serial\u0027\u003eW1KS427111E\u003c/entry\u003e\n  \u003c/baseBoard\u003e\n  \n  \nnormally baseBoard asset is empty. \nOn linux os side these fields are propagated via dmi interface.","commit_id":"afc2888db0d94f309ed8922ca0ba70aa60544850"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1cb64afddbbf737f1014b182ac2f954386eae538","unresolved":true,"context_lines":[{"line_number":1079,"context_line":"            if CONF.libvirt.baseBoard_asset_tag \u003d\u003d \"uuid\":"},{"line_number":1080,"context_line":"                baseBoard.append(self._text_node(\"entry\",self.system_uuid,"},{"line_number":1081,"context_line":"                                                 name\u003d\"asset\"))"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        if self.system_family is not None:"},{"line_number":1084,"context_line":"            system.append(self._text_node(\"entry\", self.system_family,"},{"line_number":1085,"context_line":"                                          name\u003d\"family\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2c4333b_0263427c","line":1082,"updated":"2024-07-23 08:24:30.000000000","message":"I understand AWS does it, and user can see it here `/sys/devices/virtual/dmi/id/board_asset_tag` \n\nbut can you please clear the usecase, how this will be helpful.\na nonroot can request for metadata and get instance_uuid.\n\n`curl http://169.254.169.254/openstack/latest/meta_data.json`","commit_id":"afc2888db0d94f309ed8922ca0ba70aa60544850"},{"author":{"_account_id":37175,"name":"Alexander Hild","display_name":"hildale","email":"alexander.hild@stackit.cloud","username":"hildale"},"change_message_id":"906bd011a971a91f61cd9cbaf01631b54016051d","unresolved":true,"context_lines":[{"line_number":1079,"context_line":"            if CONF.libvirt.baseBoard_asset_tag \u003d\u003d \"uuid\":"},{"line_number":1080,"context_line":"                baseBoard.append(self._text_node(\"entry\",self.system_uuid,"},{"line_number":1081,"context_line":"                                                 name\u003d\"asset\"))"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        if self.system_family is not None:"},{"line_number":1084,"context_line":"            system.append(self._text_node(\"entry\", self.system_family,"},{"line_number":1085,"context_line":"                                          name\u003d\"family\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"efb4481a_3bbe7305","line":1082,"in_reply_to":"d2c4333b_0263427c","updated":"2024-07-23 09:56:13.000000000","message":"its a requirement from a customer that is working as nonroot. \ndmi interface is used because its available on every platform.\n\ni made a config parameter so its completely optional.","commit_id":"afc2888db0d94f309ed8922ca0ba70aa60544850"}]}