)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3da836709307b9d790fed2c69a22a9653304b84","unresolved":true,"context_lines":[{"line_number":10,"context_line":"The added  option allows you to present the uuid_number also in"},{"line_number":11,"context_line":"/sys/class/dmi/id/board_asset_tag, which is readable by nonroot users."},{"line_number":12,"context_line":"modify os settings to make /sys/class/dmi/id/product_uuid (udev..) is no option."},{"line_number":13,"context_line":"AWS does it the same way, see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ed147dcd74cee0727b42baa2872a9a0a8a3cb62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ef8c3098_af423aab","line":13,"updated":"2024-07-25 10:55:27.000000000","message":"conforming to aws\u0027s behavior is not a general goal of nova or openstack.\n\nwe do already provide the instance uuid in a number of ways.\n\nwe already provide it in the uuid field of the xml and in the serial filed of the domain\n\nif i run dmi decode in a nova instnace we see the following in the system infomation header.\n\nHandle 0x0100, DMI type 1, 27 bytes\nSystem Information\n\tManufacturer: OpenStack Foundation\n\tProduct Name: OpenStack Nova\n\tVersion: 25.0.2\n\tSerial Number: 77af9915-326f-4cca-a4d8-c34b6afc511f\n\tUUID: 77af9915-326f-4cca-a4d8-c34b6afc511f\n\tWake-up Type: Power Switch\n\tSKU Number: Not Specified\n\tFamily: Virtual Machine\n\nthe serial number and uuid  secation are both set to the instance uuid by default","commit_id":"b29da3c5a8bab5c1a402c0ec3eb3894cd8b2067d"},{"author":{"_account_id":37175,"name":"Alexander Hild","display_name":"hildale","email":"alexander.hild@stackit.cloud","username":"hildale"},"change_message_id":"bd660272b150b0ed5c7535fd1b4b5c307dad5c5f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"The added  option allows you to present the uuid_number also in"},{"line_number":11,"context_line":"/sys/class/dmi/id/board_asset_tag, which is readable by nonroot users."},{"line_number":12,"context_line":"modify os settings to make /sys/class/dmi/id/product_uuid (udev..) is no option."},{"line_number":13,"context_line":"AWS does it the same way, see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ed147dcd74cee0727b42baa2872a9a0a8a3cb62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b57e595e_f5db2d2b","line":13,"in_reply_to":"0631d73e_066d460b","updated":"2024-07-26 10:58:09.000000000","message":"its an requirement from a customer. for product licensing it is necessary that they can read the uuid as nonroot from dmi.","commit_id":"b29da3c5a8bab5c1a402c0ec3eb3894cd8b2067d"},{"author":{"_account_id":37175,"name":"Alexander Hild","display_name":"hildale","email":"alexander.hild@stackit.cloud","username":"hildale"},"change_message_id":"79cc5e6ab3089fcca1207c06270f8dd589ca1ab0","unresolved":true,"context_lines":[{"line_number":10,"context_line":"The added  option allows you to present the uuid_number also in"},{"line_number":11,"context_line":"/sys/class/dmi/id/board_asset_tag, which is readable by nonroot users."},{"line_number":12,"context_line":"modify os settings to make /sys/class/dmi/id/product_uuid (udev..) is no option."},{"line_number":13,"context_line":"AWS does it the same way, see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ed147dcd74cee0727b42baa2872a9a0a8a3cb62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0631d73e_066d460b","line":13,"in_reply_to":"98988730_c9779224","updated":"2024-07-25 11:27:16.000000000","message":"Hello,\nwith root rights this is never a problem. without them it is.","commit_id":"b29da3c5a8bab5c1a402c0ec3eb3894cd8b2067d"},{"author":{"_account_id":37175,"name":"Alexander Hild","display_name":"hildale","email":"alexander.hild@stackit.cloud","username":"hildale"},"change_message_id":"13eb22f54feca5d2ab91f4d4b76896ec5ee03425","unresolved":true,"context_lines":[{"line_number":10,"context_line":"The added  option allows you to present the uuid_number also in"},{"line_number":11,"context_line":"/sys/class/dmi/id/board_asset_tag, which is readable by nonroot users."},{"line_number":12,"context_line":"modify os settings to make /sys/class/dmi/id/product_uuid (udev..) is no option."},{"line_number":13,"context_line":"AWS does it the same way, see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ed147dcd74cee0727b42baa2872a9a0a8a3cb62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"729fda6c_b0ec4f3c","line":13,"in_reply_to":"b57e595e_f5db2d2b","updated":"2024-07-30 06:38:34.000000000","message":"i found similar cases in older reviews... for example:\nhttps://review.opendev.org/c/openstack/nova/+/752723\n\non hyperv side chassis_asset_tag to identify that the running vm is a hyperv vm. \nwhy isnt there sudo or api call isnt used ?","commit_id":"b29da3c5a8bab5c1a402c0ec3eb3894cd8b2067d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2696823c9f143b6810271101d6a270b05df6bdc3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"The added  option allows you to present the uuid_number also in"},{"line_number":11,"context_line":"/sys/class/dmi/id/board_asset_tag, which is readable by nonroot users."},{"line_number":12,"context_line":"modify os settings to make /sys/class/dmi/id/product_uuid (udev..) is no option."},{"line_number":13,"context_line":"AWS does it the same way, see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ed147dcd74cee0727b42baa2872a9a0a8a3cb62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"98988730_c9779224","line":13,"in_reply_to":"ef8c3098_af423aab","updated":"2024-07-25 10:57:35.000000000","message":"by the way the amazon doc say you shoudl retrive this by doing\n\"sudo dmidecode --string system-uuid\"\n\nubuntu@devstack-bugfix:~$ sudo dmidecode --string system-uuid\n77af9915-326f-4cca-a4d8-c34b6afc511f\n\nwhich returns the correct data today.\n\nallow non root users to do this in a guest is out of scope of nova btu we already do support that via the metadata api and config drive as i noted above.","commit_id":"b29da3c5a8bab5c1a402c0ec3eb3894cd8b2067d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3da836709307b9d790fed2c69a22a9653304b84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c95e965b_7f31ed19","updated":"2024-07-25 10:55:27.000000000","message":"this information is already avlaiabel within the guest via dmidecode and has been\nfor years. i do not see a compleing reason to advertise it a third way in dmi decodes output, in addtion to including it in config driver and/or metadata api.","commit_id":"b29da3c5a8bab5c1a402c0ec3eb3894cd8b2067d"}]}