)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d87ba2cfe82fdb356aad03845290d2cd1b92feab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"525a3f32_99438933","updated":"2024-08-01 10:10:31.000000000","message":"change does make sense, but then I saw this, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py#L1600-L1604\n\nalso from my test, list_all_devices always return all devices.","commit_id":"01ac27012cd7f2964c5e700d2247bd41f2e9029e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6a22bf4c7e433dc29fb1b818129ddeac086fcd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b2c8abe9_ed561e56","updated":"2026-04-09 10:12:54.000000000","message":"recheck lets get some fresh results","commit_id":"01ac27012cd7f2964c5e700d2247bd41f2e9029e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"27c2209d84e916ff58966b4073ea63c969186dd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a726237_30886159","updated":"2026-04-28 22:54:01.000000000","message":"recheck openstack-tox-cover TIMED_OUT","commit_id":"01ac27012cd7f2964c5e700d2247bd41f2e9029e"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"b41468ef8eca00fc4c8110d384ad3da6ad860763","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93ee3ea5_c3fc018b","updated":"2026-04-13 07:57:50.000000000","message":"recheck openstack-tox-cover timed out","commit_id":"01ac27012cd7f2964c5e700d2247bd41f2e9029e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d87ba2cfe82fdb356aad03845290d2cd1b92feab","unresolved":true,"context_lines":[{"line_number":8568,"context_line":"                flags\u003d(libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA))]"},{"line_number":8569,"context_line":"        pci_devs \u003d {"},{"line_number":8570,"context_line":"            dev.name(): dev for dev in self._host.list_all_devices("},{"line_number":8571,"context_line":"                flags\u003d(libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV))}"},{"line_number":8572,"context_line":"        pci_info \u003d ["},{"line_number":8573,"context_line":"            self._host._get_pcidev_info("},{"line_number":8574,"context_line":"                name, dev, net_devs,"}],"source_content_type":"text/x-python","patch_set":2,"id":"571b0390_493fe283","line":8571,"updated":"2024-08-01 10:10:31.000000000","message":"in my test there is no difference in the output\n```\n(Pdb) dev_flags\n131090\n(Pdb) libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_NET\n16\n(Pdb) libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV\n2\n(Pdb) libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA\n131072\n(Pdb) 16 | 2 |131072\n131090\n\n(Pdb) self._host.list_all_devices(flags\u003ddev_flags)\ndict_values([\n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544370\u003e,\n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544790\u003e, \n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544820\u003e, \n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544850\u003e,\n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb5dc552130\u003e])\n\n```\n\n\nindividual.\n```\n(Pdb) self._host.list_all_devices(libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_NET)\ndict_values([\n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544370\u003e, \n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544790\u003e, \n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544820\u003e, \n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544850\u003e, \n\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb5dc552130\u003e])\n\n(Pdb) self._host.list_all_devices(libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV)\ndict_values([\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544370\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544790\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544820\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544850\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb5dc552130\u003e])\n\n(Pdb) self._host.list_all_devices(libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA)\ndict_values([\u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544370\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544790\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544820\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb603544850\u003e, \u003cnova.tests.fixtures.libvirt.NodeDevice object at 0x7fb5dc552130\u003e])\n```","commit_id":"01ac27012cd7f2964c5e700d2247bd41f2e9029e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"906d387684b733173ee74452a811f84e3adaa52b","unresolved":true,"context_lines":[{"line_number":8568,"context_line":"                flags\u003d(libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA))]"},{"line_number":8569,"context_line":"        pci_devs \u003d {"},{"line_number":8570,"context_line":"            dev.name(): dev for dev in self._host.list_all_devices("},{"line_number":8571,"context_line":"                flags\u003d(libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV))}"},{"line_number":8572,"context_line":"        pci_info \u003d ["},{"line_number":8573,"context_line":"            self._host._get_pcidev_info("},{"line_number":8574,"context_line":"                name, dev, net_devs,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e9ab8644_ae918851","line":8571,"in_reply_to":"571b0390_493fe283","updated":"2024-08-01 10:12:51.000000000","message":"I know, here its a fixture, may we need a functional test.","commit_id":"01ac27012cd7f2964c5e700d2247bd41f2e9029e"}]}