)]}'
{"id":"openstack%2Fnova~925606","triplet_id":"openstack%2Fnova~master~I83ccb134ce77e9c9a79c39e66e77353c736227c3","project":"openstack/nova","branch":"master","topic":"bp/manila_shares_attachments","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2025-04-15 16:31:05.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I83ccb134ce77e9c9a79c39e66e77353c736227c3","subject":"[manila]Lock/Unlock share by the share_mapping","status":"ABANDONED","created":"2024-08-02 15:36:59.000000000","updated":"2025-04-15 16:31:05.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bc534bbcbbe5cbabc2c44255ae040ebc403989d4","_number":925606,"virtual_id_number":925606,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2024-08-05 16:37:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-02 15:56:12.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-02 17:30:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-08-02 17:45:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0c1a555179612eae7c0588cc29dc86fb3ea9bf15","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-08-02 15:36:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d89fef5466e150f9ef4c35fdc7e1ae886d5f1489","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-08-02 15:37:29.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3a1629b402d0ffc7c4b336a144de6e591cf53847","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-08-02 15:56:12.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-925606-9gwwq/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"f27024b77e7b8d8aa7ef3a334345f0016ae53662","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-08-02 16:15:45.000000000","message":"Patch Set 2:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-925606-4dq4d/index.html\u003e","accounts_in_message":[],"_revision_number":2},{"id":"205e881c7ecdbf179e7eda9ce0bdde0aa7b148f9","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-02 17:30:03.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/032f21b48f58418a8e7ec815c4f9c869\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/d11679771e024e40859d4303c189db45 : FAILURE in 22m 42s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/8c9f791e88f54778bfc6cf6efe550618 : FAILURE in 35m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b37196df05a7073af7d3050518a4ac0bff32188a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-02 17:45:18.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/dbf955183121463ea145fa5b1e2cd763\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/f996de616248409687b6ecef83a338e7 : SUCCESS in 58m 29s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/ffd889794d384f14af02438c4a3177eb : SUCCESS in 1h 44m 47s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/fcd8eddee37248068f4f1aea468d958a : SUCCESS in 1h 01m 02s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4e85be5878cc4578960337c08f44dada : FAILURE in 19m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/76cc9f9de2d2427e8afcfcd8177a12f9 : SUCCESS in 7m 54s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fcc4677b1aeb4d04ba25a54778ae905c : FAILURE in 12m 54s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ff8bd1fb23924b4d94930cac3c0e31f5 : FAILURE in 12m 30s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/040c9e1e0eda4c0396751f50ef7de017 : FAILURE in 17m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bc5128dc254b478599a14637c8cc641a : SUCCESS in 10m 39s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/cb923b2a43ef48e283f708fd20d50d7a : SUCCESS in 1h 03m 18s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/1491d8ee175149e398136fdf5168f48a : SUCCESS in 1h 50m 23s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ba3c53de4b834fdaa104328e5b226477 : SUCCESS in 44m 29s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/21cfe2ad96344726ae262914601a7fd4 : SUCCESS in 55m 35s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/b33f3168cad545558b4206c10cbe64cb : SUCCESS in 1h 42m 28s\n- nova-next https://zuul.opendev.org/t/openstack/build/e1a6f04d980c45618a1daafe1cb61ab3 : FAILURE in 2h 02m 10s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/101654505f6746f4ae74fbc1937e8a22 : SUCCESS in 43m 07s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/bcbfd78cc46f407b80cff59489e1daa7 : SUCCESS in 5m 15s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/bb73809253f84613a1035bdfcaafa1d2 : FAILURE in 25m 49s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/cb85a1e6e54a4e7992ec65308926beb0 : FAILURE in 26m 19s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/7c5ffd9cc639472c8aa0ed8f77aa9b24 : FAILURE in 29m 31s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/f4858e40175c4839976409712ba6b2bc : SUCCESS in 1h 54m 57s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/8f944aadf94349dcb3b6306cdee80e79 : SUCCESS in 1h 34m 06s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/bf72df8eaf9d4d579113671d0d783507 : SUCCESS in 1h 12m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d5ae7bde4dfd4f6dacc2d766d81aa833 : SUCCESS in 38m 15s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/6bb261d0ce7d47b2908c93314d1eae69 : SUCCESS in 18m 56s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/8ecacda5704649b28d4d53b2c8bf79b2 : SUCCESS in 28m 40s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7d73ad009c35db56e8d7cccd73242c401bf93ea5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-08-05 13:51:38.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":3},{"id":"7af6a0d45b1b03843da6105de5a90b67b7327ca8","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-08-05 14:10:59.000000000","message":"Patch Set 3:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-925606-mxln2/index.html\u003e","accounts_in_message":[],"_revision_number":3},{"id":"a2c2e66244b61adfa81b8ab97f5a23fc1db5e8fc","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-05 14:27:11.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6f282c2f396f441a84108b5f5eeebb3d\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/3537fdbde05146859f1be81848c49ddc : FAILURE in 30m 15s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/aa8e43644b1d4373833973b88477b21e : FAILURE in 25m 51s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"e299fe297b4eea39af11f541039ce22d7f49eddb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-05 16:37:30.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/dbc5231cc7b444cbb8e40fcf7d051e57\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/94e11ed34a5c44e68fae0e75abf1597c : SUCCESS in 1h 10m 18s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/52143d31ccbc4a898dac05aaa6706773 : SUCCESS in 1h 51m 41s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9fde1b94f74148a7b6a4e9a3a4cb715c : SUCCESS in 51m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/86e91835c32b485cb664a9fa9f8d0a97 : FAILURE in 19m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eb8acf7b3c6c445fa80ba02a5efb0402 : SUCCESS in 9m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c1020c2e48b14cb4974de1c01003199f : FAILURE in 11m 54s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/3ecd327bac7d4340b96340fdce5e41d0 : FAILURE in 15m 26s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/864775633c254356a343615c50f0df1e : FAILURE in 18m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92688c44e5af430bb8baf7d6436a93b1 : SUCCESS in 11m 27s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/a57977ff56fd4209bdba44acec3e4623 : SUCCESS in 51m 41s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/63d6163e87b341f887775780c7964b66 : SUCCESS in 1h 59m 45s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6192ea3838494253bbdd43817a7851d2 : SUCCESS in 41m 57s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/c4872a8305ee46a58cab043772c8e587 : SUCCESS in 58m 15s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/af3f85c689f949f1a3e15cd12f291dbd : SUCCESS in 2h 29m 30s\n- nova-next https://zuul.opendev.org/t/openstack/build/34a0351302c54e9098e983d5199be049 : SUCCESS in 1h 21m 00s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/b50ac9bc71ea4418bd79951bcc108e2d : SUCCESS in 48m 31s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/24ced3415a894bad996883acbd210d65 : SUCCESS in 5m 31s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a49230ed1d5d4c5099d963b3a49e6e3b : FAILURE in 25m 11s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/90af9f13cb98408ab2acffe1ba0df96d : FAILURE in 32m 34s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/769409c20d8b4aa4b2e5da11059b2f63 : FAILURE in 38m 27s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/1aab188e8a9047ef97eb4e49fbdeefe5 : SUCCESS in 1h 53m 35s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/4a990a7c1a304834af1622e28180cb9d : SUCCESS in 1h 41m 19s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ba3263ea75f54d0aa701a636ba0cc8a6 : SUCCESS in 1h 27m 49s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/db646f68d4f14484b674eb0c54790d2f : SUCCESS in 47m 12s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/31c77db0bd464c04b6a76be7b2fdfb62 : SUCCESS in 18m 57s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/a4e84c0f59e147db8e33b216609c2e7b : SUCCESS in 27m 12s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"bc534bbcbbe5cbabc2c44255ae040ebc403989d4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-04-15 16:31:05.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4eca59fe3600440105b17abb8b667b7f8cab1e99","revisions":{"947f0ccab2fba4901ce5dbd5a7b444a27f1817e3":{"kind":"REWORK","_number":1,"created":"2024-08-02 15:36:59.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/06/925606/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/925606/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/925606/1"}}},"commit":{"parents":[{"commit":"34158119214d81b6c99ee2cccfbde63006e67047","subject":"[manila]Use client token when talking to manila","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34158119214d81b6c99ee2cccfbde63006e67047"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-07-31 15:12:02.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-07-31 15:29:06.000000000","tz":120},"subject":"[manila]Lock/Unlock share by the share_mapping","message":"[manila]Lock/Unlock share by the share_mapping\n\nThe locking done by the SDK when nova creates an access rule is not\nenough as that only restrict the deletion of the access object but does\nnot restrict the deletion of the share itself. So without this fix a\nshare can be deleted via the manila API while the share is used by a\nnova VM.\n\nSo this patch creates a lock on the share directly via the manila API\nduring the allow_share RPC and deletes the lock during the deny_share\nRPC. The lifetime of the lock is tight to the lifetime of the\nshare_mapping and not to the manila access rule as the access rule is\nonly removed if there are no other VMs using the same share.\n\nTODO:\n* Change the DB model to store the lock uuid in the share_mapping table\n  so that nova can delete the lock by uuid\n* Add test coverage\n\nChange-Id: I83ccb134ce77e9c9a79c39e66e77353c736227c3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/947f0ccab2fba4901ce5dbd5a7b444a27f1817e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/947f0ccab2fba4901ce5dbd5a7b444a27f1817e3"}]},"branch":"refs/heads/master"},"f65f63f693c5d6678b37114920301c48079aa4b6":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-08-02 15:37:29.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/06/925606/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/925606/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/925606/2"}}},"commit":{"parents":[{"commit":"34158119214d81b6c99ee2cccfbde63006e67047","subject":"[manila]Use client token when talking to manila","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34158119214d81b6c99ee2cccfbde63006e67047"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-07-31 15:12:02.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-08-02 15:37:03.000000000","tz":120},"subject":"[manila]Lock/Unlock share by the share_mapping","message":"[manila]Lock/Unlock share by the share_mapping\n\nThe locking done by the SDK when nova creates an access rule is not\nenough as that only restrict the deletion of the access object but does\nnot restrict the deletion of the share itself. So without this fix a\nshare can be deleted via the manila API while the share is used by a\nnova VM.\n\nSo this patch creates a lock on the share directly via the manila API\nduring the allow_share RPC and deletes the lock during the deny_share\nRPC. The lifetime of the lock is tight to the lifetime of the\nshare_mapping and not to the manila access rule as the access rule is\nonly removed if there are no other VMs using the same share.\n\nTODO:\n* Change the DB model to store the lock uuid in the share_mapping table\n  so that nova can delete the lock by uuid\n* Add test coverage\n\nDepends-On: https://review.opendev.org/c/openstack/openstacksdk/+/925605\n\nChange-Id: I83ccb134ce77e9c9a79c39e66e77353c736227c3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f65f63f693c5d6678b37114920301c48079aa4b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f65f63f693c5d6678b37114920301c48079aa4b6"}]},"branch":"refs/heads/master"},"4eca59fe3600440105b17abb8b667b7f8cab1e99":{"kind":"REWORK","_number":3,"created":"2024-08-05 13:51:38.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/06/925606/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/06/925606/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/06/925606/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/06/925606/3"}}},"commit":{"parents":[{"commit":"8eb0652bf35a9bcbcc0f66143a84079f92c8aed4","subject":"[manila]Use client token when talking to manila","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8eb0652bf35a9bcbcc0f66143a84079f92c8aed4"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-07-31 15:12:02.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-08-05 13:51:14.000000000","tz":120},"subject":"[manila]Lock/Unlock share by the share_mapping","message":"[manila]Lock/Unlock share by the share_mapping\n\nThe locking done by the SDK when nova creates an access rule is not\nenough as that only restrict the deletion of the access object but does\nnot restrict the deletion of the share itself. So without this fix a\nshare can be deleted via the manila API while the share is used by a\nnova VM.\n\nSo this patch creates a lock on the share directly via the manila API\nduring the allow_share RPC and deletes the lock during the deny_share\nRPC. The lifetime of the lock is tight to the lifetime of the\nshare_mapping and not to the manila access rule as the access rule is\nonly removed if there are no other VMs using the same share.\n\nTODO:\n* Change the DB model to store the lock uuid in the share_mapping table\n  so that nova can delete the lock by uuid\n* Add test coverage\n\nDepends-On: https://review.opendev.org/c/openstack/openstacksdk/+/925605\n\nChange-Id: I83ccb134ce77e9c9a79c39e66e77353c736227c3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4eca59fe3600440105b17abb8b667b7f8cab1e99"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4eca59fe3600440105b17abb8b667b7f8cab1e99"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}