)]}'
{".zuul.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c1524bbec64f14185ef2def0840a3e1befa224e","unresolved":true,"context_lines":[{"line_number":872,"context_line":"#        - cyborg-tempest:"},{"line_number":873,"context_line":"#            irrelevant-files: *nova-base-irrelevant-files"},{"line_number":874,"context_line":"#            voting: false"},{"line_number":875,"context_line":"#        - barbican-tempest-plugin-simple-crypto:"},{"line_number":876,"context_line":"#            irrelevant-files: *nova-base-irrelevant-files"},{"line_number":877,"context_line":"#            voting: false"},{"line_number":878,"context_line":"    gate:"},{"line_number":879,"context_line":"      jobs:"},{"line_number":880,"context_line":"        - nova-live-migration"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0d6c3093_8c612193","line":877,"range":{"start_line":875,"start_character":9,"end_line":877,"end_character":26},"updated":"2024-08-06 23:46:01.000000000","message":"for this poc to be useful we need a job with barbican enabeld and vtpm testing\n\nwe do not need to use this job but we cant get maning full results with just the jobs that are enabeld as they are not using the vtpm feature.","commit_id":"968f8aa5f08c6483a70f6a733f5a61cd0df44ea3"}],"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"986732ff5b9018f2e8a36d0b9c2040eead39a211","unresolved":true,"context_lines":[{"line_number":25,"context_line":"* libvirt.host.find_secret() (called by the secret deletion code) was"},{"line_number":26,"context_line":"  under the impression that \u0027vtpm\u0027 was an invalid usage type. Fix"},{"line_number":27,"context_line":"  that."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Related to blueprint vtpm-live-migration"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I9267dd803ddce61a2847d8e5696f1084c502f1f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":38,"id":"032897ea_45baff34","line":28,"updated":"2025-10-02 22:30:20.000000000","message":"Note to self: need to add a reno to this patch. Alternatively, consider one reno at the end.","commit_id":"9df59ade69e24f63a65a2857ce8a3c3b584aab3f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"29545ecb6673a067d2d4b99afbc4c7a0000dbd2d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"* libvirt.host.find_secret() (called by the secret deletion code) was"},{"line_number":26,"context_line":"  under the impression that \u0027vtpm\u0027 was an invalid usage type. Fix"},{"line_number":27,"context_line":"  that."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Related to blueprint vtpm-live-migration"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I9267dd803ddce61a2847d8e5696f1084c502f1f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":38,"id":"67dbbc3a_304bcc41","line":28,"in_reply_to":"032897ea_45baff34","updated":"2025-10-18 02:35:23.000000000","message":"Done","commit_id":"9df59ade69e24f63a65a2857ce8a3c3b584aab3f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"94222d78cd683a3ee8d60b088ceaa78ff0a53758","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"eead1325_65bd30b8","updated":"2025-09-24 00:37:30.000000000","message":"recheck nova-tox-py312-threading\n```\n  File \"/home/zuul/src/opendev.org/openstack/nova/nova/conductor/manager.py\", line 1224, in rebuild_instance\n    migration \u003d objects.Migration.get_by_instance_and_status(\n                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/oslo_versionedobjects/base.py\", line 184, in wrapper\n    result \u003d fn(cls, context, *args, **kwargs)\n             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/nova/objects/migration.py\", line 174, in get_by_instance_and_status\n    db_migration \u003d db.migration_get_by_instance_and_status(\n                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/nova/db/main/api.py\", line 224, in wrapper\n    return f(context, *args, **kwargs)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/nova/db/main/api.py\", line 3308, in migration_get_by_instance_and_status\n    first()\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/orm/query.py\", line 2759, in first\n    return self.limit(1)._iter().first()  # type: ignore\n           ^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/orm/query.py\", line 2857, in _iter\n    result: Union[ScalarResult[_T], Result[_T]] \u003d self.session.execute(\n                                                  ^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/orm/session.py\", line 2365, in execute\n    return self._execute_internal(\n           ^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/orm/session.py\", line 2241, in _execute_internal\n    conn \u003d self._connection_for_bind(bind)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/orm/session.py\", line 2110, in _connection_for_bind\n    return trans._connection_for_bind(engine, execution_options)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"\u003cstring\u003e\", line 2, in _connection_for_bind\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/orm/state_changes.py\", line 137, in _go\n    ret_value \u003d fn(self, *arg, **kw)\n                ^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/orm/session.py\", line 1242, in _connection_for_bind\n    transaction \u003d conn.begin()\n                  ^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 856, in begin\n    self._transaction \u003d RootTransaction(self)\n                        ^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 2678, in __init__\n    self._connection_begin_impl()\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchem\n    y/engine/base.py\", line 2696, in _connection_begin_impl\n    self.connection._begin_impl(self)\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 1099, in _begin_impl\n    self.dispatch.begin(self)\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/event/attr.py\", line 497, in __call__\n    fn(*args, **kw)\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/oslo_db/sqlalchemy/engines.py\", line 448, in _sqlite_emit_begin\n    conn.execute(sqlalchemy.text(\"BEGIN\"))\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 1413, in execute\n    return meth(\n           ^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/sql/elements.py\", line 526, in _execute_on_connection\n    return connection._execute_clauseelement(\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 1635, in _execute_clauseelement\n    ret \u003d self._execute_context(\n          ^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 1840, in _execute_context\n    return self._exec_single_context(\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 1980, in _exec_single_context\n    self._handle_dbapi_exception(\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 2346, in _handle_dbapi_exception\n    raise newraise.with_traceback(exc_info[2]) from e\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/base.py\", line 1961, in _exec_single_context\n    self.dialect.do_execute(\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py312-threading/lib/python3.12/site-packages/sqlalchemy/engine/default.py\", line 944, in do_execute\n    cursor.execute(statement, parameters)\nsqlalchemy.exc.OperationalError: (sqlite3.OperationalError) cannot start a transaction within a transaction\n```","commit_id":"a6c9036b42a29a20c38cd4c371c014d82b41ed1a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f1f008dc77615f672a88dab3c3bc6acf5cd352de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"06c41e4b_2741b301","updated":"2025-10-08 17:11:03.000000000","message":"recheck rabbit connection timeout\n\nOct 08 07:18:59.317824 np07e0625d928e4 nova-compute[39886]: ERROR oslo.messaging._drivers.impl_rabbit [None req-b831c0aa-1b11-40d0-ab40-b66d01874e10 None None] Connection failed: timed out (retrying in 31.0 seconds): TimeoutError: timed out","commit_id":"faab281fd72ecf32d82594d42df0f3b05e9cbe62"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"af335aa1c68371a31a3e8f283b390b0eb98c7a44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"261d2885_a7414f70","updated":"2025-10-21 03:09:00.000000000","message":"recheck echo \u0027Timed out waiting for controller compute service to be enabled\u0027 seems like nova-compute too slow starting up","commit_id":"6771134440d83ed23ae4b5726d8352ff19405c22"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"db61b4816cd83e2b70eb5d04e5a745497a8e9e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"33e67934_27961770","updated":"2025-11-02 20:04:13.000000000","message":"recheck [instance: 5d1c58ab-d09a-4749-8410-4acf6ea23443] Unable to update binding profile for port: d7afadc0-1491-4055-9272-671437d10467 due to failure: Port d7afadc0-1491-4055-9272-671437d10467 could not be found.","commit_id":"2f73c952fc1b77fd06d64cded6967f18abe43c13"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5e6b69380b18a76d2712a3d34d9110eedd6b0519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"a28845fd_aba56ca6","updated":"2025-11-18 17:14:02.000000000","message":"recheck guest kernel panic","commit_id":"65f3df4a59266706fbe94783a66aca24ec688cec"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9214f1fcc25bcd66be880559eaebc0b650d257a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"f16afd95_b2b52a41","updated":"2026-02-05 22:35:12.000000000","message":"recheck nova-grenade-multinode guest kernel panic","commit_id":"779d7abd89218d2adab71b6a747de575f74601ea"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f82cb161d54cf88ff4cc7dc4bcec012c450cf628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"06283c63_7477d219","updated":"2026-04-04 09:09:53.000000000","message":"recheck dep updated","commit_id":"7eb9d89b77a59477b3079b5afe18f847412cb42d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"43c2271a60df45297dcb75360ac51030c5054361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"3b06f201_56989f6e","updated":"2026-04-05 20:59:39.000000000","message":"recheck dep updated","commit_id":"24f37f1d73fa8be88ff03a6878bc0b0532ef328d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"63dea227802626e49703b54c85a4ed0e5f34c54d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"70c6e9b4_68cda02f","updated":"2026-04-05 18:27:24.000000000","message":"recheck dep updated","commit_id":"24f37f1d73fa8be88ff03a6878bc0b0532ef328d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"884cb81ba0cd3f6ed96efaa557fd9add9752c4da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"c5e4f48a_e1e59594","updated":"2026-04-06 00:46:54.000000000","message":"recheck dep updated","commit_id":"24f37f1d73fa8be88ff03a6878bc0b0532ef328d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0b269d0c80bcb9e4e5f4e3726eb103a1fa98f218","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"e14d0391_0cc614ef","updated":"2026-04-05 00:07:10.000000000","message":"recheck dep updated","commit_id":"24f37f1d73fa8be88ff03a6878bc0b0532ef328d"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f9e49b83c28867eef96836e3ab59f00d2cdb552","unresolved":true,"context_lines":[{"line_number":5527,"context_line":"        until\u003dMIN_COMPUTE_VDPA_HOTPLUG_LIVE_MIGRATION"},{"line_number":5528,"context_line":"    )"},{"line_number":5529,"context_line":"    @block_accelerators()"},{"line_number":5530,"context_line":"    @reject_vtpm_instances(instance_actions.LIVE_MIGRATION)"},{"line_number":5531,"context_line":"    @reject_sev_instances(instance_actions.LIVE_MIGRATION)"},{"line_number":5532,"context_line":"    @check_instance_lock"},{"line_number":5533,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.PAUSED])"}],"source_content_type":"text/x-python","patch_set":3,"id":"54734395_5d0978ef","side":"PARENT","line":5530,"updated":"2024-08-06 19:33:50.000000000","message":"this will need to be conditional based on the min compute service version","commit_id":"bb2d7f9cad577f3a32cb9523e2b1d9a6d6db3407"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f9e49b83c28867eef96836e3ab59f00d2cdb552","unresolved":true,"context_lines":[{"line_number":11491,"context_line":"            LOG.debug(\u0027No dst_numa_info in migrate_data, \u0027"},{"line_number":11492,"context_line":"                      \u0027no cores to power up in pre_live_migration.\u0027)"},{"line_number":11493,"context_line":""},{"line_number":11494,"context_line":"        secret_uuid, passphrase \u003d crypto.ensure_vtpm_secret(context, instance)"},{"line_number":11495,"context_line":"        libvirt_secret \u003d self._host.create_secret("},{"line_number":11496,"context_line":"            \u0027vtpm\u0027, instance.uuid, password\u003dpassphrase,"},{"line_number":11497,"context_line":"            uuid\u003dsecret_uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6a62c1da_8e368b05","line":11494,"updated":"2024-08-06 19:33:50.000000000","message":"this will need a compute server version bump","commit_id":"968f8aa5f08c6483a70f6a733f5a61cd0df44ea3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84389c821d5053068ab556bbb5f6d2aaeeabc638","unresolved":true,"context_lines":[{"line_number":11491,"context_line":"            LOG.debug(\u0027No dst_numa_info in migrate_data, \u0027"},{"line_number":11492,"context_line":"                      \u0027no cores to power up in pre_live_migration.\u0027)"},{"line_number":11493,"context_line":""},{"line_number":11494,"context_line":"        secret_uuid, passphrase \u003d crypto.ensure_vtpm_secret(context, instance)"},{"line_number":11495,"context_line":"        libvirt_secret \u003d self._host.create_secret("},{"line_number":11496,"context_line":"            \u0027vtpm\u0027, instance.uuid, password\u003dpassphrase,"},{"line_number":11497,"context_line":"            uuid\u003dsecret_uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1960cbc_dd3956e1","line":11494,"in_reply_to":"6a62c1da_8e368b05","updated":"2024-08-06 19:34:39.000000000","message":"we will also need to delete this on revert by the way","commit_id":"968f8aa5f08c6483a70f6a733f5a61cd0df44ea3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dbcea9c9604187e1cbee1e48b32ed4e623359ff9","unresolved":true,"context_lines":[{"line_number":11734,"context_line":"        \"\"\"Clean up destination node after a failed live migration.\"\"\""},{"line_number":11735,"context_line":"        secret_uuid \u003d instance.system_metadata.get(\u0027vtpm_secret_uuid\u0027)"},{"line_number":11736,"context_line":"        if secret_uuid:"},{"line_number":11737,"context_line":"            self._host.delete_secret(\u0027vtpm\u0027, instance.uuid)"},{"line_number":11738,"context_line":"        try:"},{"line_number":11739,"context_line":"            self.destroy(context, instance, network_info, block_device_info,"},{"line_number":11740,"context_line":"                         destroy_disks)"}],"source_content_type":"text/x-python","patch_set":42,"id":"ca256f17_fe82bf02","line":11737,"updated":"2025-10-16 00:09:01.000000000","message":"TODO: should add code comment about why this is needed.\n\n(It\u0027s because for \u0027deployment\u0027 secret security, the libvirt secret needs to be created on the dest, then start the guest on the dest, then undefine/delete the secret on the dest. Well, if we don\u0027t succeed the live migration, we won\u0027t reach the undefine/delete step, so we need to delete it as part of the rollback.)","commit_id":"95c9fe756a28ea1ee6c1ed9aae6d2dc9c5cc16f9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"29545ecb6673a067d2d4b99afbc4c7a0000dbd2d","unresolved":false,"context_lines":[{"line_number":11734,"context_line":"        \"\"\"Clean up destination node after a failed live migration.\"\"\""},{"line_number":11735,"context_line":"        secret_uuid \u003d instance.system_metadata.get(\u0027vtpm_secret_uuid\u0027)"},{"line_number":11736,"context_line":"        if secret_uuid:"},{"line_number":11737,"context_line":"            self._host.delete_secret(\u0027vtpm\u0027, instance.uuid)"},{"line_number":11738,"context_line":"        try:"},{"line_number":11739,"context_line":"            self.destroy(context, instance, network_info, block_device_info,"},{"line_number":11740,"context_line":"                         destroy_disks)"}],"source_content_type":"text/x-python","patch_set":42,"id":"1475aaa1_1522d772","line":11737,"in_reply_to":"ca256f17_fe82bf02","updated":"2025-10-18 02:35:23.000000000","message":"Done","commit_id":"95c9fe756a28ea1ee6c1ed9aae6d2dc9c5cc16f9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dbcea9c9604187e1cbee1e48b32ed4e623359ff9","unresolved":true,"context_lines":[{"line_number":11738,"context_line":"        try:"},{"line_number":11739,"context_line":"            self.destroy(context, instance, network_info, block_device_info,"},{"line_number":11740,"context_line":"                         destroy_disks)"},{"line_number":11741,"context_line":"            if ("},{"line_number":11742,"context_line":"                \u0027vtpm_secret_uuid\u0027 in migrate_data and"},{"line_number":11743,"context_line":"                \u0027vtpm_secret_value\u0027 in migrate_data"},{"line_number":11744,"context_line":"            ):"},{"line_number":11745,"context_line":"                self._host.delete_secret(\u0027vtpm\u0027, instance.uuid)"},{"line_number":11746,"context_line":"        finally:"},{"line_number":11747,"context_line":"            # NOTE(gcb): Failed block live migration may leave instance"},{"line_number":11748,"context_line":"            # directory at destination node, ensure it is always deleted."}],"source_content_type":"text/x-python","patch_set":42,"id":"680270ae_2d587b50","line":11745,"range":{"start_line":11741,"start_character":0,"end_line":11745,"end_character":63},"updated":"2025-10-16 00:09:01.000000000","message":"And if we have the above, we don\u0027t need this, right?","commit_id":"95c9fe756a28ea1ee6c1ed9aae6d2dc9c5cc16f9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"29545ecb6673a067d2d4b99afbc4c7a0000dbd2d","unresolved":false,"context_lines":[{"line_number":11738,"context_line":"        try:"},{"line_number":11739,"context_line":"            self.destroy(context, instance, network_info, block_device_info,"},{"line_number":11740,"context_line":"                         destroy_disks)"},{"line_number":11741,"context_line":"            if ("},{"line_number":11742,"context_line":"                \u0027vtpm_secret_uuid\u0027 in migrate_data and"},{"line_number":11743,"context_line":"                \u0027vtpm_secret_value\u0027 in migrate_data"},{"line_number":11744,"context_line":"            ):"},{"line_number":11745,"context_line":"                self._host.delete_secret(\u0027vtpm\u0027, instance.uuid)"},{"line_number":11746,"context_line":"        finally:"},{"line_number":11747,"context_line":"            # NOTE(gcb): Failed block live migration may leave instance"},{"line_number":11748,"context_line":"            # directory at destination node, ensure it is always deleted."}],"source_content_type":"text/x-python","patch_set":42,"id":"c56fdb0f_61ee52fd","line":11745,"range":{"start_line":11741,"start_character":0,"end_line":11745,"end_character":63},"in_reply_to":"680270ae_2d587b50","updated":"2025-10-18 02:35:23.000000000","message":"Done","commit_id":"95c9fe756a28ea1ee6c1ed9aae6d2dc9c5cc16f9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb473b4df4a2234a38760cc3869c33583dd77693","unresolved":true,"context_lines":[{"line_number":12083,"context_line":"                instance.flavor) \u003d\u003d \u0027deployment\u0027:"},{"line_number":12084,"context_line":"            # For \u0027deployment\u0027 secret security mode, we need to create the"},{"line_number":12085,"context_line":"            # libvirt secret on the destination ahead of the live migration."},{"line_number":12086,"context_line":"            self._get_or_create_secret_for_vtpm(context, instance)"},{"line_number":12087,"context_line":""},{"line_number":12088,"context_line":"        return migrate_data"},{"line_number":12089,"context_line":""}],"source_content_type":"text/x-python","patch_set":73,"id":"26b37fcd_22f507dc","line":12086,"updated":"2026-04-02 18:18:32.000000000","message":"before we do this we shoudl do a partical revert of \nhttps://review.opendev.org/c/openstack/nova/+/942021\nto remove the get_nova_service_user_context function and its use in \nget_request_context.\nhttps://opendev.org/openstack/nova/src/branch/master/nova/vtpm.py#L62-L75\n\nwe shoudl instead be exclusively using a dedicated  `barbican` section.\n\nthis is complcated in this case as castalena seam to be registereing that itself \nbecause at some poitn we apprently deprecated the secton \n\nhttps://github.com/openstack/nova/blob/653f7a42d0c9db126c0d5eb94af8945732f68d72/releasenotes/notes/deprecate-barbican-config-options-68ae65643ac41e2f.yaml#L4\n\n\nso instead of the barnican se\nhttps://docs.openstack.org/nova/latest/configuration/config.html#barbican \nbeing defiend in nova and beign a full keystone auth section some options are spread into \nhttps://docs.openstack.org/nova/latest/configuration/config.html#barbican-service-user\n\n\n\ni personaly see 3 options\n1 add `[barbican_client]` or some other section that we excludvly use wehn we need to use the openstack sdk to talk to barbcan.\n2 compose the optoin we required form teh 2 setc fo castellan ones.\n3 deprecate the [barbican-service-user] in castalan and move those option adn any other option requried to make the `[barbican]` secton a superset fo the standard keystone_auth options.","commit_id":"95390f35a150564844b7c03e81bab99ec4c794a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"14ab5f0f4cde6f76237761cd55848c98b05b2340","unresolved":true,"context_lines":[{"line_number":12083,"context_line":"                instance.flavor) \u003d\u003d \u0027deployment\u0027:"},{"line_number":12084,"context_line":"            # For \u0027deployment\u0027 secret security mode, we need to create the"},{"line_number":12085,"context_line":"            # libvirt secret on the destination ahead of the live migration."},{"line_number":12086,"context_line":"            self._get_or_create_secret_for_vtpm(context, instance)"},{"line_number":12087,"context_line":""},{"line_number":12088,"context_line":"        return migrate_data"},{"line_number":12089,"context_line":""}],"source_content_type":"text/x-python","patch_set":73,"id":"d2aee351_a15c0a70","line":12086,"in_reply_to":"26b37fcd_22f507dc","updated":"2026-04-02 18:22:04.000000000","message":"if we make this change we would also need \nhttps://review.opendev.org/c/openstack/devstack/+/968114","commit_id":"95390f35a150564844b7c03e81bab99ec4c794a0"}]}