)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f456ea6de8d23fed431782466ffb322d808b776f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70927a5a_07a84de2","updated":"2024-08-19 13:13:41.000000000","message":"-1 is mainly for the misleading comments\nand partly because this should ideally be tested without using the libvirt test case\n\nwe shoudl use the generic one but im kind fo ok with using libvirt\n\nnote you will need to fix the fake virt driver too eventuallly","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b57537200c3a5ff34d6594c7e393d00a116c77e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b8c1e4c0_b0369993","updated":"2024-08-29 23:17:08.000000000","message":"Looks OK to me","commit_id":"cd05be973870237753b9e78683ffefaa40177ada"}],"nova/tests/functional/regressions/test_bug_2062425.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ed9747d93c7b4516d6c804559970dbc17ef04de3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4dd5ac3d_998420c2","line":43,"updated":"2024-08-12 11:05:34.000000000","message":"for some reason, just self.assertRaises(exception.NoVlidHost, self._create_server,..,..) did not work for me.","commit_id":"717eb8a3552479be92d320dcce06df8bad10a23a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f456ea6de8d23fed431782466ffb322d808b776f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a166da25_32891a01","line":43,"in_reply_to":"4dd5ac3d_998420c2","updated":"2024-08-19 13:13:41.000000000","message":"that becasue you should not get a NoValidHost execption\n\nyou shoudl get a openstack api client expception or similar\n\nyou are calling the rest api so you cant expect to get a server side api exepction class here.\n\nserver create is also an async operation so you will only get a direct exepction of its a format/auth/login related issue or if the validation of the request fails because a flaovr/image does not exsit\n\nthe create server api request will succeed\nthe instnace however will go into the errror state instead of active beccause teh schduler fails to find a host but that is not reflected in the api respcoe since that happesn after we respond to the client.\n\n\nthis is the correcct way to assert the error","commit_id":"717eb8a3552479be92d320dcce06df8bad10a23a"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1b3b2acbbc24a60685de6581849a0065179ddd64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"724ff47d_2e0d1ef4","line":43,"in_reply_to":"a166da25_32891a01","updated":"2024-08-20 15:02:55.000000000","message":"Acknowledged, thanks, I get the async call because of rpc.cast.\n\nbut I was hoping to assert exception directly because I am using wait to get into error and that time, exception will be raised.\n\nI checked in cli by directly calling the API and there also, it only say failed, and do not say exception raised at compute side, only `Error creating server`,  so its alright.","commit_id":"717eb8a3552479be92d320dcce06df8bad10a23a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f456ea6de8d23fed431782466ffb322d808b776f","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.tests.functional.libvirt import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb6381_857580c4","line":18,"updated":"2024-08-19 13:13:41.000000000","message":"technically this is ont virt driver sepcific.\n\nwe can use the libvirt testcase but you shoudl be able to repoduce this with any virt driver today since none fo them are currently reporting the architecture traits.","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85dc12c034be69f785f4078d6ea7f83e4c916fc1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.tests.functional.libvirt import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3cbb7f2_93023718","line":18,"in_reply_to":"a46eb6fb_dda1a5bd","updated":"2024-08-21 11:37:27.000000000","message":"Acknowledged","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24b6295cdea33e0de26d3004f5bc7da7b9f9258f","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.tests.functional.libvirt import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":3,"id":"a46eb6fb_dda1a5bd","line":18,"in_reply_to":"dcd0a8f2_9b783936","updated":"2024-08-20 15:44:29.000000000","message":"no we rechnaly shoudl be using the fake driver here.\n\nremember the regression tests in generall are not ment ot use the deeper base classes.\n\nim just reminding amit that in general we should not use the more advanced fixtures if we can repoduce it with the less advanced one.\n\n\ni didn\u0027t -1 for this but using the libvirt fixture reduces test coverage it does not increase it in genereal.","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4562fa62e65633257919b0aaa9a7f48046a065ac","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.tests.functional.libvirt import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":3,"id":"5897748b_edf3ecc2","line":18,"in_reply_to":"dfeb6381_857580c4","updated":"2024-08-20 14:51:17.000000000","message":"I understand that this is not libvirt-specific, but each virt driver will have to implement the fix, so aren\u0027t we better off testing with the libvirt driver and our fakelibvirt fixture so that the subsequent fix in the libvirt driver is tested by the functional test?\n\nThe alternative is to use the fake virt driver in the reproducer test, and then the fix will have to include the fake virt driver, which seems less useful than testing the libvirt driver fix in func tests.\n\nAm I missing something?","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1b3b2acbbc24a60685de6581849a0065179ddd64","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.tests.functional.libvirt import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":3,"id":"dcd0a8f2_9b783936","line":18,"in_reply_to":"dfeb6381_857580c4","updated":"2024-08-20 15:02:55.000000000","message":"with suggested changes, in this patch (reproducer) now getting NoValidHost for all archs (locally tested)\n\nbut without libvirtfixture, test is not passing, even TRAIT is added in resource provider (i.e fix in next patch).\n\n\nupdated reporducer without libvitfxiture: https://paste.openstack.org/show/bHXtIN2O1MHcv4VdHfy7/","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f456ea6de8d23fed431782466ffb322d808b776f","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Regression test for bug #2062425"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    reference arch list"},{"line_number":26,"context_line":"    https://docs.openstack.org/glance/latest/admin/useful-image-properties.html#image-property-keys-and-values"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2cc7dc87_20fd74a7","line":26,"updated":"2024-08-19 13:13:41.000000000","message":"you can link to this but the actual source of truth for this is in nova not glance\n\n\nhttps://docs.openstack.org/glance/latest/admin/useful-image-properties.html os just addtional docs for the image properties defiend in nova code.\n\n\nin this case \n\nhttps://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L319-L320\n\nis an enum filed\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L1228\n\ndefiend here\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L120-L228\n\nanyway we dont need to change thsi just letting you knwo for future refernce\n\nstephen had an old patch to properly document this in nova\n\nhttps://review.opendev.org/c/openstack/nova/+/756867\n\nwhich i quickly rebased\n\nso goign for ward we may agress this gap an allow use to obsolete \nhttps://docs.openstack.org/glance/latest/admin/useful-image-properties.html","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1b3b2acbbc24a60685de6581849a0065179ddd64","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Regression test for bug #2062425"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    reference arch list"},{"line_number":26,"context_line":"    https://docs.openstack.org/glance/latest/admin/useful-image-properties.html#image-property-keys-and-values"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"73227675_0c17ae53","line":26,"in_reply_to":"2cc7dc87_20fd74a7","updated":"2024-08-20 15:02:55.000000000","message":"Acknowledged, yes I was in doubt so added ref. thanks for clearing.","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85dc12c034be69f785f4078d6ea7f83e4c916fc1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Regression test for bug #2062425"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    reference arch list"},{"line_number":26,"context_line":"    https://docs.openstack.org/glance/latest/admin/useful-image-properties.html#image-property-keys-and-values"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    microversion \u003d \u0027latest\u0027"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a54bddea_67a157db","line":26,"in_reply_to":"73227675_0c17ae53","updated":"2024-08-21 11:37:27.000000000","message":"Acknowledged","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f456ea6de8d23fed431782466ffb322d808b776f","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        # but I think that makes it tempest test."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # right now just hard-coding,"},{"line_number":42,"context_line":"        # because I know this is same for CI as well."},{"line_number":43,"context_line":"        arch \u003d \"x86_64\""},{"line_number":44,"context_line":"        cpu_arch_image \u003d copy.deepcopy(self.glance.image1)"},{"line_number":45,"context_line":"        cpu_arch_image[\u0027properties\u0027][\u0027hw_architecture\u0027] \u003d arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"72a11d8d_c82ba148","line":42,"updated":"2024-08-19 13:13:41.000000000","message":"ci has nothing to do with this.\n\nthis is a functional test. it does not depend on teh acrchitrure of the host it runs on or on ci.\n\nwe can and should hardcode this.","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24b6295cdea33e0de26d3004f5bc7da7b9f9258f","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        # but I think that makes it tempest test."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # right now just hard-coding,"},{"line_number":42,"context_line":"        # because I know this is same for CI as well."},{"line_number":43,"context_line":"        arch \u003d \"x86_64\""},{"line_number":44,"context_line":"        cpu_arch_image \u003d copy.deepcopy(self.glance.image1)"},{"line_number":45,"context_line":"        cpu_arch_image[\u0027properties\u0027][\u0027hw_architecture\u0027] \u003d arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"c2a68279_d02f7b26","line":42,"in_reply_to":"72a11d8d_c82ba148","updated":"2024-08-20 15:44:29.000000000","message":"this is why i -1\n\nits implying that this test case depend on what we use in the ci or the laptop we run it on. it dose not","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85dc12c034be69f785f4078d6ea7f83e4c916fc1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        # but I think that makes it tempest test."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # right now just hard-coding,"},{"line_number":42,"context_line":"        # because I know this is same for CI as well."},{"line_number":43,"context_line":"        arch \u003d \"x86_64\""},{"line_number":44,"context_line":"        cpu_arch_image \u003d copy.deepcopy(self.glance.image1)"},{"line_number":45,"context_line":"        cpu_arch_image[\u0027properties\u0027][\u0027hw_architecture\u0027] \u003d arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"913322a4_8a7199ec","line":42,"in_reply_to":"c2a68279_d02f7b26","updated":"2024-08-21 11:37:27.000000000","message":"Done","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24b6295cdea33e0de26d3004f5bc7da7b9f9258f","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_server_create_with_arm(self):"},{"line_number":59,"context_line":"        # for some reason armv7l, succeeded in x86_64 hosts,"},{"line_number":60,"context_line":"        # when it should not."},{"line_number":61,"context_line":"        arch \u003d \"armv7l\""},{"line_number":62,"context_line":"        cpu_arch_image \u003d copy.deepcopy(self.glance.image1)"},{"line_number":63,"context_line":"        cpu_arch_image[\u0027properties\u0027][\u0027hw_architecture\u0027] \u003d arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb93c69d_0ec29205","line":60,"updated":"2024-08-20 15:44:29.000000000","message":"it succeed becasue there is no trait for armv7 little ending\n\nso this is expected to work because the triat is not being added as a required trait\n\nARMV7 does exist and will fail.\n\nso this testcase is misleading","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85dc12c034be69f785f4078d6ea7f83e4c916fc1","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_server_create_with_arm(self):"},{"line_number":59,"context_line":"        # for some reason armv7l, succeeded in x86_64 hosts,"},{"line_number":60,"context_line":"        # when it should not."},{"line_number":61,"context_line":"        arch \u003d \"armv7l\""},{"line_number":62,"context_line":"        cpu_arch_image \u003d copy.deepcopy(self.glance.image1)"},{"line_number":63,"context_line":"        cpu_arch_image[\u0027properties\u0027][\u0027hw_architecture\u0027] \u003d arch"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aff147a_f64c45df","line":60,"in_reply_to":"bb93c69d_0ec29205","updated":"2024-08-21 11:37:27.000000000","message":"Done","commit_id":"407c6e1cd80fbd0a308edb2560baff5450a8cb5d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b57537200c3a5ff34d6594c7e393d00a116c77e4","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":"import ddt"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f75d2dd0_c87e36b3","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"updated":"2024-08-29 23:17:08.000000000","message":"Nit: ddt is a third party lib so it should go next to the oslo import below, not here.","commit_id":"cd05be973870237753b9e78683ffefaa40177ada"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9f967cf53ee2f2009dd2d56e97dcac7e11bee5df","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":"import ddt"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"235b1b05_37b93067","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"in_reply_to":"f75d2dd0_c87e36b3","updated":"2024-08-30 06:29:47.000000000","message":"ack,\nits unused, I missed to remove it. earlier was testing this reproducer with other cpu_arch, but then removed them and forgot to remove this","commit_id":"cd05be973870237753b9e78683ffefaa40177ada"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c8d2602bed18bf8cce1eda8ca682a10c62b4a03","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        self.start_compute()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_server_create_with_valid_arch(self):"},{"line_number":38,"context_line":"        arch \u003d \"x86_64\""},{"line_number":39,"context_line":"        cpu_arch_image \u003d copy.deepcopy(self.glance.image1)"},{"line_number":40,"context_line":"        cpu_arch_image[\u0027properties\u0027][\u0027hw_architecture\u0027] \u003d arch"},{"line_number":41,"context_line":"        cpu_arch_image[\u0027id\u0027] \u003d uuids.cpu_arch_image"}],"source_content_type":"text/x-python","patch_set":4,"id":"adb6a602_64c5e04d","line":38,"updated":"2024-08-21 11:38:49.000000000","message":"by the way we will need to ensure that the libvirt fixture returns x86_64 as the cpu architecture when fixing this.\n\ni think we alraddy did that a few years ago when the arm ci was being added but we shoudl double check","commit_id":"cd05be973870237753b9e78683ffefaa40177ada"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b57537200c3a5ff34d6594c7e393d00a116c77e4","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        self.start_compute()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_server_create_with_valid_arch(self):"},{"line_number":38,"context_line":"        arch \u003d \"x86_64\""},{"line_number":39,"context_line":"        cpu_arch_image \u003d copy.deepcopy(self.glance.image1)"},{"line_number":40,"context_line":"        cpu_arch_image[\u0027properties\u0027][\u0027hw_architecture\u0027] \u003d arch"},{"line_number":41,"context_line":"        cpu_arch_image[\u0027id\u0027] \u003d uuids.cpu_arch_image"}],"source_content_type":"text/x-python","patch_set":4,"id":"37ccfd00_48e39e91","line":38,"in_reply_to":"adb6a602_64c5e04d","updated":"2024-08-29 23:17:08.000000000","message":"It looks like it does return x86_64?\nhttps://github.com/openstack/nova/blob/7e082705de486c36cb221edce3e53463b514c617/nova/tests/fixtures/libvirt.py#L793","commit_id":"cd05be973870237753b9e78683ffefaa40177ada"}]}