)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70ce9acae7f3ba1b21cd5ad58f993b04504d71dc","unresolved":true,"context_lines":[{"line_number":2460,"context_line":"            LOG.info(\u0027Took %0.2f seconds to build instance.\u0027,"},{"line_number":2461,"context_line":"                     timer.elapsed(), instance\u003dinstance)"},{"line_number":2462,"context_line":"            return build_results.ACTIVE"},{"line_number":2463,"context_line":"        except exception.RescheduledException as e:"},{"line_number":2464,"context_line":"            retry \u003d filter_properties.get(\u0027retry\u0027)"},{"line_number":2465,"context_line":"            if not retry:"},{"line_number":2466,"context_line":"                # no retry information, do not reschedule."}],"source_content_type":"text/x-python","patch_set":3,"id":"fad914a2_7698d1e3","line":2463,"updated":"2024-08-14 18:06:01.000000000","message":"3.) ... we should move the instnace.refesh() here instead of using a decorator\n\nthat way we are sure.","commit_id":"bb9de3a07993412276566d75cd67cfa5c56cd9c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70ce9acae7f3ba1b21cd5ad58f993b04504d71dc","unresolved":true,"context_lines":[{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"            self._nil_out_instance_obj_host_and_node(instance)"},{"line_number":2490,"context_line":"            instance.task_state \u003d task_states.SCHEDULING"},{"line_number":2491,"context_line":"            instance.save()"},{"line_number":2492,"context_line":"            # The instance will have already claimed resources from this host"},{"line_number":2493,"context_line":"            # before this build was attempted. Now that it has failed, we need"},{"line_number":2494,"context_line":"            # to unclaim those resources before casting to the conductor, so"}],"source_content_type":"text/x-python","patch_set":3,"id":"42bce069_745b6ba9","line":2491,"updated":"2024-08-14 18:06:01.000000000","message":"4.) that it refreshed before this save.","commit_id":"bb9de3a07993412276566d75cd67cfa5c56cd9c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70ce9acae7f3ba1b21cd5ad58f993b04504d71dc","unresolved":true,"context_lines":[{"line_number":2497,"context_line":"            self.reportclient.delete_allocation_for_instance("},{"line_number":2498,"context_line":"                context, instance.uuid, force\u003dTrue)"},{"line_number":2499,"context_line":""},{"line_number":2500,"context_line":"            self.compute_task_api.build_instances(context, [instance],"},{"line_number":2501,"context_line":"                    image, filter_properties, admin_password,"},{"line_number":2502,"context_line":"                    injected_files, requested_networks, security_groups,"},{"line_number":2503,"context_line":"                    block_device_mapping, request_spec\u003drequest_spec,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a82f0575_6b61a679","line":2500,"updated":"2024-08-14 18:06:01.000000000","message":"instead of being staved on the conductor as a result of this rpc","commit_id":"bb9de3a07993412276566d75cd67cfa5c56cd9c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f8049a474a3fe83532e49888673792860951eddd","unresolved":true,"context_lines":[{"line_number":2497,"context_line":"            self.reportclient.delete_allocation_for_instance("},{"line_number":2498,"context_line":"                context, instance.uuid, force\u003dTrue)"},{"line_number":2499,"context_line":""},{"line_number":2500,"context_line":"            self.compute_task_api.build_instances(context, [instance],"},{"line_number":2501,"context_line":"                    image, filter_properties, admin_password,"},{"line_number":2502,"context_line":"                    injected_files, requested_networks, security_groups,"},{"line_number":2503,"context_line":"                    block_device_mapping, request_spec\u003drequest_spec,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b954207_2ca40fc7","line":2500,"in_reply_to":"a82f0575_6b61a679","updated":"2024-08-14 18:07:23.000000000","message":"this was 5.)","commit_id":"bb9de3a07993412276566d75cd67cfa5c56cd9c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70ce9acae7f3ba1b21cd5ad58f993b04504d71dc","unresolved":true,"context_lines":[{"line_number":2568,"context_line":"        else:"},{"line_number":2569,"context_line":"            return None"},{"line_number":2570,"context_line":""},{"line_number":2571,"context_line":"    def _build_and_run_instance(self, context, instance, image, injected_files,"},{"line_number":2572,"context_line":"            admin_password, requested_networks, security_groups,"},{"line_number":2573,"context_line":"            block_device_mapping, node, limits, filter_properties,"},{"line_number":2574,"context_line":"            request_spec\u003dNone, accel_uuids\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fb826e62_151c824f","line":2571,"updated":"2024-08-14 18:06:01.000000000","message":"2.) there are too many ways to exit form this for me to be comfortable  so either we shoudl add a decorator to this...","commit_id":"bb9de3a07993412276566d75cd67cfa5c56cd9c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70ce9acae7f3ba1b21cd5ad58f993b04504d71dc","unresolved":true,"context_lines":[{"line_number":2741,"context_line":"                          instance\u003dinstance)"},{"line_number":2742,"context_line":"            # NOTE(mgoddard): If the instance has any PCI devices,"},{"line_number":2743,"context_line":"            # these will have been deallocated."},{"line_number":2744,"context_line":"            instance.refresh()"},{"line_number":2745,"context_line":"            self._notify_about_instance_usage(context, instance,"},{"line_number":2746,"context_line":"                    \u0027create.error\u0027, fault\u003de)"},{"line_number":2747,"context_line":"            compute_utils.notify_about_instance_create("}],"source_content_type":"text/x-python","patch_set":3,"id":"642a362e_27e8d81f","line":2744,"updated":"2024-08-14 18:06:01.000000000","message":"1.) while this now works since this is the path we are taking in the functioanl test because the exectip we are raising is not caught by any of the excpet cases.","commit_id":"bb9de3a07993412276566d75cd67cfa5c56cd9c2"}]}