)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"fed33f42af72f3b4a05cfd805659169e5b4f175c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96b27750_f484046a","updated":"2024-08-21 09:29:48.000000000","message":"recheck unrelated tempest test failed for nova-multi-cell job\n2 with server taking too much time to allow SSH access, because booting took longer\n1 test_instances_with_cinder_volumes_on_all_compute_nodes: ssh timeout while running mkfs on target vm.","commit_id":"e6954514ef393261f7469428bc7aa06d3f1e79ae"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"44550beace718f2301fe5b1ebe67f8b6c84aae18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b419cb1d_6224ef7f","updated":"2024-09-25 10:36:12.000000000","message":"Looks fine to me.","commit_id":"180f97c24923af62222e2c77f9c6688fec7bb817"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d3c1bd3f02f1ee4b92e1ead8897352a17e6f69ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"710fa572_c8cdd95e","updated":"2024-08-30 06:32:55.000000000","message":"recheck\nthe gate -1 is because of docs-job bug, which is fixes now, so this is good to review","commit_id":"180f97c24923af62222e2c77f9c6688fec7bb817"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a2081fcc8aae3b901d0dc61b2cb32d7ebfc5af17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"addc070d_7a260c5d","updated":"2024-10-09 19:51:48.000000000","message":"Soft -1 same as the point on the previous patch","commit_id":"ab1360b2c86d0c12d7576b29a3de8958b6bf39ef"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b5f71c42b54c8a4c55aad19691828089f019ae47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dd7490d0_54fb72ca","updated":"2024-10-10 20:52:24.000000000","message":"Looks good to me. I want to let Sean sign off on this (confirm this is the only trait we want VMware driver to report) and I\u0027ll upgrade to +2.","commit_id":"4f587a58fa90ed07db6bf924dd9b9b132c7c6930"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f19ad0565ff33dfc0395eafde7b15dcc3e2f0de2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9bfed201_01ac9912","updated":"2024-10-16 17:04:57.000000000","message":"Upgrading to +2/+W after Sean\u0027s ack, thanks","commit_id":"4f587a58fa90ed07db6bf924dd9b9b132c7c6930"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"57208461d8009a249db722539fa178d6decd2d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6d4b092c_bbb64c2b","updated":"2024-10-10 10:01:07.000000000","message":"recheck \nap-get update deployment issue\nErr:23 https://mirror.sjc3.raxflex.opendev.org/ubuntu jammy-security/main amd64 Packages\n  403  Forbidden [IP: 65.17.193.187 443]","commit_id":"4f587a58fa90ed07db6bf924dd9b9b132c7c6930"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f19ad0565ff33dfc0395eafde7b15dcc3e2f0de2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fa310478_4391c758","in_reply_to":"d4c730dd_cff546ff","updated":"2024-10-16 17:04:57.000000000","message":"Yep, makes sense. I agree better to under report and adjust than to over report.","commit_id":"4f587a58fa90ed07db6bf924dd9b9b132c7c6930"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d5e2c2d405af62cd54c0da0d9fd97a92ab7d30a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d4c730dd_cff546ff","in_reply_to":"dd7490d0_54fb72ca","updated":"2024-10-16 09:37:58.000000000","message":"VMware is trciky. it apprenly can supprot other architeture but i have neeve seen which ones it supprot docuemnted.\n\nand while vmware may be able to do that i dont know if vmware via nova can\n\nso for now i would be lincned to just have x86 for now and if someone comes and says hay X also work and here is how to detect it we can go back and add that.\n\nwe hav so little testing on the vmware side that i would prefer to under preport and fix it later then over report and not know.","commit_id":"4f587a58fa90ed07db6bf924dd9b9b132c7c6930"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"0e521786552bf1e25f4f8e16249e7a0c5cf859e7","unresolved":true,"context_lines":[{"line_number":2148,"context_line":"    def test__get_cpu_traits(self):"},{"line_number":2149,"context_line":"        expected \u003d {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":2150,"context_line":"        traits \u003d self.conn._get_cpu_traits()"},{"line_number":2151,"context_line":"        self.assertDictEqual(traits, expected)"},{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"    def test_invalid_datastore_regex(self):"},{"line_number":2154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f9118464_8024adb5","line":2151,"updated":"2024-08-22 07:50:24.000000000","message":"I think we usually have the expected as first argument (e.g. line 2146 above, but also looking at a `git grep assertDictEqual`).","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"0ea98864ed1f551ef5892e8dcc0fa604c36db4f7","unresolved":false,"context_lines":[{"line_number":2148,"context_line":"    def test__get_cpu_traits(self):"},{"line_number":2149,"context_line":"        expected \u003d {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":2150,"context_line":"        traits \u003d self.conn._get_cpu_traits()"},{"line_number":2151,"context_line":"        self.assertDictEqual(traits, expected)"},{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"    def test_invalid_datastore_regex(self):"},{"line_number":2154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c48316ba_a6615d30","line":2151,"in_reply_to":"1baa9db5_ef82cb6d","updated":"2024-08-29 08:54:49.000000000","message":"Done","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8136caf7ba6e8e968ed2bd832e9f9d44ebab381a","unresolved":true,"context_lines":[{"line_number":2148,"context_line":"    def test__get_cpu_traits(self):"},{"line_number":2149,"context_line":"        expected \u003d {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":2150,"context_line":"        traits \u003d self.conn._get_cpu_traits()"},{"line_number":2151,"context_line":"        self.assertDictEqual(traits, expected)"},{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"    def test_invalid_datastore_regex(self):"},{"line_number":2154,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1baa9db5_ef82cb6d","line":2151,"in_reply_to":"f9118464_8024adb5","updated":"2024-08-22 08:15:37.000000000","message":"ack, sure, will fix it on/if respin","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f39c579c61ba560af876304d5593bf551b1189a0","unresolved":true,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"581f619b_6941065d","line":536,"range":{"start_line":536,"start_character":10,"end_line":536,"end_character":33},"updated":"2024-08-19 10:30:43.000000000","message":"I could not find any doc for this.","commit_id":"682b3e7a99a84997f1ce31f0d32a31b8fe37f702"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d4a528602ae86f7e94f03e055354bcbba5aad7af","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb298584_7f497184","line":536,"range":{"start_line":536,"start_character":10,"end_line":536,"end_character":33},"in_reply_to":"026ea533_f0eab36e","updated":"2024-08-21 06:48:42.000000000","message":"Acknowledged,\nupdated thanks","commit_id":"682b3e7a99a84997f1ce31f0d32a31b8fe37f702"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"8953645ca8301741c2c3b9093cb15551b9842100","unresolved":true,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fda6dceb_9b3fc8a3","line":536,"range":{"start_line":536,"start_character":10,"end_line":536,"end_character":33},"in_reply_to":"581f619b_6941065d","updated":"2024-08-19 11:20:00.000000000","message":"I\u0027ve found these docs https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.esxi.install.doc/GUID-DEB8086A-306B-4239-BF76-E354679202FC.html talking about having to check the hardware compatibility guide.\n\nhttps://www.vmware.com/resources/compatibility/search.php?deviceCategory\u003dcpu is that guide and afaics it only lists x86-compatible CPUs\n\nOn the other hand I found a blog post by VMware talking about an ARM project: https://blogs.vmware.com/arm/2023/10/31/esxi-arm-fling-continuation-update/\n\nI\u0027d say go with X86 until somebody finds a user for VMware with ARM.\n\nOne more thing: https://docs.openstack.org/nova/latest/configuration/extra-specs.html only lists `HW_ARCH_X86_64` not `HW_ARCH_X86`.","commit_id":"682b3e7a99a84997f1ce31f0d32a31b8fe37f702"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6c766d29ca9a9206c4b99e9ead6f3f171750bae","unresolved":true,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"026ea533_f0eab36e","line":536,"range":{"start_line":536,"start_character":10,"end_line":536,"end_character":33},"in_reply_to":"f28282f5_85c84606","updated":"2024-08-19 12:29:08.000000000","message":"i guess the real question is does nova with vmware support arm not just does vmware support arm\n\nif we want to say nova supprot arm with vmware then we sould need to have that tested in ci.\n\nso lets stick with X86_64 only","commit_id":"682b3e7a99a84997f1ce31f0d32a31b8fe37f702"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4789029f47ff9878e937b2f910e3ea0ca86a2cd3","unresolved":true,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f28282f5_85c84606","line":536,"range":{"start_line":536,"start_character":10,"end_line":536,"end_character":33},"in_reply_to":"fda6dceb_9b3fc8a3","updated":"2024-08-19 11:53:39.000000000","message":"thanks Johannes for the links\n\n\u003e I\u0027d say go with X86 until somebody finds a user for VMware with ARM.\n\nyeah that was the plan, to find out it in reviews.\n\nI think we can go with `x86 and arm`\n\nref https://www.vmware.com/resources/compatibility/search.php?deviceCategory\u003dsoftware\u0026testConfig\u003d16","commit_id":"682b3e7a99a84997f1ce31f0d32a31b8fe37f702"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6c766d29ca9a9206c4b99e9ead6f3f171750bae","unresolved":true,"context_lines":[{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":540,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"265397d7_bdc081bb","line":537,"range":{"start_line":537,"start_character":17,"end_line":537,"end_character":28},"updated":"2024-08-19 12:29:08.000000000","message":"ya this is wrong HW_ARCH_X86_64 is correct.\n\nwe dropped supprot for 32 host in nova about 6 years ago.\none of our core depenciies had a cpyton module that took a hard dep on 64bit only adn we decied it was time to require 64 hosts.","commit_id":"682b3e7a99a84997f1ce31f0d32a31b8fe37f702"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d4a528602ae86f7e94f03e055354bcbba5aad7af","unresolved":false,"context_lines":[{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":540,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"2c458079_018c071f","line":537,"range":{"start_line":537,"start_character":17,"end_line":537,"end_character":28},"in_reply_to":"265397d7_bdc081bb","updated":"2024-08-21 06:48:42.000000000","message":"Acknowledged","commit_id":"682b3e7a99a84997f1ce31f0d32a31b8fe37f702"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"0e521786552bf1e25f4f8e16249e7a0c5cf859e7","unresolved":true,"context_lines":[{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86_64"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":540,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"dadaa5fe_145f6708","line":537,"updated":"2024-08-22 07:50:24.000000000","message":"I see that libvirt uses a dictionary here, but I don\u0027t see a point in using one for this code. Are we planning to extend the code to later also have disabled traits like libvirt seems to support?","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"64a7a5c413ce7e6bc63dbefdc28d6ef70a91c1f3","unresolved":true,"context_lines":[{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86_64"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":540,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba06d96a_5cef805e","line":537,"in_reply_to":"4cd026a5_480b4252","updated":"2024-08-22 11:32:02.000000000","message":"If I read it correctly, we take the dict and convert it to a list immediately with `*traits`. So I don\u0027t get the point of the dict.\n\nThe libvirt driver seems to have a bunch of traits and on converting them to a list, it check if they are enabled or valid or something: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L9394-L9396","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"0ea98864ed1f551ef5892e8dcc0fa604c36db4f7","unresolved":true,"context_lines":[{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86_64"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":540,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"e200bdfe_eac098e8","line":537,"in_reply_to":"ba06d96a_5cef805e","updated":"2024-08-29 08:54:49.000000000","message":"ack, updated","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8136caf7ba6e8e968ed2bd832e9f9d44ebab381a","unresolved":true,"context_lines":[{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86_64"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":540,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"4cd026a5_480b4252","line":537,"in_reply_to":"dadaa5fe_145f6708","updated":"2024-08-22 08:15:37.000000000","message":"this is how resource provider store info for all, {key: bool}.\ndo you mean, we should use some other data structure, as we are not going to add any more trait for vmware ?","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"57208461d8009a249db722539fa178d6decd2d43","unresolved":false,"context_lines":[{"line_number":534,"context_line":"    def _get_cpu_traits(self):"},{"line_number":535,"context_line":"        # hw_arch trait"},{"line_number":536,"context_line":"        # vmware only support x86_64"},{"line_number":537,"context_line":"        return {\u0027HW_ARCH_X86_64\u0027: True}"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":540,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"a636acb0_b0b7f536","line":537,"in_reply_to":"e200bdfe_eac098e8","updated":"2024-10-10 10:01:07.000000000","message":"Done","commit_id":"67f087b29bfca2043900038991f715b8c6ea5231"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a2081fcc8aae3b901d0dc61b2cb32d7ebfc5af17","unresolved":true,"context_lines":[{"line_number":529,"context_line":"        # would add nested providers representing tenant VDC and similar."},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # nova with vmware only supports HW_ARCH_X86_64"},{"line_number":532,"context_line":"        cpu_arch_trait \u003d \u0027HW_ARCH_X86_64\u0027"},{"line_number":533,"context_line":"        provider_tree.add_traits(nodename, cpu_arch_trait)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":536,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ad46024c_4d4a88fa","line":533,"range":{"start_line":532,"start_character":8,"end_line":533,"end_character":58},"updated":"2024-10-09 19:51:48.000000000","message":"I learned about a cool new feature from Sean 😄 \n\nI suggest to guard this with a check for validity for the same reason on the libvirt patch. It\u0027s easy to make a typo or mistake when you are hand-writing the same value on both sides of the implementation and the unit test. If you consistently make the same typo or misremembered the value, your test will pass even though in real life you will not get the behavior you wanted. This is one of the cases where there is a joke about \"unit tests that verify whether Python works\".\n\nSo, especially if there\u0027s a very easy way to check it before returning it, I think it\u0027s worth it to do.\n\n(Don\u0027t forget to import os_traits if you add this)\n\n```suggestion\n        cpu_arch_trait \u003d \u0027HW_ARCH_X86_64\u0027\n        if cpu_arch_trait in ot.get_traits():\n            provider_tree.add_traits(nodename, cpu_arch_trait)\n```","commit_id":"ab1360b2c86d0c12d7576b29a3de8958b6bf39ef"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"57208461d8009a249db722539fa178d6decd2d43","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        # would add nested providers representing tenant VDC and similar."},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # nova with vmware only supports HW_ARCH_X86_64"},{"line_number":532,"context_line":"        cpu_arch_trait \u003d \u0027HW_ARCH_X86_64\u0027"},{"line_number":533,"context_line":"        provider_tree.add_traits(nodename, cpu_arch_trait)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def prepare_for_spawn(self, instance):"},{"line_number":536,"context_line":"        \"\"\"Perform pre-checks for spawn.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3dcb3564_0710b4b3","line":533,"range":{"start_line":532,"start_character":8,"end_line":533,"end_character":58},"in_reply_to":"ad46024c_4d4a88fa","updated":"2024-10-10 10:01:07.000000000","message":"Done","commit_id":"ab1360b2c86d0c12d7576b29a3de8958b6bf39ef"}]}