)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43e58c0211ab11f90e56ed7231bf5542edcd5552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ffd97fc_1da895ea","updated":"2024-08-19 13:17:15.000000000","message":"+1 because im not sure if we shoudl merge this or not\n\nits proably hte best path forward like with vmware but we may need to have a followup to detect and report the architrue propelry with zvm.","commit_id":"9289cc6f79e81b096f03ee8e2d0b02d25c201f10"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"67c62be837d0d9830400de61ba1d253d20f7aa34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f650cccf_f7b7599f","updated":"2024-08-30 06:33:20.000000000","message":"recheck\nthe gate -1 is because of docs-job bug, which is fixes now, so this is good to review","commit_id":"f22e8540515354889aa5608eca1d835c9a25c057"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"57cafc9d2aadf0030e69076bb193a11dd2b613b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f71b752e_14004e7f","updated":"2024-10-09 19:58:50.000000000","message":"Soft -1 same as the point on the previous patch","commit_id":"ce5e3bca371fa970673ec7c83aaf79634978d02f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"21374f6f1f62c30162e389868fd32ad613d6a8ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ceee6e26_eff3e7d3","updated":"2024-10-11 01:50:59.000000000","message":"recheck \ndeployment issue","commit_id":"9378d16d57eea5209b6ca5781c184e039246c676"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3ca6bc4fc2d68219d1b94abe845cef571bdeac72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a3b38101_b395fd6c","updated":"2024-10-12 17:14:15.000000000","message":"recheck kernel panic\nKernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000 ]---","commit_id":"9378d16d57eea5209b6ca5781c184e039246c676"}],"nova/virt/zvm/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43e58c0211ab11f90e56ed7231bf5542edcd5552","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        provider_tree.update_inventory(nodename, inventory)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # set hw_architecture trait"},{"line_number":457,"context_line":"        traits \u003d {\u0027HW_ARCH_PPC\u0027: True}"},{"line_number":458,"context_line":"        provider_tree.add_traits(nodename, *traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"babb3511_1454b71d","line":457,"updated":"2024-08-19 13:17:15.000000000","message":"this is actully a littel tricky \n\nhttps://github.com/openstack/os-traits/blob/master/os_traits/hw/arch.py#L38-L42\n\ni dont actully knwo which of \n\n    \u0027PPC\u0027,\n    \u0027PPCLE\u0027,\n    \u0027PPC64\u0027,\n    \u0027PPC64LE\u0027,\n    \u0027PPCEMB\u0027,\n    \n    is supproited \n    \nif we are going to report only one of the traits then \nHW_ARCH_PPC is proably the most resonable","commit_id":"9289cc6f79e81b096f03ee8e2d0b02d25c201f10"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1058569581725b08fbe1d3f4005663d35c03f331","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        provider_tree.update_inventory(nodename, inventory)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # set hw_architecture trait"},{"line_number":457,"context_line":"        traits \u003d {\u0027HW_ARCH_PPC\u0027: True}"},{"line_number":458,"context_line":"        provider_tree.add_traits(nodename, *traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c90e67d3_4a779c09","line":457,"in_reply_to":"81b8fc69_df620682","updated":"2024-10-17 01:44:22.000000000","message":"Honestly I don\u0027t know enough to have thoughts on it. So it\u0027s all you 🙂","commit_id":"9289cc6f79e81b096f03ee8e2d0b02d25c201f10"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4a51debaf9426c2593acf1751100aa9e9a62c24f","unresolved":true,"context_lines":[{"line_number":454,"context_line":"        provider_tree.update_inventory(nodename, inventory)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # set hw_architecture trait"},{"line_number":457,"context_line":"        traits \u003d {\u0027HW_ARCH_PPC\u0027: True}"},{"line_number":458,"context_line":"        provider_tree.add_traits(nodename, *traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"81b8fc69_df620682","line":457,"in_reply_to":"babb3511_1454b71d","updated":"2024-10-16 09:41:28.000000000","message":"maybe we shoudl also report PPC64\n\nHW_ARCH_PPC  i think is 32bit but i done know if pepople make that distinction HW_ARCH_PPC64 is the 64 bit version of that so maybe we shoudl report that.\n\nagain like vmware its hard to know without testing.\n\nwe could jsut decide to not report it for zvm at all (it might also be s390x)\nand someone using zvm just woudl not use the image metadata prefileter\n\n@melwittt@gmail.com any toughts on this?","commit_id":"9289cc6f79e81b096f03ee8e2d0b02d25c201f10"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"57cafc9d2aadf0030e69076bb193a11dd2b613b8","unresolved":true,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # set hw_architecture trait"},{"line_number":457,"context_line":"        cpu_arch_trait \u003d \u0027HW_ARCH_PPC\u0027"},{"line_number":458,"context_line":"        provider_tree.add_traits(nodename, cpu_arch_trait)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c998e784_d02115e9","line":458,"updated":"2024-10-09 19:58:50.000000000","message":"I think it would be worth checking if the trait is in os_traits.get_traits() before adding it.\n\n(later) I was thinking about that `ProviderTree` must not be validating any traits ... but I think I realize it can\u0027t know all valid traits because of `CUSTOM_` traits.","commit_id":"ce5e3bca371fa970673ec7c83aaf79634978d02f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"21374f6f1f62c30162e389868fd32ad613d6a8ca","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # set hw_architecture trait"},{"line_number":457,"context_line":"        cpu_arch_trait \u003d \u0027HW_ARCH_PPC\u0027"},{"line_number":458,"context_line":"        provider_tree.add_traits(nodename, cpu_arch_trait)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dc593672_db36b80b","line":458,"in_reply_to":"c998e784_d02115e9","updated":"2024-10-11 01:50:59.000000000","message":"Done","commit_id":"ce5e3bca371fa970673ec7c83aaf79634978d02f"}]}